Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135212/?format=api
{ "id": 135212, "url": "https://patches.dpdk.org/api/patches/135212/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231214221012.9598-4-jspewock@iol.unh.edu/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231214221012.9598-4-jspewock@iol.unh.edu>", "list_archive_url": "https://inbox.dpdk.org/dev/20231214221012.9598-4-jspewock@iol.unh.edu", "date": "2023-12-14T22:10:08", "name": "[v4,2/7] dts: allow passing parameters into interactive apps", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7084b31e9b9b5bc85fb20db01f5e9bb7aaa4b5c4", "submitter": { "id": 2772, "url": "https://patches.dpdk.org/api/people/2772/?format=api", "name": "Jeremy Spewock", "email": "jspewock@iol.unh.edu" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231214221012.9598-4-jspewock@iol.unh.edu/mbox/", "series": [ { "id": 30564, "url": "https://patches.dpdk.org/api/series/30564/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30564", "date": "2023-12-14T22:10:08", "name": null, "version": 4, "mbox": "https://patches.dpdk.org/series/30564/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/135212/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/135212/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 1ACCB436F4;\n\tThu, 14 Dec 2023 23:11:30 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1893243366;\n\tThu, 14 Dec 2023 23:11:22 +0100 (CET)", "from mail-il1-f226.google.com (mail-il1-f226.google.com\n [209.85.166.226])\n by mails.dpdk.org (Postfix) with ESMTP id 336B143360\n for <dev@dpdk.org>; Thu, 14 Dec 2023 23:11:20 +0100 (CET)", "by mail-il1-f226.google.com with SMTP id\n e9e14a558f8ab-35f884515fbso340935ab.3\n for <dev@dpdk.org>; Thu, 14 Dec 2023 14:11:20 -0800 (PST)", "from postal.iol.unh.edu (postal.iol.unh.edu.\n [2606:4100:3880:1234::84]) by smtp-relay.gmail.com with ESMTPS id\n j11-20020a92ca0b000000b0035d56982785sm1220080ils.77.2023.12.14.14.11.18\n (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128);\n Thu, 14 Dec 2023 14:11:19 -0800 (PST)", "from iol.unh.edu (unknown\n [IPv6:2606:4100:3880:1271:90f9:1b64:f6e6:867f])\n by postal.iol.unh.edu (Postfix) with ESMTP id 98E60605C312;\n Thu, 14 Dec 2023 17:11:18 -0500 (EST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=iol.unh.edu; s=unh-iol; t=1702591879; x=1703196679; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=8PkZFNIb4FYyzi/xXyZ+4+3TKRrd7iSse1Ifxnl7lPQ=;\n b=Q2v8RIONMum9ln+0hPM1VCLD+M8aHtuCD3628pqq45E2sDCmvjUXRrkPJL2ou8L7i4\n 0bqMJYmJxbhDPyEvndCJUG3MLvm1OjddflaXX5VNEKrlOhBdjV+gi7/2p9cCghdN1fqd\n blEICa2usaH3W9BPVwKIwNedEVc7bl9D7Mz+c=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1702591879; x=1703196679;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=8PkZFNIb4FYyzi/xXyZ+4+3TKRrd7iSse1Ifxnl7lPQ=;\n b=lPSIz3AkzERBCl1/5N5ALpt2rTuzFILWQ1M8YeaQ54YYnnfbkfEhKz1YwZZu9fNxTy\n uWby9WwWrHTHLZlP5IWIh+sZxW6gGV0BAn+qvb+4eJ4lwjzox6eRMzmLFHv3KnMivsYe\n tuUXI+oEEguLmX9ss2kNYhkQ1tTxiWuFGfLZxAHgJdWf4TOVOcjIzbt6CC5EyZugB22C\n LPG9ulNAwI1YivgpAh6tFt8XwYQuqlYIyNQYy5bb9qakbqhPggVUfSi461xoy5huMibo\n cQuf4aemccnOX9bQfNL9qR4ned6hf5wQUcoEhpaCoKQOh6gU6NdIoqmCsGAG/zLBqJ55\n /Syw==", "X-Gm-Message-State": "AOJu0Yw7DV+xnrYm5uPA3yAc7CP998wd4I5ZK8lIv3RFqv6kTAoYrehn\n WIWHtjl/HaSHz+fIG34lVnSue+2/qa52v4YZbQ05OLJ3kww5h9hAq1e/2MGux/npHQ==", "X-Google-Smtp-Source": "\n AGHT+IGB9+SyUBHK6T6HEjGl6vU7Qly4+rReJt1TMrICOT0PrXNk4/MuGJ3fp6/D1R4/9yFX0SNBsujHyUFS", "X-Received": "by 2002:a05:6e02:134e:b0:35f:71e9:a0b5 with SMTP id\n k14-20020a056e02134e00b0035f71e9a0b5mr3814744ilr.61.1702591879508;\n Thu, 14 Dec 2023 14:11:19 -0800 (PST)", "X-Relaying-Domain": "iol.unh.edu", "From": "jspewock@iol.unh.edu", "To": "Honnappa.Nagarahalli@arm.com, juraj.linkes@pantheon.tech,\n thomas@monjalon.net, wathsala.vithanage@arm.com, probb@iol.unh.edu,\n paul.szczepanek@arm.com, yoan.picchi@foss.arm.com, ferruh.yigit@amd.com,\n andrew.rybchenko@oktetlabs.ru", "Cc": "dev@dpdk.org,\n\tJeremy Spewock <jspewock@iol.unh.edu>", "Subject": "[PATCH v4 2/7] dts: allow passing parameters into interactive apps", "Date": "Thu, 14 Dec 2023 17:10:08 -0500", "Message-ID": "<20231214221012.9598-4-jspewock@iol.unh.edu>", "X-Mailer": "git-send-email 2.43.0", "In-Reply-To": "<20231113202833.12900-1-jspewock@iol.unh.edu>", "References": "<20231113202833.12900-1-jspewock@iol.unh.edu>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Jeremy Spewock <jspewock@iol.unh.edu>\n\nModified interactive applications to allow for the ability to pass\nparameters into the app on start up. Also modified the way EAL\nparameters are handled so that the trailing \"--\" separator is added be\ndefault after all EAL parameters.\n\nSigned-off-by: Jeremy Spewock <jspewock@iol.unh.edu>\n---\n .../remote_session/remote/testpmd_shell.py | 2 +-\n dts/framework/testbed_model/sut_node.py | 16 ++++++++++------\n 2 files changed, 11 insertions(+), 7 deletions(-)", "diff": "diff --git a/dts/framework/remote_session/remote/testpmd_shell.py b/dts/framework/remote_session/remote/testpmd_shell.py\nindex b5e4cba9b3..369807a33e 100644\n--- a/dts/framework/remote_session/remote/testpmd_shell.py\n+++ b/dts/framework/remote_session/remote/testpmd_shell.py\n@@ -62,7 +62,7 @@ class TestPmdShell(InteractiveShell):\n \n def _start_application(self, get_privileged_command: Callable[[str], str] | None) -> None:\n \"\"\"See \"_start_application\" in InteractiveShell.\"\"\"\n- self._app_args += \" -- -i\"\n+ self._app_args += \" -i\"\n super()._start_application(get_privileged_command)\n \n def start(self, verify: bool = True) -> None:\ndiff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py\nindex 7f75043bd3..9c92232d9e 100644\n--- a/dts/framework/testbed_model/sut_node.py\n+++ b/dts/framework/testbed_model/sut_node.py\n@@ -361,7 +361,8 @@ def create_interactive_shell(\n shell_cls: Type[InteractiveShellType],\n timeout: float = SETTINGS.timeout,\n privileged: bool = False,\n- eal_parameters: EalParameters | str | None = None,\n+ eal_parameters: EalParameters | None = None,\n+ app_parameters: str = \"\",\n ) -> InteractiveShellType:\n \"\"\"Factory method for creating a handler for an interactive session.\n \n@@ -376,19 +377,22 @@ def create_interactive_shell(\n eal_parameters: List of EAL parameters to use to launch the app. If this\n isn't provided or an empty string is passed, it will default to calling\n create_eal_parameters().\n+ app_parameters: Additional arguments to pass into the application on the\n+ command-line.\n Returns:\n Instance of the desired interactive application.\n \"\"\"\n- if not eal_parameters:\n- eal_parameters = self.create_eal_parameters()\n-\n- # We need to append the build directory for DPDK apps\n+ # We need to append the build directory and add EAL parameters for DPDK apps\n if shell_cls.dpdk_app:\n+ if not eal_parameters:\n+ eal_parameters = self.create_eal_parameters()\n+ app_parameters = f\"{eal_parameters} -- {app_parameters}\"\n+\n shell_cls.path = self.main_session.join_remote_path(\n self.remote_dpdk_build_dir, shell_cls.path\n )\n \n- return super().create_interactive_shell(shell_cls, timeout, privileged, str(eal_parameters))\n+ return super().create_interactive_shell(shell_cls, timeout, privileged, app_parameters)\n \n def bind_ports_to_driver(self, for_dpdk: bool = True) -> None:\n \"\"\"Bind all ports on the SUT to a driver.\n", "prefixes": [ "v4", "2/7" ] }