Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/135005/?format=api
{ "id": 135005, "url": "https://patches.dpdk.org/api/patches/135005/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231211073904.811243-2-haijie1@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231211073904.811243-2-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231211073904.811243-2-haijie1@huawei.com", "date": "2023-12-11T07:39:03", "name": "[1/2] eal: fix constraints on stdatomic API", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "3d65416d5ac364a95926f6d01e1c88010df602e7", "submitter": { "id": 2935, "url": "https://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231211073904.811243-2-haijie1@huawei.com/mbox/", "series": [ { "id": 30504, "url": "https://patches.dpdk.org/api/series/30504/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30504", "date": "2023-12-11T07:39:02", "name": "bugfix and replace on use of stdatomic API", "version": 1, "mbox": "https://patches.dpdk.org/series/30504/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/135005/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/135005/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 67D3D436C6;\n\tMon, 11 Dec 2023 08:42:54 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 2282540DF5;\n\tMon, 11 Dec 2023 08:42:51 +0100 (CET)", "from szxga04-in.huawei.com (szxga04-in.huawei.com [45.249.212.190])\n by mails.dpdk.org (Postfix) with ESMTP id D54B340041\n for <dev@dpdk.org>; Mon, 11 Dec 2023 08:42:48 +0100 (CET)", "from mail.maildlp.com (unknown [172.19.163.17])\n by szxga04-in.huawei.com (SkyGuard) with ESMTP id 4SpYbS1QQyz29fpJ;\n Mon, 11 Dec 2023 15:41:40 +0800 (CST)", "from kwepemd100004.china.huawei.com (unknown [7.221.188.31])\n by mail.maildlp.com (Postfix) with ESMTPS id C96621A016F;\n Mon, 11 Dec 2023 15:42:45 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.28; Mon, 11 Dec 2023 15:42:45 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Tyler Retzlaff <roretzla@linux.microsoft.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "CC": "<lihuisong@huawei.com>, <fengchengwen@huawei.com>,\n <liudongdong3@huawei.com>, <haijie1@huawei.com>", "Subject": "[PATCH 1/2] eal: fix constraints on stdatomic API", "Date": "Mon, 11 Dec 2023 15:39:03 +0800", "Message-ID": "<20231211073904.811243-2-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231211073904.811243-1-haijie1@huawei.com>", "References": "<20231211073904.811243-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems706-chm.china.huawei.com (10.3.19.183) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The first parameter of rte_atomic_exchange_explicit() must be a\npointer to _Atomic type. If run command \"meson setup --werror\n-Denable_stdatomic=true build && ninja -C build\", error will occur.\nThia patch fixes it.\n\nFixes: 1ec6a845b5cb (\"eal: use stdatomic API in public headers\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n app/test/test_atomic.c | 6 +++---\n lib/eal/include/generic/rte_atomic.h | 12 ++++++------\n 2 files changed, 9 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/test/test_atomic.c b/app/test/test_atomic.c\nindex db07159e81ab..c3cb3ae0ea57 100644\n--- a/app/test/test_atomic.c\n+++ b/app/test/test_atomic.c\n@@ -347,9 +347,9 @@ typedef union {\n const uint8_t CRC8_POLY = 0x91;\n uint8_t crc8_table[256];\n \n-volatile uint16_t token16;\n-volatile uint32_t token32;\n-volatile uint64_t token64;\n+volatile RTE_ATOMIC(uint16_t) token16;\n+volatile RTE_ATOMIC(uint32_t) token32;\n+volatile RTE_ATOMIC(uint64_t) token64;\n \n static void\n build_crc8_table(void)\ndiff --git a/lib/eal/include/generic/rte_atomic.h b/lib/eal/include/generic/rte_atomic.h\nindex 0e639dad76a4..38c3b41f9c68 100644\n--- a/lib/eal/include/generic/rte_atomic.h\n+++ b/lib/eal/include/generic/rte_atomic.h\n@@ -207,11 +207,11 @@ rte_atomic16_cmpset(volatile uint16_t *dst, uint16_t exp, uint16_t src)\n * The original value at that location\n */\n static inline uint16_t\n-rte_atomic16_exchange(volatile uint16_t *dst, uint16_t val);\n+rte_atomic16_exchange(volatile RTE_ATOMIC(uint16_t) *dst, uint16_t val);\n \n #ifdef RTE_FORCE_INTRINSICS\n static inline uint16_t\n-rte_atomic16_exchange(volatile uint16_t *dst, uint16_t val)\n+rte_atomic16_exchange(volatile RTE_ATOMIC(uint16_t) *dst, uint16_t val)\n {\n \treturn rte_atomic_exchange_explicit(dst, val, rte_memory_order_seq_cst);\n }\n@@ -492,11 +492,11 @@ rte_atomic32_cmpset(volatile uint32_t *dst, uint32_t exp, uint32_t src)\n * The original value at that location\n */\n static inline uint32_t\n-rte_atomic32_exchange(volatile uint32_t *dst, uint32_t val);\n+rte_atomic32_exchange(volatile RTE_ATOMIC(uint32_t) *dst, uint32_t val);\n \n #ifdef RTE_FORCE_INTRINSICS\n static inline uint32_t\n-rte_atomic32_exchange(volatile uint32_t *dst, uint32_t val)\n+rte_atomic32_exchange(volatile RTE_ATOMIC(uint32_t) *dst, uint32_t val)\n {\n \treturn rte_atomic_exchange_explicit(dst, val, rte_memory_order_seq_cst);\n }\n@@ -776,11 +776,11 @@ rte_atomic64_cmpset(volatile uint64_t *dst, uint64_t exp, uint64_t src)\n * The original value at that location\n */\n static inline uint64_t\n-rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val);\n+rte_atomic64_exchange(volatile RTE_ATOMIC(uint64_t) *dst, uint64_t val);\n \n #ifdef RTE_FORCE_INTRINSICS\n static inline uint64_t\n-rte_atomic64_exchange(volatile uint64_t *dst, uint64_t val)\n+rte_atomic64_exchange(volatile RTE_ATOMIC(uint64_t) *dst, uint64_t val)\n {\n \treturn rte_atomic_exchange_explicit(dst, val, rte_memory_order_seq_cst);\n }\n", "prefixes": [ "1/2" ] }