Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1350/?format=api
{ "id": 1350, "url": "https://patches.dpdk.org/api/patches/1350/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416409096-1340-2-git-send-email-helin.zhang@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416409096-1340-2-git-send-email-helin.zhang@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416409096-1340-2-git-send-email-helin.zhang@intel.com", "date": "2014-11-19T14:58:14", "name": "[dpdk-dev,v6,1/3] i40e: Use constant as the default hash keys", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "944248afb488383d2d9640c83288da91a9ef632f", "submitter": { "id": 14, "url": "https://patches.dpdk.org/api/people/14/?format=api", "name": "Zhang, Helin", "email": "helin.zhang@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416409096-1340-2-git-send-email-helin.zhang@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1350/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1350/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id F2B857F7D;\n\tWed, 19 Nov 2014 15:48:04 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id E9DF77EB0\n\tfor <dev@dpdk.org>; Wed, 19 Nov 2014 15:48:01 +0100 (CET)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga102.jf.intel.com with ESMTP; 19 Nov 2014 06:56:15 -0800", "from shvmail01.sh.intel.com ([10.239.29.42])\n\tby orsmga002.jf.intel.com with ESMTP; 19 Nov 2014 06:58:26 -0800", "from shecgisg004.sh.intel.com (shecgisg004.sh.intel.com\n\t[10.239.29.89])\n\tby shvmail01.sh.intel.com with ESMTP id sAJEwNKa032268;\n\tWed, 19 Nov 2014 22:58:23 +0800", "from shecgisg004.sh.intel.com (localhost [127.0.0.1])\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/SuSE Linux 0.8) with ESMTP\n\tid sAJEwLJG001381; Wed, 19 Nov 2014 22:58:23 +0800", "(from hzhan75@localhost)\n\tby shecgisg004.sh.intel.com (8.13.6/8.13.6/Submit) id sAJEwLMq001377; \n\tWed, 19 Nov 2014 22:58:21 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,417,1413270000\"; d=\"scan'208\";a=\"639737714\"", "From": "Helin Zhang <helin.zhang@intel.com>", "To": "dev@dpdk.org", "Date": "Wed, 19 Nov 2014 22:58:14 +0800", "Message-Id": "<1416409096-1340-2-git-send-email-helin.zhang@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "In-Reply-To": "<1416409096-1340-1-git-send-email-helin.zhang@intel.com>", "References": "<1413861289-26662-1-git-send-email-helin.zhang@intel.com>\n\t<1416409096-1340-1-git-send-email-helin.zhang@intel.com>", "Subject": "[dpdk-dev] [PATCH v6 1/3] i40e: Use constant as the default hash\n\tkeys", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Calculating the default RSS hash keys at run time is not needed at\nall, and may have race conditions. The alternative is to use array\nof random values which were generated manually as the default hash\nkeys.\n\nSigned-off-by: Helin Zhang <helin.zhang@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 14 +++++++-------\n 1 file changed, 7 insertions(+), 7 deletions(-)", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex 5074262..9096802 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -92,7 +92,7 @@\n #define I40E_48_BIT_SHIFT 48\n #define I40E_48_BIT_MASK 0xFFFFFFFFFFFFULL\n \n-/* Default queue interrupt throttling time in microseconds*/\n+/* Default queue interrupt throttling time in microseconds */\n #define I40E_ITR_INDEX_DEFAULT 0\n #define I40E_QUEUE_ITR_INTERVAL_DEFAULT 32 /* 32 us */\n #define I40E_QUEUE_ITR_INTERVAL_MAX 8160 /* 8160 us */\n@@ -210,9 +210,6 @@ static int i40e_dev_filter_ctrl(struct rte_eth_dev *dev,\n \t\t\t\tenum rte_filter_op filter_op,\n \t\t\t\tvoid *arg);\n \n-/* Default hash key buffer for RSS */\n-static uint32_t rss_key_default[I40E_PFQF_HKEY_MAX_INDEX + 1];\n-\n static struct rte_pci_id pci_id_i40e_map[] = {\n #define RTE_PCI_DEV_ID_DECL_I40E(vend, dev) {RTE_PCI_DEVICE(vend, dev)},\n #include \"rte_pci_dev_ids.h\"\n@@ -4893,9 +4890,12 @@ i40e_pf_config_rss(struct i40e_pf *pf)\n \t}\n \tif (rss_conf.rss_key == NULL || rss_conf.rss_key_len <\n \t\t(I40E_PFQF_HKEY_MAX_INDEX + 1) * sizeof(uint32_t)) {\n-\t\t/* Calculate the default hash key */\n-\t\tfor (i = 0; i <= I40E_PFQF_HKEY_MAX_INDEX; i++)\n-\t\t\trss_key_default[i] = (uint32_t)rte_rand();\n+\t\t/* Random default keys */\n+\t\tstatic uint32_t rss_key_default[] = {0x6b793944,\n+\t\t\t0x23504cb5, 0x5bea75b6, 0x309f4f12, 0x3dc0a2b8,\n+\t\t\t0x024ddcdf, 0x339b8ca0, 0x4c4af64a, 0x34fac605,\n+\t\t\t0x55d85839, 0x3a58997d, 0x2ec938e1, 0x66031581};\n+\n \t\trss_conf.rss_key = (uint8_t *)rss_key_default;\n \t\trss_conf.rss_key_len = (I40E_PFQF_HKEY_MAX_INDEX + 1) *\n \t\t\t\t\t\t\tsizeof(uint32_t);\n", "prefixes": [ "dpdk-dev", "v6", "1/3" ] }