Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134860/?format=api
https://patches.dpdk.org/api/patches/134860/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231205040524.3525473-1-joyce.kong@arm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231205040524.3525473-1-joyce.kong@arm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231205040524.3525473-1-joyce.kong@arm.com", "date": "2023-12-05T04:05:24", "name": "[v1] net/memif: fix segfault with Tx burst larger than 255", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9944bd6062bac693b7a29123f06288df128b4514", "submitter": { "id": 970, "url": "https://patches.dpdk.org/api/people/970/?format=api", "name": "Joyce Kong", "email": "joyce.kong@arm.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231205040524.3525473-1-joyce.kong@arm.com/mbox/", "series": [ { "id": 30449, "url": "https://patches.dpdk.org/api/series/30449/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30449", "date": "2023-12-05T04:05:24", "name": "[v1] net/memif: fix segfault with Tx burst larger than 255", "version": 1, "mbox": "https://patches.dpdk.org/series/30449/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/134860/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/134860/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 3D49E43437;\n\tTue, 5 Dec 2023 05:05:36 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D977742D45;\n\tTue, 5 Dec 2023 05:05:35 +0100 (CET)", "from foss.arm.com (foss.arm.com [217.140.110.172])\n by mails.dpdk.org (Postfix) with ESMTP id BDF2E4064A;\n Tue, 5 Dec 2023 05:05:34 +0100 (CET)", "from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])\n by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id BA17C1474;\n Mon, 4 Dec 2023 20:06:20 -0800 (PST)", "from net-arm-n1amp-02.shanghai.arm.com\n (net-arm-n1amp-02.shanghai.arm.com [10.169.210.107])\n by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 6A7313F5A1;\n Mon, 4 Dec 2023 20:05:31 -0800 (PST)" ], "From": "Joyce Kong <joyce.kong@arm.com>", "To": "Jakub Grajciar <jgrajcia@cisco.com>,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Joyce Kong <joyce.kong@arm.com>, Ruifeng Wang <ruifeng.wang@arm.com>", "Cc": "dev@dpdk.org, nd@arm.com, stable@dpdk.org,\n Liangxing Wang <liangxing.wang@arm.com>", "Subject": "[PATCH v1] net/memif: fix segfault with Tx burst larger than 255", "Date": "Tue, 5 Dec 2023 04:05:24 +0000", "Message-Id": "<20231205040524.3525473-1-joyce.kong@arm.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There will be a segfault when tx burst size is larger than\n256. This is because eth_memif_tx uses an index i which is\nuint8_t to count transmitted nb_pkts. Extend i to uint16_t,\nthe same size as nb_pkts.\n\nFixes: b5613c8f9d0a (\"net/memif: add a Tx fast path\")\nCc: stable@dpdk.org\n\nReported-by: Liangxing Wang <liangxing.wang@arm.com>\nSigned-off-by: Joyce Kong <joyce.kong@arm.com>\nReviewed-by: Ruifeng Wang <ruifeng.wang@arm.com>\n---\n drivers/net/memif/rte_eth_memif.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/memif/rte_eth_memif.c b/drivers/net/memif/rte_eth_memif.c\nindex 7cc8c0da91..6f45a00172 100644\n--- a/drivers/net/memif/rte_eth_memif.c\n+++ b/drivers/net/memif/rte_eth_memif.c\n@@ -684,7 +684,7 @@ eth_memif_tx(void *queue, struct rte_mbuf **bufs, uint16_t nb_pkts)\n \t\tn_free = __atomic_load_n(&ring->head, __ATOMIC_ACQUIRE) - slot;\n \t}\n \n-\tuint8_t i;\n+\tuint16_t i;\n \tstruct rte_mbuf **buf_tmp = bufs;\n \tmbuf_head = *buf_tmp++;\n \tstruct rte_mempool *mp = mbuf_head->pool;\n", "prefixes": [ "v1" ] }{ "id": 134860, "url": "