Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134829/?format=api
{ "id": 134829, "url": "https://patches.dpdk.org/api/patches/134829/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231205021330.260017-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231205021330.260017-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20231205021330.260017-2-stephen@networkplumber.org", "date": "2023-12-05T02:09:39", "name": "[01/18] gso: don't log message on non TCP/UDP", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "9adfb914ac1c424a573cf598e81382532b82bfee", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231205021330.260017-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 30446, "url": "https://patches.dpdk.org/api/series/30446/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30446", "date": "2023-12-05T02:09:38", "name": "Convert static log types in libraries to dynamic", "version": 1, "mbox": "https://patches.dpdk.org/series/30446/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/134829/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/134829/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BF214433FD;\n\tTue, 5 Dec 2023 03:13:51 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AF61B427DF;\n\tTue, 5 Dec 2023 03:13:51 +0100 (CET)", "from mail-pf1-f169.google.com (mail-pf1-f169.google.com\n [209.85.210.169])\n by mails.dpdk.org (Postfix) with ESMTP id 02ADD427DC\n for <dev@dpdk.org>; Tue, 5 Dec 2023 03:13:50 +0100 (CET)", "by mail-pf1-f169.google.com with SMTP id\n d2e1a72fcca58-6cc02e77a9cso5028987b3a.0\n for <dev@dpdk.org>; Mon, 04 Dec 2023 18:13:49 -0800 (PST)", "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n p26-20020a62b81a000000b0069346777241sm355958pfe.97.2023.12.04.18.13.48\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 Dec 2023 18:13:48 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701742429;\n x=1702347229; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=E49niAugGEAMLV8Z1NsCKtuhfBRzu0ptaCY90g32kqY=;\n b=aG+LdMAhqmuoG8nLkl6Ki8rj+ejZg0q94+ydinjF3N3MPT7DJ6Hmwk5yKQVDLLttvn\n TSqOTTOXGlHGIXNKOy0RTnWV/Iy2kXPrkMzLCADjnjeqax3mrbvBT1Si8XFtSpLpOErV\n jPwVJgPu6EmMJ2zx2HeSGxJqD+H/W9h4vVgk1ckq40dHaGlaJYdYDHSKCubjc3+zzpLv\n eycGJ9zi0enOz+0WU4UmeD9Xox+Vnn8j4gnpU7uUKktygRUpWbFvWc/DNxnjD7/h4b9o\n Q8bNTPiz3A461k/IuxNLXxmk4id0b6Iz3xtDzT39K3El/PcuzsO/7qTXWKMGEA9A2Aay\n l9kA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701742429; x=1702347229;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=E49niAugGEAMLV8Z1NsCKtuhfBRzu0ptaCY90g32kqY=;\n b=SbXH1B3X/oCAKrKLFzemwAanrmli10bNn+hr2rcxI4B2RtY7cVVcegJd5qqnXDDZrO\n 7ErM6FFWTZu1o3msES3+O7Ao9EQxqiiYRMdxqlaCs2OPpD84S0R/sKUbZvRENOO+5JSK\n mWbEpOY3pnhkd6VneuFsOiA+swctifU45wH4YpJZycP6L/6VYN7P5OjZgSDG4YFYVlvN\n D4BqS+vOakZFEMzsIw7yvDpfQfaH2POqKJyOiEz/bPny0b2/konfyYh/uW+JgpHjTTFC\n 1Bou+k23T+O37ohJorUZIQkHt2c53fRq+9AntDOuUf4e9oGlTo2FsZoqskkw0kVUdBYR\n 2m1Q==", "X-Gm-Message-State": "AOJu0Yx1GXyVlHA8F2JKxKz5gdMZ2ErFNJr65lZkfmTsa/HP7d0UjuRL\n fy8V5iZQzUUycDt+YNkOMSjjtpZfypxvrvEUQh0=", "X-Google-Smtp-Source": "\n AGHT+IHCL9wo1jwv0Y6ubPRr/rhGu9rGgsqura3JQk3OEPCrvMl0LalX8ZeQDyXgBZ0jaulyMBs3KA==", "X-Received": "by 2002:a05:6a00:1812:b0:6ce:6420:e174 with SMTP id\n y18-20020a056a00181200b006ce6420e174mr769078pfa.36.1701742429167;\n Mon, 04 Dec 2023 18:13:49 -0800 (PST)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>, Jiayu Hu <hujiayu.hu@foxmail.com>,\n Mark Kavanagh <mark.b.kavanagh@intel.com>", "Subject": "[PATCH 01/18] gso: don't log message on non TCP/UDP", "Date": "Mon, 4 Dec 2023 18:09:39 -0800", "Message-ID": "<20231205021330.260017-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.42.0", "In-Reply-To": "<20231205021330.260017-1-stephen@networkplumber.org>", "References": "<20230329234049.11071-1-stephen@networkplumber.org>\n <20231205021330.260017-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If a large packet is passed into GSO routines of unknown protocol\nthen library would log a message.\nBetter to tell the application instead of logging.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\nReviewed-by: Jiayu Hu <jiayu.hu@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gso/rte_gso.c | 4 +---\n lib/gso/rte_gso.h | 1 +\n 2 files changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c\nindex 4b59217c16ee..e29c7d884aed 100644\n--- a/lib/gso/rte_gso.c\n+++ b/lib/gso/rte_gso.c\n@@ -80,9 +80,7 @@ rte_gso_segment(struct rte_mbuf *pkt,\n \t\tret = gso_udp4_segment(pkt, gso_size, direct_pool,\n \t\t\t\tindirect_pool, pkts_out, nb_pkts_out);\n \t} else {\n-\t\t/* unsupported packet, skip */\n-\t\tRTE_LOG(DEBUG, GSO, \"Unsupported packet type\\n\");\n-\t\tret = 0;\n+\t\tret = -ENOTSUP;\t/* only UDP or TCP allowed */\n \t}\n \n \tif (ret < 0) {\ndiff --git a/lib/gso/rte_gso.h b/lib/gso/rte_gso.h\nindex 40922524df42..c0f9a1b66ff2 100644\n--- a/lib/gso/rte_gso.h\n+++ b/lib/gso/rte_gso.h\n@@ -114,6 +114,7 @@ struct rte_gso_ctx {\n * - The number of GSO segments filled in pkts_out on success.\n * - Return 0 if it does not need to be GSO'd.\n * - Return -ENOMEM if run out of memory in MBUF pools.\n+ * - Return -ENOTSUP for protocols that can not be segmented\n * - Return -EINVAL for invalid parameters.\n */\n int rte_gso_segment(struct rte_mbuf *pkt,\n", "prefixes": [ "01/18" ] }