Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134819/?format=api
{ "id": 134819, "url": "https://patches.dpdk.org/api/patches/134819/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231204183710.86921-6-ajit.khaparde@broadcom.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231204183710.86921-6-ajit.khaparde@broadcom.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231204183710.86921-6-ajit.khaparde@broadcom.com", "date": "2023-12-04T18:37:01", "name": "[05/14] net/bnxt: refactor mem zone allocation", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "9a65d4bac5799c85328279d72093af8fa8583695", "submitter": { "id": 501, "url": "https://patches.dpdk.org/api/people/501/?format=api", "name": "Ajit Khaparde", "email": "ajit.khaparde@broadcom.com" }, "delegate": { "id": 1766, "url": "https://patches.dpdk.org/api/users/1766/?format=api", "username": "ajitkhaparde", "first_name": "Ajit", "last_name": "Khaparde", "email": "ajit.khaparde@broadcom.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231204183710.86921-6-ajit.khaparde@broadcom.com/mbox/", "series": [ { "id": 30445, "url": "https://patches.dpdk.org/api/series/30445/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30445", "date": "2023-12-04T18:36:56", "name": "support new 5760X P7 devices", "version": 1, "mbox": "https://patches.dpdk.org/series/30445/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/134819/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/134819/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C435F4366C;\n\tMon, 4 Dec 2023 19:38:03 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 095ED42D2A;\n\tMon, 4 Dec 2023 19:37:30 +0100 (CET)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id 63EAB427E1\n for <dev@dpdk.org>; Mon, 4 Dec 2023 19:37:27 +0100 (CET)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-6ce49d9d874so1400226b3a.2\n for <dev@dpdk.org>; Mon, 04 Dec 2023 10:37:27 -0800 (PST)", "from C02GC2QQMD6T.wifi.broadcom.net ([192.19.223.252])\n by smtp.gmail.com with ESMTPSA id\n s3-20020a056a00178300b006be5af77f06sm4236664pfg.2.2023.12.04.10.37.24\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 04 Dec 2023 10:37:25 -0800 (PST)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=broadcom.com; s=google; t=1701715046; x=1702319846; darn=dpdk.org;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:from:to:cc:subject:date:message-id:reply-to;\n bh=21T0anMGA8hqWP45ePk9zHhiTTidNl7o0HNEEVzcv/w=;\n b=Y2hW+XIkJaZzrfvKscEtHzB6JE4LWsgFqsBMI7Pxo14dRBdG4+lZNM6PfZIefeit6d\n GLtyqz96y/Q1/NGcTWi0L4cNjtZkIfZhN0Usap3xax7vbDbR9MlYOh4sUTbhR9r2R6HJ\n /UFjXPYYVpNNsIlydEqFL3MbAqFuRQC+5+/WY=", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701715046; x=1702319846;\n h=mime-version:references:in-reply-to:message-id:date:subject:cc:to\n :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n bh=21T0anMGA8hqWP45ePk9zHhiTTidNl7o0HNEEVzcv/w=;\n b=X2sdwzA3y7/p5QBkA/6AbR248YFfcft7j+7Xzl8eBkgSMfgN83GpH4oM7oC2M3Rz47\n gMpa2ZFY0EVmOPnXhsaVPx58qLyvxy6syMvAqF0Sz7vn14E3VGGqr8Yi2mYfPRDeXMP0\n FFNvZ+6ySahi5PTldabmKulqU8L3PKYBIP2w6FCNiI0vvbsDMOmqm7H1RNiFAIwpE873\n 00rbtXstySMm1C3qgTIGFOiesI/BSrKQIAP4m7AdrU7OEguy7ntoG77ZHIP8sGOJrk5I\n Jbs3zOQ1EWTPcS+DMjM7ZJ8cLKCkcOM0JfPkl3bLBR2SidN9QrxaBskWVogd7ccGTDj9\n xVQw==", "X-Gm-Message-State": "AOJu0Yyys5HJ5ChEEy47LlI09UKS2QWMeWW72LtJ9mxz9/IKfT9DRFyW\n tszkJ1YfoFwm5M8ZAali/D1nHwurmBi/ybtRL3brdgcXlaFvi6qVkf6pL90UDhS1KkNKHNS+68P\n lWIng3yMrrhNo+iHSC8nQufTq0zVrv3odIh3woCtKUCde4vavJSQ2KKAB7udCiL2yMlT+", "X-Google-Smtp-Source": "\n AGHT+IEHXFZ9ua91QtfTL8qfXPsUOuSpzUGXfRsBs/vjgWFphvCLkdZAdVzTPq+1kUiHO6lh+huUmA==", "X-Received": "by 2002:a05:6a00:3492:b0:6ce:4fd9:48af with SMTP id\n cp18-20020a056a00349200b006ce4fd948afmr2380725pfb.60.1701715046096;\n Mon, 04 Dec 2023 10:37:26 -0800 (PST)", "From": "Ajit Khaparde <ajit.khaparde@broadcom.com>", "To": "dev@dpdk.org", "Cc": "Somnath Kotur <somnath.kotur@broadcom.com>,\n Kalesh AP <kalesh-anakkur.purayil@broadcom.com>", "Subject": "[PATCH 05/14] net/bnxt: refactor mem zone allocation", "Date": "Mon, 4 Dec 2023 10:37:01 -0800", "Message-Id": "<20231204183710.86921-6-ajit.khaparde@broadcom.com>", "X-Mailer": "git-send-email 2.39.2 (Apple Git-143)", "In-Reply-To": "<20231204183710.86921-1-ajit.khaparde@broadcom.com>", "References": "<20231204183710.86921-1-ajit.khaparde@broadcom.com>", "MIME-Version": "1.0", "Content-Type": "multipart/signed; protocol=\"application/pkcs7-signature\";\n micalg=sha-256; boundary=\"000000000000dbe7bc060bb3686c\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Currently we are allocating memzone for VNIC attributes per VNIC.\nIn cases where the firmware supports a higher VNIC count, this could\nlead to a higher number of memzone segments than supported.\n\nMove the memzone for VNIC attributes per function instead of per\nVNIC. Divide the memzone per VNIC as needed.\n\nSigned-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>\nReviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>\nReviewed-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>\n---\n drivers/net/bnxt/bnxt.h | 1 +\n drivers/net/bnxt/bnxt_vnic.c | 52 +++++++++++++++++++-----------------\n drivers/net/bnxt/bnxt_vnic.h | 1 -\n 3 files changed, 28 insertions(+), 26 deletions(-)", "diff": "diff --git a/drivers/net/bnxt/bnxt.h b/drivers/net/bnxt/bnxt.h\nindex 542ef13f7c..6af668e92f 100644\n--- a/drivers/net/bnxt/bnxt.h\n+++ b/drivers/net/bnxt/bnxt.h\n@@ -772,6 +772,7 @@ struct bnxt {\n \n \tstruct bnxt_vnic_info\t*vnic_info;\n \tSTAILQ_HEAD(, bnxt_vnic_info)\tfree_vnic_list;\n+\tconst struct rte_memzone *vnic_rss_mz;\n \n \tstruct bnxt_filter_info\t*filter_info;\n \tSTAILQ_HEAD(, bnxt_filter_info)\tfree_filter_list;\ndiff --git a/drivers/net/bnxt/bnxt_vnic.c b/drivers/net/bnxt/bnxt_vnic.c\nindex f86d27fd79..d40daf631e 100644\n--- a/drivers/net/bnxt/bnxt_vnic.c\n+++ b/drivers/net/bnxt/bnxt_vnic.c\n@@ -123,13 +123,11 @@ void bnxt_free_vnic_attributes(struct bnxt *bp)\n \n \tfor (i = 0; i < bp->max_vnics; i++) {\n \t\tvnic = &bp->vnic_info[i];\n-\t\tif (vnic->rss_mz != NULL) {\n-\t\t\trte_memzone_free(vnic->rss_mz);\n-\t\t\tvnic->rss_mz = NULL;\n-\t\t\tvnic->rss_hash_key = NULL;\n-\t\t\tvnic->rss_table = NULL;\n-\t\t}\n+\t\tvnic->rss_hash_key = NULL;\n+\t\tvnic->rss_table = NULL;\n \t}\n+\trte_memzone_free(bp->vnic_rss_mz);\n+\tbp->vnic_rss_mz = NULL;\n }\n \n int bnxt_alloc_vnic_attributes(struct bnxt *bp, bool reconfig)\n@@ -153,31 +151,35 @@ int bnxt_alloc_vnic_attributes(struct bnxt *bp, bool reconfig)\n \n \tentry_length = RTE_CACHE_LINE_ROUNDUP(entry_length + rss_table_size);\n \n-\tfor (i = 0; i < bp->max_vnics; i++) {\n-\t\tvnic = &bp->vnic_info[i];\n-\n-\t\tsnprintf(mz_name, RTE_MEMZONE_NAMESIZE,\n-\t\t\t \"bnxt_\" PCI_PRI_FMT \"_vnicattr_%d\", pdev->addr.domain,\n-\t\t\t pdev->addr.bus, pdev->addr.devid, pdev->addr.function, i);\n-\t\tmz_name[RTE_MEMZONE_NAMESIZE - 1] = 0;\n-\t\tmz = rte_memzone_lookup(mz_name);\n-\t\tif (mz == NULL) {\n-\t\t\tmz = rte_memzone_reserve(mz_name,\n-\t\t\t\t\t\t entry_length,\n+\tsnprintf(mz_name, RTE_MEMZONE_NAMESIZE,\n+\t\t \"bnxt_\" PCI_PRI_FMT \"_vnicattr\", pdev->addr.domain,\n+\t\t pdev->addr.bus, pdev->addr.devid, pdev->addr.function);\n+\tmz_name[RTE_MEMZONE_NAMESIZE - 1] = 0;\n+\tmz = rte_memzone_lookup(mz_name);\n+\tif (mz == NULL) {\n+\t\tmz = rte_memzone_reserve_aligned(mz_name,\n+\t\t\t\t\t\t entry_length * bp->max_vnics,\n \t\t\t\t\t\t bp->eth_dev->device->numa_node,\n \t\t\t\t\t\t RTE_MEMZONE_2MB |\n \t\t\t\t\t\t RTE_MEMZONE_SIZE_HINT_ONLY |\n-\t\t\t\t\t\t RTE_MEMZONE_IOVA_CONTIG);\n-\t\t\tif (mz == NULL) {\n-\t\t\t\tPMD_DRV_LOG(ERR, \"Cannot allocate bnxt vnic_attributes memory\\n\");\n-\t\t\t\treturn -ENOMEM;\n-\t\t\t}\n+\t\t\t\t\t\t RTE_MEMZONE_IOVA_CONTIG,\n+\t\t\t\t\t\t BNXT_PAGE_SIZE);\n+\t\tif (mz == NULL) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t \"Cannot allocate vnic_attributes memory\\n\");\n+\t\t\treturn -ENOMEM;\n \t\t}\n-\t\tvnic->rss_mz = mz;\n-\t\tmz_phys_addr = mz->iova;\n+\t}\n+\tbp->vnic_rss_mz = mz;\n+\tfor (i = 0; i < bp->max_vnics; i++) {\n+\t\tuint32_t offset = entry_length * i;\n+\n+\t\tvnic = &bp->vnic_info[i];\n+\n+\t\tmz_phys_addr = mz->iova + offset;\n \n \t\t/* Allocate rss table and hash key */\n-\t\tvnic->rss_table = (void *)((char *)mz->addr);\n+\t\tvnic->rss_table = (void *)((char *)mz->addr + offset);\n \t\tvnic->rss_table_dma_addr = mz_phys_addr;\n \t\tmemset(vnic->rss_table, -1, entry_length);\n \ndiff --git a/drivers/net/bnxt/bnxt_vnic.h b/drivers/net/bnxt/bnxt_vnic.h\nindex 4396d95bda..7a6a0aa739 100644\n--- a/drivers/net/bnxt/bnxt_vnic.h\n+++ b/drivers/net/bnxt/bnxt_vnic.h\n@@ -47,7 +47,6 @@ struct bnxt_vnic_info {\n \tuint16_t\thash_type;\n \tuint8_t\t\thash_mode;\n \tuint8_t\t\tprev_hash_mode;\n-\tconst struct rte_memzone *rss_mz;\n \trte_iova_t\trss_table_dma_addr;\n \tuint16_t\t*rss_table;\n \trte_iova_t\trss_hash_key_dma_addr;\n", "prefixes": [ "05/14" ] }