Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134748/?format=api
{ "id": 134748, "url": "https://patches.dpdk.org/api/patches/134748/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231203112543.844014-2-michaelba@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231203112543.844014-2-michaelba@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231203112543.844014-2-michaelba@nvidia.com", "date": "2023-12-03T11:25:21", "name": "[v1,01/23] common/mlx5: fix duplicate read of general capabilities", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4081338877b05857f73e1f8d209fb4fbbf6650e8", "submitter": { "id": 1949, "url": "https://patches.dpdk.org/api/people/1949/?format=api", "name": "Michael Baum", "email": "michaelba@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231203112543.844014-2-michaelba@nvidia.com/mbox/", "series": [ { "id": 30433, "url": "https://patches.dpdk.org/api/series/30433/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30433", "date": "2023-12-03T11:25:23", "name": "net/mlx5: support Geneve and options for HWS", "version": 1, "mbox": "https://patches.dpdk.org/series/30433/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/134748/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/134748/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id EA3D84365F;\n\tSun, 3 Dec 2023 12:26:29 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id E0081402E0;\n\tSun, 3 Dec 2023 12:26:17 +0100 (CET)", "from NAM02-SN1-obe.outbound.protection.outlook.com\n (mail-sn1nam02on2074.outbound.protection.outlook.com [40.107.96.74])\n by mails.dpdk.org (Postfix) with ESMTP id 37D1B402BB;\n Sun, 3 Dec 2023 12:26:15 +0100 (CET)", "from MW4PR04CA0206.namprd04.prod.outlook.com (2603:10b6:303:86::31)\n by CH3PR12MB8878.namprd12.prod.outlook.com (2603:10b6:610:17e::21)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.32; Sun, 3 Dec\n 2023 11:26:12 +0000", "from CO1PEPF000042AB.namprd03.prod.outlook.com\n (2603:10b6:303:86:cafe::65) by MW4PR04CA0206.outlook.office365.com\n (2603:10b6:303:86::31) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7046.30 via Frontend\n Transport; Sun, 3 Dec 2023 11:26:12 +0000", "from mail.nvidia.com (216.228.117.160) by\n CO1PEPF000042AB.mail.protection.outlook.com (10.167.243.40) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.7068.20 via Frontend Transport; Sun, 3 Dec 2023 11:26:11 +0000", "from rnnvmail204.nvidia.com (10.129.68.6) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023\n 03:25:52 -0800", "from rnnvmail205.nvidia.com (10.129.68.10) by rnnvmail204.nvidia.com\n (10.129.68.6) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 3 Dec 2023\n 03:25:52 -0800", "from nvidia.com (10.127.8.13) by mail.nvidia.com (10.129.68.10) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41 via Frontend\n Transport; Sun, 3 Dec 2023 03:25:50 -0800" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=Ax4y0ycEJL+9AZKpub87GyRihK+eGWe8pCQmnnnUQ9M2Yfc9hU+C7BypQKOzytolJH5/9ae6PW1tR5/8rac6Mn096wxWcGfA0beBCkfuzPUHapgPLYzWh0G/Uhk5A53Gkj8texu2VMYO50UtEruPjtgYstLBogdfgQp7tFqcDol95Q5g31tbqi24pNuzaWeNZ8qD2SVhZmYSsZU+HQLKGJS0zBKQSi/6ZzQsTARXgMV30noWTC7xsXllg5hlpq4s0t6VPjWa4QsjSxYEwCugxkW/bO0vK4mDl4vKuRUnJugBhYnDENjCKo0RgbNLp8SMO6n4cMhMP1szZZTJZFZvmA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=s7Yc7yS2OBcxKzaxvyS9PM+zn2fpVRP1CbdSR3MORZY=;\n b=EeO6WynQtSkaftOmP7SB2SJRRy1KOK0T8kTO6Ig2UruFeb17qB2AGa/uvi2QIwXmYTYwFUdHm1jQH77z0f7bPVFeDfOzqLijDVATYSn7oST8CzMs0XoRjY0SJ9HMHM4s++jCtvMBW8zBS0fEoi7kPvTc8bt29Dah2DLKMp8lVrHOvgbqgzy1y37woY3GHMqYhzaup6b1XbFaB632+/sSd9+7yqQKHlsbg0utJ808yHje4ohhDj4CIEk+wz90McRNkmzVqCEE/ICo+PTBqv16vYX/ipGX4J958VbXG8SKUwYkXtH1ibRwd5vu3w3uhul2FVhLibn85ruW/RdcnmQ0ug==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=s7Yc7yS2OBcxKzaxvyS9PM+zn2fpVRP1CbdSR3MORZY=;\n b=c0iEuC/g2Xhs8Xgw/nar1vZdWSmzJ8Vl41FMBuCAy6aek0pyg/QbrfPMDlgg0vNzBFNg1Erbz+OkJz3qju3/CKf3i52FCVjbbqvN5L6wqn/mcI4iKFYrYainXVJnsZ6CwuEpgYCusBfThABmCyrNFjIAcsh7lH5/4wNuwQLPVQ+cElxsoxqjFwD6A3AF5gYKs6+otxvxpHY64hmg6kGZiGkMiOG2j5LWMy2E6EQG00P1309Tp2vsep0R5U9HCT7wQ7liyY4GB44acEzzjZ+6b9L84KmFj9ialGv3Mb7ukqaD0/fSAUFcEVy2JRhVDzpVws731WokIvpd1qWNjpPe0Q==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Michael Baum <michaelba@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "Matan Azrad <matan@nvidia.com>, Raslan Darawsheh <rasland@nvidia.com>,\n Viacheslav Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>,\n Suanming Mou <suanmingm@nvidia.com>, <dekelp@nvidia.com>, <stable@dpdk.org>", "Subject": "[PATCH v1 01/23] common/mlx5: fix duplicate read of general\n capabilities", "Date": "Sun, 3 Dec 2023 13:25:21 +0200", "Message-ID": "<20231203112543.844014-2-michaelba@nvidia.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231203112543.844014-1-michaelba@nvidia.com>", "References": "<20231203112543.844014-1-michaelba@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-NV-OnPremToCloud": "ExternallySecured", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CO1PEPF000042AB:EE_|CH3PR12MB8878:EE_", "X-MS-Office365-Filtering-Correlation-Id": "95ca11d7-d157-4448-5deb-08dbf3f2a773", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 4/qJXYiGMnghKUCLNM40T98QO6ei+4q57jZNcGgI04T/VS0w8c9Ew5NwEwx8QaszTwfT/Z5rgS+/L/Q1y1Y8pOztW1PKEio0PJ1q3SITF+H+2ZeeOiR5oy0lvJW6T7NRagFRZQhozwtz7XE/wxgf+LccdTaugKb5lFDqTfN2Bcu0CPJI/qC9vap+H6y1vO9Is7ELg5lf4/unApkYOsW9Qeo++LjrBAXFLEdKRWvWqY9ujOmBMvS38chcGGONNhbriYjxvy9IaNHvwE3c3n0JYIyg3Y+JppGKFJCG4V3ISjZfdhjjiH8wK+wTeD6TBxb/IYiU2yXM2MEahE9BoizxxPGQ+2QXPdWtpHVX0cpYNgPKkJi2KFKUeBPOjoET1v1K0pLbY6tGjmQydRi+SEheIde3OeMNrk/AgpESSqvruIT4y1M8eFFkNXRfT/ygHtfgdKHx9QUMH1Cwt2Om3C/ZLF5bb55wWkJle+XSiXTj+x4lkfj6Vk7zJW4fUL3nDLeGoKKJxCPSH+dLjjw/ZOEVcOAYXrhtg2/8o2yNff920SfgG5SkM6nAzGIaczJnqe7Gd8X6Kq4RCKgBiUJq3+6A5woauvrXIpqRku4UvQw+wHZb0LARgwMjOY1Xblu5X62YNQT1l5GLM1acawkd2WG0Ox6XX9g6CySzBCxgBmTABUKaPTHmUWqP0DWrOFpPILh+UVBTmy4TR1TnEyoXgKyfLHL6RduGxlmeKqam9p0yJAw1Q485KwzmXbpjRXYuT3we", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(136003)(346002)(39860400002)(396003)(376002)(230922051799003)(186009)(64100799003)(1800799012)(451199024)(82310400011)(46966006)(40470700004)(36840700001)(6286002)(82740400003)(26005)(7636003)(55016003)(47076005)(356005)(336012)(426003)(36756003)(70586007)(70206006)(54906003)(6916009)(316002)(40480700001)(83380400001)(36860700001)(1076003)(41300700001)(2616005)(2906002)(478600001)(6666004)(7696005)(8676002)(8936002)(4326008)(5660300002)(86362001)(450100002)(40460700003);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Dec 2023 11:26:11.8641 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 95ca11d7-d157-4448-5deb-08dbf3f2a773", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CO1PEPF000042AB.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "CH3PR12MB8878", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "General object types support is indicated in bitmap general_obj_types,\nwhich is part of HCA capabilities list.\nThis bitmap was read multiple times, and each time a different bit was\nextracted.\n\nPrevious patch optimized the code, reading the bitmap once into a local\nvariable, and then extracting the required bits.\nHowever, it missed few of them which still read the bitmap for\nthemselves. In addition, for other readings, it moved them to use local\nvariable without removing the old reading, and they are read twice.\n\nThis patch moves them all to use the local variable and removes all\nduplications.\n\nFixes: 876d4702b141 (\"common/mlx5: optimize read of general capabilities\")\nCc: dekelp@nvidia.com\nCc: stable@dpdk.org\n\nSigned-off-by: Michael Baum <michaelba@nvidia.com>\n---\n drivers/common/mlx5/mlx5_devx_cmds.c | 18 ++++--------------\n 1 file changed, 4 insertions(+), 14 deletions(-)", "diff": "diff --git a/drivers/common/mlx5/mlx5_devx_cmds.c b/drivers/common/mlx5/mlx5_devx_cmds.c\nindex 4d8818924a..41f6e0a727 100644\n--- a/drivers/common/mlx5/mlx5_devx_cmds.c\n+++ b/drivers/common/mlx5/mlx5_devx_cmds.c\n@@ -966,18 +966,6 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,\n \tattr->max_geneve_tlv_option_data_len = MLX5_GET(cmd_hca_cap, hcattr,\n \t\t\tmax_geneve_tlv_option_data_len);\n \tattr->qos.sup = MLX5_GET(cmd_hca_cap, hcattr, qos);\n-\tattr->qos.flow_meter_aso_sup = !!(MLX5_GET64(cmd_hca_cap, hcattr,\n-\t\t\t\t\t general_obj_types) &\n-\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_FLOW_METER_ASO);\n-\tattr->vdpa.valid = !!(MLX5_GET64(cmd_hca_cap, hcattr,\n-\t\t\t\t\t general_obj_types) &\n-\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_VIRTQ_NET_Q);\n-\tattr->vdpa.queue_counters_valid = !!(MLX5_GET64(cmd_hca_cap, hcattr,\n-\t\t\t\t\t\t\tgeneral_obj_types) &\n-\t\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_VIRTIO_Q_COUNTERS);\n-\tattr->parse_graph_flex_node = !!(MLX5_GET64(cmd_hca_cap, hcattr,\n-\t\t\t\t\t general_obj_types) &\n-\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_PARSE_GRAPH_FLEX_NODE);\n \tattr->wqe_index_ignore = MLX5_GET(cmd_hca_cap, hcattr,\n \t\t\t\t\t wqe_index_ignore_cap);\n \tattr->cross_channel = MLX5_GET(cmd_hca_cap, hcattr, cd);\n@@ -1001,6 +989,9 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,\n \t/* Read the general_obj_types bitmap and extract the relevant bits. */\n \tgeneral_obj_types_supported = MLX5_GET64(cmd_hca_cap, hcattr,\n \t\t\t\t\t\t general_obj_types);\n+\tattr->qos.flow_meter_aso_sup =\n+\t\t\t!!(general_obj_types_supported &\n+\t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_FLOW_METER_ASO);\n \tattr->vdpa.valid = !!(general_obj_types_supported &\n \t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_VIRTQ_NET_Q);\n \tattr->vdpa.queue_counters_valid =\n@@ -1074,8 +1065,7 @@ mlx5_devx_cmd_query_hca_attr(void *ctx,\n \t\tMLX5_GET(cmd_hca_cap, hcattr, umr_modify_entity_size_disabled);\n \tattr->wait_on_time = MLX5_GET(cmd_hca_cap, hcattr, wait_on_time);\n \tattr->crypto = MLX5_GET(cmd_hca_cap, hcattr, crypto);\n-\tattr->ct_offload = !!(MLX5_GET64(cmd_hca_cap, hcattr,\n-\t\t\t\t\t general_obj_types) &\n+\tattr->ct_offload = !!(general_obj_types_supported &\n \t\t\t MLX5_GENERAL_OBJ_TYPES_CAP_CONN_TRACK_OFFLOAD);\n \tattr->rq_delay_drop = MLX5_GET(cmd_hca_cap, hcattr, rq_delay_drop);\n \tattr->nic_flow_table = MLX5_GET(cmd_hca_cap, hcattr, nic_flow_table);\n", "prefixes": [ "v1", "01/23" ] }