Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 134710,
    "url": "https://patches.dpdk.org/api/patches/134710/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231129173122.126895-9-stephen@networkplumber.org/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20231129173122.126895-9-stephen@networkplumber.org>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20231129173122.126895-9-stephen@networkplumber.org",
    "date": "2023-11-29T17:26:02",
    "name": "[v5,08/19] net/fm10k, net/ixgbe: remove word sanity",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "601e33fe34836aada8a6d4bfc50f0d2df512f38e",
    "submitter": {
        "id": 27,
        "url": "https://patches.dpdk.org/api/people/27/?format=api",
        "name": "Stephen Hemminger",
        "email": "stephen@networkplumber.org"
    },
    "delegate": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/users/1/?format=api",
        "username": "tmonjalo",
        "first_name": "Thomas",
        "last_name": "Monjalon",
        "email": "thomas@monjalon.net"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231129173122.126895-9-stephen@networkplumber.org/mbox/",
    "series": [
        {
            "id": 30417,
            "url": "https://patches.dpdk.org/api/series/30417/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30417",
            "date": "2023-11-29T17:25:54",
            "name": "remove use of the term \"sanity check\"",
            "version": 5,
            "mbox": "https://patches.dpdk.org/series/30417/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/134710/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/134710/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0905A43403;\n\tWed, 29 Nov 2023 18:32:43 +0100 (CET)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D8B6F42E87;\n\tWed, 29 Nov 2023 18:31:48 +0100 (CET)",
            "from mail-pf1-f170.google.com (mail-pf1-f170.google.com\n [209.85.210.170])\n by mails.dpdk.org (Postfix) with ESMTP id 39AB642E74\n for <dev@dpdk.org>; Wed, 29 Nov 2023 18:31:44 +0100 (CET)",
            "by mail-pf1-f170.google.com with SMTP id\n d2e1a72fcca58-6cdd405ca77so771019b3a.0\n for <dev@dpdk.org>; Wed, 29 Nov 2023 09:31:44 -0800 (PST)",
            "from hermes.local (204-195-123-141.wavecable.com. [204.195.123.141])\n by smtp.gmail.com with ESMTPSA id\n y42-20020a056a0003aa00b006baa1cf561dsm10950435pfs.0.2023.11.29.09.31.42\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 29 Nov 2023 09:31:42 -0800 (PST)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1701279103;\n x=1701883903; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=Uxzqi3Ttw66KFa+NRBUaaeEWM0wPDaO0ETmcAD43CLY=;\n b=H5dacleHdXqD1tY/PkvzULXz5ihDpwcEPPdi+gywABdJ9FhdYifspYSXzaTxdCYYwi\n 6q19XRZbT1gBTmZh+zYX4jgH0NFshlSQfDojT1j3kAXDU9voos1VyGIQaPzAgZdC+S9C\n XcEHNIZ97wIpqTry6rvjBNzj2gmduLYO7DH38Xil7z2i5NZ+nIDS4zeFYEYjuX5kSeoe\n mxKcQS+EOU58zyTFReHTOGoyC/Uu9YEtiMSfwD22R6rsI3Qus1xNzkFIBaIGRnifm9ZS\n +z7lEchiCzq+StEnATU0ozwk6wGJI2cgh/5psPnf2Npm8I9C+nILpdJhMhQoFHvIi/wr\n LqrQ==",
        "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1701279103; x=1701883903;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=Uxzqi3Ttw66KFa+NRBUaaeEWM0wPDaO0ETmcAD43CLY=;\n b=rTfyLnZGR5cJHwcqfFt9a8SKDkyVnWmOBwlwUy4Qs1QKSByPtd2F2RpWoOFMUhGzKj\n eXp8xslD1pepOcdPpp47O2CpsvnV8vxO2KUIggZZ7sN6V6DlQyOg5L/5t7I5zn3n4lIF\n HMa3Dlyn/KUwA6A6Y6nz/hajFNW+W04NLjJYp6/zXknsumRXtCcH9y1+4/VWx0pADqeq\n aFVw5KfFiIeZD5nWXy5D2YqQnBSuekj5HFs19UmCyu3eNd7QvVU6AgXBFxaGO7svjRZf\n hVrTwwNGIhgqVDCxWXqChZki4KmdNPUbzluaGhSD+LNFKzLp5tjqvMXYI3z6se2NUTRX\n bmjQ==",
        "X-Gm-Message-State": "AOJu0YyF95Deez12F11ahwC4nq+G/GPrSY9F0aWN01LK0Wv79Vxolxsn\n Reyh/Kvqoy8cnmp8wwTkPsi+XBVQZZ9fnyHTUHc=",
        "X-Google-Smtp-Source": "\n AGHT+IEOxJtQeqcmoMuiy+5o5yAMlWunjRY2SiEYECii16KK96mkYIZzrMl7mwEuxXzF2oHdLZGyjw==",
        "X-Received": "by 2002:a05:6a00:15cb:b0:6cd:85a4:bbbc with SMTP id\n o11-20020a056a0015cb00b006cd85a4bbbcmr14319146pfu.9.1701279103187;\n Wed, 29 Nov 2023 09:31:43 -0800 (PST)",
        "From": "Stephen Hemminger <stephen@networkplumber.org>",
        "To": "dev@dpdk.org",
        "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Qi Zhang <qi.z.zhang@intel.com>, Xiao Wang <xiao.w.wang@intel.com>,\n Qiming Yang <qiming.yang@intel.com>, Wenjun Wu <wenjun1.wu@intel.com>",
        "Subject": "[PATCH v5 08/19] net/fm10k, net/ixgbe: remove word sanity",
        "Date": "Wed, 29 Nov 2023 09:26:02 -0800",
        "Message-ID": "<20231129173122.126895-9-stephen@networkplumber.org>",
        "X-Mailer": "git-send-email 2.42.0",
        "In-Reply-To": "<20231129173122.126895-1-stephen@networkplumber.org>",
        "References": "<20230802232550.125487-1-stephen@networkplumber.org>\n <20231129173122.126895-1-stephen@networkplumber.org>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Remove non-inclusive term sanity from these Intel drivers.\n\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n drivers/net/fm10k/fm10k_ethdev.c | 2 +-\n drivers/net/fm10k/fm10k_rxtx.c   | 2 +-\n drivers/net/ixgbe/ixgbe_fdir.c   | 2 +-\n drivers/net/ixgbe/ixgbe_ipsec.c  | 2 +-\n drivers/net/ixgbe/ixgbe_rxtx.c   | 2 +-\n 5 files changed, 5 insertions(+), 5 deletions(-)",
    "diff": "diff --git a/drivers/net/fm10k/fm10k_ethdev.c b/drivers/net/fm10k/fm10k_ethdev.c\nindex 4d3c4c10cfa4..894cf8c8a6b5 100644\n--- a/drivers/net/fm10k/fm10k_ethdev.c\n+++ b/drivers/net/fm10k/fm10k_ethdev.c\n@@ -1757,7 +1757,7 @@ mempool_element_size_valid(struct rte_mempool *mp)\n \t/* account for up to 512B of alignment */\n \tmin_size -= FM10K_RX_DATABUF_ALIGN;\n \n-\t/* sanity check for overflow */\n+\t/* check for overflow */\n \tif (min_size > mp->elt_size)\n \t\treturn 0;\n \ndiff --git a/drivers/net/fm10k/fm10k_rxtx.c b/drivers/net/fm10k/fm10k_rxtx.c\nindex c0841ab8cb34..94345299b22a 100644\n--- a/drivers/net/fm10k/fm10k_rxtx.c\n+++ b/drivers/net/fm10k/fm10k_rxtx.c\n@@ -647,7 +647,7 @@ fm10k_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\tif (q->nb_free < mb->nb_segs)\n \t\t\tbreak;\n \n-\t\t/* sanity check to make sure the mbuf is valid */\n+\t\t/* check to make sure the mbuf is valid */\n \t\tif ((mb->nb_segs == 0) ||\n \t\t    ((mb->nb_segs > 1) && (mb->next == NULL)))\n \t\t\tbreak;\ndiff --git a/drivers/net/ixgbe/ixgbe_fdir.c b/drivers/net/ixgbe/ixgbe_fdir.c\nindex 06d6e2126de5..51bbf577e3fe 100644\n--- a/drivers/net/ixgbe/ixgbe_fdir.c\n+++ b/drivers/net/ixgbe/ixgbe_fdir.c\n@@ -1130,7 +1130,7 @@ ixgbe_fdir_filter_program(struct rte_eth_dev *dev,\n \t\treturn -ENOTSUP;\n \n \t/*\n-\t * Sanity check for x550.\n+\t * Check for x550.\n \t * When adding a new filter with flow type set to IPv4,\n \t * the flow director mask should be configed before,\n \t * and the L4 protocol and ports are masked.\ndiff --git a/drivers/net/ixgbe/ixgbe_ipsec.c b/drivers/net/ixgbe/ixgbe_ipsec.c\nindex d3313085560d..d4aa3e9ede8e 100644\n--- a/drivers/net/ixgbe/ixgbe_ipsec.c\n+++ b/drivers/net/ixgbe/ixgbe_ipsec.c\n@@ -615,7 +615,7 @@ ixgbe_crypto_enable_ipsec(struct rte_eth_dev *dev)\n \trx_offloads = dev->data->dev_conf.rxmode.offloads;\n \ttx_offloads = dev->data->dev_conf.txmode.offloads;\n \n-\t/* sanity checks */\n+\t/* input validation */\n \tif (rx_offloads & RTE_ETH_RX_OFFLOAD_TCP_LRO) {\n \t\tPMD_DRV_LOG(ERR, \"RSC and IPsec not supported\");\n \t\treturn -1;\ndiff --git a/drivers/net/ixgbe/ixgbe_rxtx.c b/drivers/net/ixgbe/ixgbe_rxtx.c\nindex 90b0a7004f50..0e53b8a73a18 100644\n--- a/drivers/net/ixgbe/ixgbe_rxtx.c\n+++ b/drivers/net/ixgbe/ixgbe_rxtx.c\n@@ -4983,7 +4983,7 @@ ixgbe_set_rsc(struct rte_eth_dev *dev)\n \tuint32_t rdrxctl;\n \tuint32_t rfctl;\n \n-\t/* Sanity check */\n+\t/* Offload check */\n \tdev->dev_ops->dev_infos_get(dev, &dev_info);\n \tif (dev_info.rx_offload_capa & RTE_ETH_RX_OFFLOAD_TCP_LRO)\n \t\trsc_capable = true;\n",
    "prefixes": [
        "v5",
        "08/19"
    ]
}