Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13462/?format=api
{ "id": 13462, "url": "https://patches.dpdk.org/api/patches/13462/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1465666025-10159-2-git-send-email-johndale@cisco.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465666025-10159-2-git-send-email-johndale@cisco.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1465666025-10159-2-git-send-email-johndale@cisco.com", "date": "2016-06-11T17:27:05", "name": "[dpdk-dev,v4,2/2] enic: improve out of resources error handling", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "3cd5481419862d07782286744cf35b0fbbe7c9e9", "submitter": { "id": 359, "url": "https://patches.dpdk.org/api/people/359/?format=api", "name": "John Daley (johndale)", "email": "johndale@cisco.com" }, "delegate": { "id": 10, "url": "https://patches.dpdk.org/api/users/10/?format=api", "username": "bruce", "first_name": "Bruce", "last_name": "Richardson", "email": "bruce.richardson@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1465666025-10159-2-git-send-email-johndale@cisco.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/13462/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/13462/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id DAF592C72;\n\tSat, 11 Jun 2016 19:27:43 +0200 (CEST)", "from alln-iport-7.cisco.com (alln-iport-7.cisco.com\n\t[173.37.142.94]) by dpdk.org (Postfix) with ESMTP id 906022C6B\n\tfor <dev@dpdk.org>; Sat, 11 Jun 2016 19:27:42 +0200 (CEST)", "from alln-core-1.cisco.com ([173.36.13.131])\n\tby alln-iport-7.cisco.com with ESMTP/TLS/DHE-RSA-AES256-SHA;\n\t11 Jun 2016 17:27:42 +0000", "from cisco.com (savbu-usnic-a.cisco.com [10.193.184.48])\n\tby alln-core-1.cisco.com (8.14.5/8.14.5) with ESMTP id u5BHRgi7003932;\n\tSat, 11 Jun 2016 17:27:42 GMT", "by cisco.com (Postfix, from userid 392789)\n\tid 05A4D3FAAE24; Sat, 11 Jun 2016 10:27:42 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n\td=cisco.com; i=@cisco.com; l=2215; q=dns/txt; s=iport;\n\tt=1465666062; x=1466875662;\n\th=from:to:cc:subject:date:message-id:in-reply-to: references;\n\tbh=h3lqHaTaiSgaRSZK+ZRflUAgdt+3emHFYzARXLn1WbE=;\n\tb=mXhLG4rrGCkw4wGHxGQ2FU2FMZF+QBWDxCSGmW2k7e/gM34p5nAfuIxk\n\tv/W6O8R8nA9nP4N0kyW6WZOpYKmB8DF6vUgIb2Pp4pbfUJdxp7HlQEpqb\n\t/rZRUlTNxJsY+0ZUF+MW1kzjPGd/FnQ43AAFu9fQjbQHfghzUzR3xtICI s=;", "X-IronPort-AV": "E=Sophos;i=\"5.26,457,1459814400\"; d=\"scan'208\";a=\"284425761\"", "From": "John Daley <johndale@cisco.com>", "To": "bruce.richardson@intel.com", "Cc": "dev@dpdk.org, John Daley <johndale@cisco.com>", "Date": "Sat, 11 Jun 2016 10:27:05 -0700", "Message-Id": "<1465666025-10159-2-git-send-email-johndale@cisco.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1465666025-10159-1-git-send-email-johndale@cisco.com>", "References": "<20160610092236.GA11860@bricha3-MOBL3>\n\t<1465666025-10159-1-git-send-email-johndale@cisco.com>", "Subject": "[dpdk-dev] [PATCH v4 2/2] enic: improve out of resources error\n\thandling", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "If configuration fails due to lack of resources, be more specific\nabout which resources are lacking - work queues, read queues or\ncompletion queues. Return -EINVAL instead of -1 if more queeues\nare requested than are available.\n\nFixes: fefed3d1e62c (\"enic: new driver\")\nSigned-off-by: John Daley <johndale@cisco.com>\n---\n\nv4: only modify wq/rq/cq counts on success, return -EINVAL on error.\n\n drivers/net/enic/enic_main.c | 30 ++++++++++++++++++++----------\n 1 file changed, 20 insertions(+), 10 deletions(-)", "diff": "diff --git a/drivers/net/enic/enic_main.c b/drivers/net/enic/enic_main.c\nindex 738792e..32ecdae 100644\n--- a/drivers/net/enic/enic_main.c\n+++ b/drivers/net/enic/enic_main.c\n@@ -826,22 +826,32 @@ static void enic_dev_deinit(struct enic *enic)\n int enic_set_vnic_res(struct enic *enic)\n {\n \tstruct rte_eth_dev *eth_dev = enic->rte_dev;\n+\tint rc = 0;\n \n-\tif ((enic->rq_count < eth_dev->data->nb_rx_queues) ||\n-\t\t(enic->wq_count < eth_dev->data->nb_tx_queues)) {\n-\t\tdev_err(dev, \"Not enough resources configured, aborting\\n\");\n-\t\treturn -1;\n+\tif (enic->rq_count < eth_dev->data->nb_rx_queues) {\n+\t\tdev_err(dev, \"Not enough Receive queues. Requested:%u, Configured:%u\\n\",\n+\t\t\teth_dev->data->nb_rx_queues, enic->rq_count);\n+\t\trc = -EINVAL;\n+\t}\n+\tif (enic->wq_count < eth_dev->data->nb_tx_queues) {\n+\t\tdev_err(dev, \"Not enough Transmit queues. Requested:%u, Configured:%u\\n\",\n+\t\t\teth_dev->data->nb_tx_queues, enic->wq_count);\n+\t\trc = -EINVAL;\n \t}\n \n-\tenic->rq_count = eth_dev->data->nb_rx_queues;\n-\tenic->wq_count = eth_dev->data->nb_tx_queues;\n \tif (enic->cq_count < (enic->rq_count + enic->wq_count)) {\n-\t\tdev_err(dev, \"Not enough resources configured, aborting\\n\");\n-\t\treturn -1;\n+\t\tdev_err(dev, \"Not enough Completion queues. Required:%u, Configured:%u\\n\",\n+\t\t\tenic->rq_count + enic->wq_count, enic->cq_count);\n+\t\trc = -EINVAL;\n \t}\n \n-\tenic->cq_count = enic->rq_count + enic->wq_count;\n-\treturn 0;\n+\tif (rc == 0) {\n+\t\tenic->rq_count = eth_dev->data->nb_rx_queues;\n+\t\tenic->wq_count = eth_dev->data->nb_tx_queues;\n+\t\tenic->cq_count = enic->rq_count + enic->wq_count;\n+\t}\n+\n+\treturn rc;\n }\n \n static int enic_dev_init(struct enic *enic)\n", "prefixes": [ "dpdk-dev", "v4", "2/2" ] }