Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 1345,
    "url": "https://patches.dpdk.org/api/patches/1345/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416387973-28431-1-git-send-email-bruce.richardson@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<1416387973-28431-1-git-send-email-bruce.richardson@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/1416387973-28431-1-git-send-email-bruce.richardson@intel.com",
    "date": "2014-11-19T09:06:13",
    "name": "[dpdk-dev] test: fix misplaced braces in strncmp call",
    "commit_ref": null,
    "pull_url": null,
    "state": "accepted",
    "archived": true,
    "hash": "18f7294c841dc5a2cd7780731b70e44a64f00c88",
    "submitter": {
        "id": 20,
        "url": "https://patches.dpdk.org/api/people/20/?format=api",
        "name": "Bruce Richardson",
        "email": "bruce.richardson@intel.com"
    },
    "delegate": null,
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416387973-28431-1-git-send-email-bruce.richardson@intel.com/mbox/",
    "series": [],
    "comments": "https://patches.dpdk.org/api/patches/1345/comments/",
    "check": "pending",
    "checks": "https://patches.dpdk.org/api/patches/1345/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@dpdk.org",
        "Delivered-To": "patchwork@dpdk.org",
        "Received": [
            "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 0932C7E18;\n\tWed, 19 Nov 2014 11:03:21 +0100 (CET)",
            "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n\tby dpdk.org (Postfix) with ESMTP id 9BDEA682E\n\tfor <dev@dpdk.org>; Wed, 19 Nov 2014 11:03:17 +0100 (CET)",
            "from fmsmga002.fm.intel.com ([10.253.24.26])\n\tby fmsmga101.fm.intel.com with ESMTP; 19 Nov 2014 01:06:16 -0800",
            "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby fmsmga002.fm.intel.com with ESMTP; 19 Nov 2014 01:06:14 -0800",
            "from sivswdev01.ir.intel.com (sivswdev01.ir.intel.com\n\t[10.237.217.45])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tsAJ96EUL008582; Wed, 19 Nov 2014 09:06:14 GMT",
            "from sivswdev01.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev01.ir.intel.com with ESMTP id sAJ96EPX028472;\n\tWed, 19 Nov 2014 09:06:14 GMT",
            "(from bricha3@localhost)\n\tby sivswdev01.ir.intel.com with  id sAJ96DBj028468;\n\tWed, 19 Nov 2014 09:06:13 GMT"
        ],
        "X-ExtLoop1": "1",
        "X-IronPort-AV": "E=Sophos;i=\"5.07,415,1413270000\"; d=\"scan'208\";a=\"634383365\"",
        "From": "Bruce Richardson <bruce.richardson@intel.com>",
        "To": "dev@dpdk.org",
        "Date": "Wed, 19 Nov 2014 09:06:13 +0000",
        "Message-Id": "<1416387973-28431-1-git-send-email-bruce.richardson@intel.com>",
        "X-Mailer": "git-send-email 1.7.4.1",
        "Subject": "[dpdk-dev] [PATCH] test: fix misplaced braces in strncmp call",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.15",
        "Precedence": "list",
        "List-Id": "patches and discussions about DPDK <dev.dpdk.org>",
        "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://dpdk.org/ml/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org",
        "Sender": "\"dev\" <dev-bounces@dpdk.org>"
    },
    "content": "This patch fixes two occurances where a call to strncmp had the closing\nbrace in the wrong place. Changing this form:\n\tif (strncmp(X,Y,sizeof(X) != 0))\nwhich does a comparison of length 1, to\n\tif (strncmp(X,Y,sizeof(X)) != 0)\nwhich does the correct length comparison and then compares the result to\nzero in the \"if\" part, as the author presumably originally intended.\n\nReported-by: Larry Wang <liang-min.wang@intel.com>\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n app/test/test_devargs.c | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test/test_devargs.c b/app/test/test_devargs.c\nindex f0acf8e..dcbdd09 100644\n--- a/app/test/test_devargs.c\n+++ b/app/test/test_devargs.c\n@@ -90,9 +90,9 @@ test_devargs(void)\n \t\tgoto fail;\n \tdevargs = TAILQ_FIRST(&devargs_list);\n \tif (strncmp(devargs->virtual.drv_name, \"eth_ring1\",\n-\t\t\tsizeof(devargs->virtual.drv_name) != 0))\n+\t\t\tsizeof(devargs->virtual.drv_name)) != 0)\n \t\tgoto fail;\n-\tif (strncmp(devargs->args, \"k1=val,k2=val2\", sizeof(devargs->args) != 0))\n+\tif (strncmp(devargs->args, \"k1=val,k2=val2\", sizeof(devargs->args)) != 0)\n \t\tgoto fail;\n \tfree_devargs_list();\n \n",
    "prefixes": [
        "dpdk-dev"
    ]
}