Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1344/?format=api
https://patches.dpdk.org/api/patches/1344/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/B6059B2012717B4390714544B1F509E110DC5B05@SHSMSX103.ccr.corp.intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<B6059B2012717B4390714544B1F509E110DC5B05@SHSMSX103.ccr.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/B6059B2012717B4390714544B1F509E110DC5B05@SHSMSX103.ccr.corp.intel.com", "date": "2014-11-19T07:53:29", "name": "[dpdk-dev,v5,02/21] i40e: tear down flow director", "commit_ref": null, "pull_url": null, "state": "not-applicable", "archived": true, "hash": "f1c12769068f3642e55059f09a8b96d6c5e91518", "submitter": { "id": 54, "url": "https://patches.dpdk.org/api/people/54/?format=api", "name": "Cao, Min", "email": "min.cao@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/B6059B2012717B4390714544B1F509E110DC5B05@SHSMSX103.ccr.corp.intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1344/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1344/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id A5FE77F74;\n\tWed, 19 Nov 2014 10:52:52 +0100 (CET)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n\tby dpdk.org (Postfix) with ESMTP id 2AF8C7E18\n\tfor <dev@dpdk.org>; Wed, 19 Nov 2014 10:52:50 +0100 (CET)", "from fmsmga003.fm.intel.com ([10.253.24.29])\n\tby fmsmga102.fm.intel.com with ESMTP; 18 Nov 2014 23:54:09 -0800", "from kmsmsx151.gar.corp.intel.com ([172.21.73.86])\n\tby FMSMGA003.fm.intel.com with ESMTP; 18 Nov 2014 23:44:47 -0800", "from shsmsx104.ccr.corp.intel.com (10.239.4.70) by\n\tKMSMSX151.gar.corp.intel.com (172.21.73.86) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Wed, 19 Nov 2014 15:53:30 +0800", "from shsmsx103.ccr.corp.intel.com ([169.254.4.240]) by\n\tSHSMSX104.ccr.corp.intel.com ([169.254.5.182]) with mapi id\n\t14.03.0195.001; Wed, 19 Nov 2014 15:53:29 +0800" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"4.97,862,1389772800\"; d=\"scan'208\";a=\"418528591\"", "From": "\"Cao, Min\" <min.cao@intel.com>", "To": "\"Wu, Jingjing\" <jingjing.wu@intel.com>, \"dev@dpdk.org\" <dev@dpdk.org>", "Thread-Topic": "[PATCH v5 02/21] i40e: tear down flow director", "Thread-Index": "AQHP9BLuJbZnkCbgOk25k6d8L9fjsZxnsxPg", "Date": "Wed, 19 Nov 2014 07:53:29 +0000", "Message-ID": "<B6059B2012717B4390714544B1F509E110DC5B05@SHSMSX103.ccr.corp.intel.com>", "References": "<1413939687-11177-1-git-send-email-jingjing.wu@intel.com>\n\t<1414654006-7472-1-git-send-email-jingjing.wu@intel.com>\n\t<1414654006-7472-3-git-send-email-jingjing.wu@intel.com>", "In-Reply-To": "<1414654006-7472-3-git-send-email-jingjing.wu@intel.com>", "Accept-Language": "zh-CN, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[10.239.127.40]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Subject": "Re: [dpdk-dev] [PATCH v5 02/21] i40e: tear down flow director", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Tested-by: Min Cao <min.cao@intel.com>\n\nPatch name: \t\t[PATCH v5 00/21] Support flow director programming on Fortville\nTest Flag: \t\t\tTested-by\nTester name: \t\tmin.cao@intel.com\nResult summary:\t\ttotal 3 cases, 3 passed, 0 failed\n\nTest Case 1:\t\t\nName:\t\t\t\tFortville flow director with no flexible playload(IPv4/IPv6)\nEnvironment:\t\tOS: Fedora20 3.11.10-301.fc20.x86_64\n\t\t\t\tgcc (GCC) 4.8.2\n\t\t\t\tCPU: Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz\n\t\t\t\tNIC: Fortville eagle/spirit \nTest result:\t\tPASSED\n\nTest Case 2:\t\t\nName:\t\t\t\tFortville flow director with flexible playload(IPv4/IPv6)\nEnvironment:\t\tOS: Fedora20 3.11.10-301.fc20.x86_64\n\t\t\t\tgcc (GCC) 4.8.2\n\t\t\t\tCPU: Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz\n\t\t\t\tNIC: Fortville eagle/spirit \nTest result:\t\tPASSED\n\nTest Case 3:\t\t\nName:\t\t\t\tFortville flow director flush\nEnvironment:\t\tOS: Fedora20 3.11.10-301.fc20.x86_64\n\t\t\t\tgcc (GCC) 4.8.2\n\t\t\t\tCPU: Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz\n\t\t\t\tNIC: Fortville eagle/spirit \nTest result:\t\tPASSED\n\nTest Case 4:\t\t\nName:\t\t\t\tFortville flow director performance\nEnvironment:\t\tOS: Fedora20 3.11.10-301.fc20.x86_64\n\t\t\t\tgcc (GCC) 4.8.2\n\t\t\t\tCPU: Intel(R) Xeon(R) CPU E5-2680 0 @ 2.70GHz\n\t\t\t\tNIC: Fortville eagle/spirit \nTest result:\t\tPASSED\n\n-----Original Message-----\nFrom: Wu, Jingjing \nSent: Thursday, October 30, 2014 3:26 PM\nTo: dev@dpdk.org\nCc: Wu, Jingjing; Cao, Min\nSubject: [PATCH v5 02/21] i40e: tear down flow director\n\nTo support flow director tear down, this patch includes\n - queue 0 pair release\n - release vsi\n\nSigned-off-by: Jingjing Wu <jingjing.wu@intel.com>\n---\n lib/librte_pmd_i40e/i40e_ethdev.c | 4 +++-\n lib/librte_pmd_i40e/i40e_ethdev.h | 1 +\n lib/librte_pmd_i40e/i40e_fdir.c | 19 +++++++++++++++++++\n 3 files changed, 23 insertions(+), 1 deletion(-)\n\n\\ No newline at end of file", "diff": "diff --git a/lib/librte_pmd_i40e/i40e_ethdev.c b/lib/librte_pmd_i40e/i40e_ethdev.c\nindex cea7725..812c91d 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.c\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.c\n@@ -514,7 +514,8 @@ eth_i40e_dev_init(__rte_unused struct eth_driver *eth_drv,\n \treturn 0;\n \n err_setup_pf_switch:\n-\trte_free(pf->main_vsi);\n+\ti40e_fdir_teardown(pf);\n+\ti40e_vsi_release(pf->main_vsi);\n err_get_mac_addr:\n err_configure_lan_hmc:\n \t(void)i40e_shutdown_lan_hmc(hw);\n@@ -849,6 +850,7 @@ i40e_dev_close(struct rte_eth_dev *dev)\n \ti40e_shutdown_lan_hmc(hw);\n \n \t/* release all the existing VSIs and VEBs */\n+\ti40e_fdir_teardown(pf);\n \ti40e_vsi_release(pf->main_vsi);\n \n \t/* shutdown the adminq */\ndiff --git a/lib/librte_pmd_i40e/i40e_ethdev.h b/lib/librte_pmd_i40e/i40e_ethdev.h\nindex 6d30f75..35fcc46 100644\n--- a/lib/librte_pmd_i40e/i40e_ethdev.h\n+++ b/lib/librte_pmd_i40e/i40e_ethdev.h\n@@ -379,6 +379,7 @@ enum i40e_status_code i40e_fdir_setup_tx_resources(struct i40e_pf *pf,\n enum i40e_status_code i40e_fdir_setup_rx_resources(struct i40e_pf *pf,\n \t\t\t\t unsigned int socket_id);\n int i40e_fdir_setup(struct i40e_pf *pf);\n+void i40e_fdir_teardown(struct i40e_pf *pf);\n \n /* I40E_DEV_PRIVATE_TO */\n #define I40E_DEV_PRIVATE_TO_PF(adapter) \\\ndiff --git a/lib/librte_pmd_i40e/i40e_fdir.c b/lib/librte_pmd_i40e/i40e_fdir.c\nindex a44bb73..bb474d2 100644\n--- a/lib/librte_pmd_i40e/i40e_fdir.c\n+++ b/lib/librte_pmd_i40e/i40e_fdir.c\n@@ -219,4 +219,23 @@ fail_setup_tx:\n \ti40e_vsi_release(vsi);\n \tpf->fdir.fdir_vsi = NULL;\n \treturn err;\n+}\n+\n+/*\n+ * i40e_fdir_teardown - release the Flow Director resources\n+ * @pf: board private structure\n+ */\n+void\n+i40e_fdir_teardown(struct i40e_pf *pf)\n+{\n+\tstruct i40e_vsi *vsi;\n+\n+\tvsi = pf->fdir.fdir_vsi;\n+\ti40e_dev_rx_queue_release(pf->fdir.rxq);\n+\tpf->fdir.rxq = NULL;\n+\ti40e_dev_tx_queue_release(pf->fdir.txq);\n+\tpf->fdir.txq = NULL;\n+\ti40e_vsi_release(vsi);\n+\tpf->fdir.fdir_vsi = NULL;\n+\treturn;\n }\n", "prefixes": [ "dpdk-dev", "v5", "02/21" ] }{ "id": 1344, "url": "