Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13434/?format=api
{ "id": 13434, "url": "https://patches.dpdk.org/api/patches/13434/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1465564749-1405-3-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1465564749-1405-3-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1465564749-1405-3-git-send-email-thomas.monjalon@6wind.com", "date": "2016-06-10T13:19:05", "name": "[dpdk-dev,v2,2/6] mk: fix driver dependencies order for static application", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "e09915d690fec412127d08861204768f9363791b", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1465564749-1405-3-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/13434/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/13434/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 36BDA2BC1;\n\tFri, 10 Jun 2016 15:19:23 +0200 (CEST)", "from mail-wm0-f47.google.com (mail-wm0-f47.google.com\n\t[74.125.82.47]) by dpdk.org (Postfix) with ESMTP id 29DDC2BB1\n\tfor <dev@dpdk.org>; Fri, 10 Jun 2016 15:19:20 +0200 (CEST)", "by mail-wm0-f47.google.com with SMTP id n184so266588825wmn.1\n\tfor <dev@dpdk.org>; Fri, 10 Jun 2016 06:19:20 -0700 (PDT)", "from XPS13.localdomain (184.203.134.77.rev.sfr.net.\n\t[77.134.203.184]) by smtp.gmail.com with ESMTPSA id\n\to4sm12302758wjx.45.2016.06.10.06.19.18\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 10 Jun 2016 06:19:19 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id:in-reply-to:references;\n\tbh=VBKGLC+G6cTpRKuHkrDBHIsGHYjz26zIJK1IQa8yW10=;\n\tb=cWIkBmahDfrWknvFWYyVZNrVPiPYxiXi9qG/LSf0MOpc4iAIOljKePe+/2NF2RTNEb\n\t9LKUzK/WhFQWoLiZoSkwRQY24nnB4lIAmyUupD8KvZwB6jSf1HjlhFwMQiX/NbTu4NvE\n\tGJcKCrKHMScbU8dnaesDoBJkXv/mV/xGsjViN6MYzW/Ply64udyhPRk5ZrUJQQRxYMHP\n\t7TzRzSEDXAKRKV66CPLy9Webk3HO12nydIkQUZHyElr5v0fwJNhDsOKn6Pb2ltXw9YVg\n\tpQ1dg/3niLUYB+fGtePKG+JGjJxbAAitFvXIawrpZprQqXwFEzqjn6VqmSVPlz8QbhxY\n\tsH1g==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to\n\t:references;\n\tbh=VBKGLC+G6cTpRKuHkrDBHIsGHYjz26zIJK1IQa8yW10=;\n\tb=lEp+O8f/0B/VUuFsME1OD9nDFFNCuv00VfNJbkjJokRYGQwBZA9V3CY39799T5rR3C\n\toljCYdW4ODVj5Ha2voJ+MJf6zqoajeawOTYpQLWsCfrOeOz0+WGfvKbQqiLvq3YmCUgf\n\tBQEMzZ5nSHf1nx2wjYhvthxHT/Lg0iKveLPDb/vJVixR07Sdl3OM0Vtf4EMyXojISrFd\n\tdLC18WUx3TRNnw7EOYI3tC5nSvE6pZ1YRLCpsRK+Kl2ceUwVblyHyUM55fAgGM1OIGnj\n\tqmxLt3sdsJ93eRquDUV+1YafdZWQSY2WSY7rW13rI6Ktc5GGCkCweGI9BaJ3GnWdUBQt\n\t/tvw==", "X-Gm-Message-State": "ALyK8tKq3esA3XRtFULoM9IqRm3M21ROCQ5nYqitCYXvypZfMCnfv9JadLQce8wFszYZkfQ0", "X-Received": "by 10.28.152.130 with SMTP id a124mr18614121wme.98.1465564759818;\n\tFri, 10 Jun 2016 06:19:19 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "Ferruh Yigit <ferruh.yigit@intel.com>", "Cc": "dev@dpdk.org", "Date": "Fri, 10 Jun 2016 15:19:05 +0200", "Message-Id": "<1465564749-1405-3-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "In-Reply-To": "<1465564749-1405-1-git-send-email-thomas.monjalon@6wind.com>", "References": "<1464367686-3475-1-git-send-email-ferruh.yigit@intel.com>\n\t<1465564749-1405-1-git-send-email-thomas.monjalon@6wind.com>", "Subject": "[dpdk-dev] [PATCH v2 2/6] mk: fix driver dependencies order for\n\tstatic application", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "On a linker command line, the dependencies must be declared after\nthe libraries using them.\nIt will avoid some issues when building an application with static\nlibraries and --as-needed option.\n\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n mk/rte.app.mk | 38 +++++++++++---------------------------\n 1 file changed, 11 insertions(+), 27 deletions(-)", "diff": "diff --git a/mk/rte.app.mk b/mk/rte.app.mk\nindex 07be17c..8068e66 100644\n--- a/mk/rte.app.mk\n+++ b/mk/rte.app.mk\n@@ -93,22 +93,6 @@ ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) += -lfuse\n endif\n _LDLIBS-$(CONFIG_RTE_PORT_PCAP) += -lpcap\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lpcap\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lz\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -libverbs\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -libverbs\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lsze2\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lxenstore\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lgxio\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += -lm\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += -lz\n-# QAT / AESNI GCM PMDs are dependent on libcrypto (from openssl)\n-# for calculating HMAC precomputes\n-ifeq ($(CONFIG_RTE_LIBRTE_PMD_QAT),y)\n-_LDLIBS-y += -lcrypto\n-else ifeq ($(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM),y)\n-_LDLIBS-y += -lcrypto\n-endif\n endif # !CONFIG_RTE_BUILD_SHARED_LIBS\n \n _LDLIBS-y += --start-group\n@@ -124,13 +108,13 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_EAL) += -lrte_eal\n _LDLIBS-$(CONFIG_RTE_LIBRTE_CMDLINE) += -lrte_cmdline\n _LDLIBS-$(CONFIG_RTE_LIBRTE_CFGFILE) += -lrte_cfgfile\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_BOND) += -lrte_pmd_bond\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_XENVIRT) += -lrte_pmd_xenvirt -lxenstore\n \n ifeq ($(CONFIG_RTE_BUILD_SHARED_LIB),n)\n # plugins (link only if static libraries)\n \n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AF_PACKET) += -lrte_pmd_af_packet\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lrte_pmd_bnx2x\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_BNX2X_PMD) += -lrte_pmd_bnx2x -lz\n _LDLIBS-$(CONFIG_RTE_LIBRTE_CXGBE_PMD) += -lrte_pmd_cxgbe\n _LDLIBS-$(CONFIG_RTE_LIBRTE_E1000_PMD) += -lrte_pmd_e1000\n _LDLIBS-$(CONFIG_RTE_LIBRTE_ENA_PMD) += -lrte_pmd_ena\n@@ -138,15 +122,15 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_ENIC_PMD) += -lrte_pmd_enic\n _LDLIBS-$(CONFIG_RTE_LIBRTE_FM10K_PMD) += -lrte_pmd_fm10k\n _LDLIBS-$(CONFIG_RTE_LIBRTE_I40E_PMD) += -lrte_pmd_i40e\n _LDLIBS-$(CONFIG_RTE_LIBRTE_IXGBE_PMD) += -lrte_pmd_ixgbe\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += -lrte_pmd_nfp\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX4_PMD) += -lrte_pmd_mlx4 -libverbs\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_MLX5_PMD) += -lrte_pmd_mlx5 -libverbs\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_MPIPE_PMD) += -lrte_pmd_mpipe -lgxio\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_NFP_PMD) += -lrte_pmd_nfp -lm\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL) += -lrte_pmd_null\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += -lrte_pmd_qede\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_PCAP) += -lrte_pmd_pcap -lpcap\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_QEDE_PMD) += -lrte_pmd_qede -lz\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_RING) += -lrte_pmd_ring\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lrte_pmd_szedata2\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SZEDATA2) += -lrte_pmd_szedata2 -lsze2\n _LDLIBS-$(CONFIG_RTE_LIBRTE_VIRTIO_PMD) += -lrte_pmd_virtio\n ifeq ($(CONFIG_RTE_LIBRTE_VHOST),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_VHOST) += -lrte_pmd_vhost\n@@ -156,10 +140,10 @@ _LDLIBS-$(CONFIG_RTE_LIBRTE_VMXNET3_PMD) += -lrte_pmd_vmxnet3_uio\n ifeq ($(CONFIG_RTE_LIBRTE_CRYPTODEV),y)\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -lrte_pmd_aesni_mb\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_MB) += -L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += -lrte_pmd_aesni_gcm\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += -lrte_pmd_aesni_gcm -lcrypto\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_AESNI_GCM) += -L$(AESNI_MULTI_BUFFER_LIB_PATH) -lIPSec_MB\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_NULL_CRYPTO) += -lrte_pmd_null_crypto\n-_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat\n+_LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_QAT) += -lrte_pmd_qat -lcrypto\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += -lrte_pmd_snow3g\n _LDLIBS-$(CONFIG_RTE_LIBRTE_PMD_SNOW3G) += -L$(LIBSSO_PATH)/build -lsso\n endif # CONFIG_RTE_LIBRTE_CRYPTODEV\n", "prefixes": [ "dpdk-dev", "v2", "2/6" ] }