Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134301/?format=api
https://patches.dpdk.org/api/patches/134301/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231114112407.3496460-24-huangdengdui@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114112407.3496460-24-huangdengdui@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114112407.3496460-24-huangdengdui@huawei.com", "date": "2023-11-14T11:23:47", "name": "[v2,23/43] net/af_xdp: use rte strerror", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "7083a5e477b1d87af812f248c863b13c25cba84b", "submitter": { "id": 3066, "url": "https://patches.dpdk.org/api/people/3066/?format=api", "name": "huangdengdui", "email": "huangdengdui@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231114112407.3496460-24-huangdengdui@huawei.com/mbox/", "series": [ { "id": 30292, "url": "https://patches.dpdk.org/api/series/30292/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30292", "date": "2023-11-14T11:23:25", "name": "replace strerror", "version": 2, "mbox": "https://patches.dpdk.org/series/30292/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/134301/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/134301/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 0F48E4332B;\n\tTue, 14 Nov 2023 12:26:31 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 67F5940608;\n\tTue, 14 Nov 2023 12:24:37 +0100 (CET)", "from szxga02-in.huawei.com (szxga02-in.huawei.com [45.249.212.188])\n by mails.dpdk.org (Postfix) with ESMTP id AA69940608\n for <dev@dpdk.org>; Tue, 14 Nov 2023 12:24:12 +0100 (CET)", "from dggpeml500011.china.huawei.com (unknown [172.30.72.54])\n by szxga02-in.huawei.com (SkyGuard) with ESMTP id 4SV3jq44jgzPpKJ;\n Tue, 14 Nov 2023 19:19:59 +0800 (CST)", "from localhost.huawei.com (10.50.165.33) by\n dggpeml500011.china.huawei.com (7.185.36.84) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Tue, 14 Nov 2023 19:24:11 +0800" ], "From": "Dengdui Huang <huangdengdui@huawei.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, <stephen@networkplumber.org>,\n <lihuisong@huawei.com>, <fengchengwen@huawei.com>, <liuyonglong@huawei.com>", "Subject": "[PATCH v2 23/43] net/af_xdp: use rte strerror", "Date": "Tue, 14 Nov 2023 19:23:47 +0800", "Message-ID": "<20231114112407.3496460-24-huangdengdui@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20231114112407.3496460-1-huangdengdui@huawei.com>", "References": "<20231114082539.1858594-44-huangdengdui@huawei.com>\n <20231114112407.3496460-1-huangdengdui@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.50.165.33]", "X-ClientProxiedBy": "dggems705-chm.china.huawei.com (10.3.19.182) To\n dggpeml500011.china.huawei.com (7.185.36.84)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The function strerror() is insecure in a multi-thread environment.\nThis patch uses rte_strerror() to replace it.\n\nCc: stable@dpdk.org\n\nSigned-off-by: Dengdui Huang <huangdengdui@huawei.com>\nAcked-by: Chengwen Feng <fengchengwen@huawei.com>\n---\n drivers/net/af_xdp/rte_eth_af_xdp.c | 12 ++++++------\n 1 file changed, 6 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c\nindex 353c8688ec..087b6e33db 100644\n--- a/drivers/net/af_xdp/rte_eth_af_xdp.c\n+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c\n@@ -1165,7 +1165,7 @@ xsk_umem_info *xdp_umem_configure(struct pmd_internals *internals,\n \t\t\t\t&rxq->fq, &rxq->cq, &usr_config);\n \t\tif (ret) {\n \t\t\tAF_XDP_LOG(ERR, \"Failed to create umem [%d]: [%s]\\n\",\n-\t\t\t\t errno, strerror(errno));\n+\t\t\t\t errno, rte_strerror(errno));\n \t\t\tgoto err;\n \t\t}\n \t\tumem->buffer = base_addr;\n@@ -1367,7 +1367,7 @@ init_uds_sock(struct sockaddr_un *server)\n \tif (connect(sock, (struct sockaddr *)server, sizeof(struct sockaddr_un)) < 0) {\n \t\tclose(sock);\n \t\tAF_XDP_LOG(ERR, \"Error connecting stream socket errno = [%d]: [%s]\\n\",\n-\t\t\t errno, strerror(errno));\n+\t\t\t errno, rte_strerror(errno));\n \t\treturn -1;\n \t}\n \n@@ -1451,7 +1451,7 @@ read_msg(int sock, char *response, struct sockaddr_un *s, int *fd)\n \t\treturn 0;\n \n \tif (msglen < 0) {\n-\t\tAF_XDP_LOG(ERR, \"recvmsg failed, %s\\n\", strerror(errno));\n+\t\tAF_XDP_LOG(ERR, \"recvmsg failed, %s\\n\", rte_strerror(errno));\n \t\treturn -1;\n \t}\n \n@@ -1486,7 +1486,7 @@ make_request_cni(int sock, struct sockaddr_un *server, char *request,\n \t\trval = send_msg(sock, request, req_fd);\n \n \tif (rval < 0) {\n-\t\tAF_XDP_LOG(ERR, \"Write error %s\\n\", strerror(errno));\n+\t\tAF_XDP_LOG(ERR, \"Write error %s\\n\", rte_strerror(errno));\n \t\treturn -1;\n \t}\n \n@@ -1970,7 +1970,7 @@ parse_prog_arg(const char *key __rte_unused,\n \n \tif (access(value, F_OK) != 0) {\n \t\tAF_XDP_LOG(ERR, \"Error accessing %s: %s\\n\",\n-\t\t\t value, strerror(errno));\n+\t\t\t value, rte_strerror(errno));\n \t\treturn -EINVAL;\n \t}\n \n@@ -2421,7 +2421,7 @@ rte_pmd_af_xdp_probe(struct rte_vdev_device *dev)\n \t\tret = rte_mp_action_register(ETH_AF_XDP_MP_KEY, afxdp_mp_send_fds);\n \t\tif (ret < 0 && rte_errno != ENOTSUP) {\n \t\t\tAF_XDP_LOG(ERR, \"%s: Failed to register multi-process IPC callback: %s\\n\",\n-\t\t\t\t name, strerror(rte_errno));\n+\t\t\t\t name, rte_strerror(rte_errno));\n \t\t\treturn -1;\n \t\t}\n \t}\n", "prefixes": [ "v2", "23/43" ] }{ "id": 134301, "url": "