Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/134253/?format=api
{ "id": 134253, "url": "https://patches.dpdk.org/api/patches/134253/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231114084133.3573959-23-haijie1@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231114084133.3573959-23-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231114084133.3573959-23-haijie1@huawei.com", "date": "2023-11-14T08:41:33", "name": "[v2,22/22] devtools: check for some reentrant function", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "7cb890ac2427f71eb608fe615ba713cbafc14ecb", "submitter": { "id": 2935, "url": "https://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231114084133.3573959-23-haijie1@huawei.com/mbox/", "series": [ { "id": 30286, "url": "https://patches.dpdk.org/api/series/30286/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30286", "date": "2023-11-14T08:41:12", "name": "replace strtok with reentrant version", "version": 2, "mbox": "https://patches.dpdk.org/series/30286/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/134253/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/134253/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 38C8443325;\n\tTue, 14 Nov 2023 09:49:17 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 679BF41101;\n\tTue, 14 Nov 2023 09:47:40 +0100 (CET)", "from szxga03-in.huawei.com (szxga03-in.huawei.com [45.249.212.189])\n by mails.dpdk.org (Postfix) with ESMTP id 8EF3640A79\n for <dev@dpdk.org>; Tue, 14 Nov 2023 09:47:23 +0100 (CET)", "from kwepemd100004.china.huawei.com (unknown [172.30.72.57])\n by szxga03-in.huawei.com (SkyGuard) with ESMTP id 4SV0DR4DcjzMmnS;\n Tue, 14 Nov 2023 16:42:47 +0800 (CST)", "from localhost.localdomain (10.67.165.2) by\n kwepemd100004.china.huawei.com (7.221.188.31) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.2.1258.23; Tue, 14 Nov 2023 16:47:21 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Thomas Monjalon <thomas@monjalon.net>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>, <fengchengwen@huawei.com>", "Subject": "[PATCH v2 22/22] devtools: check for some reentrant function", "Date": "Tue, 14 Nov 2023 16:41:33 +0800", "Message-ID": "<20231114084133.3573959-23-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.30.0", "In-Reply-To": "<20231114084133.3573959-1-haijie1@huawei.com>", "References": "<20231113104550.2138654-1-haijie1@huawei.com>\n <20231114084133.3573959-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.67.165.2]", "X-ClientProxiedBy": "dggems701-chm.china.huawei.com (10.3.19.178) To\n kwepemd100004.china.huawei.com (7.221.188.31)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Multiple threads calling the same function may cause condition\nrace issues, which often leads to abnormal behavior and can cause\nmore serious vulnerabilities such as abnormal termination, denial\nof service, and compromised data integrity.\n\nThis patch adds check in checkpatches.sh for strtok, which is\nnon-reentrant.\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\n---\n devtools/checkpatches.sh | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex 066449d147e8..0a936219c069 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -119,6 +119,14 @@ check_forbidden_additions() { # <patch>\n \t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n \t\t\"$1\" || res=1\n \n+\t# refrain from using some non-reentrant functions\n+\tawk -v FOLDERS=\"lib drivers app examples\" \\\n+\t\t-v EXPRESSIONS=\"strtok\\\\\\(\" \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using non-reentrant function strtok, prefer strtok_s' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n \t# refrain from using some pthread functions\n \tawk -v FOLDERS=\"lib drivers app examples\" \\\n \t\t-v EXPRESSIONS=\"pthread_(create|join|detach|set(_?name_np|affinity_np)|attr_set(inheritsched|schedpolicy))\\\\\\(\" \\\n", "prefixes": [ "v2", "22/22" ] }