Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133616/?format=api
https://patches.dpdk.org/api/patches/133616/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231029182300.227879-14-getelson@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231029182300.227879-14-getelson@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231029182300.227879-14-getelson@nvidia.com", "date": "2023-10-29T18:23:00", "name": "[13/13] net/mlx5: add validation support for tags", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5e647377f59593e5591760ade4b9a7806ce4502f", "submitter": { "id": 1882, "url": "https://patches.dpdk.org/api/people/1882/?format=api", "name": "Gregory Etelson", "email": "getelson@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231029182300.227879-14-getelson@nvidia.com/mbox/", "series": [ { "id": 30051, "url": "https://patches.dpdk.org/api/series/30051/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30051", "date": "2023-10-29T18:22:47", "name": "net/mlx5: support more REG C registers", "version": 1, "mbox": "https://patches.dpdk.org/series/30051/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/133616/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/133616/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id AF14643239;\n\tSun, 29 Oct 2023 19:25:09 +0100 (CET)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B98D0427E3;\n\tSun, 29 Oct 2023 19:24:13 +0100 (CET)", "from NAM02-BN1-obe.outbound.protection.outlook.com\n (mail-bn1nam02on2080.outbound.protection.outlook.com [40.107.212.80])\n by mails.dpdk.org (Postfix) with ESMTP id 0497440E4A\n for <dev@dpdk.org>; Sun, 29 Oct 2023 19:24:09 +0100 (CET)", "from SN7P222CA0005.NAMP222.PROD.OUTLOOK.COM (2603:10b6:806:124::22)\n by SA3PR12MB7952.namprd12.prod.outlook.com (2603:10b6:806:316::6)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26; Sun, 29 Oct\n 2023 18:24:07 +0000", "from SN1PEPF0002636D.namprd02.prod.outlook.com\n (2603:10b6:806:124:cafe::7d) by SN7P222CA0005.outlook.office365.com\n (2603:10b6:806:124::22) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.26 via Frontend\n Transport; Sun, 29 Oct 2023 18:24:07 +0000", "from mail.nvidia.com (216.228.117.160) by\n SN1PEPF0002636D.mail.protection.outlook.com (10.167.241.138) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6933.15 via Frontend Transport; Sun, 29 Oct 2023 18:24:07 +0000", "from rnnvmail201.nvidia.com (10.129.68.8) by mail.nvidia.com\n (10.129.200.66) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct\n 2023 11:23:58 -0700", "from nvidia.com (10.126.231.35) by rnnvmail201.nvidia.com\n (10.129.68.8) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 29 Oct\n 2023 11:23:55 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=mtUp3yzmsRwbocR3hBo6aAVaiDXOZTm7Dxgx647sb0Avl1X6axeAuYtE7SBx1fGA1YmsvhX8u/+DMs8kXFpWOnEqgtI82t21viL39bdfUZG5NNu0AcvfKL6KmNRKyzBGzDDm+TGgt/Z6kofrk8LBZQ9jqe6VeusJC8QcgME5VqiRbdYjLYCmgNSpqezf25DaPTT/EtXmuci+AYeNm9L6PN9Aq43LA9JkrCI3Wgysltqpy7iJ/QhFZ72iFiJ6/6LdWgzZT0FdZgTEm+UNQ/CuRt3okTq30aHdRhP7vo4ErB91k5iDEOBeNSLi/N7eqOwojiBX34xyZMIAfQxttMwR8Q==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=fEwZQKklvwd8ru1LpFvPEJKclQc5+1E4dQZYF2gRL/w=;\n b=PH2EunOB8S+EXX+buaDOmjb2s01a7XuwSfI3HK1gISgRh0Vhhbh7Exo9K6cu+YBeM2sOBreyBq6+4xLHVDlpCUzoj2hHYNBTS4tfREAttL08T0T1L/4shDcsvw5HxUFwFMAi8OU0T07u2TRntnTkKMFEjk3d1EVcCF0kP3PZVwyHSm0tYeSYu3LSaykQdSp7cN6x+cHWCN9+GNonhdHa1oy/jm/1XtTMd3RUQclFPLi4vgvRcyiqCRIn6VOEuWrUCIuhHpumtovL7XpJlxn6lDnJvYyerz5LxQ0yPplT1uwiuuoFgE/H6+a3HOp8w4eaIPrRoOmqbz+M4D2ic7mBiw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.160) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none (0)", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=fEwZQKklvwd8ru1LpFvPEJKclQc5+1E4dQZYF2gRL/w=;\n b=uiVDkngcVs6fbHa0HfaJlCCBdBfPITF+JcKtKNgYjXXdZ48DcxvZYVTf1Bs80bQikO5YPD5EhkElfxTLRw/jsUKMlYFoRo88OAf9TceDO5yyriAbUShVxsr0ZmIyKsW1rZ3YcFYc3YC/CQv8kvJ3qniutVkicZqv9I00j+EctToJZ8nGnLBFBVlfPYjXE2FOq189tx8+XtbolNjFi5tUt2xVHbACf/5K8Wi90RpJnlgnvE+0j+cWX2wz5TTFrP1ObKl39sEPgJTpxoir4jrjVA6jfs8NJpERmOMGpViQpytlW1+e/5coEQOVe9RbpT/xUODDa2FK871zFDE96Sk4sA==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.160)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.160 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.160; helo=mail.nvidia.com; pr=C", "From": "Gregory Etelson <getelson@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<getelson@nvidia.com>, <mkashani@nvidia.com>, <rasland@nvidia.com>, \"Ori\n Kam\" <orika@nvidia.com>, Matan Azrad <matan@nvidia.com>, Viacheslav Ovsiienko\n <viacheslavo@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>", "Subject": "[PATCH 13/13] net/mlx5: add validation support for tags", "Date": "Sun, 29 Oct 2023 20:23:00 +0200", "Message-ID": "<20231029182300.227879-14-getelson@nvidia.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231029182300.227879-1-getelson@nvidia.com>", "References": "<20231029182300.227879-1-getelson@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail201.nvidia.com (10.129.68.8) To\n rnnvmail201.nvidia.com (10.129.68.8)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SN1PEPF0002636D:EE_|SA3PR12MB7952:EE_", "X-MS-Office365-Filtering-Correlation-Id": "419820dc-b886-4ef4-97b5-08dbd8ac3d0e", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n 3IrLDIF3Ezbxh8SWweoBl+5Twh4F6q7T+GYHbda7YkSXpuM0wmX3gKeR4AEqg8EBDN0uDi4IiTzi6Bzp7ox8sf2sSTopWeIgw+1D/c4kSG7JAVRsqzJRALVeS6FdK7QUru+HGkbEw/Nvn+RiSTaTNpe/SAlpri0TY6eEfjotAbotfWDH4HRfhcynd+DuIrnaXGNo63TwH7qCgmQ4DTTUb1LmKVQERgodPapkXroL1gs/c8OQRLLaApW+u4ddqefMYoO42fVtc+RIEC66/RF5//QPdKO8ke90UPMhXkFUocBoXvb4aDAz/cqfouIaqOYwiP4GaN0W/6hRm1TJkeUXqf09fyZ40mXBDzOEOBcbfGDVihE/Dv95fm2Vl4ZC34yUTs97VGUAM6sOFhkQ32cr8QZQY/Q+pc1be4WdH/jBnf/Nm+4RljaGmf6er9z+Sqhq858Vrm7b0qT9qC6ZSDCMrLnl+8R9VJBTCwE2iuMMxMX76PorbEOXRiDVQsT+q768zcuiSeBiuJ3vu1vnRiLeOj6OQe3o1LK3pcG2B05p22XL6Y8wPhCT+z6eZ5PeAYwfIKfX742kpLcXX3qbyohM/jXJi8TsCBhtmGK39fhCnR0wU8bdhXas7IXrTriyJ/d+MIM6Ll5R7WRxG84Nezbt6OySjZkek2Yen18SotpfEPk+8Z9BywicihigVDYf+5nSSTpitSyuXtTg8L0KWQOohSFSfpiHEgxhYXQpe7O+cmKJIqOza9tPhNhnTv86VQAR", "X-Forefront-Antispam-Report": "CIP:216.228.117.160; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge1.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(39860400002)(396003)(376002)(136003)(346002)(230922051799003)(64100799003)(451199024)(1800799009)(186009)(82310400011)(36840700001)(46966006)(40470700004)(2906002)(86362001)(41300700001)(4326008)(8676002)(8936002)(5660300002)(40460700003)(36756003)(478600001)(55016003)(40480700001)(47076005)(7696005)(6666004)(1076003)(107886003)(7636003)(6916009)(54906003)(316002)(16526019)(26005)(6286002)(70206006)(336012)(426003)(70586007)(83380400001)(82740400003)(36860700001)(2616005)(356005);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "29 Oct 2023 18:24:07.1991 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 419820dc-b886-4ef4-97b5-08dbd8ac3d0e", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.160];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n SN1PEPF0002636D.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "SA3PR12MB7952", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Ori Kam <orika@nvidia.com>\n\nThis commit introduce validation for invalid tags\n\nSigned-off-by: Ori Kam <orika@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow_hw.c | 30 +++++++++++++++++++++++++++---\n 1 file changed, 27 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow_hw.c b/drivers/net/mlx5/mlx5_flow_hw.c\nindex f2159e40fd..2b1fc519fc 100644\n--- a/drivers/net/mlx5/mlx5_flow_hw.c\n+++ b/drivers/net/mlx5/mlx5_flow_hw.c\n@@ -4049,7 +4049,8 @@ flow_hw_modify_field_is_used(const struct rte_flow_action_modify_field *action,\n }\n \n static int\n-flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n+flow_hw_validate_action_modify_field(struct rte_eth_dev *dev,\n+\t\t\t\t const struct rte_flow_action *action,\n \t\t\t\t const struct rte_flow_action *mask,\n \t\t\t\t struct rte_flow_error *error)\n {\n@@ -4118,6 +4119,22 @@ flow_hw_validate_action_modify_field(const struct rte_flow_action *action,\n \t\tif (ret)\n \t\t\treturn ret;\n \t}\n+\tif ((action_conf->dst.field == RTE_FLOW_FIELD_TAG &&\n+\t action_conf->dst.tag_index >= MLX5_FLOW_HW_TAGS_MAX &&\n+\t action_conf->dst.tag_index != MLX5_LINEAR_HASH_TAG_INDEX) ||\n+\t (action_conf->src.field == RTE_FLOW_FIELD_TAG &&\n+\t action_conf->src.tag_index >= MLX5_FLOW_HW_TAGS_MAX &&\n+\t action_conf->src.tag_index != MLX5_LINEAR_HASH_TAG_INDEX))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t \"tag index is out of range\");\n+\tif ((action_conf->dst.field == RTE_FLOW_FIELD_TAG &&\n+\t flow_hw_get_reg_id(dev, RTE_FLOW_ITEM_TYPE_TAG, action_conf->dst.tag_index) == REG_NON) ||\n+\t (action_conf->src.field == RTE_FLOW_FIELD_TAG &&\n+\t flow_hw_get_reg_id(dev, RTE_FLOW_ITEM_TYPE_TAG, action_conf->src.tag_index) == REG_NON))\n+\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ACTION, action,\n+\t\t\t\t\t \"tag index is out of range\");\n \tif (mask_conf->width != UINT32_MAX)\n \t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\tRTE_FLOW_ERROR_TYPE_ACTION, action,\n@@ -4728,7 +4745,7 @@ mlx5_flow_hw_actions_validate(struct rte_eth_dev *dev,\n \t\t\taction_flags |= MLX5_FLOW_ACTION_METER;\n \t\t\tbreak;\n \t\tcase RTE_FLOW_ACTION_TYPE_MODIFY_FIELD:\n-\t\t\tret = flow_hw_validate_action_modify_field(action, mask,\n+\t\t\tret = flow_hw_validate_action_modify_field(dev, action, mask,\n \t\t\t\t\t\t\t\t error);\n \t\t\tif (ret < 0)\n \t\t\t\treturn ret;\n@@ -5596,7 +5613,14 @@ flow_hw_pattern_validate(struct rte_eth_dev *dev,\n \t\t\tif (tag == NULL)\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n \t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n-\t\t\t\t\t\t\t NULL, \"Tag spec is NULL\");\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Tag spec is NULL\");\n+\t\t\tif (tag->index >= MLX5_FLOW_HW_TAGS_MAX &&\n+\t\t\t tag->index != MLX5_LINEAR_HASH_TAG_INDEX)\n+\t\t\t\treturn rte_flow_error_set(error, EINVAL,\n+\t\t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t\t\t NULL,\n+\t\t\t\t\t\t\t \"Invalid tag index\");\n \t\t\ttag_idx = flow_hw_get_reg_id(dev, RTE_FLOW_ITEM_TYPE_TAG, tag->index);\n \t\t\tif (tag_idx == REG_NON)\n \t\t\t\treturn rte_flow_error_set(error, EINVAL,\n", "prefixes": [ "13/13" ] }{ "id": 133616, "url": "