Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133544/?format=api
{ "id": 133544, "url": "https://patches.dpdk.org/api/patches/133544/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231028061558.1842855-7-chaoyong.he@corigine.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231028061558.1842855-7-chaoyong.he@corigine.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231028061558.1842855-7-chaoyong.he@corigine.com", "date": "2023-10-28T06:15:53", "name": "[06/11] net/nfp: remove redundancy logic of init control BAR", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f3019975db4b851414da30f1f89337b27017c600", "submitter": { "id": 2554, "url": "https://patches.dpdk.org/api/people/2554/?format=api", "name": "Chaoyong He", "email": "chaoyong.he@corigine.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231028061558.1842855-7-chaoyong.he@corigine.com/mbox/", "series": [ { "id": 30037, "url": "https://patches.dpdk.org/api/series/30037/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=30037", "date": "2023-10-28T06:15:47", "name": "Clean up NFP PMD", "version": 1, "mbox": "https://patches.dpdk.org/series/30037/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/133544/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/133544/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 579AF43220;\n\tSat, 28 Oct 2023 08:17:12 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 31F5F406FF;\n\tSat, 28 Oct 2023 08:16:40 +0200 (CEST)", "from NAM10-BN7-obe.outbound.protection.outlook.com\n (mail-bn7nam10on2109.outbound.protection.outlook.com [40.107.92.109])\n by mails.dpdk.org (Postfix) with ESMTP id 357424067B\n for <dev@dpdk.org>; Sat, 28 Oct 2023 08:16:39 +0200 (CEST)", "from SJ0PR13MB5545.namprd13.prod.outlook.com (2603:10b6:a03:424::5)\n by PH7PR13MB6268.namprd13.prod.outlook.com (2603:10b6:510:24f::16)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6933.22; Sat, 28 Oct\n 2023 06:16:37 +0000", "from SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b]) by SJ0PR13MB5545.namprd13.prod.outlook.com\n ([fe80::45b3:d83c:cff2:4a1b%6]) with mapi id 15.20.6933.022; Sat, 28 Oct 2023\n 06:16:37 +0000" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=jVhD5Kn51ItyMbD1jbo8d4MLIp+0G39RXtPjy50mtSbp/Veq5jXfu4mrZ5bjrH6QBaB2M4hbEN95hWkV0G9lx21Td3i+wCBfRpqSbsMP9tp8cmRIxH3U551RKaKmWw9G+9Lhd5mAv7FIGHNiGeS/oRZJmir9eygMIxWzOUVGCNIsHkWuVxQwp4zhuFOeE3CnXaDJFOeDq4Ku6Nj/QxbqJH+PsVoqry73BcH895eJJ/YhjxAZSPmNIpkDfCTmQ/pRpraY2mZe4SYy1rY+JGTY3cR0KUljbDeDpyuForvSr2f7jUKwLZERNfWaOYxQ2JU+ZHpXGUkWtpR4vGzO3M3pyA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=NkfMDfRrTLE3qt/C6yfAZREhgUecWJRL16YRoImUBX0=;\n b=jK9IUWQaRVgejeGFJli58F1VYFBSXxslS3QJB6bJo7FYuwHpcM45HrY5lOiSykm1FUlfOnde6aDWFpU4oDGplEv7XyDjwgu6K2VFJrt6Z52PTxKGNhf/Cbo5IJspNhVEDkBveBTpfSFwmLrXp7ik6PnA4lYUjqQbN8JnDYBmu5RBEWWVtwxoEX4MLOdyMXXdwJ9mjfoHR8ax+ZeH/3XFiiHNqOmOeZ0pHc5o3PtiiJ57oepjifWFiRYM5JrEJUc+2JApP5XM3XcyiLjnejCKHyApVKllF6fNqdSzE3DRYanE9vLQWO9KFk/lqfxBDSBkfN0G+CSRXcDsYI4gKtOZmA==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass\n smtp.mailfrom=corigine.com; dmarc=pass action=none header.from=corigine.com;\n dkim=pass header.d=corigine.com; arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=corigine.onmicrosoft.com; s=selector2-corigine-onmicrosoft-com;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=NkfMDfRrTLE3qt/C6yfAZREhgUecWJRL16YRoImUBX0=;\n b=Nc4L4ygcSvLsXsKTMDmkLKS/wRR6clXB9dSfSkMNuOvcKuw9qFboPNAUzaNcEMuJaOfFT6OZtkc3dJkDvl2ffk82AiAGHrHgx2WojRxelUn1q0FFKu32td5phdEr2xkGNTz8FU8MwgTI85RObmqmmskYnxBjPjhRuliNArzOlDc=", "Authentication-Results": "dkim=none (message not signed)\n header.d=none;dmarc=none action=none header.from=corigine.com;", "From": "Chaoyong He <chaoyong.he@corigine.com>", "To": "dev@dpdk.org", "Cc": "oss-drivers@corigine.com, Chaoyong He <chaoyong.he@corigine.com>,\n Peng Zhang <peng.zhang@corigine.com>", "Subject": "[PATCH 06/11] net/nfp: remove redundancy logic of init control BAR", "Date": "Sat, 28 Oct 2023 14:15:53 +0800", "Message-Id": "<20231028061558.1842855-7-chaoyong.he@corigine.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231028061558.1842855-1-chaoyong.he@corigine.com>", "References": "<20231028061558.1842855-1-chaoyong.he@corigine.com>", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-ClientProxiedBy": "SJ0PR03CA0246.namprd03.prod.outlook.com\n (2603:10b6:a03:3a0::11) To SJ0PR13MB5545.namprd13.prod.outlook.com\n (2603:10b6:a03:424::5)", "MIME-Version": "1.0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "SJ0PR13MB5545:EE_|PH7PR13MB6268:EE_", "X-MS-Office365-Filtering-Correlation-Id": "191c80ae-d647-4dca-ef1b-08dbd77d70dc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n CO9EDswBAlQbRgQf++MMbAHI5a7/a14dHsTPKjMPjHcsgrWMxR/DuGJzy+/+w9caWXeUoQEWfOfMJznHD0QyVbBO6TMsksDxl4ashgZnH+dW8IW9ZHnPr4IqTnXa1xv723Jp1aIHBrdZNV/uQWojGahay2FSKGgiqUtU6PruuI5ipCB29vKXZMc/olRlvopI2myktyDkw+L+6tGLebxXsd8y7QH3iOPCVUQjxfmQbcb3+c02fQOmIMDCLrP1xa6qF7m2bUTTVTi6bYoiM/X4c6mkuNqSk7bJoIGyYzoOEuMrogm3d9kVQ/gyXs4XgbljGQxCk4hU5cHTpJArZE/A2m+gFPNAWkyCTSWrxXcCPorpbd23K4DNSmg1xYw5VKbU5kVvSp+NKByLOutV5qaC3DlW3A2k+HKyUy6dNNn53eb++v2YeBGZk3/L89Moz5HU+laAaU747bw5rKED09WMlCzjbMZFnXBTYnhkbWQEqxj3K7ycNTilXFyif3BTmEFXhh/e/he6dpuSbkESCk4regUXhDpu16SN6SNLrhN48bchV5nSGKwJiHPFchGUfQETxxDUf+sulmmABoG6BX1fio6PJzb3+0GXnC6aQsQ2HVhvyvYqDT4Dp4pHm4XH4WIDmh4SyPgBWUiaU2ntrQDoi4b3w8wvhDfIOdzMpi+f8RA=", "X-Forefront-Antispam-Report": "CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:SJ0PR13MB5545.namprd13.prod.outlook.com; PTR:; CAT:NONE;\n SFS:(13230031)(396003)(39830400003)(366004)(346002)(376002)(136003)(230922051799003)(186009)(1800799009)(451199024)(64100799003)(2906002)(38100700002)(83380400001)(1076003)(107886003)(5660300002)(2616005)(86362001)(6512007)(41300700001)(44832011)(36756003)(38350700005)(66476007)(316002)(6916009)(66946007)(54906003)(66556008)(52116002)(6666004)(6506007)(6486002)(8676002)(26005)(478600001)(4326008)(8936002);\n DIR:OUT; SFP:1102;", "X-MS-Exchange-AntiSpam-MessageData-ChunkCount": "1", "X-MS-Exchange-AntiSpam-MessageData-0": "\n z+JdfaSNcAVNgJ/YWx8zRTleYU7zs4tNyYTRyW05OT1oUEztrZzI9Nh2L4GO4oeFhXnbOgu4f7hE+j8a2eDnheEFr97OWbJyTIjQEPi3KgDgZFf7sW8+XM9oX/KTFlRGleIw8dxWMJBskLP71clBx7fL2TByau6+zQBx20bMs9AapIfM6Gku80V8uNQ0uNIQcLdb+MX6oEMm3aWZEV/Im9aQvOd5bQfMCc58Ct45zSKa9oxrHHWN7CU7UrMZ5GOuYb4zWzU4HbfexZbjd9hhOfQW5bxBwlo52VJyEHZMgcQU1zZpZw2HGJ2Tw7HxYaT0iPY/15AL1ZL2fOGbE5u2lknWyuHokekJtsSLS4/Y3A5+KLpXRkNV9orsThu7K4/ts0YAKuN/QLSqrFfR1ORnJvHzHQtgOWGQVWwQr61NkMRuY+zlR36wRko2X8c7VhoOeM8k0ne4N1zZh5aNJiQYkNVJDZMzflJGxiax5P/L0wVkJYTtmaWzmzn8AjLI/+0zp5CRpThcvpvAuc/mXheMtmVMoklYHgCOoGBnW0SBrO2yR8MYTdBwuAUiBQXirICS4VRfh98jNY1jZpJuOo7en7g1G9sWTtuZvHY3Y0wM71DWud0ad95KrycXU4XwfOdzfF6oJZ41bKEhTPUCVPZd5U9ybsDjf70t+ZiPqG2ANMXnQmW/deTt5htXlYsJfU2rZgUP/7IcMAPxwIEtutgb/gcdyuVD2DWRHncsjWjE8bOOhDEBOmWCGCmqpRq2KwuektiuhNYOa6ObigzNHXObl9F2T5DgYZzo7rgwMGZwneDQ+tkKk631O/Z5hJ7vOTCven8ixzIlXuJOVhyU51MeMXv7a2e6f4H6/2EiV+BSjb/YDDlfohwa+352IEbkNuS71N5Bu7b+JXVYnA2wTuukz6mCdHE3mY9RM1azIlLL0snoLnGdgiq3OnZKjWGaYsHYKqUXfk534jBcFIsXLJMA1MzRGE5x23P5swFv9h584q3FUw6KFVOByyiedyEexqcXoTENgX8dHGqnhgOjhy8+iyaFXV/Uj/F2vomK/6+iZ9h7JYdP7YR5TO5Bczc8+dRqRdiuAe2t7wegjAzET52RAXgsYqBxQ0w58Ekeam8S9/LHdTpa3g5W3yaShvUSuD80yzhcHpDHNXkIGVlxhqZYBFIlbHxzskY1jQ7blVy+QY7V7AS+mTFhvWdp+61odHDe9+WEUkPCnXIc3n8+DYWlnROwcXOJ8Cs4hfSfb+rBrUJ0eeYWwM8n2WIBJzmJ9hB9XN/KEstxxb5u2E1HP0O9yY/P0xhqQoYpXEQNfNOiImALDjuSBjyPnb9lM+t04cplJ6b1LKA8EkULDe8mlFr5lpObSY5/mMRxypSm9aOpIx7gKU0BSM0mcu54Lh6iaYDkFjnp/9EV7zSyZcIzo6RyuPLp+ZVecsXuMBKVlCQO3jFYEIlxm7T5Aj7/+MOA+Ak1s9d3H2ffJvXiIqQKBcAgYQMWoeQZc9VIe0f0O7UhHUogdJVEnOI6dA9Yz5bb6kdZKiWn8tOP9ismj7Vxw+KJLhF/oF6t1xXVo5FPfBSj8iv2Z17bdsSw8kbOEjUDiy26MiQm1KC3F0Qe/KDEAEaFPA==", "X-OriginatorOrg": "corigine.com", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 191c80ae-d647-4dca-ef1b-08dbd77d70dc", "X-MS-Exchange-CrossTenant-AuthSource": "SJ0PR13MB5545.namprd13.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Internal", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "28 Oct 2023 06:16:37.0662 (UTC)", "X-MS-Exchange-CrossTenant-FromEntityHeader": "Hosted", "X-MS-Exchange-CrossTenant-Id": "fe128f2c-073b-4c20-818e-7246a585940c", "X-MS-Exchange-CrossTenant-MailboxType": "HOSTED", "X-MS-Exchange-CrossTenant-UserPrincipalName": "\n 7VIUyiHt6FmJlPb7Gi8hH8bHNT3RB2pM0p+j52nuqRqtlfUTiiM4VwD0LZmxU+NqLL3Ff8yYmcGp6lTgZoGjTBqam2wF7hOIRJRIbYBKObo=", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PH7PR13MB6268", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "There are two initialize statements of control BAR in 'nfp_net_init()'\nand the first one is unneeded, and what it really use is the check of\nNULL value of the 'mem_resource'. So we move the check of 'mem_resource'\nto the start of probe logic.\n\nSigned-off-by: Chaoyong He <chaoyong.he@corigine.com>\nReviewed-by: Peng Zhang <peng.zhang@corigine.com>\n---\n drivers/net/nfp/nfp_ethdev.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/nfp/nfp_ethdev.c b/drivers/net/nfp/nfp_ethdev.c\nindex 7c5b780e82..8057452799 100644\n--- a/drivers/net/nfp/nfp_ethdev.c\n+++ b/drivers/net/nfp/nfp_ethdev.c\n@@ -503,12 +503,6 @@ nfp_net_init(struct rte_eth_dev *eth_dev)\n \n \trte_eth_copy_pci_info(eth_dev, pci_dev);\n \n-\thw->ctrl_bar = pci_dev->mem_resource[0].addr;\n-\tif (hw->ctrl_bar == NULL) {\n-\t\tPMD_DRV_LOG(ERR, \"hw->ctrl_bar is NULL. BAR0 not configured\");\n-\t\treturn -ENODEV;\n-\t}\n-\n \tif (port == 0) {\n \t\tuint32_t min_size;\n \n@@ -890,6 +884,11 @@ nfp_pf_init(struct rte_pci_device *pci_dev)\n \tif (pci_dev == NULL)\n \t\treturn -ENODEV;\n \n+\tif (pci_dev->mem_resource[0].addr == NULL) {\n+\t\tPMD_INIT_LOG(ERR, \"The address of BAR0 is NULL.\");\n+\t\treturn -ENODEV;\n+\t}\n+\n \tdev_info = nfp_dev_info_get(pci_dev->id.device_id);\n \tif (dev_info == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Not supported device ID\");\n@@ -1089,6 +1088,11 @@ nfp_pf_secondary_init(struct rte_pci_device *pci_dev)\n \tif (pci_dev == NULL)\n \t\treturn -ENODEV;\n \n+\tif (pci_dev->mem_resource[0].addr == NULL) {\n+\t\tPMD_INIT_LOG(ERR, \"The address of BAR0 is NULL.\");\n+\t\treturn -ENODEV;\n+\t}\n+\n \tdev_info = nfp_dev_info_get(pci_dev->id.device_id);\n \tif (dev_info == NULL) {\n \t\tPMD_INIT_LOG(ERR, \"Not supported device ID\");\n", "prefixes": [ "06/11" ] }