Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1335/?format=api
https://patches.dpdk.org/api/patches/1335/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/4727e2e183c2ed6e59d60569aa477ed1f1f24318.1416318389.git.e_zhumabekov@sts.kz/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<4727e2e183c2ed6e59d60569aa477ed1f1f24318.1416318389.git.e_zhumabekov@sts.kz>", "list_archive_url": "https://inbox.dpdk.org/dev/4727e2e183c2ed6e59d60569aa477ed1f1f24318.1416318389.git.e_zhumabekov@sts.kz", "date": "2014-11-18T14:05:09", "name": "[dpdk-dev,v4,5/5] test: remove redundant compile checks", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "4e34c1b1af54cccfbbab31da280081b1cefa72c8", "submitter": { "id": 36, "url": "https://patches.dpdk.org/api/people/36/?format=api", "name": "Yerden Zhumabekov", "email": "e_zhumabekov@sts.kz" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/4727e2e183c2ed6e59d60569aa477ed1f1f24318.1416318389.git.e_zhumabekov@sts.kz/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1335/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1335/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id B00947F11;\n\tTue, 18 Nov 2014 14:54:12 +0100 (CET)", "from mgw.gov.kz (mgw.gov.kz [89.218.88.242])\n\tby dpdk.org (Postfix) with ESMTP id 6D7075323\n\tfor <dev@dpdk.org>; Tue, 18 Nov 2014 14:54:09 +0100 (CET)", "from mgw.gov.kz (mx.ctsat.kz [178.89.4.95])\n\tby mgw.gov.kz with ESMTP id sAIE4S1d014469-sAIE4S1f014469\n\t(version=TLSv1.0 cipher=AES128-SHA bits=128 verify=NO);\n\tTue, 18 Nov 2014 20:04:28 +0600", "from EXCASHUB2.rgp.local (192.168.40.53) by EdgeForefront.rgp.local\n\t(192.168.40.59) with Microsoft SMTP Server (TLS) id 14.2.247.3;\n\tTue, 18 Nov 2014 20:04:17 +0600", "from r220.rgp.local (192.168.59.10) by excashub2.rgp.local\n\t(192.168.40.48) with Microsoft SMTP Server (TLS) id 14.2.247.3;\n\tTue, 18 Nov 2014 20:04:39 +0600" ], "From": "Yerden Zhumabekov <e_zhumabekov@sts.kz>", "To": "<dev@dpdk.org>", "Date": "Tue, 18 Nov 2014 20:05:09 +0600", "Message-ID": "<4727e2e183c2ed6e59d60569aa477ed1f1f24318.1416318389.git.e_zhumabekov@sts.kz>", "X-Mailer": "git-send-email 1.7.9.5", "In-Reply-To": "<cover.1416318389.git.e_zhumabekov@sts.kz>", "References": "<1409724351-23786-1-git-send-email-e_zhumabekov@sts.kz>\n\t<cover.1416318389.git.e_zhumabekov@sts.kz>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Originating-IP": "[192.168.59.10]", "X-FEAS-SYSTEM-WL": "e_zhumabekov@sts.kz", "Subject": "[dpdk-dev] [PATCH v4 5/5] test: remove redundant compile checks", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "Since rte_hash_crc() can now be run regardless of SSE4.2 support,\nwe can safely remove compile checks for RTE_MACHINE_CPUFLAG_SSE4_2\nin test utilities.\n\nSigned-off-by: Yerden Zhumabekov <e_zhumabekov@sts.kz>\n---\n app/test/test_hash.c | 7 -------\n app/test/test_hash_perf.c | 11 -----------\n 2 files changed, 18 deletions(-)", "diff": "diff --git a/app/test/test_hash.c b/app/test/test_hash.c\nindex 178ec3f..76b1b8f 100644\n--- a/app/test/test_hash.c\n+++ b/app/test/test_hash.c\n@@ -55,10 +55,7 @@\n #include <rte_hash.h>\n #include <rte_fbk_hash.h>\n #include <rte_jhash.h>\n-\n-#ifdef RTE_MACHINE_CPUFLAG_SSE4_2\n #include <rte_hash_crc.h>\n-#endif\n \n /*******************************************************************************\n * Hash function performance test configuration section. Each performance test\n@@ -67,11 +64,7 @@\n * The five arrays below control what tests are performed. Every combination\n * from the array entries is tested.\n */\n-#ifdef RTE_MACHINE_CPUFLAG_SSE4_2\n static rte_hash_function hashtest_funcs[] = {rte_jhash, rte_hash_crc};\n-#else\n-static rte_hash_function hashtest_funcs[] = {rte_jhash};\n-#endif\n static uint32_t hashtest_initvals[] = {0};\n static uint32_t hashtest_key_lens[] = {0, 2, 4, 5, 6, 7, 8, 10, 11, 15, 16, 21, 31, 32, 33, 63, 64};\n /******************************************************************************/\ndiff --git a/app/test/test_hash_perf.c b/app/test/test_hash_perf.c\nindex be34957..05a88ec 100644\n--- a/app/test/test_hash_perf.c\n+++ b/app/test/test_hash_perf.c\n@@ -56,10 +56,7 @@\n #include <rte_hash.h>\n #include <rte_fbk_hash.h>\n #include <rte_jhash.h>\n-\n-#ifdef RTE_MACHINE_CPUFLAG_SSE4_2\n #include <rte_hash_crc.h>\n-#endif\n \n /* Types of hash table performance test that can be performed */\n enum hash_test_t {\n@@ -97,11 +94,7 @@ struct tbl_perf_test_params {\n */\n #define HASHTEST_ITERATIONS 1000000\n \n-#ifdef RTE_MACHINE_CPUFLAG_SSE4_2\n static rte_hash_function hashtest_funcs[] = {rte_jhash, rte_hash_crc};\n-#else\n-static rte_hash_function hashtest_funcs[] = {rte_jhash};\n-#endif\n static uint32_t hashtest_initvals[] = {0};\n static uint32_t hashtest_key_lens[] = {2, 4, 5, 6, 7, 8, 10, 11, 15, 16, 21, 31, 32, 33, 63, 64};\n /******************************************************************************/\n@@ -243,7 +236,6 @@ struct tbl_perf_test_params tbl_perf_params[] =\n { LOOKUP, ITERATIONS, 1048576, 4, 64, rte_jhash, 0},\n { LOOKUP, ITERATIONS, 1048576, 8, 64, rte_jhash, 0},\n { LOOKUP, ITERATIONS, 1048576, 16, 64, rte_jhash, 0},\n-#ifdef RTE_MACHINE_CPUFLAG_SSE4_2\n /* Small table, add */\n /* Test type | Iterations | Entries | BucketSize | KeyLen | HashFunc | InitVal */\n { ADD_ON_EMPTY, 1024, 1024, 1, 16, rte_hash_crc, 0},\n@@ -376,7 +368,6 @@ struct tbl_perf_test_params tbl_perf_params[] =\n { LOOKUP, ITERATIONS, 1048576, 4, 64, rte_hash_crc, 0},\n { LOOKUP, ITERATIONS, 1048576, 8, 64, rte_hash_crc, 0},\n { LOOKUP, ITERATIONS, 1048576, 16, 64, rte_hash_crc, 0},\n-#endif\n };\n \n /******************************************************************************/\n@@ -423,10 +414,8 @@ static const char *get_hash_name(rte_hash_function f)\n \tif (f == rte_jhash)\n \t\treturn \"jhash\";\n \n-#ifdef RTE_MACHINE_CPUFLAG_SSE4_2\n \tif (f == rte_hash_crc)\n \t\treturn \"rte_hash_crc\";\n-#endif\n \n \treturn \"UnknownHash\";\n }\n", "prefixes": [ "dpdk-dev", "v4", "5/5" ] }{ "id": 1335, "url": "