Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/133268/?format=api
{ "id": 133268, "url": "https://patches.dpdk.org/api/patches/133268/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231024174315.318408-1-drc@linux.vnet.ibm.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231024174315.318408-1-drc@linux.vnet.ibm.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231024174315.318408-1-drc@linux.vnet.ibm.com", "date": "2023-10-24T17:43:15", "name": "[v3] eal/linux: verify mmu type for DPDK support (ppc64le)", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f7468fbf333b4d64c413d8c189becc81beaa4b42", "submitter": { "id": 1256, "url": "https://patches.dpdk.org/api/people/1256/?format=api", "name": "David Christensen", "email": "drc@linux.vnet.ibm.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231024174315.318408-1-drc@linux.vnet.ibm.com/mbox/", "series": [ { "id": 29968, "url": "https://patches.dpdk.org/api/series/29968/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29968", "date": "2023-10-24T17:43:15", "name": "[v3] eal/linux: verify mmu type for DPDK support (ppc64le)", "version": 3, "mbox": "https://patches.dpdk.org/series/29968/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/133268/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/133268/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9EC5E4316B;\n\tTue, 24 Oct 2023 19:43:36 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 47624402A9;\n\tTue, 24 Oct 2023 19:43:36 +0200 (CEST)", "from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com\n [148.163.156.1]) by mails.dpdk.org (Postfix) with ESMTP id C77D74021D\n for <dev@dpdk.org>; Tue, 24 Oct 2023 19:43:34 +0200 (CEST)", "from pps.filterd (m0353729.ppops.net [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39OHbQ0h010471; Tue, 24 Oct 2023 17:43:31 GMT", "from pps.reinject (localhost [127.0.0.1])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3txjfyg8y7-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 24 Oct 2023 17:43:31 +0000", "from m0353729.ppops.net (m0353729.ppops.net [127.0.0.1])\n by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 39OHcSuD016389;\n Tue, 24 Oct 2023 17:43:30 GMT", "from ppma21.wdc07v.mail.ibm.com\n (5b.69.3da9.ip4.static.sl-reverse.com [169.61.105.91])\n by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 3txjfyg8x9-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 24 Oct 2023 17:43:30 +0000", "from pps.filterd (ppma21.wdc07v.mail.ibm.com [127.0.0.1])\n by ppma21.wdc07v.mail.ibm.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39OGRQDn026839; Tue, 24 Oct 2023 17:43:29 GMT", "from smtprelay04.wdc07v.mail.ibm.com ([172.16.1.71])\n by ppma21.wdc07v.mail.ibm.com (PPS) with ESMTPS id 3tvsyns4mu-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT);\n Tue, 24 Oct 2023 17:43:29 +0000", "from smtpav03.wdc07v.mail.ibm.com (smtpav03.wdc07v.mail.ibm.com\n [10.39.53.230])\n by smtprelay04.wdc07v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id\n 39OHhSY441878256\n (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK);\n Tue, 24 Oct 2023 17:43:28 GMT", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id B24115805C;\n Tue, 24 Oct 2023 17:43:28 +0000 (GMT)", "from smtpav03.wdc07v.mail.ibm.com (unknown [127.0.0.1])\n by IMSVA (Postfix) with ESMTP id E165558054;\n Tue, 24 Oct 2023 17:43:27 +0000 (GMT)", "from ltc19u30.ibm.com (unknown [9.114.224.51])\n by smtpav03.wdc07v.mail.ibm.com (Postfix) with ESMTP;\n Tue, 24 Oct 2023 17:43:27 +0000 (GMT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com;\n h=from : to : cc : subject\n : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding; s=pp1;\n bh=m1Rjrw1NTha2EBzRvkaPB2f1fpcUSsucUWAxsCocrPY=;\n b=nmAM+QFXNGIpv6D/9/bEXZ+N3XGlwxuQNQvV42LXFuQgdtJ7upTcNe87plWd7ofk2UZZ\n Jkp/fnLmCQQ/F4fasDjgx7hZs/QFmMFHQcoPQG5zjnL6U5ERkmK3/ZQtcrna0J1o7c6d\n tUDFrBtTIuBGbYe9oJZ62xC+KBnQ6oTkUZ0y/t9YvpYPccGHENRZyghe57t6Q/PpjiMn\n 46yTEoFq5Hbf/2eDVkugoIODnvdRr6O9PPcSgC6OTlxflBlZAC6msKGQf0+EfyuH5AkM\n 63kzJ1SH38lmJ5YZjjfdsywdQHo/j3n+t2FJ+pnUhLbqzhkYpczfmGH6shsl+lQpfjDr 1g==", "From": "David Christensen <drc@linux.vnet.ibm.com>", "To": "thomas@monjalon.net, Ruifeng Wang <ruifeng.wang@arm.com>,\n Min Zhou <zhoumin@loongson.cn>, David Christensen <drc@linux.vnet.ibm.com>,\n Stanislaw Kardach <kda@semihalf.com>,\n Bruce Richardson <bruce.richardson@intel.com>,\n Konstantin Ananyev <konstantin.v.ananyev@yandex.ru>", "Cc": "dev@dpdk.org", "Subject": "[PATCH v3] eal/linux: verify mmu type for DPDK support (ppc64le)", "Date": "Tue, 24 Oct 2023 13:43:15 -0400", "Message-Id": "<20231024174315.318408-1-drc@linux.vnet.ibm.com>", "X-Mailer": "git-send-email 2.39.1", "In-Reply-To": "<20231023231939.188417-1-drc@linux.vnet.ibm.com>", "References": "<20231023231939.188417-1-drc@linux.vnet.ibm.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-TM-AS-GCONF": "00", "X-Proofpoint-GUID": "5jltskxX6XwQbNRgU3cxrdW4dMAP3JNO", "X-Proofpoint-ORIG-GUID": "XOKfeokEUwvX8ob4HMv_CwoNHs7a5WWM", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-24_17,2023-10-24_01,2023-05-22_02", "X-Proofpoint-Spam-Details": "rule=outbound_notspam policy=outbound score=0\n suspectscore=0 clxscore=1015\n lowpriorityscore=0 malwarescore=0 priorityscore=1501 mlxlogscore=999\n spamscore=0 mlxscore=0 phishscore=0 bulkscore=0 impostorscore=0\n adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1\n engine=8.12.0-2310170001 definitions=main-2310240152", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "IBM POWER systems support more than one type of memory management unit\n(MMU). The Power ISA 3.0 specification, which applies to P9 and later\nCPUs, defined a new Radix MMU which, among other things, allows an\nanonymous memory page mapping to be converted into a hugepage mapping\nat a specific address. This is a required feature in DPDK so we need\nto test the MMU type when POWER systems are used and provide a more\nuseful error message for the user when running on an unsupported\nsystem.\n\nBugzilla ID: 1221\n\nSuggested-by: Thomas Monjalon <thomas@monjalon.net>\nSigned-off-by: David Christensen <drc@linux.vnet.ibm.com>\n---\nv3:\n * Move test function from \"common\" tree to \"linux\"\nv2:\n * Replace ifdef with arch specific functions\n---\n lib/eal/arm/meson.build | 1 +\n lib/eal/arm/rte_mmu.c | 11 ++++++\n lib/eal/linux/eal.c | 8 +++++\n lib/eal/linux/eal_linux_private.h | 17 ++++++++++\n lib/eal/loongarch/meson.build | 1 +\n lib/eal/loongarch/rte_mmu.c | 11 ++++++\n lib/eal/ppc/meson.build | 1 +\n lib/eal/ppc/rte_mmu.c | 56 +++++++++++++++++++++++++++++++\n lib/eal/riscv/meson.build | 1 +\n lib/eal/riscv/rte_mmu.c | 11 ++++++\n lib/eal/x86/meson.build | 1 +\n lib/eal/x86/rte_mmu.c | 11 ++++++\n 12 files changed, 130 insertions(+)\n create mode 100644 lib/eal/arm/rte_mmu.c\n create mode 100644 lib/eal/linux/eal_linux_private.h\n create mode 100644 lib/eal/loongarch/rte_mmu.c\n create mode 100644 lib/eal/ppc/rte_mmu.c\n create mode 100644 lib/eal/riscv/rte_mmu.c\n create mode 100644 lib/eal/x86/rte_mmu.c\n\n--\n2.39.1", "diff": "diff --git a/lib/eal/arm/meson.build b/lib/eal/arm/meson.build\nindex dca1106aaeec..6fba3d6ba7b8 100644\n--- a/lib/eal/arm/meson.build\n+++ b/lib/eal/arm/meson.build\n@@ -7,5 +7,6 @@ sources += files(\n 'rte_cpuflags.c',\n 'rte_cycles.c',\n 'rte_hypervisor.c',\n+ 'rte_mmu.c',\n 'rte_power_intrinsics.c',\n )\ndiff --git a/lib/eal/arm/rte_mmu.c b/lib/eal/arm/rte_mmu.c\nnew file mode 100644\nindex 000000000000..3c043be10236\n--- /dev/null\n+++ b/lib/eal/arm/rte_mmu.c\n@@ -0,0 +1,11 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) IBM Corporation 2023\n+ */\n+\n+#include <linux/eal_linux_private.h>\n+\n+bool\n+eal_mmu_supported_linux_arch(void)\n+{\n+\treturn true;\n+}\ndiff --git a/lib/eal/linux/eal.c b/lib/eal/linux/eal.c\nindex 5f4b2fb0054a..6f838265b15b 100644\n--- a/lib/eal/linux/eal.c\n+++ b/lib/eal/linux/eal.c\n@@ -44,6 +44,7 @@\n\n #include <telemetry_internal.h>\n #include \"eal_private.h\"\n+#include \"eal_linux_private.h\"\n #include \"eal_thread.h\"\n #include \"eal_internal_cfg.h\"\n #include \"eal_filesystem.h\"\n@@ -983,6 +984,13 @@ rte_eal_init(int argc, char **argv)\n \t\treturn -1;\n \t}\n\n+\t/* verify if DPDK supported on architecture MMU */\n+\tif (!eal_mmu_supported_linux_arch()) {\n+\t\trte_eal_init_alert(\"unsupported MMU type.\");\n+\t\trte_errno = ENOTSUP;\n+\t\treturn -1;\n+\t}\n+\n \tif (!__atomic_compare_exchange_n(&run_once, &has_run, 1, 0,\n \t\t\t\t\t__ATOMIC_RELAXED, __ATOMIC_RELAXED)) {\n \t\trte_eal_init_alert(\"already called initialization.\");\ndiff --git a/lib/eal/linux/eal_linux_private.h b/lib/eal/linux/eal_linux_private.h\nnew file mode 100644\nindex 000000000000..b7eaac922849\n--- /dev/null\n+++ b/lib/eal/linux/eal_linux_private.h\n@@ -0,0 +1,17 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2023 IBM Corporation\n+ */\n+\n+#ifndef _EAL_LINUX_PRIVATE_H_\n+#define _EAL_LINUX_PRIVATE_H_\n+\n+#include <stdbool.h>\n+\n+/**\n+ * Check for architecture supported MMU.\n+ *\n+ * This function is private to the EAL for Linux.\n+ */\n+bool eal_mmu_supported_linux_arch(void);\n+\n+#endif /* _EAL_LINUX_PRIVATE_H_ */\ndiff --git a/lib/eal/loongarch/meson.build b/lib/eal/loongarch/meson.build\nindex 4dcc27babb9b..3acfe6c3bd77 100644\n--- a/lib/eal/loongarch/meson.build\n+++ b/lib/eal/loongarch/meson.build\n@@ -7,5 +7,6 @@ sources += files(\n 'rte_cpuflags.c',\n 'rte_cycles.c',\n 'rte_hypervisor.c',\n+ 'rte_mmu.c',\n 'rte_power_intrinsics.c',\n )\ndiff --git a/lib/eal/loongarch/rte_mmu.c b/lib/eal/loongarch/rte_mmu.c\nnew file mode 100644\nindex 000000000000..3c043be10236\n--- /dev/null\n+++ b/lib/eal/loongarch/rte_mmu.c\n@@ -0,0 +1,11 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) IBM Corporation 2023\n+ */\n+\n+#include <linux/eal_linux_private.h>\n+\n+bool\n+eal_mmu_supported_linux_arch(void)\n+{\n+\treturn true;\n+}\ndiff --git a/lib/eal/ppc/meson.build b/lib/eal/ppc/meson.build\nindex 71c7ac870da6..eeeaeee240b7 100644\n--- a/lib/eal/ppc/meson.build\n+++ b/lib/eal/ppc/meson.build\n@@ -7,5 +7,6 @@ sources += files(\n 'rte_cpuflags.c',\n 'rte_cycles.c',\n 'rte_hypervisor.c',\n+ 'rte_mmu.c',\n 'rte_power_intrinsics.c',\n )\ndiff --git a/lib/eal/ppc/rte_mmu.c b/lib/eal/ppc/rte_mmu.c\nnew file mode 100644\nindex 000000000000..fd762defd72d\n--- /dev/null\n+++ b/lib/eal/ppc/rte_mmu.c\n@@ -0,0 +1,56 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) IBM Corporation 2023\n+ */\n+\n+#include \"stdio.h\"\n+#include \"string.h\"\n+#include \"rte_log.h\"\n+#include <linux/eal_linux_private.h>\n+\n+bool\n+eal_mmu_supported_linux_arch(void)\n+{\n+\tstatic const char proc_cpuinfo[] = \"/proc/cpuinfo\";\n+\tstatic const char str_mmu[] = \"MMU\";\n+\tstatic const char str_radix[] = \"Radix\";\n+\tstatic const char err_msg[] = \"DPDK on PPC64 requires radix-mmu\";\n+\tchar buf[512];\n+\tchar *ret = NULL;\n+\tFILE *f = fopen(proc_cpuinfo, \"r\");\n+\n+\tif (f == NULL) {\n+\t\tRTE_LOG(ERR, EAL, \"Cannot open %s\\n\", proc_cpuinfo);\n+\t\treturn false;\n+\t}\n+\n+\t/*\n+\t * Example \"MMU\" in /proc/cpuinfo:\n+\t * ...\n+\t * model\t: 8335-GTW\n+\t * machine\t: PowerNV 8335-GTW\n+\t * firmware\t: OPAL\n+\t * MMU\t\t: Radix\n+\t * ... or ...\n+\t * model : IBM,9009-22A\n+\t * machine : CHRP IBM,9009-22A\n+\t * MMU : Hash\n+\t */\n+\twhile (fgets(buf, sizeof(buf), f) != NULL) {\n+\t\tret = strstr(buf, str_mmu);\n+\t\tif (ret == NULL)\n+\t\t\tcontinue;\n+\t\tret += sizeof(str_mmu) - 1;\n+\t\tret = strchr(ret, ':');\n+\t\tif (ret == NULL)\n+\t\t\tcontinue;\n+\t\tret = strstr(ret, str_radix);\n+\t\tbreak;\n+\t}\n+\tfclose(f);\n+\n+\tif (ret == NULL) {\n+\t\tfprintf(stderr, \"EAL: FATAL: %s\\n\", err_msg);\n+\t\tRTE_LOG(ERR, EAL, \"%s\\n\", err_msg);\n+\t}\n+\treturn (ret != NULL);\n+}\ndiff --git a/lib/eal/riscv/meson.build b/lib/eal/riscv/meson.build\nindex dca1106aaeec..6fba3d6ba7b8 100644\n--- a/lib/eal/riscv/meson.build\n+++ b/lib/eal/riscv/meson.build\n@@ -7,5 +7,6 @@ sources += files(\n 'rte_cpuflags.c',\n 'rte_cycles.c',\n 'rte_hypervisor.c',\n+ 'rte_mmu.c',\n 'rte_power_intrinsics.c',\n )\ndiff --git a/lib/eal/riscv/rte_mmu.c b/lib/eal/riscv/rte_mmu.c\nnew file mode 100644\nindex 000000000000..3c043be10236\n--- /dev/null\n+++ b/lib/eal/riscv/rte_mmu.c\n@@ -0,0 +1,11 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) IBM Corporation 2023\n+ */\n+\n+#include <linux/eal_linux_private.h>\n+\n+bool\n+eal_mmu_supported_linux_arch(void)\n+{\n+\treturn true;\n+}\ndiff --git a/lib/eal/x86/meson.build b/lib/eal/x86/meson.build\nindex d33a240e1a98..e08dffa13dcc 100644\n--- a/lib/eal/x86/meson.build\n+++ b/lib/eal/x86/meson.build\n@@ -7,6 +7,7 @@ sources += files(\n 'rte_cpuflags.c',\n 'rte_cycles.c',\n 'rte_hypervisor.c',\n+ 'rte_mmu.c',\n 'rte_spinlock.c',\n 'rte_power_intrinsics.c',\n )\ndiff --git a/lib/eal/x86/rte_mmu.c b/lib/eal/x86/rte_mmu.c\nnew file mode 100644\nindex 000000000000..3c043be10236\n--- /dev/null\n+++ b/lib/eal/x86/rte_mmu.c\n@@ -0,0 +1,11 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright (C) IBM Corporation 2023\n+ */\n+\n+#include <linux/eal_linux_private.h>\n+\n+bool\n+eal_mmu_supported_linux_arch(void)\n+{\n+\treturn true;\n+}\n", "prefixes": [ "v3" ] }