Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132876/?format=api
{ "id": 132876, "url": "https://patches.dpdk.org/api/patches/132876/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231018072949.69094-1-skori@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231018072949.69094-1-skori@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231018072949.69094-1-skori@marvell.com", "date": "2023-10-18T07:29:49", "name": "[v3,1/1] usertools/rss: add CNXK RSS key", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "dc945334b026cf586ec56962912cbc778e01bffc", "submitter": { "id": 1318, "url": "https://patches.dpdk.org/api/people/1318/?format=api", "name": "Sunil Kumar Kori", "email": "skori@marvell.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231018072949.69094-1-skori@marvell.com/mbox/", "series": [ { "id": 29899, "url": "https://patches.dpdk.org/api/series/29899/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29899", "date": "2023-10-18T07:29:49", "name": "[v3,1/1] usertools/rss: add CNXK RSS key", "version": 3, "mbox": "https://patches.dpdk.org/series/29899/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132876/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132876/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9B4D843196;\n\tWed, 18 Oct 2023 09:29:58 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 88B9240648;\n\tWed, 18 Oct 2023 09:29:58 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 627424025F\n for <dev@dpdk.org>; Wed, 18 Oct 2023 09:29:57 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 39I3uqau018813 for <dev@dpdk.org>; Wed, 18 Oct 2023 00:29:56 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3tstb3uvwj-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 18 Oct 2023 00:29:56 -0700", "from DC5-EXCH01.marvell.com (10.69.176.38) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 18 Oct 2023 00:29:54 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 18 Oct 2023 00:29:54 -0700", "from localhost.localdomain (unknown [10.28.34.25])\n by maili.marvell.com (Postfix) with ESMTP id 689203F7060;\n Wed, 18 Oct 2023 00:29:53 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=avztEMBViumxmfB93XE+icq48t4F0TZcIomj3euxMGM=;\n b=HY6coolxKXzOTQwGa31mK4KJOdsGYZXuogCAU1U/zP0Iw76eBCte8gOZ/+zKTJD7beh7\n C54FwKBES7xVZiQlih618Yg7gOjAo82jBFo5taaKVj0LSJDzr2lTOaLTBY8Ob6l84hCd\n cUNUpcjPd0y9H9e0Ql6IzO40dgS52LBTlgDlcsaeUGjo0o4tsmvOQHoM8uLPC1ETHoNH\n d+7N48XB2JSFCwl/3RRaIoRKUJjf7cFYimCZcTIJ6ixh6TAJnb4tXYD48TGNxFUBluOp\n Em93Li6MS7/7kL3Fu5CZc6ZVEDBeby0qLJM/QAE8E2tdTRW+gUUoRnIdOxU1fTwTY9+h cQ==", "From": "<skori@marvell.com>", "To": "", "CC": "<dev@dpdk.org>, Sunil Kumar Kori <skori@marvell.com>, Jerin Jacob\n <jerinj@marvell.com>", "Subject": "[PATCH v3 1/1] usertools/rss: add CNXK RSS key", "Date": "Wed, 18 Oct 2023 12:59:49 +0530", "Message-ID": "<20231018072949.69094-1-skori@marvell.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20231009163610.1096092-1-skori@marvell.com>", "References": "<20231009163610.1096092-1-skori@marvell.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "ChiiEf1eK24tEM4eU6y7FIBswpEIVF4H", "X-Proofpoint-GUID": "ChiiEf1eK24tEM4eU6y7FIBswpEIVF4H", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.272,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-18_05,2023-10-17_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sunil Kumar Kori <skori@marvell.com>\n\nThis patch adds RSS key for CNXK platforms. CNXK platform uses\n48 bytes long key for hash calculations.\n\nFor the same patch also updates help mesaages to provide range\ninformation for supporting NICs/platforms.\n\nAlso CNXK uses reta size as 64 so to get correct offset to retrieve\nqueue index, user must pass reta_size option as 64 i.e. -t 64.\n\nExamples:\n$ ./dpdk-rss-flows.py -k cnxk 8 28.0.0.0/24 40.0.0.0/24 -t 64\nSRC_IP DST_IP QUEUE\n28.0.0.1 40.0.0.1 7\n28.0.0.1 40.0.0.2 2\n28.0.0.1 40.0.0.3 4\n28.0.0.1 40.0.0.7 1\n28.0.0.1 40.0.0.8 3\n28.0.0.1 40.0.0.9 5\n28.0.0.1 40.0.0.10 0\n28.0.0.1 40.0.0.11 6\n\nSigned-off-by: Sunil Kumar Kori <skori@marvell.com>\nAcked-by: Jerin Jacob <jerinj@marvell.com>\n---\nv2..v3:\n - Fix key size range check.\n - Fix default key size file name.\n\nv1..v2:\n - Fix checkpatch errors.\n\n usertools/dpdk-rss-flows.py | 19 ++++++++++++++++---\n 1 file changed, 16 insertions(+), 3 deletions(-)", "diff": "diff --git a/usertools/dpdk-rss-flows.py b/usertools/dpdk-rss-flows.py\nindex 73821eb471..937f9e1927 100755\n--- a/usertools/dpdk-rss-flows.py\n+++ b/usertools/dpdk-rss-flows.py\n@@ -188,11 +188,24 @@ def balanced_traffic(\n 0x81, 0x15, 0x03, 0x66,\n )\n )\n+# default_key, see drivers/common/cnxk/roc_nix_rss.c\n+# Marvell's cnxk NICs take 48 bytes keys\n+RSS_KEY_CNXK = bytes(\n+ (\n+ 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,\n+ 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,\n+ 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,\n+ 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,\n+ 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,\n+ 0xfe, 0xed, 0x0b, 0xad, 0xfe, 0xed, 0x0b, 0xad,\n+ )\n+)\n # fmt: on\n DEFAULT_DRIVER_KEYS = {\n \"intel\": RSS_KEY_INTEL,\n \"mlx\": RSS_KEY_MLX,\n \"i40e\": RSS_KEY_I40E,\n+ \"cnxk\": RSS_KEY_CNXK,\n }\n \n \n@@ -201,8 +214,8 @@ def rss_key(value):\n return DEFAULT_DRIVER_KEYS[value]\n try:\n key = binascii.unhexlify(value)\n- if len(key) not in (40, 52):\n- raise argparse.ArgumentTypeError(\"The key must be 40 or 52 bytes long\")\n+ if len(key) not in range(40, 52):\n+ raise argparse.ArgumentTypeError(\"The key must be 40 to 52 bytes long\")\n return key\n except (TypeError, ValueError) as e:\n raise argparse.ArgumentTypeError(str(e)) from e\n@@ -299,7 +312,7 @@ def parse_args():\n default=RSS_KEY_INTEL,\n type=rss_key,\n help=\"\"\"\n- The random 40-bytes key used to compute the RSS hash. This option\n+ The random 40 to 52 bytes key used to compute the RSS hash. This option\n supports either a well-known name or the hex value of the key\n (well-known names: \"intel\", \"mlx\", default: \"intel\").\n \"\"\",\n", "prefixes": [ "v3", "1/1" ] }