Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132661/?format=api
{ "id": 132661, "url": "https://patches.dpdk.org/api/patches/132661/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231016205948.2252342-1-joshwash@google.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231016205948.2252342-1-joshwash@google.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231016205948.2252342-1-joshwash@google.com", "date": "2023-10-16T20:59:48", "name": "net/gve: Update max_rx_pktlen to be based on MTU", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "75487e6bfc66c1f8655d1c2ff333d5eaa7f34ddc", "submitter": { "id": 2921, "url": "https://patches.dpdk.org/api/people/2921/?format=api", "name": "Joshua Washington", "email": "joshwash@google.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231016205948.2252342-1-joshwash@google.com/mbox/", "series": [ { "id": 29857, "url": "https://patches.dpdk.org/api/series/29857/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29857", "date": "2023-10-16T20:59:48", "name": "net/gve: Update max_rx_pktlen to be based on MTU", "version": 1, "mbox": "https://patches.dpdk.org/series/29857/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132661/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132661/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B3BD143182;\n\tMon, 16 Oct 2023 22:59:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id A562F40299;\n\tMon, 16 Oct 2023 22:59:53 +0200 (CEST)", "from mail-yw1-f201.google.com (mail-yw1-f201.google.com\n [209.85.128.201])\n by mails.dpdk.org (Postfix) with ESMTP id CBAD8400D6\n for <dev@dpdk.org>; Mon, 16 Oct 2023 22:59:51 +0200 (CEST)", "by mail-yw1-f201.google.com with SMTP id\n 00721157ae682-5a21e8ee1b7so46047027b3.1\n for <dev@dpdk.org>; Mon, 16 Oct 2023 13:59:51 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=google.com; s=20230601; t=1697489991; x=1698094791; darn=dpdk.org;\n h=cc:to:from:subject:message-id:mime-version:date:from:to:cc:subject\n :date:message-id:reply-to;\n bh=7cPB6CNdHTjnfdAPx13ikW3fEpqHkoxAj7v/2lOsALQ=;\n b=UTvSKR4NBPmBXEuBtji7ZErWuVlTAgr7SjvkNft34lNSRJ+kAM4QdF2HLUK18Ym7Sb\n cwNYJCLHpU0ae8kdpG6oKBQIho/DdFUePauR1kh5ejeFj/2hDDMIeMIKwl0/mnzvQxSk\n qRUcjHXPCjzrXHzjnjpSYIKPnWMpU2FwofgtDl8MNSjrKRZtzy+7/Tl32Wq1axH97WkS\n vtXnIVi5OylQKFF8C+nOFFDOA6G4gljSYdLWIf7CI62pxjvsSdH/2UY2VP9LpRUy/jcf\n ISmdYfrs/0fFkQWOvSPeW2y5F6RW01qGDQ2ParBRPKU7n6WCoIK/KtgUzitKdQBxOHg2\n Pidw==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1697489991; x=1698094791;\n h=cc:to:from:subject:message-id:mime-version:date:x-gm-message-state\n :from:to:cc:subject:date:message-id:reply-to;\n bh=7cPB6CNdHTjnfdAPx13ikW3fEpqHkoxAj7v/2lOsALQ=;\n b=of+m7YLGjTcAqj++BvxZrngYXxszInAv3oDR6/jfRfDWKzEWRd4ST4ed6i6bf1yWMu\n KZDyJhaB59cSyzSuf/fku1UZXDWSpQI1CB2sFCE+wG8f9W3Xz6GHA1M/3H5OCpwFQRdZ\n 04nUWdyTSu+Faw1ZEMmGbY2XMmTAR+qFAihqQc6M2DB6w8wfzNCozq9UA+4jaHEUATYw\n r8koxDyu2MHrfdy6fG8RTze1aAm7jI0Dy0ddW+0uYqmZC5lJea9D21vG6/iL1FXUrFl3\n nl/0mrabyd6Tv522VdLfZGaXmOTC9pvnIcIfVjPgOZV/XYL1KdAdxKinDrebLvRywxRJ\n l7iQ==", "X-Gm-Message-State": "AOJu0Ywut7QSDEBJLqLkz+gwb+5Ubmp5d2x3W8N28X1w0wK3swFuV8hG\n yIXgbuFFUAUjejwhGXyIEG5MGyFzYtJ1hw==", "X-Google-Smtp-Source": "\n AGHT+IHUUXpTIr5sndAfCkVMkAIPv7hcdWY1NvzZ/zUMklSCVSji7zTT0kx2G6cc2InRetWvZAj0FBwekzgqQw==", "X-Received": "from joshwash.sea.corp.google.com\n ([2620:15c:11c:202:8b71:1974:d716:ecf2])\n (user=joshwash job=sendgmr) by 2002:a25:cfcc:0:b0:d9b:b6bd:4894 with SMTP id\n f195-20020a25cfcc000000b00d9bb6bd4894mr15290ybg.5.1697489991254; Mon, 16 Oct\n 2023 13:59:51 -0700 (PDT)", "Date": "Mon, 16 Oct 2023 13:59:48 -0700", "Mime-Version": "1.0", "X-Mailer": "git-send-email 2.42.0.655.g421f12c284-goog", "Message-ID": "<20231016205948.2252342-1-joshwash@google.com>", "Subject": "[PATCH] net/gve: Update max_rx_pktlen to be based on MTU", "From": "Joshua Washington <joshwash@google.com>", "To": "Junfeng Guo <junfeng.guo@intel.com>,\n Jeroen de Borst <jeroendb@google.com>,\n Rushil Gupta <rushilg@google.com>, Joshua Washington <joshwash@google.com>", "Cc": "dev@dpdk.org, Ferruh Yigit <ferruh.yigit@amd.com>", "Content-Type": "text/plain; charset=\"UTF-8\"", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Before this patch, max_rx_pktlen was always set to UINT16_MAX. This, in\nconjunction with the MTU fix, causes problems with testpmd, as setting the\npacket length with the --max-pkt-len flag causes the MTU to be set\nhigher than possible due to underflow.\n\nAs an example, setting --max-pkt-len=1460 (the default MTU on Google\nCloud VMs) causes testpmd to set the following:\n mtu = 1460 - eth_overhead,\n\nwhere eth_overhead = dev->max_rx_pktlen - dev->max_mtu = 65535 - 1460.\n\nThus, mtu = 1460 - 65535 + 1460 = 2921 due to underflow.\n\nSigned-off-by: Joshua Washington <joshwash@google.com>\n\nFixes: 030025b74202 (\"net/gve: fix max MTU limit\")\nCc: joshwash@google.com\n---\n drivers/net/gve/gve_ethdev.c | 2 +-\n drivers/net/gve/gve_ethdev.h | 1 -\n 2 files changed, 1 insertion(+), 2 deletions(-)", "diff": "diff --git a/drivers/net/gve/gve_ethdev.c b/drivers/net/gve/gve_ethdev.c\nindex b441f96623..eb3bc7e151 100644\n--- a/drivers/net/gve/gve_ethdev.c\n+++ b/drivers/net/gve/gve_ethdev.c\n@@ -297,7 +297,7 @@ gve_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)\n \tdev_info->max_rx_queues = priv->max_nb_rxq;\n \tdev_info->max_tx_queues = priv->max_nb_txq;\n \tdev_info->min_rx_bufsize = GVE_MIN_BUF_SIZE;\n-\tdev_info->max_rx_pktlen = GVE_MAX_RX_PKTLEN;\n+\tdev_info->max_rx_pktlen = priv->max_mtu + RTE_ETHER_HDR_LEN;\n \tdev_info->max_mtu = priv->max_mtu;\n \tdev_info->min_mtu = RTE_ETHER_MIN_MTU;\n \ndiff --git a/drivers/net/gve/gve_ethdev.h b/drivers/net/gve/gve_ethdev.h\nindex 1cba282128..755ee8ad15 100644\n--- a/drivers/net/gve/gve_ethdev.h\n+++ b/drivers/net/gve/gve_ethdev.h\n@@ -21,7 +21,6 @@\n #define GVE_TX_MAX_FREE_SZ 512\n \n #define GVE_MIN_BUF_SIZE\t 1024\n-#define GVE_MAX_RX_PKTLEN\t 65535\n \n #define GVE_TX_CKSUM_OFFLOAD_MASK (\t\t\\\n \t\tRTE_MBUF_F_TX_L4_MASK |\t\\\n", "prefixes": [] }