Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132331/?format=api
{ "id": 132331, "url": "https://patches.dpdk.org/api/patches/132331/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231005062513.29467-2-hkalra@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231005062513.29467-2-hkalra@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231005062513.29467-2-hkalra@marvell.com", "date": "2023-10-05T06:25:13", "name": "[2/2] common/cnxk: fix race condition between up and down mbox", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "8e0079295ca04a57e5e436f8780e3c21bf6b5c4f", "submitter": { "id": 1182, "url": "https://patches.dpdk.org/api/people/1182/?format=api", "name": "Harman Kalra", "email": "hkalra@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231005062513.29467-2-hkalra@marvell.com/mbox/", "series": [ { "id": 29742, "url": "https://patches.dpdk.org/api/series/29742/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29742", "date": "2023-10-05T06:25:12", "name": "[1/2] common/cnxk: fix handling up and down interrupts", "version": 1, "mbox": "https://patches.dpdk.org/series/29742/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132331/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132331/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 2B86D426BE;\n\tThu, 5 Oct 2023 08:25:39 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 39EDA402D1;\n\tThu, 5 Oct 2023 08:25:38 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0b-0016f401.pphosted.com\n [67.231.156.173])\n by mails.dpdk.org (Postfix) with ESMTP id 06F7F402A9\n for <dev@dpdk.org>; Thu, 5 Oct 2023 08:25:36 +0200 (CEST)", "from pps.filterd (m0045851.ppops.net [127.0.0.1])\n by mx0b-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 3953xPT1019149 for <dev@dpdk.org>; Wed, 4 Oct 2023 23:25:36 -0700", "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0b-0016f401.pphosted.com (PPS) with ESMTPS id 3th29umsv3-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Wed, 04 Oct 2023 23:25:36 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Wed, 4 Oct 2023 23:25:33 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Wed, 4 Oct 2023 23:25:33 -0700", "from localhost.localdomain (unknown [10.29.52.211])\n by maili.marvell.com (Postfix) with ESMTP id 3B9F23F7070;\n Wed, 4 Oct 2023 23:25:26 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-type; s=pfpt0220; bh=q4YZciaMiS0r2+vS9ZEigMTn8YtY/r9q1xON3ygMOtA=;\n b=PuVt4JUBEGjITaDMAmrIsEM4Reb/Lz2FGjOsMxVPEBNoRjOPxgU+bk8yCb9+fTgW/tus\n H2rLUO0fkYsmX/MazmLdAX6ygnkVQkTZ/9v3HA5TW7hHnGTsXGYlcYyPUesl6xPuyTEH\n ZYjFhESBeA/CY3cnvH4VS/qTW3Xl1zLUUvgj5FhjTHDWlwKHmERjePgnqoOL0K92PRnI\n pzuOYu4hxQ2XBsPUKL5RkuktRaXwIE3YPVTvqU5lWptpb5k3VJ/m8lnh7/er4qkUGntm\n hSszjWP7xS0AFxkkiX1Dmw3Mp+/+3HRpPf66B1ZfVVfFWoPZwrOsUO5K/EGvXKCr+r2B 1A==", "From": "Harman Kalra <hkalra@marvell.com>", "To": "<jerinj@marvell.com>, Nithin Dabilpuram <ndabilpuram@marvell.com>, \"Kiran\n Kumar K\" <kirankumark@marvell.com>, Sunil Kumar Kori <skori@marvell.com>,\n Satha Rao <skoteshwar@marvell.com>", "CC": "<dev@dpdk.org>, Harman Kalra <hkalra@marvell.com>", "Subject": "[PATCH 2/2] common/cnxk: fix race condition between up and down mbox", "Date": "Thu, 5 Oct 2023 11:55:13 +0530", "Message-ID": "<20231005062513.29467-2-hkalra@marvell.com>", "X-Mailer": "git-send-email 2.18.0", "In-Reply-To": "<20231005062513.29467-1-hkalra@marvell.com>", "References": "<20231005062513.29467-1-hkalra@marvell.com>", "MIME-Version": "1.0", "Content-Type": "text/plain", "X-Proofpoint-GUID": "tsMwI6VPtFAxd9aoP_wGUXhEL-PLd8Sd", "X-Proofpoint-ORIG-GUID": "tsMwI6VPtFAxd9aoP_wGUXhEL-PLd8Sd", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-05_03,2023-10-02_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fixing a possible case for race condition where an up mbox\ninterrupt over writes the down mbox message.\nAlthough mbox_wait_for_zero() makes sure no up/down message\nis pending before raising an up mbox interrupt. But there is a\nsmall window were a VF may send a down mbox request to PF after\nmbox_wait_for_zero() and before PF attempts to send a up\nmessage to same VF. In such scenario interrupt register which has\ndown message bit set will get overwritten by up message bit.\n\nAs a solution, read interrupt register and OR the status with\nrequired up/down bit before writing to the interrupt register.\n\nFixes: fa4ee2d43188 (\"common/cnxk: sync between mbox up and down messages\")\n\nSigned-off-by: Harman Kalra <hkalra@marvell.com>\n---\n drivers/common/cnxk/roc_mbox.c | 16 ++++++++++------\n 1 file changed, 10 insertions(+), 6 deletions(-)", "diff": "diff --git a/drivers/common/cnxk/roc_mbox.c b/drivers/common/cnxk/roc_mbox.c\nindex c91fa63e83..7b734fcd24 100644\n--- a/drivers/common/cnxk/roc_mbox.c\n+++ b/drivers/common/cnxk/roc_mbox.c\n@@ -209,10 +209,9 @@ static void\n mbox_msg_send_data(struct mbox *mbox, int devid, uint8_t data)\n {\n \tstruct mbox_dev *mdev = &mbox->dev[devid];\n-\tstruct mbox_hdr *tx_hdr =\n-\t\t(struct mbox_hdr *)((uintptr_t)mdev->mbase + mbox->tx_start);\n-\tstruct mbox_hdr *rx_hdr =\n-\t\t(struct mbox_hdr *)((uintptr_t)mdev->mbase + mbox->rx_start);\n+\tstruct mbox_hdr *tx_hdr = (struct mbox_hdr *)((uintptr_t)mdev->mbase + mbox->tx_start);\n+\tstruct mbox_hdr *rx_hdr = (struct mbox_hdr *)((uintptr_t)mdev->mbase + mbox->rx_start);\n+\tuint64_t intr_val;\n \n \t/* Reset header for next messages */\n \ttx_hdr->msg_size = mdev->msg_size;\n@@ -229,11 +228,16 @@ mbox_msg_send_data(struct mbox *mbox, int devid, uint8_t data)\n \t/* Sync mbox data into memory */\n \tplt_wmb();\n \n+\t/* Check for any pending interrupt */\n+\tintr_val = plt_read64(\n+\t\t(volatile void *)(mbox->reg_base + (mbox->trigger | (devid << mbox->tr_shift))));\n+\n+\tintr_val |= (uint64_t)data;\n \t/* The interrupt should be fired after num_msgs is written\n \t * to the shared memory\n \t */\n-\tplt_write64(data, (volatile void *)(mbox->reg_base +\n-\t\t\t\t(mbox->trigger | (devid << mbox->tr_shift))));\n+\tplt_write64(intr_val, (volatile void *)(mbox->reg_base +\n+\t\t\t\t\t\t(mbox->trigger | (devid << mbox->tr_shift))));\n }\n \n /**\n", "prefixes": [ "2/2" ] }