Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132307/?format=api
{ "id": 132307, "url": "https://patches.dpdk.org/api/patches/132307/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231004162834.249828-1-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231004162834.249828-1-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231004162834.249828-1-bruce.richardson@intel.com", "date": "2023-10-04T16:28:34", "name": "[v2] eventdev: drop custom OS defines", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "ebd3242f399b34614f97c965ca03e0f105ac09e2", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231004162834.249828-1-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29737, "url": "https://patches.dpdk.org/api/series/29737/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29737", "date": "2023-10-04T16:28:34", "name": "[v2] eventdev: drop custom OS defines", "version": 2, "mbox": "https://patches.dpdk.org/series/29737/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132307/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132307/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6DF10426B7;\n\tWed, 4 Oct 2023 18:35:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 581A1402B3;\n\tWed, 4 Oct 2023 18:35:26 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.24])\n by mails.dpdk.org (Postfix) with ESMTP id 375FB402A9\n for <dev@dpdk.org>; Wed, 4 Oct 2023 18:35:23 +0200 (CEST)", "from fmsmga002.fm.intel.com ([10.253.24.26])\n by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 04 Oct 2023 09:28:46 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.135])\n by fmsmga002.fm.intel.com with ESMTP; 04 Oct 2023 09:28:44 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1696437324; x=1727973324;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=iawmBXrn0HT0dQxRCN/FhFp7rP6Zqr/1lXlawedPMMU=;\n b=iisZ+Uckt48A680hLod+m8KB04MdxnSIfN2dVg40K3BQxEuAH/D6UBxp\n iFB5nTHnq29/MkRXLQcZjAxlD+bw1Fv++n0o8PZE9xtafVsYQCPoBSvao\n k4tXH+zRqBHCNzDXB5qWO/Qg6U2NOiOSoSPiXL70prb9vy1UxgANcpRIZ\n 8CAfge7PFOjXgRPMSbE7JYnzKta0Sg+nP2/0eQJxKPCt2aEQHnTfAnuGU\n l9/7RmUxsZgxoImcmvGUQtbu95cU1bqACr5QSQDDtQN2GNJxEQUPmULpQ\n ToYmh6+NYb9SGVmwUl0tqG7ek6Y8quuUppTRTUWbDltARvdSwuBSmTCd3 Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10853\"; a=\"386051506\"", "E=Sophos;i=\"6.03,200,1694761200\"; d=\"scan'208\";a=\"386051506\"", "E=McAfee;i=\"6600,9927,10853\"; a=\"867464444\"", "E=Sophos;i=\"6.03,200,1694761200\"; d=\"scan'208\";a=\"867464444\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>,\n Jerin Jacob <jerinj@marvell.com>,\n Naga Harish K S V <s.v.naga.harish.k@intel.com>", "Subject": "[PATCH v2] eventdev: drop custom OS defines", "Date": "Wed, 4 Oct 2023 17:28:34 +0100", "Message-Id": "<20231004162834.249828-1-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20231003170115.571133-1-bruce.richardson@intel.com>", "References": "<20231003170115.571133-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The eventdev library doesn't need to put in place its own defines for\nLinux and BSD. There are already defines for the OS environment in\nrte_config.h that can be re-used, but since these are just for\nidentifying Linux/non-Linux, we can just check for the standard define\n'__linux__' instead.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n lib/eventdev/meson.build | 6 ------\n lib/eventdev/rte_event_eth_rx_adapter.c | 6 +++---\n 2 files changed, 3 insertions(+), 9 deletions(-)", "diff": "diff --git a/lib/eventdev/meson.build b/lib/eventdev/meson.build\nindex 250abcb154..a04bb86f0f 100644\n--- a/lib/eventdev/meson.build\n+++ b/lib/eventdev/meson.build\n@@ -7,12 +7,6 @@ if is_windows\n subdir_done()\n endif\n \n-if is_linux\n- cflags += '-DLINUX'\n-else\n- cflags += '-DBSD'\n-endif\n-\n sources = files(\n 'eventdev_private.c',\n 'eventdev_trace_points.c',\ndiff --git a/lib/eventdev/rte_event_eth_rx_adapter.c b/lib/eventdev/rte_event_eth_rx_adapter.c\nindex ea7106a1fe..6db03adf04 100644\n--- a/lib/eventdev/rte_event_eth_rx_adapter.c\n+++ b/lib/eventdev/rte_event_eth_rx_adapter.c\n@@ -5,7 +5,7 @@\n #include <ctype.h>\n #include <stdlib.h>\n #include <pthread.h>\n-#if defined(LINUX)\n+#if defined(__linux__)\n #include <sys/epoll.h>\n #endif\n #include <unistd.h>\n@@ -1567,11 +1567,11 @@ rxa_default_conf_cb(uint8_t id, uint8_t dev_id,\n static int\n rxa_epoll_create1(void)\n {\n-#if defined(LINUX)\n+#if defined(__linux__)\n \tint fd;\n \tfd = epoll_create1(EPOLL_CLOEXEC);\n \treturn fd < 0 ? -errno : fd;\n-#elif defined(BSD)\n+#else\n \treturn -ENOTSUP;\n #endif\n }\n", "prefixes": [ "v2" ] }