Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132299/?format=api
{ "id": 132299, "url": "https://patches.dpdk.org/api/patches/132299/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231004105449.367667-1-mattias.ronnblom@ericsson.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231004105449.367667-1-mattias.ronnblom@ericsson.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231004105449.367667-1-mattias.ronnblom@ericsson.com", "date": "2023-10-04T10:54:49", "name": "random: clarify PRNG MT safety guarantees", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "7338d8e864ac98ffbbaefafbc150afea3666e030", "submitter": { "id": 1077, "url": "https://patches.dpdk.org/api/people/1077/?format=api", "name": "Mattias Rönnblom", "email": "mattias.ronnblom@ericsson.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231004105449.367667-1-mattias.ronnblom@ericsson.com/mbox/", "series": [ { "id": 29732, "url": "https://patches.dpdk.org/api/series/29732/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29732", "date": "2023-10-04T10:54:49", "name": "random: clarify PRNG MT safety guarantees", "version": 1, "mbox": "https://patches.dpdk.org/series/29732/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132299/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id F05C14266F;\n\tWed, 4 Oct 2023 13:00:29 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id BD12E40289;\n\tWed, 4 Oct 2023 13:00:29 +0200 (CEST)", "from EUR01-VE1-obe.outbound.protection.outlook.com\n (mail-ve1eur01on2049.outbound.protection.outlook.com [40.107.14.49])\n by mails.dpdk.org (Postfix) with ESMTP id A65F84027C\n for <dev@dpdk.org>; Wed, 4 Oct 2023 13:00:28 +0200 (CEST)", "from DB7PR03CA0087.eurprd03.prod.outlook.com (2603:10a6:10:72::28)\n by PA4PR07MB8439.eurprd07.prod.outlook.com (2603:10a6:102:2a6::14) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.35; Wed, 4 Oct\n 2023 11:00:24 +0000", "from DU6PEPF0000B61E.eurprd02.prod.outlook.com\n (2603:10a6:10:72:cafe::a0) by DB7PR03CA0087.outlook.office365.com\n (2603:10a6:10:72::28) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33 via Frontend\n Transport; Wed, 4 Oct 2023 11:00:24 +0000", "from oa.msg.ericsson.com (192.176.1.74) by\n DU6PEPF0000B61E.mail.protection.outlook.com (10.167.8.133) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id\n 15.20.6838.14 via Frontend Transport; Wed, 4 Oct 2023 11:00:24 +0000", "from SESSMR604.ericsson.se (100.87.178.32) by ESESSMB505.ericsson.se\n (153.88.183.193) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.32; Wed, 4\n Oct 2023 13:00:11 +0200", "from ESESBMB503.ericsson.se (153.88.183.58) by SESSMR604.ericsson.se\n (100.87.178.96) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.2.1118.26; Wed, 4 Oct\n 2023 13:00:11 +0200", "from seliicinfr00049.seli.gic.ericsson.se (153.88.183.153) by\n smtp.internal.ericsson.com (153.88.183.186) with Microsoft SMTP Server id\n 15.1.2507.32 via Frontend Transport; Wed, 4 Oct 2023 13:00:11 +0200", "from breslau.. (seliicwb00002.seli.gic.ericsson.se [10.156.25.100])\n by seliicinfr00049.seli.gic.ericsson.se (Postfix) with ESMTP id\n 96F7D380061; Wed, 4 Oct 2023 13:00:11 +0200 (CEST)" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=hGZeGjBqJI/TKlCvEb+DLJKqeOrzfmuabxGA996/6ALf2XzKcqYOlLKMQr4EpvSM6fX4m/dZNHO0IQMNPOtNaI204BNxEgqL+cZUdULqvEkTTb3QkarH47UUiCfoDmaipP5le7KvYymFK1cLRt/OhBz0n0JoJ2w61JTx7lc+PxfzB8jizinD0XzKCYVO4mjrzebq7HmlwuWy1vNq1lAQpyCgAjJlJpndGTWLHuuTPPgsWfbiJInze+Bz3pedATjdWAp6Zcp/qBmgCBLe281Y3PtDlZXKgCIMjzGP7kGTabhmzefVKG8NuISZyr39051F4HapWtZDN6bEzePilRaZOw==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=XvhVgoiiO2WGhNmn8dmKizgs8N7hL5kthLZBK09PRjE=;\n b=f8NeTpkzXnwyRkqzB6zovZJL12LSix75bGfGrpQ8DIsrP+GncUGY8Ye0t5TKY0ZQqTkB+J/Nwtja+i/8H1rSYQR8sTK3F7xRteHPzBYHPlFZQhtvD40UlPjSjf40Z+6rJ+bvhCttOd4W0fSSX1M5b1sHbCMKjLxjhXmbsly4z9Mf417JhH/yAyB6QYns2mpFUA4u1blCLLUe6kgD9vLTHBaB8tr8Rym8fMSyPNMkZ19kSf+/MIxp1zhleR+jknaKc1r1PUa+K1v96+PANahOF8DGu78F4yJpN43nXQbsMuQexZQwwUoWRhS8KTlxPF68+C8rHQWWHVmEBZQE+BJGww==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 192.176.1.74) smtp.rcpttodomain=dpdk.org smtp.mailfrom=ericsson.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=ericsson.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=ericsson.com;\n s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=XvhVgoiiO2WGhNmn8dmKizgs8N7hL5kthLZBK09PRjE=;\n b=kQQ1JMYUkD8BvFzzBHvgBKsMiuwZ1c/drJGgxeNvFVG3OjObK24hpSiWA+vwI85upcLBg6TV6hJ7lLwkX0EgqZZMjUTarMFsg42eBy+h8kpkNtjRr6DenF246gsC5rNrEEeJr35NNALZofBTWCxCsadguGnbQdEEjz2UxQ0CjtI=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 192.176.1.74)\n smtp.mailfrom=ericsson.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=ericsson.com;", "Received-SPF": "Pass (protection.outlook.com: domain of ericsson.com designates\n 192.176.1.74 as permitted sender)\n receiver=protection.outlook.com;\n client-ip=192.176.1.74; helo=oa.msg.ericsson.com; pr=C", "From": "=?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "To": "<dev@dpdk.org>", "CC": "<hofors@lysator.liu.se>, Stephen Hemminger <stephen@networkplumber.org>,\n <david.marchand@redhat.com>,\n =?utf-8?q?Mattias_R=C3=B6nnblom?= <mattias.ronnblom@ericsson.com>", "Subject": "[PATCH] random: clarify PRNG MT safety guarantees", "Date": "Wed, 4 Oct 2023 12:54:49 +0200", "Message-ID": "<20231004105449.367667-1-mattias.ronnblom@ericsson.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"UTF-8\"", "Content-Transfer-Encoding": "8bit", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "DU6PEPF0000B61E:EE_|PA4PR07MB8439:EE_", "X-MS-Office365-Filtering-Correlation-Id": "8700ad3d-dd6f-496b-02f1-08dbc4c91c4e", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n xFDNZtqYHgqlBXU8zcac6DUDijxECzRsGSsMun48d2bhYkfIfg+JFxXdd0B4OhMwvi1/0LYJEh17vooVgtR/UDh1Oo6NyiZDTT/5p2vgN+XSkjvsGvx2BBftBtcyoJyOoATc2tp9OQ1UNyIv4Z7ziIBp00FH73lT0d0mcU+e1nDDcSdFRwB5n+yAKg67W/ERvsqjiiSKqiwUtrOMsiYz4N1fK9W3YOwxQY7skJTiWISF7wV/R6V+9lmjI9iHDEpMPjNd2em910ZmR7Zj9SoeR31/NfNi3AGhcW4o/6R4yCLFQhZUgtFOYdLglpfs21+JkDa0o/vds5pF2/mjXcLbsFj+OSZSSX0jOWPsw1yJ/CRGx+qe4roZQveSiJHf3is5Q7OEUFOH6stq+vaptwmKZ4r2WznT8KzgeXCiIJ82HrnWY21ot3OCbLk33r85siahRoQcyO/lIsssm/Xrx/fzJYdvUeHA63dY5rWPZx6SFCvJTm+scxt5zN8QQdHRTl9tiCl/3WHEi9+lAPt1FtGgeDvXf51UUbg4y8zjzuyzpigJSHD5OPgK7XFFle1ez9TiyKgGSf0wX7Sp8SvCGcWINYiVI5HrIekXdXuVgPjwSUSTAbY9ysur2+psViDchV/Mu1hJdOJBqoJXhtfjKZqS0DHKEkYYz/6pLCqOId8mqXeItyIboPZFZBrqy6yXohqxIpUCdrJ8epTOrLq5yzv8eSmMntW062wRB+QuJYHrgvA+tcIaC5ic6n9UL9N/ivLscImpeOL4fRkNvLmZfgeY74fsUNcpvsJMR2JnruLUjeGcZteAyH6Bz1KSZJpaehUGb73C0L+RQWe6xiEaREKD5w==", "X-Forefront-Antispam-Report": "CIP:192.176.1.74; CTRY:SE; LANG:en; SCL:1; SRV:;\n IPV:NLI; SFV:NSPM; H:oa.msg.ericsson.com; PTR:office365.se.ericsson.net;\n CAT:NONE;\n SFS:(13230031)(4636009)(376002)(136003)(396003)(346002)(39860400002)(230922051799003)(82310400011)(64100799003)(451199024)(186009)(1800799009)(46966006)(36840700001)(40470700004)(40460700003)(40480700001)(6266002)(478600001)(6666004)(47076005)(86362001)(36860700001)(82960400001)(356005)(7636003)(82740400003)(54906003)(2906002)(41300700001)(2616005)(336012)(83380400001)(1076003)(107886003)(26005)(36756003)(5660300002)(70586007)(316002)(70206006)(6916009)(8936002)(4326008)(8676002);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "ericsson.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "04 Oct 2023 11:00:24.4464 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 8700ad3d-dd6f-496b-02f1-08dbc4c91c4e", "X-MS-Exchange-CrossTenant-Id": "92e84ceb-fbfd-47ab-be52-080c6b87953f", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=92e84ceb-fbfd-47ab-be52-080c6b87953f; Ip=[192.176.1.74];\n Helo=[oa.msg.ericsson.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n DU6PEPF0000B61E.eurprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "PA4PR07MB8439", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Clarify MT safety guarantees for unregistered non-EAL threads calling\nPRNG functions in rte_random.h.\n\nClarify that rte_srand() is not MT safe in regards to calls to\nrte_rand_max() and rte_drand().\n\nSigned-off-by: Mattias Rönnblom <mattias.ronnblom@ericsson.com>\nSuggested-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/include/rte_random.h | 19 +++++++++++--------\n 1 file changed, 11 insertions(+), 8 deletions(-)", "diff": "diff --git a/lib/eal/include/rte_random.h b/lib/eal/include/rte_random.h\nindex 2edf5d210b..c12eb07ea8 100644\n--- a/lib/eal/include/rte_random.h\n+++ b/lib/eal/include/rte_random.h\n@@ -27,8 +27,8 @@ extern \"C\" {\n * value.\n *\n * This function is not multi-thread safe in regards to other\n- * rte_srand() calls, nor is it in relation to concurrent rte_rand()\n- * calls.\n+ * rte_srand() calls, nor is it in relation to concurrent rte_rand(),\n+ * rte_rand_max() or rte_drand() calls.\n *\n * @param seedval\n * The value of the seed.\n@@ -41,8 +41,9 @@ rte_srand(uint64_t seedval);\n *\n * The generator is not cryptographically secure.\n *\n- * If called from EAL threads or registered non-EAL threads, this function\n- * is thread-safe.\n+ * rte_rand(), rte_rand_max() and rte_drand() are multi-thread safe,\n+ * with the exception that they may not be called by multiple\n+ * _unregistered_ non-EAL threads in parallel.\n *\n * @return\n * A pseudo-random value between 0 and (1<<64)-1.\n@@ -56,8 +57,9 @@ rte_rand(void);\n * This function returns an uniformly distributed (unbiased) random\n * number less than a user-specified maximum value.\n *\n- * If called from EAL threads or registered non-EAL threads, this function\n- * is thread-safe.\n+ * rte_rand(), rte_rand_max() and rte_drand() are multi-thread safe,\n+ * with the exception that they may not be called by multiple\n+ * _unregistered_ non-EAL threads in parallel.\n *\n * @param upper_bound\n * The upper bound of the generated number.\n@@ -78,8 +80,9 @@ rte_rand_max(uint64_t upper_bound);\n *\n * The generator is not cryptographically secure.\n *\n- * If called from EAL threads or registered non-EAL threads, this function\n- * is thread-safe.\n+ * rte_rand(), rte_rand_max() and rte_drand() are multi-thread safe,\n+ * with the exception that they may not be called by multiple\n+ * _unregistered_ non-EAL threads in parallel.\n *\n * @return\n * A pseudo-random value between 0 and 1.0.\n", "prefixes": [] }