Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132291/?format=api
{ "id": 132291, "url": "https://patches.dpdk.org/api/patches/132291/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231003204110.3344703-1-tduszynski@marvell.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231003204110.3344703-1-tduszynski@marvell.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231003204110.3344703-1-tduszynski@marvell.com", "date": "2023-10-03T20:41:09", "name": "raw/cnxk_bphy: support multi-process mode", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "d7e9dcaf05ecd6fe9dbeece20674f2c67535056d", "submitter": { "id": 2215, "url": "https://patches.dpdk.org/api/people/2215/?format=api", "name": "Tomasz Duszynski", "email": "tduszynski@marvell.com" }, "delegate": { "id": 310, "url": "https://patches.dpdk.org/api/users/310/?format=api", "username": "jerin", "first_name": "Jerin", "last_name": "Jacob", "email": "jerinj@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231003204110.3344703-1-tduszynski@marvell.com/mbox/", "series": [ { "id": 29728, "url": "https://patches.dpdk.org/api/series/29728/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29728", "date": "2023-10-03T20:41:09", "name": "raw/cnxk_bphy: support multi-process mode", "version": 1, "mbox": "https://patches.dpdk.org/series/29728/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132291/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132291/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id B50EF426B2;\n\tTue, 3 Oct 2023 22:41:28 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 4F60B40297;\n\tTue, 3 Oct 2023 22:41:28 +0200 (CEST)", "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 9337740262\n for <dev@dpdk.org>; Tue, 3 Oct 2023 22:41:26 +0200 (CEST)", "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 393FW7t3022328; Tue, 3 Oct 2023 13:41:25 -0700", "from dc5-exch02.marvell.com ([199.233.59.182])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3tgbasbjey-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT);\n Tue, 03 Oct 2023 13:41:25 -0700", "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Tue, 3 Oct 2023 13:41:24 -0700", "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Tue, 3 Oct 2023 13:41:24 -0700", "from cavium-DT10.. (unknown [10.28.34.39])\n by maili.marvell.com (Postfix) with ESMTP id 451C53F7052;\n Tue, 3 Oct 2023 13:41:18 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : mime-version : content-transfer-encoding :\n content-type; s=pfpt0220; bh=m1fjgfeFH1pTSraXTeIoDjw/Xk5a4Z1erJWeV/KEO6Q=;\n b=SPkqNCqw9JcDiyLiArv7NBC2k1V7sF7ZnYRk007bBcYRLXCiHUVoR9eR+5Lg/g5cKUsP\n gbK0Y9JqaUTkst2ykX0SeA1OWGQYeKJW5QwAsqIGy4BOdBAyyFfC3a6a2CJj4y8qEdD3\n cWqG7+kbruHhm30OahP1HevuoyNFf0VY18eOCcjMz06EJxFnEty6WCP1MiwgD8tqdNA/\n +u/dhOqiTCbXZSO/0cFcgKceKIeS0Rh7HUhaVTzumjDpTfC4QKLwiPtwYHbbzafPWvZY\n i1i/RkG2DcmlHhMti3sBghirMJgWiSEApDiDFneypLnI6x9I5X+T3C8Nj4GzK/e9pkwV NQ==", "From": "Tomasz Duszynski <tduszynski@marvell.com>", "To": "<dev@dpdk.org>, Jakub Palider <jpalider@marvell.com>, Tomasz Duszynski\n <tduszynski@marvell.com>, Anatoly Burakov <anatoly.burakov@intel.com>", "CC": "<jerinj@marvell.com>, <thomas@monjalon.net>", "Subject": "[PATCH] raw/cnxk_bphy: support multi-process mode", "Date": "Tue, 3 Oct 2023 22:41:09 +0200", "Message-ID": "<20231003204110.3344703-1-tduszynski@marvell.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Proofpoint-ORIG-GUID": "HKpUdaBllLzBe-trtlocxp8VWrekJIMj", "X-Proofpoint-GUID": "HKpUdaBllLzBe-trtlocxp8VWrekJIMj", "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-10-03_18,2023-10-02_01,2023-05-22_02", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add support for sharing BPHY PMD across multiple running processes.\nIn scenarios where resources need to be shared across processes\nuser-space need to ensure serialization.\n\nSigned-off-by: Tomasz Duszynski <tduszynski@marvell.com>\nReviewed-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>\nTested-by: Jerin Jacob Kollanukkaran <jerinj@marvell.com>\n---\n doc/guides/rawdevs/cnxk_bphy.rst | 8 ++++++++\n drivers/raw/cnxk_bphy/cnxk_bphy.c | 16 ++++++++++------\n 2 files changed, 18 insertions(+), 6 deletions(-)", "diff": "diff --git a/doc/guides/rawdevs/cnxk_bphy.rst b/doc/guides/rawdevs/cnxk_bphy.rst\nindex 2490912534..b544b543a3 100644\n--- a/doc/guides/rawdevs/cnxk_bphy.rst\n+++ b/doc/guides/rawdevs/cnxk_bphy.rst\n@@ -19,6 +19,14 @@ The BPHY CGX/RPM implements following features in the rawdev API:\n - Access to BPHY CGX/RPM via a set of predefined messages\n - Access to BPHY memory\n - Custom interrupt handlers\n+- Multiprocess aware\n+\n+Limitations\n+-----------\n+\n+In multiprocess mode user-space application must ensure no resources\n+sharing takes place. Otherwise, user-space application should ensure\n+synchronization.\n \n Device Setup\n ------------\ndiff --git a/drivers/raw/cnxk_bphy/cnxk_bphy.c b/drivers/raw/cnxk_bphy/cnxk_bphy.c\nindex d42cca649c..15dbc4c1a6 100644\n--- a/drivers/raw/cnxk_bphy/cnxk_bphy.c\n+++ b/drivers/raw/cnxk_bphy/cnxk_bphy.c\n@@ -359,10 +359,12 @@ bphy_rawdev_probe(struct rte_pci_driver *pci_drv,\n \tbphy_dev->mem.res2 = pci_dev->mem_resource[2];\n \tbphy_dev->bphy.pci_dev = pci_dev;\n \n-\tret = roc_bphy_dev_init(&bphy_dev->bphy);\n-\tif (ret) {\n-\t\trte_rawdev_pmd_release(bphy_rawdev);\n-\t\treturn ret;\n+\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\tret = roc_bphy_dev_init(&bphy_dev->bphy);\n+\t\tif (ret) {\n+\t\t\trte_rawdev_pmd_release(bphy_rawdev);\n+\t\t\treturn ret;\n+\t\t}\n \t}\n \n \treturn 0;\n@@ -390,8 +392,10 @@ bphy_rawdev_remove(struct rte_pci_device *pci_dev)\n \t\treturn -EINVAL;\n \t}\n \n-\tbphy_dev = (struct bphy_device *)rawdev->dev_private;\n-\troc_bphy_dev_fini(&bphy_dev->bphy);\n+\tif (rte_eal_process_type() == RTE_PROC_PRIMARY) {\n+\t\tbphy_dev = (struct bphy_device *)rawdev->dev_private;\n+\t\troc_bphy_dev_fini(&bphy_dev->bphy);\n+\t}\n \n \treturn rte_rawdev_pmd_release(rawdev);\n }\n", "prefixes": [] }