Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132281/?format=api
{ "id": 132281, "url": "https://patches.dpdk.org/api/patches/132281/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20231003113938.42959-1-selwin.sebastian@amd.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20231003113938.42959-1-selwin.sebastian@amd.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20231003113938.42959-1-selwin.sebastian@amd.com", "date": "2023-10-03T11:39:38", "name": "[v2] net/axgbe: use CPUID to identify cpu", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "682bdd689eefe6228cf6b6e3802b1ed9fad05edf", "submitter": { "id": 1436, "url": "https://patches.dpdk.org/api/people/1436/?format=api", "name": "Sebastian, Selwin", "email": "selwin.sebastian@amd.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20231003113938.42959-1-selwin.sebastian@amd.com/mbox/", "series": [ { "id": 29721, "url": "https://patches.dpdk.org/api/series/29721/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29721", "date": "2023-10-03T11:39:38", "name": "[v2] net/axgbe: use CPUID to identify cpu", "version": 2, "mbox": "https://patches.dpdk.org/series/29721/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132281/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/132281/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 44DFA426AE;\n\tTue, 3 Oct 2023 13:40:18 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 1BA454026C;\n\tTue, 3 Oct 2023 13:40:18 +0200 (CEST)", "from NAM10-DM6-obe.outbound.protection.outlook.com\n (mail-dm6nam10on2045.outbound.protection.outlook.com [40.107.93.45])\n by mails.dpdk.org (Postfix) with ESMTP id 737584026B;\n Tue, 3 Oct 2023 13:40:16 +0200 (CEST)", "from CY5PR15CA0192.namprd15.prod.outlook.com (2603:10b6:930:82::18)\n by MN0PR12MB5906.namprd12.prod.outlook.com (2603:10b6:208:37a::10)\n with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.33; Tue, 3 Oct\n 2023 11:40:13 +0000", "from CY4PEPF0000EDD1.namprd03.prod.outlook.com\n (2603:10b6:930:82:cafe::fe) by CY5PR15CA0192.outlook.office365.com\n (2603:10b6:930:82::18) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.34 via Frontend\n Transport; Tue, 3 Oct 2023 11:40:13 +0000", "from SATLEXMB04.amd.com (165.204.84.17) by\n CY4PEPF0000EDD1.mail.protection.outlook.com (10.167.241.205) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.20.6838.22 via Frontend Transport; Tue, 3 Oct 2023 11:40:13 +0000", "from cae-fox.amd.com (10.180.168.240) by SATLEXMB04.amd.com\n (10.181.40.145) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.27; Tue, 3 Oct\n 2023 06:40:11 -0500" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=UkSZNHwcWAizKcAXnU7RLRnD9lq5dY9YQzvY+k+t0dz25m8bgCRnRDc9IkE7CMMsMtlN49hWJ+ziSGeryHp8bOKAi4E9V2mLC2J+jnqBuft17cL+KVmHSsLVxHJlbnGjzsB7H/8XRhOWt6i5FiWCqR15yrhPzQ2C/gKlaGApPbOkMvRMJVTYqktCJM49Q3i79XiJu4o0fLrVqF92tbY6YX8DSVJwci187dIJ4pKwfXECFBE4YYdSDnaS9metnMvGkA2XaybHIREHBirGVwxCN6OgtXwv2EQ1C0RV5DEYG6PURB/TYwi/h6xYHmj8zuX2yCOwd99JIkvbmcYuLJGI7A==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=JTNLRxzkBQQ3Tf9p19mihL7E6p+o1VGDRBf+sJxGMtU=;\n b=KXr2PHT3/auVwtl63UaEDuZbPlwavYnthy2mnKgm9RB3K22Io128Il22xk4pLLuQdHLtlwsuYB6wln+5Kt2VFJDt5dTvd9IFlqoKol9KjZ2Patz8yVIwidfvg4OOfya8ACSTddxzCArglN1idR6Va1DXcd4d4t967EDhLyu/c9NE/tKM6Z9YeISwALVmTqbUGDCLubi+OieGAzXEK7HJY4mvICP/EEDyY78MQ8QZ7F+tje0aq0Q0/kO5gNzbUGNm3Alls3D1BmuGz+feT+dTbVmVSP7RhpUiDTEDXObSAG6mlcl1oPyMrYi8aJDSIV0DdtCwN+luMkg4lGpfpJxTrw==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 165.204.84.17) smtp.rcpttodomain=dpdk.org smtp.mailfrom=amd.com; dmarc=pass\n (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=JTNLRxzkBQQ3Tf9p19mihL7E6p+o1VGDRBf+sJxGMtU=;\n b=gSe368wo2eX3//dgrgVzUfz+QNRGAz4bmXz/aApNZYYwyvGTQpKeStuDr+CYPNVFz4JJWrplQfcd4TmIAeHrYLf0b+BF8tiFJR7Ik+masNMiKJhnK1KTCc5aOEAik5geQd1fIdb0ElndOyydOsbEWC+SzjfhEtjIVp2izSez4vs=", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 165.204.84.17)\n smtp.mailfrom=amd.com; dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=amd.com;", "Received-SPF": "Pass (protection.outlook.com: domain of amd.com designates\n 165.204.84.17 as permitted sender) receiver=protection.outlook.com;\n client-ip=165.204.84.17; helo=SATLEXMB04.amd.com; pr=C", "From": "Selwin Sebastian <selwin.sebastian@amd.com>", "To": "<dev@dpdk.org>", "CC": "<Ferruh.Yigit@amd.com>, Selwin Sebastian <selwin.sebastian@amd.com>,\n <stable@dpdk.org>", "Subject": "[PATCH v2] net/axgbe: use CPUID to identify cpu", "Date": "Tue, 3 Oct 2023 17:09:38 +0530", "Message-ID": "<20231003113938.42959-1-selwin.sebastian@amd.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.180.168.240]", "X-ClientProxiedBy": "SATLEXMB03.amd.com (10.181.40.144) To SATLEXMB04.amd.com\n (10.181.40.145)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "CY4PEPF0000EDD1:EE_|MN0PR12MB5906:EE_", "X-MS-Office365-Filtering-Correlation-Id": "a5bba627-0372-405c-cc25-08dbc40581bc", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n z5HnGv51iRi6MGpTQuCB8vc+RLVezwO06OYL72kWv7bxZya5eGK4kCriAXu4ugASLv/G9qIUnqY4yvOxTmHlhTfLA8tvqexZKUxzByM4+SrWElzhZp6vKZD6TZ/qbKdU7fCUEB2rLJxSk2tEmyqmJDdP3TYKK2Hl6s7f5l0Dweap/6dJvYIRfwRp6oLc9WHp+nNfV73KxwWvoCyJXOqRnfR+r3BXgF5k3JKqzVLBsaw2PiqhB3ufdZ20AsuqCKgslW5Qt/mf6GnnnWP1MQbsucQr016CKFaDkiG3NrpSp6vBDLvJpOMIuHjRtl41XV0LHtDjPDnw+IqRR+EIN3ppJeA5YkOyzggHW2VJGJdVKu5ZU3A0dpHbs67kSyGwzYxQfE8lLWblIE/L+0+5cx5IrQOqcXvJf/afpEyui8Fydmyi7lbLgXeASOvSu21F58fZjeAfgJE8VGAyvnEP//k9+abRo/r79gnPVBl7+aItFmUCUvrOIjGN90EpbW0lJ8W0T1UzwaRMaG0yfAUDV/hJ/pMAPu22vNJCgM0EqOwHK3ziPa0cw18cL+nOCbxe0xzF2uCq7PkVWsS1WOB63mbWX5gP6Ly3ijCrdhNrVa681cInco/nICLcDG57vCcggJB56up2qk0sVULytJrKzM148l+NhG2SVwfZYiLQRidqu4CI3xz2k9PNBmH49tl1dr64bl0WP4SN7n+ugUDsjaAJeQGzkkC3IciLXdvJ1E703ZH68hhQElyuPYXlMn3NoB2tEBOGw8sW5tFCcgwXN1EK2A==", "X-Forefront-Antispam-Report": "CIP:165.204.84.17; CTRY:US; LANG:en; SCL:1; SRV:;\n IPV:CAL; SFV:NSPM; H:SATLEXMB04.amd.com; PTR:InfoDomainNonexistent; CAT:NONE;\n SFS:(13230031)(4636009)(346002)(376002)(396003)(136003)(39860400002)(230922051799003)(82310400011)(64100799003)(451199024)(1800799009)(186009)(36840700001)(46966006)(40470700004)(478600001)(40460700003)(36756003)(6666004)(7696005)(41300700001)(6916009)(316002)(450100002)(8676002)(4326008)(8936002)(44832011)(54906003)(70206006)(70586007)(5660300002)(40480700001)(86362001)(47076005)(426003)(336012)(83380400001)(36860700001)(356005)(1076003)(2906002)(81166007)(2616005)(82740400003)(16526019)(26005)(36900700001);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "amd.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "03 Oct 2023 11:40:13.2477 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n a5bba627-0372-405c-cc25-08dbc40581bc", "X-MS-Exchange-CrossTenant-Id": "3dd8961f-e488-4e60-8e11-a82d994e183d", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d; Ip=[165.204.84.17];\n Helo=[SATLEXMB04.amd.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n CY4PEPF0000EDD1.namprd03.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MN0PR12MB5906", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Using root complex to identify cpu will not work for vm passthrough.\nCPUID is used to get family and modelid to identify cpu\n\nFixes: b0db927b5eba (\"net/axgbe: use PCI root complex device to distinguish device\")\nCc: stable@dpdk.org\n\nSigned-off-by: Selwin Sebastian <selwin.sebastian@amd.com>\n---\n drivers/net/axgbe/axgbe_ethdev.c | 106 ++++++++++++++++++-------------\n 1 file changed, 63 insertions(+), 43 deletions(-)", "diff": "diff --git a/drivers/net/axgbe/axgbe_ethdev.c b/drivers/net/axgbe/axgbe_ethdev.c\nindex 48714eebe6..4fdb0ae168 100644\n--- a/drivers/net/axgbe/axgbe_ethdev.c\n+++ b/drivers/net/axgbe/axgbe_ethdev.c\n@@ -12,6 +12,12 @@\n \n #include \"eal_filesystem.h\"\n \n+#ifdef RTE_ARCH_X86\n+#include <cpuid.h>\n+#else\n+#define __cpuid (n, a, b, c, d)\n+#endif\n+\n static int eth_axgbe_dev_init(struct rte_eth_dev *eth_dev);\n static int axgbe_dev_configure(struct rte_eth_dev *dev);\n static int axgbe_dev_start(struct rte_eth_dev *dev);\n@@ -172,9 +178,14 @@ static const struct axgbe_xstats axgbe_xstats_strings[] = {\n \n /* The set of PCI devices this driver supports */\n #define AMD_PCI_VENDOR_ID 0x1022\n-#define AMD_PCI_RV_ROOT_COMPLEX_ID\t0x15d0\n-#define AMD_PCI_YC_ROOT_COMPLEX_ID\t0x14b5\n-#define AMD_PCI_SNOWY_ROOT_COMPLEX_ID\t0x1450\n+\n+#define\tFam17h\t0x17\n+#define\tFam19h\t0x19\n+\n+#define\tCPUID_VENDOR_AuthenticAMD_ebx\t0x68747541\n+#define\tCPUID_VENDOR_AuthenticAMD_ecx\t0x444d4163\n+#define\tCPUID_VENDOR_AuthenticAMD_edx\t0x69746e65\n+\n #define AMD_PCI_AXGBE_DEVICE_V2A 0x1458\n #define AMD_PCI_AXGBE_DEVICE_V2B 0x1459\n \n@@ -2111,29 +2122,6 @@ static void axgbe_default_config(struct axgbe_port *pdata)\n \tpdata->power_down = 0;\n }\n \n-/*\n- * Return PCI root complex device id on success else 0\n- */\n-static uint16_t\n-get_pci_rc_devid(void)\n-{\n-\tchar pci_sysfs[PATH_MAX];\n-\tconst struct rte_pci_addr pci_rc_addr = {0, 0, 0, 0};\n-\tunsigned long device_id;\n-\n-\tsnprintf(pci_sysfs, sizeof(pci_sysfs), \"%s/\" PCI_PRI_FMT \"/device\",\n-\t\t rte_pci_get_sysfs_path(), pci_rc_addr.domain,\n-\t\t pci_rc_addr.bus, pci_rc_addr.devid, pci_rc_addr.function);\n-\n-\t/* get device id */\n-\tif (eal_parse_sysfs_value(pci_sysfs, &device_id) < 0) {\n-\t\tPMD_INIT_LOG(ERR, \"Error in reading PCI sysfs\\n\");\n-\t\treturn 0;\n-\t}\n-\n-\treturn (uint16_t)device_id;\n-}\n-\n /* Used in dev_start by primary process and then\n * in dev_init by secondary process when attaching to an existing ethdev.\n */\n@@ -2186,6 +2174,9 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \tuint32_t len;\n \tint ret;\n \n+\tunsigned int eax = 0, ebx = 0, ecx = 0, edx = 0;\n+\tunsigned char cpu_family = 0, cpu_model = 0;\n+\n \teth_dev->dev_ops = &axgbe_eth_dev_ops;\n \n \teth_dev->rx_descriptor_status = axgbe_dev_rx_descriptor_status;\n@@ -2230,26 +2221,55 @@ eth_axgbe_dev_init(struct rte_eth_dev *eth_dev)\n \t\tpdata->vdata = &axgbe_v2b;\n \n \t/*\n-\t * Use PCI root complex device ID to identify the CPU\n+\t * Use CPUID to get Family and model ID to identify the CPU\n \t */\n-\tswitch (get_pci_rc_devid()) {\n-\tcase AMD_PCI_RV_ROOT_COMPLEX_ID:\n-\t\tpdata->xpcs_window_def_reg = PCS_V2_RV_WINDOW_DEF;\n-\t\tpdata->xpcs_window_sel_reg = PCS_V2_RV_WINDOW_SELECT;\n-\t\tbreak;\n-\tcase AMD_PCI_YC_ROOT_COMPLEX_ID:\n-\t\tpdata->xpcs_window_def_reg = PCS_V2_YC_WINDOW_DEF;\n-\t\tpdata->xpcs_window_sel_reg = PCS_V2_YC_WINDOW_SELECT;\n-\t\t/* Yellow Carp devices do not need cdr workaround */\n-\t\tpdata->vdata->an_cdr_workaround = 0;\n+\t__cpuid(0x0, eax, ebx, ecx, edx);\n+\n+\tif (ebx == CPUID_VENDOR_AuthenticAMD_ebx &&\n+\t\tedx == CPUID_VENDOR_AuthenticAMD_edx &&\n+\t\tecx == CPUID_VENDOR_AuthenticAMD_ecx) {\n+\t\tint unknown_cpu = 0;\n+\t\teax = 0, ebx = 0, ecx = 0, edx = 0;\n+\n+\t\t__cpuid(0x1, eax, ebx, ecx, edx);\n+\n+\t\tcpu_family = ((GET_BITS(eax, 8, 4)) + (GET_BITS(eax, 20, 8)));\n+\t\tcpu_model = ((GET_BITS(eax, 4, 4)) | (((GET_BITS(eax, 16, 4)) << 4) & 0xF0));\n+\n+\t\tswitch (cpu_family) {\n+\t\tcase Fam17h:\n+\t\t/* V1000/R1000 */\n+\t\tif (cpu_model >= 0x10 && cpu_model <= 0x1F) {\n+\t\t\tpdata->xpcs_window_def_reg = PCS_V2_RV_WINDOW_DEF;\n+\t\t\tpdata->xpcs_window_sel_reg = PCS_V2_RV_WINDOW_SELECT;\n+\t\t/* EPYC 3000 */\n+\t\t} else if (cpu_model >= 0x01 && cpu_model <= 0x0F) {\n+\t\t\tpdata->xpcs_window_def_reg = PCS_V2_WINDOW_DEF;\n+\t\t\tpdata->xpcs_window_sel_reg = PCS_V2_WINDOW_SELECT;\n+\t\t} else {\n+\t\t\tunknown_cpu = 1;\n+\t\t}\n \t\tbreak;\n-\tcase AMD_PCI_SNOWY_ROOT_COMPLEX_ID:\n-\t\tpdata->xpcs_window_def_reg = PCS_V2_WINDOW_DEF;\n-\t\tpdata->xpcs_window_sel_reg = PCS_V2_WINDOW_SELECT;\n+\t\tcase Fam19h:\n+\t\t/* V3000 (Yellow Carp) */\n+\t\tif (cpu_model >= 0x44 && cpu_model <= 0x47) {\n+\t\t\tpdata->xpcs_window_def_reg = PCS_V2_YC_WINDOW_DEF;\n+\t\t\tpdata->xpcs_window_sel_reg = PCS_V2_YC_WINDOW_SELECT;\n+\n+\t\t\t/* Yellow Carp devices do not need cdr workaround */\n+\t\t\tpdata->vdata->an_cdr_workaround = 0;\n+\t\t} else {\n+\t\t\tunknown_cpu = 1;\n+\t\t}\n \t\tbreak;\n-\tdefault:\n-\t\tPMD_DRV_LOG(ERR, \"No supported devices found\\n\");\n-\t\treturn -ENODEV;\n+\t\tdefault:\n+\t\t\tunknown_cpu = 1;\n+\t\t\tbreak;\n+\t\t}\n+\t\tif (unknown_cpu) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Unknown CPU family, no supported axgbe device found\\n\");\n+\t\t\treturn -ENODEV;\n+\t\t}\n \t}\n \n \t/* Configure the PCS indirect addressing support */\n", "prefixes": [ "v2" ] }