Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132100/?format=api
{ "id": 132100, "url": "https://patches.dpdk.org/api/patches/132100/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230928094758.1076236-3-jiawenwu@trustnetic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230928094758.1076236-3-jiawenwu@trustnetic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230928094758.1076236-3-jiawenwu@trustnetic.com", "date": "2023-09-28T09:47:49", "name": "[02/11] net/txgbe: fix GRE tunnel packet checksum", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "5a77ac5421495a33479e98b2cb8e40771822496d", "submitter": { "id": 1932, "url": "https://patches.dpdk.org/api/people/1932/?format=api", "name": "Jiawen Wu", "email": "jiawenwu@trustnetic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230928094758.1076236-3-jiawenwu@trustnetic.com/mbox/", "series": [ { "id": 29673, "url": "https://patches.dpdk.org/api/series/29673/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29673", "date": "2023-09-28T09:47:47", "name": "Wanguxn NICs fixes and supports", "version": 1, "mbox": "https://patches.dpdk.org/series/29673/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132100/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132100/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id C296F4265E;\n\tThu, 28 Sep 2023 11:37:23 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F348140E03;\n\tThu, 28 Sep 2023 11:37:21 +0200 (CEST)", "from smtpbgeu1.qq.com (smtpbgeu1.qq.com [52.59.177.22])\n by mails.dpdk.org (Postfix) with ESMTP id A863840A80;\n Thu, 28 Sep 2023 11:37:17 +0200 (CEST)", "from wxdbg.localdomain.com ( [115.200.229.121])\n by bizesmtp.qq.com (ESMTP) with\n id ; Thu, 28 Sep 2023 17:37:05 +0800 (CST)" ], "X-QQ-mid": "bizesmtp74t1695893825tqricwgy", "X-QQ-SSF": "01400000000000K0Z000000A0000000", "X-QQ-FEAT": "jlZuxrJ108Ao/J0wkhuL8UvlKG3saqwM6uBAiwvGnIgOZlIG7ANYS9Zg38qhy\n fccAnTa7t9KnvStwHhWLVO14wtKjauDCoINusEY8NQca5ATDNr8TSoQTfIogpCed+AVB54c\n iRS7YRO9ogu20JauXjyLFVw/LmBzqg7PIkke9r1bUIUQ1frfgVaDUJ6AjMjU7h9GSJJix/a\n hb1i2ENNtJzbHuEX0oKExFl/c/uHA9bl4psOJjqX6Y0Fz1kTn0Sgzh/rC+8aUGySTLYzpsa\n CJ1pQoQZHjSjuzgIDU9CJ1Vkng27fGOSuZz2bhqCCm4A1xepMkf5eu902e7EIs1l5KaMPbC\n iGRJOBmseLXVVIbKCabM8ieGvlAuyXVYKw5/cXxdGXWyqLlmEI6qOPKVpPnOHTGGb76q8/G\n LVzzdOJi8Xk=", "X-QQ-GoodBg": "2", "X-BIZMAIL-ID": "14137782599609079605", "From": "Jiawen Wu <jiawenwu@trustnetic.com>", "To": "dev@dpdk.org", "Cc": "Jiawen Wu <jiawenwu@trustnetic.com>,\n\tstable@dpdk.org", "Subject": "[PATCH 02/11] net/txgbe: fix GRE tunnel packet checksum", "Date": "Thu, 28 Sep 2023 17:47:49 +0800", "Message-Id": "<20230928094758.1076236-3-jiawenwu@trustnetic.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230928094758.1076236-1-jiawenwu@trustnetic.com>", "References": "<20230928094758.1076236-1-jiawenwu@trustnetic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-QQ-SENDSIZE": "520", "Feedback-ID": "bizesmtp:trustnetic.com:qybglogicsvrgz:qybglogicsvrgz5a-1", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix transmit context descriptor for GRE tunnel packet to make the\nhardware compute the checksum successfully.\n\nFixes: e5ece1f467aa (\"net/txgbe: fix VXLAN-GPE packet checksum\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jiawen Wu <jiawenwu@trustnetic.com>\n---\n drivers/net/txgbe/txgbe_ptypes.c | 16 ----------------\n drivers/net/txgbe/txgbe_ptypes.h | 5 +++++\n drivers/net/txgbe/txgbe_rxtx.c | 23 ++++++++++++-----------\n 3 files changed, 17 insertions(+), 27 deletions(-)", "diff": "diff --git a/drivers/net/txgbe/txgbe_ptypes.c b/drivers/net/txgbe/txgbe_ptypes.c\nindex e1299d7363..c444d5d3f1 100644\n--- a/drivers/net/txgbe/txgbe_ptypes.c\n+++ b/drivers/net/txgbe/txgbe_ptypes.c\n@@ -320,8 +320,6 @@ txgbe_encode_ptype_tunnel(u32 ptype)\n \t\tptid |= TXGBE_PTID_TUN_EI;\n \t\tbreak;\n \tcase RTE_PTYPE_TUNNEL_GRE:\n-\t\tptid |= TXGBE_PTID_TUN_EIG;\n-\t\tbreak;\n \tcase RTE_PTYPE_TUNNEL_VXLAN:\n \tcase RTE_PTYPE_TUNNEL_VXLAN_GPE:\n \tcase RTE_PTYPE_TUNNEL_NVGRE:\n@@ -332,20 +330,6 @@ txgbe_encode_ptype_tunnel(u32 ptype)\n \t\treturn ptid;\n \t}\n \n-\tswitch (ptype & RTE_PTYPE_INNER_L2_MASK) {\n-\tcase RTE_PTYPE_INNER_L2_ETHER:\n-\t\tptid |= TXGBE_PTID_TUN_EIGM;\n-\t\tbreak;\n-\tcase RTE_PTYPE_INNER_L2_ETHER_VLAN:\n-\t\tptid |= TXGBE_PTID_TUN_EIGMV;\n-\t\tbreak;\n-\tcase RTE_PTYPE_INNER_L2_ETHER_QINQ:\n-\t\tptid |= TXGBE_PTID_TUN_EIGMV;\n-\t\tbreak;\n-\tdefault:\n-\t\tbreak;\n-\t}\n-\n \tswitch (ptype & RTE_PTYPE_INNER_L3_MASK) {\n \tcase RTE_PTYPE_INNER_L3_IPV4:\n \tcase RTE_PTYPE_INNER_L3_IPV4_EXT:\ndiff --git a/drivers/net/txgbe/txgbe_ptypes.h b/drivers/net/txgbe/txgbe_ptypes.h\nindex fa6c347d53..6fa8147f05 100644\n--- a/drivers/net/txgbe/txgbe_ptypes.h\n+++ b/drivers/net/txgbe/txgbe_ptypes.h\n@@ -348,4 +348,9 @@ struct txgbe_nvgrehdr {\n \t__be32 tni;\n };\n \n+struct txgbe_grehdr {\n+\t__be16 flags;\n+\t__be16 proto;\n+};\n+\n #endif /* _TXGBE_PTYPE_H_ */\ndiff --git a/drivers/net/txgbe/txgbe_rxtx.c b/drivers/net/txgbe/txgbe_rxtx.c\nindex 427f8b82ac..f7cd2333ab 100644\n--- a/drivers/net/txgbe/txgbe_rxtx.c\n+++ b/drivers/net/txgbe/txgbe_rxtx.c\n@@ -572,7 +572,6 @@ tx_desc_ol_flags_to_ptype(uint64_t oflags)\n \t\tptype |= RTE_PTYPE_L2_ETHER |\n \t\t\t RTE_PTYPE_L3_IPV4 |\n \t\t\t RTE_PTYPE_TUNNEL_GRE;\n-\t\tptype |= RTE_PTYPE_INNER_L2_ETHER;\n \t\tbreak;\n \tcase RTE_MBUF_F_TX_TUNNEL_GENEVE:\n \t\tptype |= RTE_PTYPE_L2_ETHER |\n@@ -705,22 +704,24 @@ txgbe_get_tun_len(struct rte_mbuf *mbuf)\n static inline uint8_t\n txgbe_parse_tun_ptid(struct rte_mbuf *tx_pkt)\n {\n-\tuint64_t l2_none, l2_mac, l2_mac_vlan;\n+\tuint64_t l2_vxlan, l2_vxlan_mac, l2_vxlan_mac_vlan;\n+\tuint64_t l2_gre, l2_gre_mac, l2_gre_mac_vlan;\n \tuint8_t ptid = 0;\n \n-\tif ((tx_pkt->ol_flags & (RTE_MBUF_F_TX_TUNNEL_VXLAN |\n-\t\t\t\tRTE_MBUF_F_TX_TUNNEL_VXLAN_GPE)) == 0)\n-\t\treturn ptid;\n+\tl2_vxlan = sizeof(struct txgbe_udphdr) + sizeof(struct txgbe_vxlanhdr);\n+\tl2_vxlan_mac = l2_vxlan + sizeof(struct rte_ether_hdr);\n+\tl2_vxlan_mac_vlan = l2_vxlan_mac + sizeof(struct rte_vlan_hdr);\n \n-\tl2_none = sizeof(struct txgbe_udphdr) + sizeof(struct txgbe_vxlanhdr);\n-\tl2_mac = l2_none + sizeof(struct rte_ether_hdr);\n-\tl2_mac_vlan = l2_mac + sizeof(struct rte_vlan_hdr);\n+\tl2_gre = sizeof(struct txgbe_grehdr);\n+\tl2_gre_mac = l2_gre + sizeof(struct rte_ether_hdr);\n+\tl2_gre_mac_vlan = l2_gre_mac + sizeof(struct rte_vlan_hdr);\n \n-\tif (tx_pkt->l2_len == l2_none)\n+\tif (tx_pkt->l2_len == l2_vxlan || tx_pkt->l2_len == l2_gre)\n \t\tptid = TXGBE_PTID_TUN_EIG;\n-\telse if (tx_pkt->l2_len == l2_mac)\n+\telse if (tx_pkt->l2_len == l2_vxlan_mac || tx_pkt->l2_len == l2_gre_mac)\n \t\tptid = TXGBE_PTID_TUN_EIGM;\n-\telse if (tx_pkt->l2_len == l2_mac_vlan)\n+\telse if (tx_pkt->l2_len == l2_vxlan_mac_vlan ||\n+\t\t\ttx_pkt->l2_len == l2_gre_mac_vlan)\n \t\tptid = TXGBE_PTID_TUN_EIGMV;\n \n \treturn ptid;\n", "prefixes": [ "02/11" ] }