Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/132015/?format=api
{ "id": 132015, "url": "https://patches.dpdk.org/api/patches/132015/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230927124034.1092086-1-krzysztof.karas@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230927124034.1092086-1-krzysztof.karas@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230927124034.1092086-1-krzysztof.karas@intel.com", "date": "2023-09-27T12:40:34", "name": "crypto/ipsec_mb: Do not dequeue ops from ring after job flush.", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "5999d2f638c832e0c672f1564d16f1873c4b77bd", "submitter": { "id": 2905, "url": "https://patches.dpdk.org/api/people/2905/?format=api", "name": "Krzysztof Karas", "email": "krzysztof.karas@intel.com" }, "delegate": { "id": 6690, "url": "https://patches.dpdk.org/api/users/6690/?format=api", "username": "akhil", "first_name": "akhil", "last_name": "goyal", "email": "gakhil@marvell.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230927124034.1092086-1-krzysztof.karas@intel.com/mbox/", "series": [ { "id": 29656, "url": "https://patches.dpdk.org/api/series/29656/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29656", "date": "2023-09-27T12:40:34", "name": "crypto/ipsec_mb: Do not dequeue ops from ring after job flush.", "version": 1, "mbox": "https://patches.dpdk.org/series/29656/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/132015/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/132015/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E772F42651;\n\tWed, 27 Sep 2023 14:40:42 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D3F58402BE;\n\tWed, 27 Sep 2023 14:40:42 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id 4BD194028C;\n Wed, 27 Sep 2023 14:40:41 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 27 Sep 2023 05:40:39 -0700", "from kkaras2.igk.intel.com ([10.211.11.138])\n by fmsmga001.fm.intel.com with ESMTP; 27 Sep 2023 05:39:30 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695818441; x=1727354441;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=qODniF95lM4FBhZusJH8hy99d+EKKtjvdfEOUCtPEbc=;\n b=Cl82l6SxzgurZ7R8tPouvW/YyotVquS0O4xKopc/jG+h3S1mPCIXDTAB\n ivr46XTe8fCdZOJfsxf95gXELw/i+vDHBmaw64hvTuf8VslVkl4xsvig2\n X/cjgCMgOgrlIg7+3qwV8Iw5C8rCFitkXvezkrA3/kz7wJi1z2F68kQ4v\n dWiMq2y+yPsLItfHMR3cnY0XU31V+QHsWwywStIicdMbVZLW5TkY+LG1l\n PNiIXGfO1Covf1gRtFoh6wp380ZjwQGeiUbXzJUHFPbN/uc7WLrEYXifZ\n 4ymzrXhWhYQ2NshitSLrYzghjw/3VWJfCnya15ym/srdbcoRjTeNH5LIV w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10846\"; a=\"385671631\"", "E=Sophos;i=\"6.03,181,1694761200\"; d=\"scan'208\";a=\"385671631\"", "E=McAfee;i=\"6600,9927,10846\"; a=\"892585617\"", "E=Sophos;i=\"6.03,181,1694761200\"; d=\"scan'208\";a=\"892585617\"" ], "X-ExtLoop1": "1", "From": "Krzysztof Karas <krzysztof.karas@intel.com>", "To": "Kai Ji <kai.ji@intel.com>, Pablo de Lara <pablo.de.lara.guarch@intel.com>,\n Marcel Cornu <marcel.d.cornu@intel.com>,\n Ciara Power <ciara.power@intel.com>", "Cc": "dev@dpdk.org, Krzysztof Karas <krzysztof.karas@intel.com>, stable@dpdk.org", "Subject": "[PATCH] crypto/ipsec_mb: Do not dequeue ops from ring after job\n flush.", "Date": "Wed, 27 Sep 2023 14:40:34 +0200", "Message-Id": "<20230927124034.1092086-1-krzysztof.karas@intel.com>", "X-Mailer": "git-send-email 2.34.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Previously it was possible to increment `processed_jobs` to a value\ngreater than requested `nb_ops`, because after flushing at most\n`nb_ops` jobs the while loop continued, so `processed_jobs` could\nstill be incremented and it was possible for this variable to be\ngreater than `nb_ops`. If `ops` provided to the function were\nonly `nb_ops` long, then the `aesni_mb_dequeue_burst()` would\nwrite to the memory outside of `ops` array.\n\nFixes: b50b8b5b38f8 (\"crypto/ipsec_mb: use burst API in AESNI\")\nCc: stable@dpdk.org\n\nSigned-off-by: Krzysztof Karas <krzysztof.karas@intel.com>\n\n---\n drivers/crypto/ipsec_mb/pmd_aesni_mb.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\nindex 9e298023d7..ff52bc85a4 100644\n--- a/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n+++ b/drivers/crypto/ipsec_mb/pmd_aesni_mb.c\n@@ -2056,7 +2056,7 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\tuint16_t n = (nb_ops / burst_sz) ?\n \t\t\tburst_sz : nb_ops;\n \n-\t\twhile (unlikely((IMB_GET_NEXT_BURST(mb_mgr, n, jobs)) < n)) {\n+\t\tif (unlikely((IMB_GET_NEXT_BURST(mb_mgr, n, jobs)) < n)) {\n \t\t\t/*\n \t\t\t * Not enough free jobs in the queue\n \t\t\t * Flush n jobs until enough jobs available\n@@ -2074,6 +2074,8 @@ aesni_mb_dequeue_burst(void *queue_pair, struct rte_crypto_op **ops,\n \t\t\t\t\tbreak;\n \t\t\t\t}\n \t\t\t}\n+\t\t\tnb_ops -= nb_jobs;\n+\t\t\tcontinue;\n \t\t}\n \n \t\t/*\n", "prefixes": [] }