Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131991/?format=api
{ "id": 131991, "url": "https://patches.dpdk.org/api/patches/131991/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230927094148.1129330-4-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230927094148.1129330-4-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230927094148.1129330-4-david.marchand@redhat.com", "date": "2023-09-27T09:41:48", "name": "[v2,4/4] net/ice: fix TSO with big segments", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "69d0e726251fb0ba34f7af43c6e1b5eb5cf60938", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230927094148.1129330-4-david.marchand@redhat.com/mbox/", "series": [ { "id": 29651, "url": "https://patches.dpdk.org/api/series/29651/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29651", "date": "2023-09-27T09:41:45", "name": "[v2,1/4] net/iavf: remove log from Tx prepare datapath function", "version": 2, "mbox": "https://patches.dpdk.org/series/29651/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131991/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131991/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5F76642651;\n\tWed, 27 Sep 2023 11:42:26 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C0A3840A6C;\n\tWed, 27 Sep 2023 11:42:17 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.133.124])\n by mails.dpdk.org (Postfix) with ESMTP id 10535409FA\n for <dev@dpdk.org>; Wed, 27 Sep 2023 11:42:16 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-32-HR69K3gMM_CVode0CpUIfw-1; Wed, 27 Sep 2023 05:42:11 -0400", "from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com\n [10.11.54.7])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 989A6185A797;\n Wed, 27 Sep 2023 09:42:10 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.224.48])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 8E1D514171B6;\n Wed, 27 Sep 2023 09:42:09 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1695807736;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=wCyb1mvyfTmJgjIKiiU1V2o7tbE0uxsAYss4KcLKZK0=;\n b=AWkpiB8WBAO2bIuVh7KwvTV66qLdCuES3wDBuCjpQYF+Ll1hOVvbePVLYivPB4lW8emDoF\n D7X9MYc0TjCu+lH102qKkYFw2mCkGyjxWNno4aJVdu3bHJbaHld/M5A01ezKFhXXzccgt1\n qmgOP29gJVcjEzVU8OHuOZUsrLiMxms=", "X-MC-Unique": "HR69K3gMM_CVode0CpUIfw-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "stable@dpdk.org, Qiming Yang <qiming.yang@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>, Kevin Liu <kevinx.liu@intel.com>", "Subject": "[PATCH v2 4/4] net/ice: fix TSO with big segments", "Date": "Wed, 27 Sep 2023 11:41:48 +0200", "Message-ID": "<20230927094148.1129330-4-david.marchand@redhat.com>", "In-Reply-To": "<20230927094148.1129330-1-david.marchand@redhat.com>", "References": "<20230919140430.3251493-1-david.marchand@redhat.com>\n <20230927094148.1129330-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.7", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Packets to be segmented with TSO are usually larger than MTU.\nPlus, a single segment for the whole packet may be used: in OVS case,\nan external rte_malloc'd buffer is used for packets received\nfrom vhost-user ports.\n\nBefore this fix, TSO packets were dropped by net/ice with the following\nmessage:\n2023-09-18T13:34:31.064Z|00020|dpdk(pmd-c31/id:22)|ERR|ice_prep_pkts():\n\tINVALID mbuf: bad data_len=[2962]\n\nRemove the check on data_len.\n\nFixes: ccf33dccf7aa (\"net/ice: check illegal packet sizes\")\nCc: stable@dpdk.org\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\n---\nNote: I am still waiting for feedback and there may be some followup patch\nlater wrt ice_prep_pkts.\nFor context, see: http://inbox.dpdk.org/dev/CAJFAV8yOa3ShkVdEXHfnmOEmUTwV3e75Bu9U3OqpNc5usTt3Rw@mail.gmail.com/T/#u\n\nChanges since v1:\n- moved log removal in a separate patch,\n\n---\n drivers/net/ice/ice_rxtx.c | 7 +------\n 1 file changed, 1 insertion(+), 6 deletions(-)", "diff": "diff --git a/drivers/net/ice/ice_rxtx.c b/drivers/net/ice/ice_rxtx.c\nindex d5513e9e93..ee9cb7b955 100644\n--- a/drivers/net/ice/ice_rxtx.c\n+++ b/drivers/net/ice/ice_rxtx.c\n@@ -3685,9 +3685,6 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \tint i, ret;\n \tuint64_t ol_flags;\n \tstruct rte_mbuf *m;\n-\tstruct ice_tx_queue *txq = tx_queue;\n-\tstruct rte_eth_dev *dev = &rte_eth_devices[txq->port_id];\n-\tuint16_t max_frame_size = dev->data->mtu + ICE_ETH_OVERHEAD;\n \n \tfor (i = 0; i < nb_pkts; i++) {\n \t\tm = tx_pkts[i];\n@@ -3704,9 +3701,7 @@ ice_prep_pkts(__rte_unused void *tx_queue, struct rte_mbuf **tx_pkts,\n \t\t\treturn i;\n \t\t}\n \n-\t\t/* check the data_len in mbuf */\n-\t\tif (m->data_len < ICE_TX_MIN_PKT_LEN ||\n-\t\t\tm->data_len > max_frame_size) {\n+\t\tif (m->pkt_len < ICE_TX_MIN_PKT_LEN) {\n \t\t\trte_errno = EINVAL;\n \t\t\treturn i;\n \t\t}\n", "prefixes": [ "v2", "4/4" ] }