Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/13191/?format=api
{ "id": 13191, "url": "https://patches.dpdk.org/api/patches/13191/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1464941723-18154-1-git-send-email-thomas.monjalon@6wind.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1464941723-18154-1-git-send-email-thomas.monjalon@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1464941723-18154-1-git-send-email-thomas.monjalon@6wind.com", "date": "2016-06-03T08:15:23", "name": "[dpdk-dev] eal/x86: fix clang build with -O0", "commit_ref": "f243d9b", "pull_url": null, "state": "accepted", "archived": true, "hash": "245ff0d20528fc9cf6cf60d8fc938b64a9fe55db", "submitter": { "id": 1, "url": "https://patches.dpdk.org/api/people/1/?format=api", "name": "Thomas Monjalon", "email": "thomas.monjalon@6wind.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1464941723-18154-1-git-send-email-thomas.monjalon@6wind.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/13191/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/13191/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id C61F92C30;\n\tFri, 3 Jun 2016 10:15:29 +0200 (CEST)", "from mail-wm0-f48.google.com (mail-wm0-f48.google.com\n\t[74.125.82.48]) by dpdk.org (Postfix) with ESMTP id 91C562BBD\n\tfor <dev@dpdk.org>; Fri, 3 Jun 2016 10:15:28 +0200 (CEST)", "by mail-wm0-f48.google.com with SMTP id a136so264160131wme.0\n\tfor <dev@dpdk.org>; Fri, 03 Jun 2016 01:15:28 -0700 (PDT)", "from XPS13.enst.fr ([2001:660:330f:38:7e7a:91ff:fe14:f0d2])\n\tby smtp.gmail.com with ESMTPSA id\n\ts1sm799770wjf.43.2016.06.03.01.15.26\n\t(version=TLSv1/SSLv3 cipher=OTHER);\n\tFri, 03 Jun 2016 01:15:27 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=6wind-com.20150623.gappssmtp.com; s=20150623;\n\th=from:to:cc:subject:date:message-id;\n\tbh=7Z24Dv5Oqlb8tznT2/rFyQ5zWcyykyuoHXHv7Bx0EZ8=;\n\tb=HsNxOwHBLhbYGCjmQhAbSz6FDSW6Dd1ifYRz3T1SNsXLwTAonTOjLqNI2khGjgKDpR\n\tmplMqvNqqk3pV3X9t6fp8cIXk3GzQjOFMjOXnAg3wO7H2BTWaikks0U8jmdltYTGq1fS\n\tvRzVFkm00awYNtV0vcud0elGnhdb0QE9alXBE3ydcEiRcoZcQLHfl6EB06kS0DLvEKzm\n\tvcItsgdxPH0HbN2iMVtWdgD07TqzUteWyUNavwdK5dfi67u71qD8ArsLKR7Cd3wf8qjb\n\tXwSJsZ/2wmze+NV9bsA3iu+VUvoyZQWyCUrgUvWkNHF9wCx2t584H2YhzHvXRvWJv+pw\n\tpGng==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:from:to:cc:subject:date:message-id;\n\tbh=7Z24Dv5Oqlb8tznT2/rFyQ5zWcyykyuoHXHv7Bx0EZ8=;\n\tb=kjIezP9vvx8cuToFXchr4g8MGGi8KtA0h5QJMyo3vZn99oaHkf56gDQbvq30VWZxpO\n\tipfXZWJd5sw6ehw8BDotyZsRcCECYUVK7Z3WMf4KClLb0I8jU/GdX+jd4G4ZSgcRuq6G\n\tohoRAsAnmJVDpJwjJ+F//fn9QtjKRKtiDkcjN9YagzkMre1K7mKpQuaIkP3h1+CnrxfS\n\t0R20CZiwx1UNLcaQoJmzabEldOBPOLH5TppylBZub2W9Rt7/syF0JebayQ1O59/13C87\n\tZnZaLQtyD3xbpPRThckxDf7NfgDy1FA6TwKVovMsA6Dt5f3H9l2mwHpEQ57M0cnxrSKB\n\tCn6w==", "X-Gm-Message-State": "ALyK8tIYcUmWCzpJwjF7VhC5wrrCDwaOCSYmXY24h9puBkDi7//ObUjkltjfrS8r+yYfMdhx", "X-Received": "by 10.194.103.105 with SMTP id fv9mr2107484wjb.162.1464941728311;\n\tFri, 03 Jun 2016 01:15:28 -0700 (PDT)", "From": "Thomas Monjalon <thomas.monjalon@6wind.com>", "To": "dev@dpdk.org", "Cc": "Damjan Marion <damarion@cisco.com>", "Date": "Fri, 3 Jun 2016 10:15:23 +0200", "Message-Id": "<1464941723-18154-1-git-send-email-thomas.monjalon@6wind.com>", "X-Mailer": "git-send-email 2.7.0", "Subject": "[dpdk-dev] [PATCH] eal/x86: fix clang build with -O0", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "From: Damjan Marion <damarion@cisco.com>\n\nClang seems to have a bug with asm inside inline function rte_xabort():\n\nrte_rtm.h:56:15: error: invalid operand for inline asm constraint 'i'\n asm volatile(\".byte 0xc6,0xf8,%P0\" :: \"i\" (status) : \"memory\");\n ^\n\nIt is seen only when building with EXTRA_CFLAGS=-O0.\n\nThe workaround is to replace the inline function by a macro.\n\nFixes: ba7468997ea6 (\"spinlock: add HTM lock elision for x86\")\n\nSigned-off-by: Damjan Marion <damarion@cisco.com>\nSigned-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>\n---\n lib/librte_eal/common/include/arch/x86/rte_rtm.h | 9 ++++-----\n 1 file changed, 4 insertions(+), 5 deletions(-)", "diff": "diff --git a/lib/librte_eal/common/include/arch/x86/rte_rtm.h b/lib/librte_eal/common/include/arch/x86/rte_rtm.h\nindex d935641..0649f79 100644\n--- a/lib/librte_eal/common/include/arch/x86/rte_rtm.h\n+++ b/lib/librte_eal/common/include/arch/x86/rte_rtm.h\n@@ -50,11 +50,10 @@ void rte_xend(void)\n \t asm volatile(\".byte 0x0f,0x01,0xd5\" ::: \"memory\");\n }\n \n-static __attribute__((__always_inline__)) inline\n-void rte_xabort(const unsigned int status)\n-{\n-\tasm volatile(\".byte 0xc6,0xf8,%P0\" :: \"i\" (status) : \"memory\");\n-}\n+/* not an inline function to workaround a clang bug with -O0 */\n+#define rte_xabort(status) do { \\\n+\tasm volatile(\".byte 0xc6,0xf8,%P0\" :: \"i\" (status) : \"memory\"); \\\n+} while (0)\n \n static __attribute__((__always_inline__)) inline\n int rte_xtest(void)\n", "prefixes": [ "dpdk-dev" ] }