Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131864/?format=api
{ "id": 131864, "url": "https://patches.dpdk.org/api/patches/131864/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230925020921.4607-6-haifeil@nvidia.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230925020921.4607-6-haifeil@nvidia.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230925020921.4607-6-haifeil@nvidia.com", "date": "2023-09-25T02:09:20", "name": "[v2,5/5] net/mlx5: add support for item NSH", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "348d7ad31ea2d2dc71ea1a1444b32ae77eeae4cc", "submitter": { "id": 2131, "url": "https://patches.dpdk.org/api/people/2131/?format=api", "name": "Haifei Luo", "email": "haifeil@nvidia.com" }, "delegate": { "id": 3268, "url": "https://patches.dpdk.org/api/users/3268/?format=api", "username": "rasland", "first_name": "Raslan", "last_name": "Darawsheh", "email": "rasland@nvidia.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230925020921.4607-6-haifeil@nvidia.com/mbox/", "series": [ { "id": 29612, "url": "https://patches.dpdk.org/api/series/29612/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29612", "date": "2023-09-25T02:09:15", "name": "support item NSH matching", "version": 2, "mbox": "https://patches.dpdk.org/series/29612/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131864/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131864/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 578DF42630;\n\tMon, 25 Sep 2023 04:10:32 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id C386840395;\n\tMon, 25 Sep 2023 04:10:13 +0200 (CEST)", "from NAM10-MW2-obe.outbound.protection.outlook.com\n (mail-mw2nam10on2070.outbound.protection.outlook.com [40.107.94.70])\n by mails.dpdk.org (Postfix) with ESMTP id 62357402E6\n for <dev@dpdk.org>; Mon, 25 Sep 2023 04:10:10 +0200 (CEST)", "from MW4P223CA0008.NAMP223.PROD.OUTLOOK.COM (2603:10b6:303:80::13)\n by MW4PR12MB7032.namprd12.prod.outlook.com (2603:10b6:303:1e9::12) with\n Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6813.20; Mon, 25 Sep\n 2023 02:10:08 +0000", "from MWH0EPF000971E4.namprd02.prod.outlook.com\n (2603:10b6:303:80:cafe::7f) by MW4P223CA0008.outlook.office365.com\n (2603:10b6:303:80::13) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6792.35 via Frontend\n Transport; Mon, 25 Sep 2023 02:10:08 +0000", "from mail.nvidia.com (216.228.117.161) by\n MWH0EPF000971E4.mail.protection.outlook.com (10.167.243.72) with Microsoft\n SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n 15.20.6838.14 via Frontend Transport; Mon, 25 Sep 2023 02:10:08 +0000", "from rnnvmail202.nvidia.com (10.129.68.7) by mail.nvidia.com\n (10.129.200.67) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 24 Sep\n 2023 19:09:52 -0700", "from nvidia.com (10.126.231.35) by rnnvmail202.nvidia.com\n (10.129.68.7) with Microsoft SMTP Server (version=TLS1_2,\n cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.986.41; Sun, 24 Sep\n 2023 19:09:50 -0700" ], "ARC-Seal": "i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none;\n b=CT9MH9i954cVXyRmiPRiwF7gjZgVDgehFO61QKH2whD2tx+xxQFFcm83R7bIU8UA2FosVDlfJGmRF9p3bLSZo+jBaQS0CoQT3ZaI277QneamQyubbdTQEquEHq+F8y1nrLlWMQq31Qa2ojhbz5VjJsFsietIpMi8Syrho9MIZBfMITwwwgrDjp6bQ5yUzD4k6F6AWQ/OtvhBs0m3CA+qB4v7PxGsjmwaSjOM3vFLNgKlsJbf2OkxzATpgtXgd6SX3hAa/Vu+8m/Kgsrsg4TMYxS2fduAtwZld+swr6jw75Pl5xRVtWMEIyxbJyW39Ebo5/r5kLMJRKNELiFiynrlZA==", "ARC-Message-Signature": "i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com;\n s=arcselector9901;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1;\n bh=rGV/LEimjla1K0ZnIRY1yJ5U0T9chLatiNyHDiSQy/E=;\n b=i6GDWlRxLVQorSGBLRIKrktxqs1t6knArfGKcMksa9OPq6p29Sl0JHrXVJXK69kC9bKeaJ59G0dsmuUv0HpZqRh7q/iAz1jtxquo4lF9itLnORlS4dD7SbMQE2s3bxbHMOs4lrc97Kud6kaNv1pIC/atAyEkX8EgACBiicvHMp2EjQ2KHIBByJ4IFp6ygCsrq6NN6wKHbzYupaJwSkEH0qgBLLiN+rpVUcpggdqNFM2xwj3x4fzoLIQNSl2ThoPwhWS8ClEtc9p4JnevvGah5eI7cLQD/ip6SFT0qphEHWYcLOwmUtppR5iJ/eNLwtZ908SHcSZbcyGyr2YPD8HjUg==", "ARC-Authentication-Results": "i=1; mx.microsoft.com 1; spf=pass (sender ip is\n 216.228.117.161) smtp.rcpttodomain=dpdk.org smtp.mailfrom=nvidia.com;\n dmarc=pass (p=reject sp=reject pct=100) action=none header.from=nvidia.com;\n dkim=none (message not signed); arc=none", "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com;\n s=selector2;\n h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;\n bh=rGV/LEimjla1K0ZnIRY1yJ5U0T9chLatiNyHDiSQy/E=;\n b=bv9xOZxercO30WSIUtzzpIzIb+f/H33tQnsqMcFbZhHHB96OHfo7iLhP1MpKqOgUxhbKOD0un5kZpftvUFcwtjT9QYp045wjS8nnBu09RCPIGV7zfJ48AmfFC2N5jpM8a4Z26ErZ3It18s0x6CDrT/UNsKVesdZ68hH3V7yPgXRr1PNd9pkBRgxWZthvpBXv5DcULsJh4q/FzzwcOUa8bEs5aBfDNjU9cXjMMlAuQxup6nzgJypdri8i6lejtp8xAByUXI3YGSYkjseNbWwf1cm8dEXT95u3CJaB6AXn0Ie1nlxw1OoLcd4azJfDTqp9d6qiS7X6Bz2AYOAHHPNc7w==", "X-MS-Exchange-Authentication-Results": "spf=pass (sender IP is 216.228.117.161)\n smtp.mailfrom=nvidia.com;\n dkim=none (message not signed)\n header.d=none;dmarc=pass action=none header.from=nvidia.com;", "Received-SPF": "Pass (protection.outlook.com: domain of nvidia.com designates\n 216.228.117.161 as permitted sender) receiver=protection.outlook.com;\n client-ip=216.228.117.161; helo=mail.nvidia.com; pr=C", "From": "Haifei Luo <haifeil@nvidia.com>", "To": "<dev@dpdk.org>", "CC": "<orika@nvidia.com>, <viacheslavo@nvidia.com>, <rasland@nvidia.com>,\n <xuemingl@nvidia.com>, <haifeil@nvidia.com>, Dariusz Sosnowski\n <dsosnowski@nvidia.com>, Matan Azrad <matan@nvidia.com>, Suanming Mou\n <suanmingm@nvidia.com>", "Subject": "[PATCH v2 5/5] net/mlx5: add support for item NSH", "Date": "Mon, 25 Sep 2023 05:09:20 +0300", "Message-ID": "<20230925020921.4607-6-haifeil@nvidia.com>", "X-Mailer": "git-send-email 2.27.0", "In-Reply-To": "<20230925020921.4607-1-haifeil@nvidia.com>", "References": "<20230809074046.121807-1-haifeil@nvidia.com>\n <20230925020921.4607-1-haifeil@nvidia.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.126.231.35]", "X-ClientProxiedBy": "rnnvmail203.nvidia.com (10.129.68.9) To\n rnnvmail202.nvidia.com (10.129.68.7)", "X-EOPAttributedMessage": "0", "X-MS-PublicTrafficType": "Email", "X-MS-TrafficTypeDiagnostic": "MWH0EPF000971E4:EE_|MW4PR12MB7032:EE_", "X-MS-Office365-Filtering-Correlation-Id": "7e0ed0a9-d5c0-49fe-ede1-08dbbd6c8ae1", "X-MS-Exchange-SenderADCheck": "1", "X-MS-Exchange-AntiSpam-Relay": "0", "X-Microsoft-Antispam": "BCL:0;", "X-Microsoft-Antispam-Message-Info": "\n aewivAFfN+5hxXtAxpJzrkX1OAj2vxnhHpNwf5VrS+Zo03V6+FetkHzXx2lmjtFv/S7eSxh9XSTEmTcygwqVHJU52k+8Myot/3ntV0h4gqbEjndCYls8Gw16VGq0jkcqKY8zHO0NLL3BDzb40IpUQyuLl/Cf7TVdXDzIeBjNjvyyYlBrJSbX9n4MfN8cXhozwJIxTRPkZEqeBMNxxoo2+GTzGlitKmBA7ytY7/EcVLlERNVTyz4c4sniIPQB1YjuWYZNMRtYCxS6dYAS/R6xFGYTJGcCiaMacXfqsZwilj1ReQbRP/Vj9TEzie+boaI5G7Tv68ePCXXGAHN10VmFTFbAD+7IvOTd3u7iJ8yRNJlvKqvz3QiTEr/OUMhbL6SBUC6qj1xqrB1mtGWfC8hQ5BIVYd/0Am+xpJyE9X/DY+AITJzS1m24f3k6EIVLdI9qgaw8w5wDEmqLkO3cpwxkxzilOJ3xci9WIpPi9guyivo6aOBiFHUTRSngl8wjWJ54hPH2kqLogVY0+vMleNWcYBppkRB3lf9FbClMeWE+7u9hTOc+UEQSScPCNTWVNHlDGfTVk0bseKZb6ipzROy6W2VPuPruqz7uPg8b0rgBmSJd3dzwMbWufVfj5dlSOSltrjYwvzF8Y+SrhcM31qqpjNR1QKLmKHrsK7iMh5ctM1w2zKZmxL4MwTxBxQUlDWwAept/MXb3AVDkVS1WmPADCrK9aZI+gEszJpBghw4KSCQDAhEoacOj99443DRE2+PR", "X-Forefront-Antispam-Report": "CIP:216.228.117.161; CTRY:US; LANG:en; SCL:1;\n SRV:;\n IPV:NLI; SFV:NSPM; H:mail.nvidia.com; PTR:dc6edge2.nvidia.com; CAT:NONE;\n SFS:(13230031)(4636009)(396003)(136003)(39860400002)(376002)(346002)(230922051799003)(82310400011)(1800799009)(451199024)(186009)(36840700001)(46966006)(40470700004)(7696005)(6666004)(47076005)(356005)(82740400003)(40480700001)(36756003)(40460700003)(7636003)(55016003)(86362001)(36860700001)(16526019)(6286002)(5660300002)(2616005)(478600001)(426003)(4326008)(107886003)(70206006)(83380400001)(8676002)(41300700001)(8936002)(26005)(316002)(54906003)(2906002)(1076003)(70586007)(6916009)(336012);\n DIR:OUT; SFP:1101;", "X-OriginatorOrg": "Nvidia.com", "X-MS-Exchange-CrossTenant-OriginalArrivalTime": "25 Sep 2023 02:10:08.5830 (UTC)", "X-MS-Exchange-CrossTenant-Network-Message-Id": "\n 7e0ed0a9-d5c0-49fe-ede1-08dbbd6c8ae1", "X-MS-Exchange-CrossTenant-Id": "43083d15-7273-40c1-b7db-39efd9ccc17a", "X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp": "\n TenantId=43083d15-7273-40c1-b7db-39efd9ccc17a; Ip=[216.228.117.161];\n Helo=[mail.nvidia.com]", "X-MS-Exchange-CrossTenant-AuthSource": "\n MWH0EPF000971E4.namprd02.prod.outlook.com", "X-MS-Exchange-CrossTenant-AuthAs": "Anonymous", "X-MS-Exchange-CrossTenant-FromEntityHeader": "HybridOnPrem", "X-MS-Exchange-Transport-CrossTenantHeadersStamped": "MW4PR12MB7032", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "1. Add validation for item NSH.\n It will fail if HCA cap for NSH is false.\n2. Add item_flags for NSH.\n3. For vxlan-gpe if next header is NSH, set next_protocol as NSH.\n\nSigned-off-by: Haifei Luo <haifeil@nvidia.com>\nAcked-by: Dariusz Sosnowski <dsosnowski@nvidia.com>\n---\n drivers/net/mlx5/mlx5_flow.c | 39 +++++++++++++++++++++++++++++++++\n drivers/net/mlx5/mlx5_flow.h | 6 +++++\n drivers/net/mlx5/mlx5_flow_dv.c | 13 ++++++++++-\n 3 files changed, 57 insertions(+), 1 deletion(-)", "diff": "diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c\nindex 202e878ddf..8ad85e6027 100644\n--- a/drivers/net/mlx5/mlx5_flow.c\n+++ b/drivers/net/mlx5/mlx5_flow.c\n@@ -3905,6 +3905,45 @@ mlx5_flow_validate_item_ecpri(const struct rte_flow_item *item,\n \t\t\t\t\t MLX5_ITEM_RANGE_NOT_ACCEPTED, error);\n }\n \n+/**\n+ * Validate the NSH item.\n+ *\n+ * @param[in] dev\n+ * Pointer to Ethernet device on which flow rule is being created on.\n+ * @param[out] error\n+ * Pointer to error structure.\n+ *\n+ * @return\n+ * 0 on success, a negative errno value otherwise and rte_errno is set.\n+ */\n+int\n+mlx5_flow_validate_item_nsh(struct rte_eth_dev *dev,\n+\t\t\t const struct rte_flow_item *item,\n+\t\t\t struct rte_flow_error *error)\n+{\n+\tstruct mlx5_priv *priv = dev->data->dev_private;\n+\n+\tif (item->mask) {\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t \"NSH fields matching is not supported\");\n+\t}\n+\n+\tif (!priv->sh->config.dv_flow_en) {\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_UNSPECIFIED,\n+\t\t\t\t\t NULL, \"NSH support requires DV flow interface\");\n+\t}\n+\n+\tif (!priv->sh->cdev->config.hca_attr.tunnel_stateless_vxlan_gpe_nsh) {\n+\t\treturn rte_flow_error_set(error, ENOTSUP,\n+\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM, item,\n+\t\t\t\t\t \"Current FW does not support matching on NSH\");\n+\t}\n+\n+\treturn 0;\n+}\n+\n static int\n flow_null_validate(struct rte_eth_dev *dev __rte_unused,\n \t\t const struct rte_flow_attr *attr __rte_unused,\ndiff --git a/drivers/net/mlx5/mlx5_flow.h b/drivers/net/mlx5/mlx5_flow.h\nindex 3a97975d69..ccb416e497 100644\n--- a/drivers/net/mlx5/mlx5_flow.h\n+++ b/drivers/net/mlx5/mlx5_flow.h\n@@ -233,6 +233,9 @@ enum mlx5_feature_name {\n /* IB BTH ITEM. */\n #define MLX5_FLOW_ITEM_IB_BTH (1ull << 51)\n \n+/* NSH ITEM */\n+#define MLX5_FLOW_ITEM_NSH (1ull << 53)\n+\n /* Outer Masks. */\n #define MLX5_FLOW_LAYER_OUTER_L3 \\\n \t(MLX5_FLOW_LAYER_OUTER_L3_IPV4 | MLX5_FLOW_LAYER_OUTER_L3_IPV6)\n@@ -2453,6 +2456,9 @@ int mlx5_flow_validate_item_ecpri(const struct rte_flow_item *item,\n \t\t\t\t uint16_t ether_type,\n \t\t\t\t const struct rte_flow_item_ecpri *acc_mask,\n \t\t\t\t struct rte_flow_error *error);\n+int mlx5_flow_validate_item_nsh(struct rte_eth_dev *dev,\n+\t\t\t\tconst struct rte_flow_item *item,\n+\t\t\t\tstruct rte_flow_error *error);\n int mlx5_flow_create_mtr_tbls(struct rte_eth_dev *dev,\n \t\t\t struct mlx5_flow_meter_info *fm,\n \t\t\t uint32_t mtr_idx,\ndiff --git a/drivers/net/mlx5/mlx5_flow_dv.c b/drivers/net/mlx5/mlx5_flow_dv.c\nindex 3f4325c5c8..5cd04b1d93 100644\n--- a/drivers/net/mlx5/mlx5_flow_dv.c\n+++ b/drivers/net/mlx5/mlx5_flow_dv.c\n@@ -7815,6 +7815,12 @@ flow_dv_validate(struct rte_eth_dev *dev, const struct rte_flow_attr *attr,\n \n \t\t\tlast_item = MLX5_FLOW_ITEM_IB_BTH;\n \t\t\tbreak;\n+\t\tcase RTE_FLOW_ITEM_TYPE_NSH:\n+\t\t\tret = mlx5_flow_validate_item_nsh(dev, items, error);\n+\t\t\tif (ret < 0)\n+\t\t\t\treturn ret;\n+\t\t\tlast_item = MLX5_FLOW_ITEM_NSH;\n+\t\t\tbreak;\n \t\tdefault:\n \t\t\treturn rte_flow_error_set(error, ENOTSUP,\n \t\t\t\t\t\t RTE_FLOW_ERROR_TYPE_ITEM,\n@@ -9720,7 +9726,9 @@ flow_dv_translate_item_vxlan_gpe(void *key, const struct rte_flow_item *item,\n \tv_protocol = vxlan_v->hdr.protocol;\n \tif (!m_protocol) {\n \t\t/* Force next protocol to ensure next headers parsing. */\n-\t\tif (pattern_flags & MLX5_FLOW_LAYER_INNER_L2)\n+\t\tif (pattern_flags & MLX5_FLOW_ITEM_NSH)\n+\t\t\tv_protocol = RTE_VXLAN_GPE_TYPE_NSH;\n+\t\telse if (pattern_flags & MLX5_FLOW_LAYER_INNER_L2)\n \t\t\tv_protocol = RTE_VXLAN_GPE_TYPE_ETH;\n \t\telse if (pattern_flags & MLX5_FLOW_LAYER_INNER_L3_IPV4)\n \t\t\tv_protocol = RTE_VXLAN_GPE_TYPE_IPV4;\n@@ -13910,6 +13918,9 @@ flow_dv_translate_items(struct rte_eth_dev *dev,\n \t\tflow_dv_translate_item_ib_bth(key, items, tunnel, key_type);\n \t\tlast_item = MLX5_FLOW_ITEM_IB_BTH;\n \t\tbreak;\n+\tcase RTE_FLOW_ITEM_TYPE_NSH:\n+\t\tlast_item = MLX5_FLOW_ITEM_NSH;\n+\t\tbreak;\n \tdefault:\n \t\tbreak;\n \t}\n", "prefixes": [ "v2", "5/5" ] }