Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131828/?format=api
{ "id": 131828, "url": "https://patches.dpdk.org/api/patches/131828/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230922093103.58541-1-shibin.koikkara.reeny@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230922093103.58541-1-shibin.koikkara.reeny@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230922093103.58541-1-shibin.koikkara.reeny@intel.com", "date": "2023-09-22T09:31:03", "name": "[v2] net/af_xdp: fix cflags to appropriate UMEM feature", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "48f362986d103eee9dcaf319940ad60abfc62172", "submitter": { "id": 2540, "url": "https://patches.dpdk.org/api/people/2540/?format=api", "name": "Koikkara Reeny, Shibin", "email": "shibin.koikkara.reeny@intel.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230922093103.58541-1-shibin.koikkara.reeny@intel.com/mbox/", "series": [ { "id": 29604, "url": "https://patches.dpdk.org/api/series/29604/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29604", "date": "2023-09-22T09:31:03", "name": "[v2] net/af_xdp: fix cflags to appropriate UMEM feature", "version": 2, "mbox": "https://patches.dpdk.org/series/29604/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131828/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/131828/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E6C0342616;\n\tFri, 22 Sep 2023 11:31:38 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 95D5F4029C;\n\tFri, 22 Sep 2023 11:31:38 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [134.134.136.65])\n by mails.dpdk.org (Postfix) with ESMTP id AEF3E40150;\n Fri, 22 Sep 2023 11:31:36 +0200 (CEST)", "from fmsmga001.fm.intel.com ([10.253.24.23])\n by orsmga103.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Sep 2023 02:31:16 -0700", "from silpixa00401350.ir.intel.com ([10.55.128.174])\n by fmsmga001.fm.intel.com with ESMTP; 22 Sep 2023 02:30:20 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695375097; x=1726911097;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=ZQZcDc44nldJqhTaEb7BU/BGvrKOO/pegA0176ZIpSg=;\n b=TMVSYD5AeOGXEHK+G2lC76K8fUbqEoILTVsCa0aGWv/BR8J5/FanOSUK\n IHcc/QFw7ooBaHtpN2NP38NKe0sQSI/2ICiMBH0uvEEk9wt4ezTMVHuyn\n ZGaoXijWUwqK0qaAPw12h2mA3VZ5UIztYlJdRje/TJN93lkYZUIC93NZm\n k29xDgeYY5i/4SmrCa+zBl9mpC9fg2tMLcJHNZt4c2rHpDWfwQGW3zq3s\n mVTWvqdRoNQCpsaYePVAWtMzaZkL+wDw1n3ws6miluQ8Oo7f+SsNXoXaN\n WTxzQRr6FCvB2ajhYXxqDe+sp7c5c4td2UZ01NToKmGELFzIyHOQwH45a A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10840\"; a=\"384622095\"", "E=Sophos;i=\"6.03,167,1694761200\"; d=\"scan'208\";a=\"384622095\"", "E=McAfee;i=\"6600,9927,10840\"; a=\"890755959\"", "E=Sophos;i=\"6.03,167,1694761200\"; d=\"scan'208\";a=\"890755959\"" ], "X-ExtLoop1": "1", "From": "Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>", "To": "dev@dpdk.org,\n\tciara.loftus@intel.com,\n\tbruce.richardson@intel.com", "Cc": "qi.z.zhang@intel.com, john.mcnamara@intel.com, stable@dpdk.org,\n Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>", "Subject": "[PATCH v2] net/af_xdp: fix cflags to appropriate UMEM feature", "Date": "Fri, 22 Sep 2023 09:31:03 +0000", "Message-Id": "<20230922093103.58541-1-shibin.koikkara.reeny@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230921102923.65738-1-shibin.koikkara.reeny@intel.com>", "References": "<20230921102923.65738-1-shibin.koikkara.reeny@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Fix missing RTE_NET_AF_XDP_SHARED_UMEM flag in\nxsk_socket__create_shared().\n\nrte_pmd_af_xdp_probe(): Initializing pmd_af_xdp for net_af_xdp0\ninit_internals(): Shared UMEM feature not available. Check kernel and\nlibbpf version\nrte_pmd_af_xdp_probe(): Failed to init internals\nvdev_probe(): failed to initialize net_af_xdp0 device\nEAL: Bus (vdev) probe failed.\n\nFixes: e024c7e838fc (\"net/af_xdp: avoid version-based check for shared UMEM\")\nFixes: 33d66940e9ba (\"build: use C11 standard\")\n\nFix is for the commit e024c7e838fc (\"net/af_xdp: avoid\nversion-based check for shared UMEM\") fixline would imply\na possible backport though, but no issue has been seen on\nversion of DPDK not using C11, so I will be skipping\nbackporting this for now.\nCommit 33d66940e9ba (\"build: use C11 standard\") enforces\nthe C11 standard so some changes need to be made to the\naf_xdp driver meson build to ensure that the appropriate\ncflags are passed when checking if certain functions are\navailable in the libbpf/libxdp libraries.\n\nSigned-off-by: Shibin Koikkara Reeny <shibin.koikkara.reeny@intel.com>\n---\n drivers/net/af_xdp/meson.build | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)", "diff": "diff --git a/drivers/net/af_xdp/meson.build b/drivers/net/af_xdp/meson.build\nindex 9a8dbb4d49..3319acca65 100644\n--- a/drivers/net/af_xdp/meson.build\n+++ b/drivers/net/af_xdp/meson.build\n@@ -56,17 +56,17 @@ if build\n '''\n \n if cc.has_function('xsk_socket__create_shared', prefix : xsk_check_prefix,\n- dependencies : ext_deps)\n+ dependencies : ext_deps, args: cflags)\n cflags += ['-DRTE_NET_AF_XDP_SHARED_UMEM']\n endif\n if cc.has_function('bpf_object__next_program',\n prefix : '#include <bpf/libbpf.h>',\n- dependencies : bpf_dep)\n+ dependencies : bpf_dep, args: cflags)\n cflags += ['-DRTE_NET_AF_XDP_LIBBPF_OBJ_OPEN']\n endif\n if cc.has_function('bpf_xdp_attach',\n prefix : '#include <bpf/libbpf.h>',\n- dependencies : bpf_dep)\n+ dependencies : bpf_dep, args: cflags)\n cflags += ['-DRTE_NET_AF_XDP_LIBBPF_XDP_ATTACH']\n endif\n endif\n", "prefixes": [ "v2" ] }