Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131824/?format=api
{ "id": 131824, "url": "https://patches.dpdk.org/api/patches/131824/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230922081912.7090-4-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230922081912.7090-4-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230922081912.7090-4-bruce.richardson@intel.com", "date": "2023-09-22T08:19:10", "name": "[RFC,3/5] net: new ethdev driver to communicate using shared mem", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "defa0b4d1e447b3f1a1923f77627a20a6b231505", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230922081912.7090-4-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29602, "url": "https://patches.dpdk.org/api/series/29602/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29602", "date": "2023-09-22T08:19:07", "name": "Using shared mempools for zero-copy IO proxying", "version": 1, "mbox": "https://patches.dpdk.org/series/29602/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131824/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131824/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9D4A642612;\n\tFri, 22 Sep 2023 10:20:03 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id F1EB240685;\n\tFri, 22 Sep 2023 10:19:46 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 2EE284013F\n for <dev@dpdk.org>; Fri, 22 Sep 2023 10:19:43 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 22 Sep 2023 01:19:32 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.14])\n by fmsmga005.fm.intel.com with ESMTP; 22 Sep 2023 01:19:31 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695370783; x=1726906783;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=odySRWZfzNgCUmG6AtpMAowK+87wFBYrZBOhfZDuvd0=;\n b=IED65ZMux8xIKe5bGTaGKR3KavoOgPmMoZmq/MZV+VVSvd+txaaR2nZ2\n GxRRpB23WJ8U1qgJcjYLQsB2n5zizC+A3fr/2muAMxtesnZdpzfKl/akJ\n JlkL4qjRdxW2DBS3tEOg7nzn+GzKT+pnasmabJSOrIJdT9Rr2RYXar4nz\n BOsLyQSwB+IcSx7dqqWLxk7sgnI2PFKpesc+iRQHcUepfQ3tovG72BdV+\n C4AbUaRSRCIC1CiUKuZqxAfIVUKzVFq76IaM6DwM1zFyRxA37saF1eVM3\n liRsoQv/uA+KNUHhu3czY3Bd4LzkhTM+RxHSUhDF09u/OINfSzHC/Mecw w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10840\"; a=\"378063973\"", "E=Sophos;i=\"6.03,167,1694761200\"; d=\"scan'208\";a=\"378063973\"", "E=McAfee;i=\"6600,9927,10840\"; a=\"1078281138\"", "E=Sophos;i=\"6.03,167,1694761200\"; d=\"scan'208\";a=\"1078281138\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[RFC PATCH 3/5] net: new ethdev driver to communicate using shared\n mem", "Date": "Fri, 22 Sep 2023 09:19:10 +0100", "Message-Id": "<20230922081912.7090-4-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230922081912.7090-1-bruce.richardson@intel.com>", "References": "<20230922081912.7090-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "This ethdev builds on the previous shared_mem bus driver and shared_mem\nmempool driver to provide an ethdev interface which can allow zero-copy\nI/O from one process to another.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n drivers/net/meson.build | 1 +\n drivers/net/shared_mem/meson.build | 11 +\n drivers/net/shared_mem/shared_mem_eth.c | 295 ++++++++++++++++++++++++\n 3 files changed, 307 insertions(+)\n create mode 100644 drivers/net/shared_mem/meson.build\n create mode 100644 drivers/net/shared_mem/shared_mem_eth.c", "diff": "diff --git a/drivers/net/meson.build b/drivers/net/meson.build\nindex bd38b533c5..505d208497 100644\n--- a/drivers/net/meson.build\n+++ b/drivers/net/meson.build\n@@ -53,6 +53,7 @@ drivers = [\n 'qede',\n 'ring',\n 'sfc',\n+ 'shared_mem',\n 'softnic',\n 'tap',\n 'thunderx',\ndiff --git a/drivers/net/shared_mem/meson.build b/drivers/net/shared_mem/meson.build\nnew file mode 100644\nindex 0000000000..17d1b84454\n--- /dev/null\n+++ b/drivers/net/shared_mem/meson.build\n@@ -0,0 +1,11 @@\n+# SPDX-License-Identifier: BSD-3-Clause\n+# Copyright(c) 2023 Intel Corporation\n+\n+if is_windows\n+ build = false\n+ reason = 'not supported on Windows'\n+endif\n+\n+sources = files('shared_mem_eth.c')\n+deps += 'bus_shared_mem'\n+require_iova_in_mbuf = false\ndiff --git a/drivers/net/shared_mem/shared_mem_eth.c b/drivers/net/shared_mem/shared_mem_eth.c\nnew file mode 100644\nindex 0000000000..564bfdb907\n--- /dev/null\n+++ b/drivers/net/shared_mem/shared_mem_eth.c\n@@ -0,0 +1,295 @@\n+/* SPDX-License-Identifier: BSD-3-Clause\n+ * Copyright(c) 2023 Intel Corporation\n+ */\n+#include <rte_common.h>\n+#include <shared_mem_bus.h>\n+#include <ethdev_driver.h>\n+\n+RTE_LOG_REGISTER_DEFAULT(shared_mem_eth_logtype, DEBUG);\n+#define SHM_ETH_LOG(level, fmt, args...) rte_log(RTE_LOG_ ## level, \\\n+\t\tshared_mem_eth_logtype, \"## SHARED MEM ETH: %s(): \" fmt \"\\n\", __func__, ##args)\n+#define SHM_ETH_ERR(fmt, args...) SHM_ETH_LOG(ERR, fmt, ## args)\n+#define SHM_ETH_INFO(fmt, args...) SHM_ETH_LOG(INFO, fmt, ## args)\n+#define SHM_ETH_DEBUG(fmt, args...) SHM_ETH_LOG(DEBUG, fmt, ## args)\n+\n+struct shm_eth_stats {\n+\tuint64_t rx_pkts;\n+\tuint64_t tx_pkts;\n+\tuint64_t rx_bytes;\n+\tuint64_t tx_bytes;\n+};\n+\n+struct shm_eth_private {\n+\tstruct rte_ether_addr addr;\n+\tstruct rte_ring *rx;\n+\tstruct rte_ring *tx;\n+\tstruct shm_eth_stats stats;\n+};\n+\n+static struct rte_mempool *rx_mp; /* TODO: use one per queue */\n+\n+static int\n+shm_eth_configure(struct rte_eth_dev *dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_start(struct rte_eth_dev *dev)\n+{\n+\tstruct shm_eth_private *priv = dev->data->dev_private;\n+\n+\tstruct eth_shared_mem_msg msg = (struct eth_shared_mem_msg){\n+\t\t.type = MSG_TYPE_START,\n+\t};\n+\trte_shm_bus_send_message(&msg, sizeof(msg));\n+\n+\trte_shm_bus_recv_message(&msg, sizeof(msg));\n+\tif (msg.type != MSG_TYPE_ACK) {\n+\t\tSHM_ETH_ERR(\"Didn't get ack from host\\n\");\n+\t\treturn -1;\n+\t}\n+\n+\tmemset(&priv->stats, 0, sizeof(priv->stats));\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_stop(struct rte_eth_dev *dev __rte_unused)\n+{\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_infos_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *info)\n+{\n+\t*info = (struct rte_eth_dev_info){\n+\t\t.driver_name = dev->device->driver->name,\n+\t\t.max_rx_queues = 1,\n+\t\t.max_tx_queues = 1,\n+\t\t.max_mac_addrs = 1,\n+\t\t.min_mtu = 64,\n+\t\t.max_mtu = UINT16_MAX,\n+\t\t.max_rx_pktlen = UINT16_MAX,\n+\t\t.nb_rx_queues = 1,\n+\t\t.nb_tx_queues = 1,\n+\t\t.tx_desc_lim = { .nb_max = 8192, .nb_min = 128, .nb_align = 64 },\n+\t\t.rx_desc_lim = { .nb_max = 8192, .nb_min = 128, .nb_align = 64 },\n+\t};\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_mtu_set(struct rte_eth_dev *dev, uint16_t mtu)\n+{\n+\tdev->data->mtu = mtu;\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_link_update(struct rte_eth_dev *dev, int wait __rte_unused)\n+{\n+\tdev->data->dev_link = (struct rte_eth_link){\n+\t\t.link_speed = RTE_ETH_SPEED_NUM_100G,\n+\t\t.link_duplex = 1,\n+\t\t.link_autoneg = 1,\n+\t\t.link_status = 1,\n+\t};\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_rx_queue_setup(struct rte_eth_dev *dev, uint16_t rx_queue_id,\n+\t\t uint16_t nb_rx_desc,\n+\t\t unsigned int socket_id,\n+\t\t const struct rte_eth_rxconf *rx_conf,\n+\t\t struct rte_mempool *mb_pool)\n+{\n+\tRTE_SET_USED(rx_conf);\n+\n+\tstruct shm_eth_private *priv = dev->data->dev_private;\n+\tchar ring_name[32];\n+\n+\tif (rte_shm_bus_get_mem_offset(mb_pool) == (uintptr_t)-1) {\n+\t\tSHM_ETH_ERR(\"Mempool not in shared memory\");\n+\t\treturn -1;\n+\t}\n+\tsnprintf(ring_name, sizeof(ring_name), \"shm_eth_rxr%u\", rx_queue_id);\n+\tpriv->rx = rte_ring_create(ring_name, nb_rx_desc, socket_id, RING_F_SP_ENQ | RING_F_SC_DEQ);\n+\tif (priv->rx == NULL)\n+\t\treturn -1;\n+\tSHM_ETH_INFO(\"RX ring @ %p\\n\", priv->rx);\n+\tif (rte_shm_bus_get_mem_offset(priv->rx) == (uintptr_t)-1) {\n+\t\tSHM_ETH_ERR(\"Ring not created on shared memory.\");\n+\t\treturn -1;\n+\t}\n+\tdev->data->rx_queues[rx_queue_id] = priv;\n+\n+\tSHM_ETH_INFO(\"Mempool offset is: %p\", (void *)rte_shm_bus_get_mem_offset(mb_pool));\n+\tSHM_ETH_INFO(\"Rx queue offset is: %p\", (void *)rte_shm_bus_get_mem_offset(priv->rx));\n+\n+\tstruct eth_shared_mem_msg msg = (struct eth_shared_mem_msg){\n+\t\t.type = MSG_TYPE_MEMPOOL_OFFSET,\n+\t\t.offset = rte_shm_bus_get_mem_offset(mb_pool),\n+\t};\n+\trte_shm_bus_send_message(&msg, sizeof(msg));\n+\tmsg = (struct eth_shared_mem_msg){\n+\t\t.type = MSG_TYPE_RX_RING_OFFSET,\n+\t\t.offset = rte_shm_bus_get_mem_offset(priv->rx),\n+\t};\n+\trte_shm_bus_send_message(&msg, sizeof(msg));\n+\trx_mp = mb_pool;\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_tx_queue_setup(struct rte_eth_dev *dev, uint16_t tx_queue_id,\n+\t\t uint16_t nb_tx_desc,\n+\t\t unsigned int socket_id,\n+\t\t const struct rte_eth_txconf *tx_conf)\n+{\n+\tRTE_SET_USED(tx_conf);\n+\n+\tstruct shm_eth_private *priv = dev->data->dev_private;\n+\tchar ring_name[32];\n+\n+\tsnprintf(ring_name, sizeof(ring_name), \"shm_eth_txr%u\", tx_queue_id);\n+\tpriv->tx = rte_ring_create(ring_name, nb_tx_desc, socket_id, RING_F_SP_ENQ | RING_F_SC_DEQ);\n+\tif (priv->tx == NULL)\n+\t\treturn -1;\n+\tSHM_ETH_DEBUG(\"TX ring @ %p\\n\", priv->tx);\n+\tif (rte_shm_bus_get_mem_offset(priv->tx) == (uintptr_t)-1) {\n+\t\tSHM_ETH_ERR(\"TX ring not on shared memory\");\n+\t\treturn -1;\n+\t}\n+\tdev->data->tx_queues[tx_queue_id] = priv;\n+\n+\tstruct eth_shared_mem_msg msg = (struct eth_shared_mem_msg){\n+\t\t.type = MSG_TYPE_TX_RING_OFFSET,\n+\t\t.offset = rte_shm_bus_get_mem_offset(priv->tx),\n+\t};\n+\trte_shm_bus_send_message(&msg, sizeof(msg));\n+\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_stats_get(struct rte_eth_dev *dev, struct rte_eth_stats *stats)\n+{\n+\tstruct shm_eth_private *priv = dev->data->dev_private;\n+\tstats->ibytes = priv->stats.rx_bytes;\n+\tstats->ipackets = priv->stats.rx_pkts;\n+\tstats->obytes = priv->stats.tx_bytes;\n+\tstats->opackets = priv->stats.tx_pkts;\n+\treturn 0;\n+}\n+\n+static const struct eth_dev_ops ops = {\n+\t\t.dev_configure = shm_eth_configure,\n+\t\t.dev_start = shm_eth_start,\n+\t\t.dev_stop = shm_eth_stop,\n+\t\t.dev_infos_get = shm_eth_infos_get,\n+\t\t.mtu_set = shm_eth_mtu_set,\n+\t\t.rx_queue_setup = shm_eth_rx_queue_setup,\n+\t\t.tx_queue_setup = shm_eth_tx_queue_setup,\n+\t\t.link_update = shm_eth_link_update,\n+\t\t.stats_get = shm_eth_stats_get,\n+};\n+\n+static uint16_t\n+shm_eth_rx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_bufs)\n+{\n+\tvoid *deq_vals[nb_bufs];\n+\tstruct shm_eth_private *priv = queue;\n+\tstruct rte_ring *rxr = priv->rx;\n+\tuintptr_t offset = (uintptr_t)rte_shm_bus_get_mem_ptr(0);\n+\n+\tint nb_rx = rte_ring_dequeue_burst(rxr, deq_vals, nb_bufs, NULL);\n+\tif (nb_rx == 0)\n+\t\treturn 0;\n+\n+\tuint64_t bytes = 0;\n+\tfor (int i = 0; i < nb_rx; i++) {\n+\t\tbufs[i] = RTE_PTR_ADD(deq_vals[i], offset);\n+\t\tbufs[i]->pool = rx_mp;\n+\t\tbufs[i]->buf_addr = RTE_PTR_ADD(bufs[i]->buf_addr, offset);\n+\t\tbytes += bufs[i]->pkt_len;\n+\t}\n+\tpriv->stats.rx_pkts += nb_rx;\n+\tpriv->stats.rx_bytes += bytes;\n+\treturn nb_rx;\n+}\n+\n+static uint16_t\n+shm_eth_tx_burst(void *queue, struct rte_mbuf **bufs, uint16_t nb_bufs)\n+{\n+\tvoid *enq_vals[nb_bufs];\n+\tstruct shm_eth_private *priv = queue;\n+\tstruct rte_ring *txr = priv->tx;\n+\tuintptr_t offset = (uintptr_t)rte_shm_bus_get_mem_ptr(0);\n+\tuint64_t bytes = 0;\n+\n+\tfor (int i = 0; i < nb_bufs; i++) {\n+\t\tbufs[i]->buf_addr = RTE_PTR_SUB(bufs[i]->buf_addr, offset);\n+\t\tbytes += bufs[i]->pkt_len;\n+\t\trte_cldemote(bufs[i]);\n+\t\tenq_vals[i] = RTE_PTR_SUB(bufs[i], offset);\n+\t}\n+\tuint16_t nb_enq = rte_ring_enqueue_burst(txr, enq_vals, nb_bufs, NULL);\n+\tif (nb_enq != nb_bufs) {\n+\t\t/* restore original buffer settings */\n+\t\tfor (int i = nb_enq; i < nb_bufs; i++) {\n+\t\t\tbufs[i]->buf_addr = RTE_PTR_ADD(bufs[i]->buf_addr, offset);\n+\t\t\tbytes -= bufs[i]->pkt_len;\n+\t\t}\n+\t}\n+\tpriv->stats.tx_pkts += nb_enq;\n+\tpriv->stats.tx_bytes += bytes;\n+\treturn nb_enq;\n+}\n+\n+static int\n+ethdev_init(struct rte_eth_dev *ethdev, void *init_params __rte_unused)\n+{\n+\tstruct shm_eth_private *priv = ethdev->data->dev_private;\n+\tethdev->dev_ops = &ops;\n+\tethdev->data->mac_addrs = &priv->addr;\n+\tethdev->rx_pkt_burst = shm_eth_rx_burst;\n+\tethdev->tx_pkt_burst = shm_eth_tx_burst;\n+\n+\tstruct eth_shared_mem_msg msg = (struct eth_shared_mem_msg){\n+\t\t.type = MSG_TYPE_GET_MAC,\n+\t};\n+\trte_shm_bus_send_message(&msg, sizeof(msg));\n+\n+\trte_shm_bus_recv_message(&msg, sizeof(msg));\n+\tif (msg.type != MSG_TYPE_REPORT_MAC) {\n+\t\tSHM_ETH_ERR(\"Didn't get mac address from host\\n\");\n+\t\treturn -1;\n+\t}\n+\trte_ether_addr_copy(&msg.ethaddr, &priv->addr);\n+\n+\treturn 0;\n+}\n+\n+static int\n+shm_eth_probe(struct shared_mem_drv *drv, struct rte_device *dev)\n+{\n+\tSHM_ETH_INFO(\"Probing device %p on driver %s\", dev, drv->driver.name);\n+\tint ret = rte_eth_dev_create(dev, \"shared_mem_ethdev\", sizeof(struct shm_eth_private),\n+\t\t\tNULL, NULL,\n+\t\t\tethdev_init, NULL);\n+\tif (ret != 0)\n+\t\tgoto out;\n+\n+\tSHM_ETH_DEBUG(\"Ethdev created ok\\n\");\n+out:\n+\treturn ret;\n+}\n+\n+struct shared_mem_drv shm_drv = {\n+\t\t.probe = shm_eth_probe,\n+};\n+\n+\n+RTE_PMD_REGISTER_SHMEM_DRV(shm_eth, shm_drv);\n", "prefixes": [ "RFC", "3/5" ] }