Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 131804,
    "url": "https://patches.dpdk.org/api/patches/131804/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230822011306.19616-1-yuying.zhang@intel.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230822011306.19616-1-yuying.zhang@intel.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230822011306.19616-1-yuying.zhang@intel.com",
    "date": "2023-08-22T01:13:06",
    "name": "[v1] app/testpmd: refine encap content",
    "commit_ref": null,
    "pull_url": null,
    "state": "changes-requested",
    "archived": true,
    "hash": "ed6751e8dd9af8bc010b3839bfae600fafd4f563",
    "submitter": {
        "id": 1844,
        "url": "https://patches.dpdk.org/api/people/1844/?format=api",
        "name": "Zhang, Yuying",
        "email": "yuying.zhang@intel.com"
    },
    "delegate": {
        "id": 319,
        "url": "https://patches.dpdk.org/api/users/319/?format=api",
        "username": "fyigit",
        "first_name": "Ferruh",
        "last_name": "Yigit",
        "email": "ferruh.yigit@amd.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230822011306.19616-1-yuying.zhang@intel.com/mbox/",
    "series": [
        {
            "id": 29592,
            "url": "https://patches.dpdk.org/api/series/29592/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29592",
            "date": "2023-08-22T01:13:06",
            "name": "[v1] app/testpmd: refine encap content",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/29592/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/131804/comments/",
    "check": "fail",
    "checks": "https://patches.dpdk.org/api/patches/131804/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9965D42608;\n\tThu, 21 Sep 2023 19:10:15 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8C5924013F;\n\tThu, 21 Sep 2023 19:10:13 +0200 (CEST)",
            "from mgamail.intel.com (mgamail.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id 7D262400D7;\n Thu, 21 Sep 2023 19:10:11 +0200 (CEST)",
            "from orsmga004.jf.intel.com ([10.7.209.38])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 21 Sep 2023 10:09:30 -0700",
            "from dpdk-pengyuan-mev.sh.intel.com ([10.67.119.128])\n by orsmga004.jf.intel.com with ESMTP; 21 Sep 2023 10:09:28 -0700"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1695316212; x=1726852212;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=e3ngruMce7NCIYAHMV0QUvzSjWwIdHuLBoU0IXgv+1A=;\n b=cynTs/UPccxvL6xDCSoBQU4M1q0YOJ3KJyMjhB1/h5yfRoYtCMgNT1Td\n Qne3LBr0GtHXqSzOgOTOZEUciVIFDDTSmreQfeNZaQgOH61UZs4d3/n+f\n Z/FIwwK7XzDN/WowwhWqTEfjLtRm+VMR7wRNvCm86TTLPc6gaehKIFTBH\n jDEohfe/f2THbEzQDkKZ3FnD900W9zTU9DXDYcN4SaLxUGBTs3267+ZPq\n OT+G4jqB6VLgS4ZNXmrhlLYMTk50+UggopUN72Fg0+QdVmvyG3ywhs7vQ\n Bye33EnIjkhS08+xGBIbI+EoHNYrsd9zy0cD1wR7LF5UOWXPZ5SDdKnDh w==;",
        "X-IronPort-AV": [
            "E=McAfee;i=\"6600,9927,10840\"; a=\"359975104\"",
            "E=Sophos;i=\"6.03,166,1694761200\"; d=\"scan'208\";a=\"359975104\"",
            "E=McAfee;i=\"6600,9927,10840\"; a=\"870902114\"",
            "E=Sophos;i=\"6.03,166,1694761200\"; d=\"scan'208\";a=\"870902114\""
        ],
        "X-ExtLoop1": "1",
        "From": "\"Zhang, Yuying\" <yuying.zhang@intel.com>",
        "To": "yuying.zhang@intel.com, dev@dpdk.org, orika@nvidia.com,\n aman.deep.singh@intel.com",
        "Cc": "stable@dpdk.org",
        "Subject": "[PATCH v1] app/testpmd: refine encap content",
        "Date": "Tue, 22 Aug 2023 01:13:06 +0000",
        "Message-Id": "<20230822011306.19616-1-yuying.zhang@intel.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "From: Yuying Zhang <yuying.zhang@intel.com>\n\nRefine vxlan encap content of all protocol headers.\n\nFixes: 1960be7d32f8 (\"app/testpmd: add VXLAN encap/decap\")\nCc: stable@dpdk.org\n\nSigned-off-by: Yuying Zhang <yuying.zhang@intel.com>\n---\n app/test-pmd/cmdline_flow.c | 12 ++++++++++--\n 1 file changed, 10 insertions(+), 2 deletions(-)",
    "diff": "diff --git a/app/test-pmd/cmdline_flow.c b/app/test-pmd/cmdline_flow.c\nindex 95c0a19beb..a488864e2b 100644\n--- a/app/test-pmd/cmdline_flow.c\n+++ b/app/test-pmd/cmdline_flow.c\n@@ -8523,7 +8523,7 @@ parse_setup_vxlan_encap_data(struct action_vxlan_encap_data *action_vxlan_encap_\n \t\t\t\t.type = RTE_FLOW_ITEM_TYPE_END,\n \t\t\t},\n \t\t},\n-\t\t.item_eth.hdr.ether_type = 0,\n+\t\t.item_eth.hdr.ether_type = rte_cpu_to_be_16(RTE_ETHER_TYPE_IPV4),\n \t\t.item_vlan = {\n \t\t\t.hdr.vlan_tci = vxlan_encap_conf.vlan_tci,\n \t\t\t.hdr.eth_proto = 0,\n@@ -8531,24 +8531,32 @@ parse_setup_vxlan_encap_data(struct action_vxlan_encap_data *action_vxlan_encap_\n \t\t.item_ipv4.hdr = {\n \t\t\t.src_addr = vxlan_encap_conf.ipv4_src,\n \t\t\t.dst_addr = vxlan_encap_conf.ipv4_dst,\n+\t\t\t.version_ihl = RTE_IPV4_VHL_DEF,\n+\t\t\t.next_proto_id = IPPROTO_UDP,\n+\t\t\t.time_to_live = IPDEFTTL,\n+\t\t\t.hdr_checksum = rte_cpu_to_be_16(1),\n \t\t},\n \t\t.item_udp.hdr = {\n \t\t\t.src_port = vxlan_encap_conf.udp_src,\n \t\t\t.dst_port = vxlan_encap_conf.udp_dst,\n+\t\t\t.dgram_cksum = RTE_BE16(0x01),\n \t\t},\n-\t\t.item_vxlan.hdr.flags = 0,\n+\t\t.item_vxlan.hdr.flags = 0x08,\n \t};\n \tmemcpy(action_vxlan_encap_data->item_eth.hdr.dst_addr.addr_bytes,\n \t       vxlan_encap_conf.eth_dst, RTE_ETHER_ADDR_LEN);\n \tmemcpy(action_vxlan_encap_data->item_eth.hdr.src_addr.addr_bytes,\n \t       vxlan_encap_conf.eth_src, RTE_ETHER_ADDR_LEN);\n \tif (!vxlan_encap_conf.select_ipv4) {\n+\t\taction_vxlan_encap_data->item_eth.type = RTE_BE16(RTE_ETHER_TYPE_IPV6);\n \t\tmemcpy(&action_vxlan_encap_data->item_ipv6.hdr.src_addr,\n \t\t       &vxlan_encap_conf.ipv6_src,\n \t\t       sizeof(vxlan_encap_conf.ipv6_src));\n \t\tmemcpy(&action_vxlan_encap_data->item_ipv6.hdr.dst_addr,\n \t\t       &vxlan_encap_conf.ipv6_dst,\n \t\t       sizeof(vxlan_encap_conf.ipv6_dst));\n+\t\taction_vxlan_encap_data->item_ipv6.hdr.proto = IPPROTO_UDP;\n+\t\taction_vxlan_encap_data->item_ipv6.hdr.hop_limits = IPDEFTTL;\n \t\taction_vxlan_encap_data->items[2] = (struct rte_flow_item){\n \t\t\t.type = RTE_FLOW_ITEM_TYPE_IPV6,\n \t\t\t.spec = &action_vxlan_encap_data->item_ipv6,\n",
    "prefixes": [
        "v1"
    ]
}