Patch Detail

HTTP 200 OK
Allow: GET, PUT, PATCH, HEAD, OPTIONS
Content-Type: application/json
Vary: Accept

{
    "id": 131785,
    "url": "https://patches.dpdk.org/api/patches/131785/?format=api",
    "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230921114820.2526810-7-ktejasree@marvell.com/",
    "project": {
        "id": 1,
        "url": "https://patches.dpdk.org/api/projects/1/?format=api",
        "name": "DPDK",
        "link_name": "dpdk",
        "list_id": "dev.dpdk.org",
        "list_email": "dev@dpdk.org",
        "web_url": "http://core.dpdk.org",
        "scm_url": "git://dpdk.org/dpdk",
        "webscm_url": "http://git.dpdk.org/dpdk",
        "list_archive_url": "https://inbox.dpdk.org/dev",
        "list_archive_url_format": "https://inbox.dpdk.org/dev/{}",
        "commit_url_format": ""
    },
    "msgid": "<20230921114820.2526810-7-ktejasree@marvell.com>",
    "list_archive_url": "https://inbox.dpdk.org/dev/20230921114820.2526810-7-ktejasree@marvell.com",
    "date": "2023-09-21T11:48:11",
    "name": "[06/15] crypto/cnxk: remove pdcp chain bit from capabilities",
    "commit_ref": null,
    "pull_url": null,
    "state": "superseded",
    "archived": true,
    "hash": "df1f7a88228d96ce5aee83a973954959a5f1c5e1",
    "submitter": {
        "id": 1789,
        "url": "https://patches.dpdk.org/api/people/1789/?format=api",
        "name": "Tejasree Kondoj",
        "email": "ktejasree@marvell.com"
    },
    "delegate": {
        "id": 6690,
        "url": "https://patches.dpdk.org/api/users/6690/?format=api",
        "username": "akhil",
        "first_name": "akhil",
        "last_name": "goyal",
        "email": "gakhil@marvell.com"
    },
    "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230921114820.2526810-7-ktejasree@marvell.com/mbox/",
    "series": [
        {
            "id": 29589,
            "url": "https://patches.dpdk.org/api/series/29589/?format=api",
            "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29589",
            "date": "2023-09-21T11:48:05",
            "name": "fixes and improvements to cnxk crypto PMD",
            "version": 1,
            "mbox": "https://patches.dpdk.org/series/29589/mbox/"
        }
    ],
    "comments": "https://patches.dpdk.org/api/patches/131785/comments/",
    "check": "success",
    "checks": "https://patches.dpdk.org/api/patches/131785/checks/",
    "tags": {},
    "related": [],
    "headers": {
        "Return-Path": "<dev-bounces@dpdk.org>",
        "X-Original-To": "patchwork@inbox.dpdk.org",
        "Delivered-To": "patchwork@inbox.dpdk.org",
        "Received": [
            "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 4796E425FF;\n\tThu, 21 Sep 2023 13:49:04 +0200 (CEST)",
            "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 992BD40EE5;\n\tThu, 21 Sep 2023 13:48:43 +0200 (CEST)",
            "from mx0b-0016f401.pphosted.com (mx0a-0016f401.pphosted.com\n [67.231.148.174])\n by mails.dpdk.org (Postfix) with ESMTP id 329B740EE1\n for <dev@dpdk.org>; Thu, 21 Sep 2023 13:48:42 +0200 (CEST)",
            "from pps.filterd (m0045849.ppops.net [127.0.0.1])\n by mx0a-0016f401.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id\n 38L7OFqR001335 for <dev@dpdk.org>; Thu, 21 Sep 2023 04:48:41 -0700",
            "from dc5-exch01.marvell.com ([199.233.59.181])\n by mx0a-0016f401.pphosted.com (PPS) with ESMTPS id 3t7u4ddv98-1\n (version=TLSv1.2 cipher=ECDHE-RSA-AES256-SHA384 bits=256 verify=NOT)\n for <dev@dpdk.org>; Thu, 21 Sep 2023 04:48:41 -0700",
            "from DC5-EXCH02.marvell.com (10.69.176.39) by DC5-EXCH01.marvell.com\n (10.69.176.38) with Microsoft SMTP Server (TLS) id 15.0.1497.48;\n Thu, 21 Sep 2023 04:48:39 -0700",
            "from maili.marvell.com (10.69.176.80) by DC5-EXCH02.marvell.com\n (10.69.176.39) with Microsoft SMTP Server id 15.0.1497.48 via Frontend\n Transport; Thu, 21 Sep 2023 04:48:39 -0700",
            "from hyd1554.marvell.com (unknown [10.29.57.11])\n by maili.marvell.com (Postfix) with ESMTP id 400605B693B;\n Thu, 21 Sep 2023 04:48:37 -0700 (PDT)"
        ],
        "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=marvell.com;\n h=from : to : cc :\n subject : date : message-id : in-reply-to : references : mime-version :\n content-transfer-encoding : content-type; s=pfpt0220;\n bh=KVjtbX26p4MQsixchNqsW5UT6umSdUIhWGj24cZ3ZFY=;\n b=VIcxHLut5AQm+QLq5aqEkeEusqbveGCuOwYRmgRkeyDIl21NCc/zNkBXHp3Bim0JMeRU\n 3fbUcaTenj54LgHoSwlnNFeabXKvu4pjSOVBAtjmhe6vb674T25FEsSIzs+VSiqlqbvA\n zxMUKZCsJGLCMxNnFDxLc4YdjqIRRVy/vTpfQXqw6/HML7kEZd7GkTM3GtlVsafI+/3l\n jTQbejS6oX1gLZK9uThblIXXyo//j4dH2uTlMzT2+G/GGJypR4/6yDHDY/f+lUq0pIaO\n XFdAgS6f1DFyshzasyjEd/gbSmXODj3T//Ln05SW4do7m4kBJibIEWH8LjJMJ/Wgl3HV sA==",
        "From": "Tejasree Kondoj <ktejasree@marvell.com>",
        "To": "Akhil Goyal <gakhil@marvell.com>",
        "CC": "Anoob Joseph <anoobj@marvell.com>, Aakash Sasidharan\n <asasidharan@marvell.com>, Gowrishankar Muthukrishnan\n <gmuthukrishn@marvell.com>,\n Vidya Sagar Velumuri <vvelumuri@marvell.com>, <dev@dpdk.org>",
        "Subject": "[PATCH 06/15] crypto/cnxk: remove pdcp chain bit from capabilities",
        "Date": "Thu, 21 Sep 2023 17:18:11 +0530",
        "Message-ID": "<20230921114820.2526810-7-ktejasree@marvell.com>",
        "X-Mailer": "git-send-email 2.25.1",
        "In-Reply-To": "<20230921114820.2526810-1-ktejasree@marvell.com>",
        "References": "<20230921114820.2526810-1-ktejasree@marvell.com>",
        "MIME-Version": "1.0",
        "Content-Transfer-Encoding": "8bit",
        "Content-Type": "text/plain",
        "X-Proofpoint-ORIG-GUID": "nMMR3qnGmzSmn74o_dBWVjfYOlQuVn3F",
        "X-Proofpoint-GUID": "nMMR3qnGmzSmn74o_dBWVjfYOlQuVn3F",
        "X-Proofpoint-Virus-Version": "vendor=baseguard\n engine=ICAP:2.0.267,Aquarius:18.0.980,Hydra:6.0.619,FMLib:17.11.176.26\n definitions=2023-09-21_09,2023-09-21_01,2023-05-22_02",
        "X-BeenThere": "dev@dpdk.org",
        "X-Mailman-Version": "2.1.29",
        "Precedence": "list",
        "List-Id": "DPDK patches and discussions <dev.dpdk.org>",
        "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>",
        "List-Archive": "<http://mails.dpdk.org/archives/dev/>",
        "List-Post": "<mailto:dev@dpdk.org>",
        "List-Help": "<mailto:dev-request@dpdk.org?subject=help>",
        "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>",
        "Errors-To": "dev-bounces@dpdk.org"
    },
    "content": "Removing pdcp_chain bit from capabilities as it is\nsupported on all platforms.\n\nSigned-off-by: Tejasree Kondoj <ktejasree@marvell.com>\n---\n drivers/common/cnxk/hw/cpt.h             |  3 +--\n drivers/crypto/cnxk/cnxk_cryptodev_ops.c | 15 ++++-----------\n 2 files changed, 5 insertions(+), 13 deletions(-)",
    "diff": "diff --git a/drivers/common/cnxk/hw/cpt.h b/drivers/common/cnxk/hw/cpt.h\nindex 5e1519e202..96a863322a 100644\n--- a/drivers/common/cnxk/hw/cpt.h\n+++ b/drivers/common/cnxk/hw/cpt.h\n@@ -76,8 +76,7 @@ union cpt_eng_caps {\n \t\tuint64_t __io reserved_15_20 : 6;\n \t\tuint64_t __io sm3 : 1;\n \t\tuint64_t __io sm4 : 1;\n-\t\tuint64_t __io reserved_23_33 : 11;\n-\t\tuint64_t __io pdcp_chain : 1;\n+\t\tuint64_t __io reserved_23_34 : 12;\n \t\tuint64_t __io sg_ver2 : 1;\n \t\tuint64_t __io reserved_36_63 : 28;\n \t};\ndiff --git a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c\nindex 50150d3f06..99bf853234 100644\n--- a/drivers/crypto/cnxk/cnxk_cryptodev_ops.c\n+++ b/drivers/crypto/cnxk/cnxk_cryptodev_ops.c\n@@ -484,18 +484,13 @@ is_valid_pdcp_cipher_alg(struct rte_crypto_sym_xform *c_xfrm,\n }\n \n static int\n-cnxk_sess_fill(struct roc_cpt *roc_cpt, struct rte_crypto_sym_xform *xform,\n-\t       struct cnxk_se_sess *sess)\n+cnxk_sess_fill(struct rte_crypto_sym_xform *xform, struct cnxk_se_sess *sess)\n {\n \tstruct rte_crypto_sym_xform *aead_xfrm = NULL;\n \tstruct rte_crypto_sym_xform *c_xfrm = NULL;\n \tstruct rte_crypto_sym_xform *a_xfrm = NULL;\n-\tbool pdcp_chain_supported = false;\n \tbool ciph_then_auth = false;\n \n-\tif (roc_cpt->hw_caps[CPT_ENG_TYPE_SE].pdcp_chain)\n-\t\tpdcp_chain_supported = true;\n-\n \tif (xform == NULL)\n \t\treturn -EINVAL;\n \n@@ -591,8 +586,7 @@ cnxk_sess_fill(struct roc_cpt *roc_cpt, struct rte_crypto_sym_xform *xform,\n \t\t\tcase RTE_CRYPTO_AUTH_SNOW3G_UIA2:\n \t\t\tcase RTE_CRYPTO_AUTH_ZUC_EIA3:\n \t\t\tcase RTE_CRYPTO_AUTH_AES_CMAC:\n-\t\t\t\tif (!pdcp_chain_supported ||\n-\t\t\t\t    !is_valid_pdcp_cipher_alg(c_xfrm, sess))\n+\t\t\t\tif (!is_valid_pdcp_cipher_alg(c_xfrm, sess))\n \t\t\t\t\treturn -ENOTSUP;\n \t\t\t\tbreak;\n \t\t\tdefault:\n@@ -627,8 +621,7 @@ cnxk_sess_fill(struct roc_cpt *roc_cpt, struct rte_crypto_sym_xform *xform,\n \t\tcase RTE_CRYPTO_AUTH_SNOW3G_UIA2:\n \t\tcase RTE_CRYPTO_AUTH_ZUC_EIA3:\n \t\tcase RTE_CRYPTO_AUTH_AES_CMAC:\n-\t\t\tif (!pdcp_chain_supported ||\n-\t\t\t    !is_valid_pdcp_cipher_alg(c_xfrm, sess))\n+\t\t\tif (!is_valid_pdcp_cipher_alg(c_xfrm, sess))\n \t\t\t\treturn -ENOTSUP;\n \t\t\tbreak;\n \t\tdefault:\n@@ -679,7 +672,7 @@ sym_session_configure(struct roc_cpt *roc_cpt, struct rte_crypto_sym_xform *xfor\n \tif (is_session_less)\n \t\tmemset(sess_priv, 0, sizeof(struct cnxk_se_sess));\n \n-\tret = cnxk_sess_fill(roc_cpt, xform, sess_priv);\n+\tret = cnxk_sess_fill(xform, sess_priv);\n \tif (ret)\n \t\tgoto priv_put;\n \n",
    "prefixes": [
        "06/15"
    ]
}