Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131755/?format=api
{ "id": 131755, "url": "https://patches.dpdk.org/api/patches/131755/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230921042349.104150-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230921042349.104150-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230921042349.104150-2-stephen@networkplumber.org", "date": "2023-09-21T04:23:46", "name": "[1/4] pdump: fix setting rte_errno on mp error", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "6b5ea89e3b2b36626c0df7fc57296227a0afac6a", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230921042349.104150-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 29581, "url": "https://patches.dpdk.org/api/series/29581/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29581", "date": "2023-09-21T04:23:45", "name": "pcapng fixes", "version": 1, "mbox": "https://patches.dpdk.org/series/29581/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131755/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131755/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id E974E42602;\n\tThu, 21 Sep 2023 06:24:08 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 532E1402DD;\n\tThu, 21 Sep 2023 06:24:05 +0200 (CEST)", "from mail-pf1-f174.google.com (mail-pf1-f174.google.com\n [209.85.210.174])\n by mails.dpdk.org (Postfix) with ESMTP id 9116B4014F\n for <dev@dpdk.org>; Thu, 21 Sep 2023 06:24:02 +0200 (CEST)", "by mail-pf1-f174.google.com with SMTP id\n d2e1a72fcca58-691c05bc5aaso149298b3a.2\n for <dev@dpdk.org>; Wed, 20 Sep 2023 21:24:02 -0700 (PDT)", "from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131])\n by smtp.gmail.com with ESMTPSA id\n u5-20020aa78485000000b00690d1269691sm311946pfn.22.2023.09.20.21.24.00\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Wed, 20 Sep 2023 21:24:00 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1695270241;\n x=1695875041; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=LsawYgUPNSz8KCXOkCvRdkh/dufEOeHsF/JSonH5eXU=;\n b=oHXNGT1Xz5BwInAX08J6fOlHw5b0ti34RS11BsWPymrguO9WZ7zRUnhI3wWYCUU0qt\n FPX8b65rNcmvHOpHbGLCQyOJTwLU3nHE1H/d5MajnRLL7TaQJg0H2EZQPceOVleRmHEV\n cYJnmfxf+FMDhIoP5VrQp5xhXFVNWwccR12sQq4v4zh4Kvs7l0/n20QqnMBIam6soXkZ\n cM/LTFTsi8cr0tvEetKE8vaw+e8cpqYRJlrJWs8sz4QSipB7CzEzolhiYxPrDJNg8VGB\n L1nZlSN1AXYvkVXGlWoAV9ibOy8qiJbZtWABsUR1VCEVPifqMAVevkW57IDv+IXTQNpk\n edOQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20230601; t=1695270241; x=1695875041;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=LsawYgUPNSz8KCXOkCvRdkh/dufEOeHsF/JSonH5eXU=;\n b=ApkyInYlUHgoZ8wl8JU2lJPi1moHiKAFITkfcFg6z+eWHiiebHM75Qb3BmZDTQvRXt\n IR3139vKaRx8o6jncXmPBd05vhnSojIEncqs4FzMfc2Cx1cUdE1nqkL79NObDYsxnWm4\n DQlKWG3AeCBITigCV1tR72r+9qzx5DyQhQBV+IvABoGjdA9QpbKK61yhNMlvczzrxywN\n uy7LiNIoiKBDUj2r/sARC53qLkWYfNew/aYFoOKthtXLTQ348q3i91CxzaLKaVQgavWF\n 7ko5YsuC1d2AbSByxZoCER5DMO0FI8C5YuEVWrh7qd+V/2WBUczC0gPb1HA8goZHaU8j\n zvmQ==", "X-Gm-Message-State": "AOJu0YzAh4PQclc4XjGmuIg10QHtuy5USw/gVjOuSnaeKLNdMZBVxtET\n HNuR62ZURdGyVVAy6fUzepMoI9lrcTWzveugVhM=", "X-Google-Smtp-Source": "\n AGHT+IEIizz1mhZ0/128MZBtPPGAx6fi389FJ7slcJq4TaMDpywsk3KZhmXPSRx3GeMs1CHhbgxW5w==", "X-Received": "by 2002:a05:6a21:3399:b0:145:47af:57d8 with SMTP id\n yy25-20020a056a21339900b0014547af57d8mr5068803pzb.2.1695270241257;\n Wed, 20 Sep 2023 21:24:01 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Reshma Pattan <reshma.pattan@intel.com>,\n Jianfeng Tan <jianfeng.tan@intel.com>", "Subject": "[PATCH 1/4] pdump: fix setting rte_errno on mp error", "Date": "Wed, 20 Sep 2023 21:23:46 -0700", "Message-Id": "<20230921042349.104150-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230921042349.104150-1-stephen@networkplumber.org>", "References": "<20230921042349.104150-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The response from MP server sets err_value to negative\non error. The convention for rte_errno is to use a positive\nvalue on error. This makes errors like duplicate registration\nshow up with the correct error value.\n\nFixes: 660098d61f57 (\"pdump: use generic multi-process channel\")\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/pdump/rte_pdump.c | 5 +++--\n 1 file changed, 3 insertions(+), 2 deletions(-)", "diff": "diff --git a/lib/pdump/rte_pdump.c b/lib/pdump/rte_pdump.c\nindex 53cca1034d41..a70085bd0211 100644\n--- a/lib/pdump/rte_pdump.c\n+++ b/lib/pdump/rte_pdump.c\n@@ -564,9 +564,10 @@ pdump_prepare_client_request(const char *device, uint16_t queue,\n \tif (rte_mp_request_sync(&mp_req, &mp_reply, &ts) == 0) {\n \t\tmp_rep = &mp_reply.msgs[0];\n \t\tresp = (struct pdump_response *)mp_rep->param;\n-\t\trte_errno = resp->err_value;\n-\t\tif (!resp->err_value)\n+\t\tif (resp->err_value == 0)\n \t\t\tret = 0;\n+\t\telse\n+\t\t\trte_errno = -resp->err_value;\n \t\tfree(mp_reply.msgs);\n \t}\n \n", "prefixes": [ "1/4" ] }