Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131505/?format=api
{ "id": 131505, "url": "https://patches.dpdk.org/api/patches/131505/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230915115206.132198-3-bruce.richardson@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230915115206.132198-3-bruce.richardson@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230915115206.132198-3-bruce.richardson@intel.com", "date": "2023-09-15T11:52:06", "name": "[2/2] devtools: check for tests added without a test suite", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "4853b254660fc9211edd8b25045372cf13a9d420", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230915115206.132198-3-bruce.richardson@intel.com/mbox/", "series": [ { "id": 29522, "url": "https://patches.dpdk.org/api/series/29522/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29522", "date": "2023-09-15T11:52:04", "name": "add checks for tests not in a suite", "version": 1, "mbox": "https://patches.dpdk.org/series/29522/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131505/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131505/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9C7E9425A4;\n\tFri, 15 Sep 2023 13:52:42 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 8D44D40A79;\n\tFri, 15 Sep 2023 13:52:42 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.115])\n by mails.dpdk.org (Postfix) with ESMTP id 3CAC240A79\n for <dev@dpdk.org>; Fri, 15 Sep 2023 13:52:41 +0200 (CEST)", "from orsmga005.jf.intel.com ([10.7.209.41])\n by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 15 Sep 2023 04:52:26 -0700", "from silpixa00401385.ir.intel.com ([10.237.214.14])\n by orsmga005.jf.intel.com with ESMTP; 15 Sep 2023 04:52:24 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1694778761; x=1726314761;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=JCdNnq7onBVdGuhlO85HdpsvppPo45mEiw/NXfWfU7Y=;\n b=PqUgNrR/NMVs5VbzCUASItRTIoi3WWVSlnfB/y3ZO+IOj902cLWXAqPR\n QF8ufKoTZzqTAixe4t5ctUTmftuSs6xKuVqyF6DKXkAit9v5qt8nmoFt1\n AhjzGB3lOZuTbzJejg2WgHOsPv4BsdEgsGgJS44dGKKQpiys1y29f9nhN\n Z/hNE/eVSIzuu8txbA6XGBrR72IywvO1mrD/dprghvlmKlUNDFlKCsPUJ\n YC82pK98GAHNV+ISYfO7aUO69Amu3mamhcloYOAtvhUd+m2LQb6KaNjEb\n 2MPewedNy1mUXTRoAx0GaAFr1WV/27C4eFK5wq0Fz64HOqgAv1SMQePGC A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10833\"; a=\"379149251\"", "E=Sophos;i=\"6.02,149,1688454000\"; d=\"scan'208\";a=\"379149251\"", "E=McAfee;i=\"6600,9927,10833\"; a=\"918631228\"", "E=Sophos;i=\"6.02,149,1688454000\"; d=\"scan'208\";a=\"918631228\"" ], "X-ExtLoop1": "1", "From": "Bruce Richardson <bruce.richardson@intel.com>", "To": "dev@dpdk.org", "Cc": "david.marchand@redhat.com,\n\tBruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH 2/2] devtools: check for tests added without a test suite", "Date": "Fri, 15 Sep 2023 12:52:06 +0100", "Message-Id": "<20230915115206.132198-3-bruce.richardson@intel.com>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230915115206.132198-1-bruce.richardson@intel.com>", "References": "<20230915115206.132198-1-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add a check in checkpatches.sh for the use of the old\nREGISTER_TEST_COMMAND macro, which just adds a test without including it\nin a test suite. Suggest to the user to add the test using the newer\nmacros which will include the test in a test suite.\n\nSigned-off-by: Bruce Richardson <bruce.richardson@intel.com>\n---\n devtools/checkpatches.sh | 8 ++++++++\n 1 file changed, 8 insertions(+)", "diff": "diff --git a/devtools/checkpatches.sh b/devtools/checkpatches.sh\nindex 55fabc5458..9b201db0a2 100755\n--- a/devtools/checkpatches.sh\n+++ b/devtools/checkpatches.sh\n@@ -159,6 +159,14 @@ check_forbidden_additions() { # <patch>\n \t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n \t\t\"$1\" || res=1\n \n+\t# prevent addition of tests not in one of our test suites\n+\tawk -v FOLDERS='app/test' \\\n+\t\t-v EXPRESSIONS='REGISTER_TEST_COMMAND' \\\n+\t\t-v RET_ON_FAIL=1 \\\n+\t\t-v MESSAGE='Using REGISTER_TEST_COMMAND instead of REGISTER_<suite_name>_TEST' \\\n+\t\t-f $(dirname $(readlink -f $0))/check-forbidden-tokens.awk \\\n+\t\t\"$1\" || res=1\n+\n \t# SVG must be included with wildcard extension to allow conversion\n \tawk -v FOLDERS='doc' \\\n \t\t-v EXPRESSIONS='::[[:space:]]*[^[:space:]]*\\\\.svg' \\\n", "prefixes": [ "2/2" ] }