Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131448/?format=api
{ "id": 131448, "url": "https://patches.dpdk.org/api/patches/131448/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230915021730.2681882-13-simei.su@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230915021730.2681882-13-simei.su@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230915021730.2681882-13-simei.su@intel.com", "date": "2023-09-15T02:17:25", "name": "[v3,12/17] common/idpf/base: refine comments and alignment", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f5e83e77064c472a83d3e04e2c6c7ac98fe0fdff", "submitter": { "id": 1298, "url": "https://patches.dpdk.org/api/people/1298/?format=api", "name": "Simei Su", "email": "simei.su@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230915021730.2681882-13-simei.su@intel.com/mbox/", "series": [ { "id": 29513, "url": "https://patches.dpdk.org/api/series/29513/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29513", "date": "2023-09-15T02:17:13", "name": "update idpf base code", "version": 3, "mbox": "https://patches.dpdk.org/series/29513/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131448/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131448/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9DC1A4259D;\n\tFri, 15 Sep 2023 04:18:10 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id AAA6240DCD;\n\tFri, 15 Sep 2023 04:17:12 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id 78FCD40DCD\n for <dev@dpdk.org>; Fri, 15 Sep 2023 04:17:10 +0200 (CEST)", "from fmsmga005.fm.intel.com ([10.253.24.32])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 14 Sep 2023 19:17:10 -0700", "from dpdk-simei-icelake.sh.intel.com ([10.67.110.167])\n by fmsmga005.fm.intel.com with ESMTP; 14 Sep 2023 19:17:07 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1694744230; x=1726280230;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=THcs0Z3xg1j7y02r6qCWgcTN+NoUGPdfZGxoY6MV+8I=;\n b=WVH3Ls+huce+h7pvLH7TR2Bl5bDVJtKsIqKzZN+EEztPQaql9BD9S/RA\n yXPbGrsadOirWNQCv5l0mjoeeVj6OID72zY/VYsDv2FN2257D15mKDG0a\n H7qIjg2bIwcz5lRTvkJppiIi9OJpBp/dGC58xF2j6/UiaeU3cR4MvPI3w\n QOmW6y93XMaK315ATkEOo4tC9rucXfsxmmPGRAHDk6efqCuZc3c2Fo9c5\n wlp5xklD9veIHKSWovrOpe4tADUprCwqLAe36lQHv/SwfrPKJ9uZFCJXt\n t6GD7+41BqUDpKQT49IFaJjfKl6AUHi4NCPRqxVndWDBNaUUjAETY+LOI Q==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10833\"; a=\"410077982\"", "E=Sophos;i=\"6.02,147,1688454000\"; d=\"scan'208\";a=\"410077982\"", "E=McAfee;i=\"6600,9927,10833\"; a=\"1075622816\"", "E=Sophos;i=\"6.02,147,1688454000\"; d=\"scan'208\";a=\"1075622816\"" ], "X-ExtLoop1": "1", "From": "Simei Su <simei.su@intel.com>", "To": "jingjing.wu@intel.com,\n\tbeilei.xing@intel.com,\n\tqi.z.zhang@intel.com", "Cc": "dev@dpdk.org, mingxia.liu@intel.com, wenjing.qiao@intel.com,\n Simei Su <simei.su@intel.com>,\n Pavan Kumar Linga <pavan.kumar.linga@intel.com>", "Subject": "[PATCH v3 12/17] common/idpf/base: refine comments and alignment", "Date": "Fri, 15 Sep 2023 10:17:25 +0800", "Message-Id": "<20230915021730.2681882-13-simei.su@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230915021730.2681882-1-simei.su@intel.com>", "References": "<20230825101344.1828774-1-simei.su@intel.com>\n <20230915021730.2681882-1-simei.su@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Refine the macros and definitions by using 'tab' spaces and new\nlines wherever necessary. Also refine the comment in\n'idpf_ctlq_setup_regs' and remove the TODO comment in idpf_rss_hash\nenum as it doesn't make any sense.\n\nSigned-off-by: Pavan Kumar Linga <pavan.kumar.linga@intel.com>\nSigned-off-by: Simei Su <simei.su@intel.com>\n---\n drivers/common/idpf/base/idpf_controlq.c | 2 +-\n drivers/common/idpf/base/idpf_controlq_api.h | 10 +----\n drivers/common/idpf/base/idpf_lan_pf_regs.h | 7 +--\n drivers/common/idpf/base/idpf_lan_txrx.h | 47 +++++++++-----------\n drivers/common/idpf/base/idpf_lan_vf_regs.h | 25 +++++++----\n 5 files changed, 46 insertions(+), 45 deletions(-)", "diff": "diff --git a/drivers/common/idpf/base/idpf_controlq.c b/drivers/common/idpf/base/idpf_controlq.c\nindex da5c930578..c24bfd23ef 100644\n--- a/drivers/common/idpf/base/idpf_controlq.c\n+++ b/drivers/common/idpf/base/idpf_controlq.c\n@@ -13,7 +13,7 @@ static void\n idpf_ctlq_setup_regs(struct idpf_ctlq_info *cq,\n \t\t struct idpf_ctlq_create_info *q_create_info)\n {\n-\t/* set head and tail registers in our local struct */\n+\t/* set control queue registers in our local struct */\n \tcq->reg.head = q_create_info->reg.head;\n \tcq->reg.tail = q_create_info->reg.tail;\n \tcq->reg.len = q_create_info->reg.len;\ndiff --git a/drivers/common/idpf/base/idpf_controlq_api.h b/drivers/common/idpf/base/idpf_controlq_api.h\nindex 78a54f6b4c..38f5d2df3c 100644\n--- a/drivers/common/idpf/base/idpf_controlq_api.h\n+++ b/drivers/common/idpf/base/idpf_controlq_api.h\n@@ -21,10 +21,7 @@ enum idpf_ctlq_type {\n \tIDPF_CTLQ_TYPE_RDMA_COMPL\t= 7\n };\n \n-/*\n- * Generic Control Queue Structures\n- */\n-\n+/* Generic Control Queue Structures */\n struct idpf_ctlq_reg {\n \t/* used for queue tracking */\n \tu32 head;\n@@ -157,10 +154,7 @@ enum idpf_mbx_opc {\n \tidpf_mbq_opc_send_msg_to_peer_drv\t= 0x0804,\n };\n \n-/*\n- * API supported for control queue management\n- */\n-\n+/* API supported for control queue management */\n /* Will init all required q including default mb. \"q_info\" is an array of\n * create_info structs equal to the number of control queues to be created.\n */\ndiff --git a/drivers/common/idpf/base/idpf_lan_pf_regs.h b/drivers/common/idpf/base/idpf_lan_pf_regs.h\nindex 8542620e01..e47afad6e9 100644\n--- a/drivers/common/idpf/base/idpf_lan_pf_regs.h\n+++ b/drivers/common/idpf/base/idpf_lan_pf_regs.h\n@@ -80,10 +80,11 @@\n /* _ITR is ITR index, _INT is interrupt index, _itrn_indx_spacing is\n * spacing b/w itrn registers of the same vector.\n */\n-#define PF_GLINT_ITR_ADDR(_ITR, _reg_start, _itrn_indx_spacing) \\\n-\t\t((_reg_start) + (((_ITR)) * (_itrn_indx_spacing)))\n+#define PF_GLINT_ITR_ADDR(_ITR, _reg_start, _itrn_indx_spacing)\t\t\\\n+\t((_reg_start) + ((_ITR) * (_itrn_indx_spacing)))\n /* For PF, itrn_indx_spacing is 4 and itrn_reg_spacing is 0x1000 */\n-#define PF_GLINT_ITR(_ITR, _INT) (PF_GLINT_BASE + (((_ITR) + 1) * 4) + ((_INT) * 0x1000))\n+#define PF_GLINT_ITR(_ITR, _INT)\t\\\n+\t(PF_GLINT_BASE + (((_ITR) + 1) * 4) + ((_INT) * 0x1000))\n #define PF_GLINT_ITR_MAX_INDEX\t\t2\n #define PF_GLINT_ITR_INTERVAL_S\t\t0\n #define PF_GLINT_ITR_INTERVAL_M\t\tIDPF_M(0xFFF, PF_GLINT_ITR_INTERVAL_S)\ndiff --git a/drivers/common/idpf/base/idpf_lan_txrx.h b/drivers/common/idpf/base/idpf_lan_txrx.h\nindex 7b03693eb1..4951e266f0 100644\n--- a/drivers/common/idpf/base/idpf_lan_txrx.h\n+++ b/drivers/common/idpf/base/idpf_lan_txrx.h\n@@ -8,9 +8,9 @@\n #include \"idpf_osdep.h\"\n \n enum idpf_rss_hash {\n-\t/* Values 0 - 28 are reserved for future use */\n-\tIDPF_HASH_INVALID\t\t= 0,\n-\tIDPF_HASH_NONF_UNICAST_IPV4_UDP\t= 29,\n+\tIDPF_HASH_INVALID\t\t\t= 0,\n+\t/* Values 1 - 28 are reserved for future use */\n+\tIDPF_HASH_NONF_UNICAST_IPV4_UDP\t\t= 29,\n \tIDPF_HASH_NONF_MULTICAST_IPV4_UDP,\n \tIDPF_HASH_NONF_IPV4_UDP,\n \tIDPF_HASH_NONF_IPV4_TCP_SYN_NO_ACK,\n@@ -19,7 +19,7 @@ enum idpf_rss_hash {\n \tIDPF_HASH_NONF_IPV4_OTHER,\n \tIDPF_HASH_FRAG_IPV4,\n \t/* Values 37-38 are reserved */\n-\tIDPF_HASH_NONF_UNICAST_IPV6_UDP\t= 39,\n+\tIDPF_HASH_NONF_UNICAST_IPV6_UDP\t\t= 39,\n \tIDPF_HASH_NONF_MULTICAST_IPV6_UDP,\n \tIDPF_HASH_NONF_IPV6_UDP,\n \tIDPF_HASH_NONF_IPV6_TCP_SYN_NO_ACK,\n@@ -32,34 +32,31 @@ enum idpf_rss_hash {\n \tIDPF_HASH_NONF_FCOE_RX,\n \tIDPF_HASH_NONF_FCOE_OTHER,\n \t/* Values 51-62 are reserved */\n-\tIDPF_HASH_L2_PAYLOAD\t\t= 63,\n+\tIDPF_HASH_L2_PAYLOAD\t\t\t= 63,\n+\n \tIDPF_HASH_MAX\n };\n \n /* Supported RSS offloads */\n-#define IDPF_DEFAULT_RSS_HASH ( \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV4_UDP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV4_SCTP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV4_TCP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV4_OTHER) | \\\n-\tBIT_ULL(IDPF_HASH_FRAG_IPV4) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV6_UDP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV6_TCP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV6_SCTP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV6_OTHER) | \\\n-\tBIT_ULL(IDPF_HASH_FRAG_IPV6) | \\\n+#define IDPF_DEFAULT_RSS_HASH\t\t\t\\\n+\t(BIT_ULL(IDPF_HASH_NONF_IPV4_UDP) |\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV4_SCTP) |\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV4_TCP) |\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV4_OTHER) |\t\\\n+\tBIT_ULL(IDPF_HASH_FRAG_IPV4) |\t\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV6_UDP) |\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV6_TCP) |\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV6_SCTP) |\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV6_OTHER) |\t\\\n+\tBIT_ULL(IDPF_HASH_FRAG_IPV6) |\t\t\\\n \tBIT_ULL(IDPF_HASH_L2_PAYLOAD))\n \n-\t/* TODO: Wrap below comment under internal flag\n-\t * Below 6 pcktypes are not supported by FVL or older products\n-\t * They are supported by FPK and future products\n-\t */\n #define IDPF_DEFAULT_RSS_HASH_EXPANDED (IDPF_DEFAULT_RSS_HASH | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV4_TCP_SYN_NO_ACK) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_UNICAST_IPV4_UDP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_MULTICAST_IPV4_UDP) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_IPV6_TCP_SYN_NO_ACK) | \\\n-\tBIT_ULL(IDPF_HASH_NONF_UNICAST_IPV6_UDP) | \\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV4_TCP_SYN_NO_ACK) |\t\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_UNICAST_IPV4_UDP) |\t\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_MULTICAST_IPV4_UDP) |\t\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_IPV6_TCP_SYN_NO_ACK) |\t\t\\\n+\tBIT_ULL(IDPF_HASH_NONF_UNICAST_IPV6_UDP) |\t\t\\\n \tBIT_ULL(IDPF_HASH_NONF_MULTICAST_IPV6_UDP))\n \n /* For idpf_splitq_base_tx_compl_desc */\ndiff --git a/drivers/common/idpf/base/idpf_lan_vf_regs.h b/drivers/common/idpf/base/idpf_lan_vf_regs.h\nindex b5ff9b2cc9..4c5249129e 100644\n--- a/drivers/common/idpf/base/idpf_lan_vf_regs.h\n+++ b/drivers/common/idpf/base/idpf_lan_vf_regs.h\n@@ -94,14 +94,23 @@\n * b/w itrn registers of the same vector\n */\n #define VF_INT_ITR0(_ITR)\t\t(0x00004C00 + ((_ITR) * 4))\n-#define VF_INT_ITRN_ADDR(_ITR, _reg_start, _itrn_indx_spacing) \\\n-\t\t ((_reg_start) + (((_ITR)) * (_itrn_indx_spacing)))\n-/* For VF with 16 vector support, itrn_reg_spacing is 0x4 and itrn_indx_spacing is 0x40 */\n-#define VF_INT_ITRN(_INT, _ITR)\t(0x00002800 + ((_INT) * 4) + ((_ITR) * 0x40))\n-/* For VF with 64 vector support, itrn_reg_spacing is 0x4 and itrn_indx_spacing is 0x100 */\n-#define VF_INT_ITRN_64(_INT, _ITR) (0x00002C00 + ((_INT) * 4) + ((_ITR) * 0x100))\n-/* For VF with 2k vector support, itrn_reg_spacing is 0x4 and itrn_indx_spacing is 0x2000 */\n-#define VF_INT_ITRN_2K(_INT, _ITR) (0x00072000 + ((_INT) * 4) + ((_ITR) * 0x2000))\n+#define VF_INT_ITRN_ADDR(_ITR, _reg_start, _itrn_indx_spacing) \\\n+\t((_reg_start) + ((_ITR) * (_itrn_indx_spacing)))\n+/* For VF with 16 vector support, itrn_reg_spacing is 0x4, itrn_indx_spacing\n+ * is 0x40 and base register offset is 0x00002800\n+ */\n+#define VF_INT_ITRN(_INT, _ITR)\t\t\t\\\n+\t(0x00002800 + ((_INT) * 4) + ((_ITR) * 0x40))\n+/* For VF with 64 vector support, itrn_reg_spacing is 0x4, itrn_indx_spacing\n+ * is 0x100 and base register offset is 0x00002C00\n+ */\n+#define VF_INT_ITRN_64(_INT, _ITR)\t\\\n+\t(0x00002C00 + ((_INT) * 4) + ((_ITR) * 0x100))\n+/* For VF with 2k vector support, itrn_reg_spacing is 0x4, itrn_indx_spacing\n+ * is 0x2000 and base register offset is 0x00072000\n+ */\n+#define VF_INT_ITRN_2K(_INT, _ITR)\t\\\n+\t(0x00072000 + ((_INT) * 4) + ((_ITR) * 0x2000))\n #define VF_INT_ITRN_MAX_INDEX\t\t2\n #define VF_INT_ITRN_INTERVAL_S\t\t0\n #define VF_INT_ITRN_INTERVAL_M\t\tIDPF_M(0xFFF, VF_INT_ITRN_INTERVAL_S)\n", "prefixes": [ "v3", "12/17" ] }