Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131415/?format=api
{ "id": 131415, "url": "https://patches.dpdk.org/api/patches/131415/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230914123615.1705654-3-david.marchand@redhat.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230914123615.1705654-3-david.marchand@redhat.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230914123615.1705654-3-david.marchand@redhat.com", "date": "2023-09-14T12:36:01", "name": "[v3,02/15] bus/pci: add const to some experimental API", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "c30b8795d864fd3be992affd8339cb5d940b5135", "submitter": { "id": 1173, "url": "https://patches.dpdk.org/api/people/1173/?format=api", "name": "David Marchand", "email": "david.marchand@redhat.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230914123615.1705654-3-david.marchand@redhat.com/mbox/", "series": [ { "id": 29507, "url": "https://patches.dpdk.org/api/series/29507/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29507", "date": "2023-09-14T12:35:59", "name": "Cleanup PCI(e) drivers", "version": 3, "mbox": "https://patches.dpdk.org/series/29507/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131415/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/131415/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 6C57842597;\n\tThu, 14 Sep 2023 14:36:42 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id D22F0406A2;\n\tThu, 14 Sep 2023 14:36:35 +0200 (CEST)", "from us-smtp-delivery-124.mimecast.com\n (us-smtp-delivery-124.mimecast.com [170.10.129.124])\n by mails.dpdk.org (Postfix) with ESMTP id ABFF34069D\n for <dev@dpdk.org>; Thu, 14 Sep 2023 14:36:33 +0200 (CEST)", "from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id\n us-mta-479-XvutVS4qPx6wZ7p_7CWP2g-1; Thu, 14 Sep 2023 08:36:28 -0400", "from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com\n [10.11.54.6])\n (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))\n (No client certificate requested)\n by mimecast-mx02.redhat.com (Postfix) with ESMTPS id BB252101FAA1;\n Thu, 14 Sep 2023 12:36:27 +0000 (UTC)", "from dmarchan.redhat.com (unknown [10.45.225.25])\n by smtp.corp.redhat.com (Postfix) with ESMTP id 963532156A27;\n Thu, 14 Sep 2023 12:36:26 +0000 (UTC)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n s=mimecast20190719; t=1694694993;\n h=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n to:to:cc:cc:mime-version:mime-version:content-type:content-type:\n content-transfer-encoding:content-transfer-encoding:\n in-reply-to:in-reply-to:references:references;\n bh=6Bio8KKzruXmSBrYk1AJPZWzohgEn+iBLPgltEFcGHk=;\n b=YwCRLzE/C4ER1mbThEO9elYfdfYBPdS3XFt0rxyyWocH+u2K+6VhQxBkqfrdf1J2+OY+cM\n bCy/AU6w+EPk+kG29qubXTVREq0XHQUAsq+SbuDffcIKEsujNuOviSpnO7zwgmRJW/mUYA\n 5Y66wLg7y+qGo30RhpX1k+cZajaW24A=", "X-MC-Unique": "XvutVS4qPx6wZ7p_7CWP2g-1", "From": "David Marchand <david.marchand@redhat.com>", "To": "dev@dpdk.org", "Cc": "thomas@monjalon.net, ferruh.yigit@amd.com, chenbo.xia@intel.com,\n nipun.gupta@amd.com, bruce.richardson@intel.com", "Subject": "[PATCH v3 02/15] bus/pci: add const to some experimental API", "Date": "Thu, 14 Sep 2023 14:36:01 +0200", "Message-ID": "<20230914123615.1705654-3-david.marchand@redhat.com>", "In-Reply-To": "<20230914123615.1705654-1-david.marchand@redhat.com>", "References": "<20230803075038.307012-1-david.marchand@redhat.com>\n <20230914123615.1705654-1-david.marchand@redhat.com>", "MIME-Version": "1.0", "X-Scanned-By": "MIMEDefang 3.1 on 10.11.54.6", "X-Mimecast-Spam-Score": "0", "X-Mimecast-Originator": "redhat.com", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain; charset=\"US-ASCII\"; x-default=true", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Those functions are fine with a const on the device pointer.\n\nSigned-off-by: David Marchand <david.marchand@redhat.com>\nAcked-by: Bruce Richardson <bruce.richardson@intel.com>\nReviewed-by: Chenbo Xia <chenbo.xia@intel.com>\n---\n drivers/bus/pci/pci_common.c | 4 ++--\n drivers/bus/pci/rte_bus_pci.h | 4 ++--\n 2 files changed, 4 insertions(+), 4 deletions(-)", "diff": "diff --git a/drivers/bus/pci/pci_common.c b/drivers/bus/pci/pci_common.c\nindex 52404ab0fe..382b0b8946 100644\n--- a/drivers/bus/pci/pci_common.c\n+++ b/drivers/bus/pci/pci_common.c\n@@ -814,7 +814,7 @@ rte_pci_get_iommu_class(void)\n }\n \n off_t\n-rte_pci_find_ext_capability(struct rte_pci_device *dev, uint32_t cap)\n+rte_pci_find_ext_capability(const struct rte_pci_device *dev, uint32_t cap)\n {\n \toff_t offset = RTE_PCI_CFG_SPACE_SIZE;\n \tuint32_t header;\n@@ -857,7 +857,7 @@ rte_pci_find_ext_capability(struct rte_pci_device *dev, uint32_t cap)\n }\n \n int\n-rte_pci_set_bus_master(struct rte_pci_device *dev, bool enable)\n+rte_pci_set_bus_master(const struct rte_pci_device *dev, bool enable)\n {\n \tuint16_t old_cmd, cmd;\n \ndiff --git a/drivers/bus/pci/rte_bus_pci.h b/drivers/bus/pci/rte_bus_pci.h\nindex 9d59c4aef3..75d0030eae 100644\n--- a/drivers/bus/pci/rte_bus_pci.h\n+++ b/drivers/bus/pci/rte_bus_pci.h\n@@ -85,7 +85,7 @@ void rte_pci_dump(FILE *f);\n * = 0: Device does not support it.\n */\n __rte_experimental\n-off_t rte_pci_find_ext_capability(struct rte_pci_device *dev, uint32_t cap);\n+off_t rte_pci_find_ext_capability(const struct rte_pci_device *dev, uint32_t cap);\n \n /**\n * Enables/Disables Bus Master for device's PCI command register.\n@@ -99,7 +99,7 @@ off_t rte_pci_find_ext_capability(struct rte_pci_device *dev, uint32_t cap);\n * 0 on success, -1 on error in PCI config space read/write.\n */\n __rte_experimental\n-int rte_pci_set_bus_master(struct rte_pci_device *dev, bool enable);\n+int rte_pci_set_bus_master(const struct rte_pci_device *dev, bool enable);\n \n /**\n * Read PCI config space.\n", "prefixes": [ "v3", "02/15" ] }