Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131241/?format=api
{ "id": 131241, "url": "https://patches.dpdk.org/api/patches/131241/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230908111701.1022724-4-beilei.xing@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230908111701.1022724-4-beilei.xing@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230908111701.1022724-4-beilei.xing@intel.com", "date": "2023-09-08T11:16:54", "name": "[v4,03/10] net/cpfl: refine handle virtual channel message", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "f27e99909412392196e012f8eb88456ef9b8296d", "submitter": { "id": 410, "url": "https://patches.dpdk.org/api/people/410/?format=api", "name": "Xing, Beilei", "email": "beilei.xing@intel.com" }, "delegate": { "id": 1540, "url": "https://patches.dpdk.org/api/users/1540/?format=api", "username": "qzhan15", "first_name": "Qi", "last_name": "Zhang", "email": "qi.z.zhang@intel.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230908111701.1022724-4-beilei.xing@intel.com/mbox/", "series": [ { "id": 29454, "url": "https://patches.dpdk.org/api/series/29454/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29454", "date": "2023-09-08T11:16:51", "name": "net/cpfl: support port representor", "version": 4, "mbox": "https://patches.dpdk.org/series/29454/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131241/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131241/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 64BF14253D;\n\tFri, 8 Sep 2023 04:58:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id B84B7402DF;\n\tFri, 8 Sep 2023 04:58:25 +0200 (CEST)", "from mgamail.intel.com (mgamail.intel.com [192.55.52.136])\n by mails.dpdk.org (Postfix) with ESMTP id E6081402D2\n for <dev@dpdk.org>; Fri, 8 Sep 2023 04:58:23 +0200 (CEST)", "from fmsmga008.fm.intel.com ([10.253.24.58])\n by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 07 Sep 2023 19:58:23 -0700", "from dpdk-beileix-icelake.sh.intel.com ([10.67.116.248])\n by fmsmga008.fm.intel.com with ESMTP; 07 Sep 2023 19:58:21 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1694141904; x=1725677904;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=kRGCzXeuatN815mUfUDHml3DhXOYzNt8532AnIaQkqI=;\n b=CFUpxOmTtHbAgE7rnVlAcJ5rnDCrbEd6sqmIdoZP2Zx+0E+zCZNu8B4P\n YBpOpfxANtWNK68y+iDMxNL+ld4d2SJQ4vZh0RbAHLyE2oc9eM8g5bkUh\n Ad4hNRT/B+DME/Ac/THTf8Ms8A/djEvTsPip2NWJ810HlXv1tpAIsrXKf\n eOK/89DXOD3YcCz6nXRPGRoWmow0vc++gKHM7fWptcCmM9xsgV/4ZV4re\n DCelwAmFZqpS1qREJSNapTRtU8AkZIrGXlJbWXgMnvJXsU91CQKmnzHP0\n tElYRQ8CBkJkkQUxz0eFl8fxR+OxfGWjJjZhtljFSdwySTjspZ83wOu7p w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10826\"; a=\"357002042\"", "E=Sophos;i=\"6.02,236,1688454000\"; d=\"scan'208\";a=\"357002042\"", "E=McAfee;i=\"6600,9927,10826\"; a=\"807789827\"", "E=Sophos;i=\"6.02,236,1688454000\"; d=\"scan'208\";a=\"807789827\"" ], "X-ExtLoop1": "1", "From": "beilei.xing@intel.com", "To": "jingjing.wu@intel.com", "Cc": "dev@dpdk.org, mingxia.liu@intel.com, Beilei Xing <beilei.xing@intel.com>,\n Qi Zhang <qi.z.zhang@intel.com>", "Subject": "[PATCH v4 03/10] net/cpfl: refine handle virtual channel message", "Date": "Fri, 8 Sep 2023 11:16:54 +0000", "Message-Id": "<20230908111701.1022724-4-beilei.xing@intel.com>", "X-Mailer": "git-send-email 2.34.1", "In-Reply-To": "<20230908111701.1022724-1-beilei.xing@intel.com>", "References": "<20230907151606.849612-1-beilei.xing@intel.com>\n <20230908111701.1022724-1-beilei.xing@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Beilei Xing <beilei.xing@intel.com>\n\nRefine handle virtual channel event message.\n\nSigned-off-by: Qi Zhang <qi.z.zhang@intel.com>\nSigned-off-by: Beilei Xing <beilei.xing@intel.com>\n---\n drivers/net/cpfl/cpfl_ethdev.c | 46 ++++++++++++++++------------------\n 1 file changed, 22 insertions(+), 24 deletions(-)", "diff": "diff --git a/drivers/net/cpfl/cpfl_ethdev.c b/drivers/net/cpfl/cpfl_ethdev.c\nindex 92fe92c00f..6b6e9b37b1 100644\n--- a/drivers/net/cpfl/cpfl_ethdev.c\n+++ b/drivers/net/cpfl/cpfl_ethdev.c\n@@ -1450,40 +1450,50 @@ cpfl_parse_devargs(struct rte_pci_device *pci_dev, struct cpfl_adapter_ext *adap\n \treturn ret;\n }\n \n-static struct idpf_vport *\n+static struct cpfl_vport *\n cpfl_find_vport(struct cpfl_adapter_ext *adapter, uint32_t vport_id)\n {\n-\tstruct idpf_vport *vport = NULL;\n+\tstruct cpfl_vport *vport = NULL;\n \tint i;\n \n \tfor (i = 0; i < adapter->cur_vport_nb; i++) {\n-\t\tvport = &adapter->vports[i]->base;\n-\t\tif (vport->vport_id != vport_id)\n+\t\tvport = adapter->vports[i];\n+\t\tif (vport->base.vport_id != vport_id)\n \t\t\tcontinue;\n \t\telse\n \t\t\treturn vport;\n \t}\n \n-\treturn vport;\n+\treturn NULL;\n }\n \n static void\n-cpfl_handle_event_msg(struct idpf_vport *vport, uint8_t *msg, uint16_t msglen)\n+cpfl_handle_vchnl_event_msg(struct cpfl_adapter_ext *adapter, uint8_t *msg, uint16_t msglen)\n {\n \tstruct virtchnl2_event *vc_event = (struct virtchnl2_event *)msg;\n-\tstruct rte_eth_dev_data *data = vport->dev_data;\n-\tstruct rte_eth_dev *dev = &rte_eth_devices[data->port_id];\n+\tstruct cpfl_vport *vport;\n+\tstruct rte_eth_dev_data *data;\n+\tstruct rte_eth_dev *dev;\n \n \tif (msglen < sizeof(struct virtchnl2_event)) {\n \t\tPMD_DRV_LOG(ERR, \"Error event\");\n \t\treturn;\n \t}\n \n+\tvport = cpfl_find_vport(adapter, vc_event->vport_id);\n+\tif (!vport) {\n+\t\tPMD_DRV_LOG(ERR, \"Can't find vport.\");\n+\t\treturn;\n+\t}\n+\n+\tdata = vport->itf.data;\n+\tdev = &rte_eth_devices[data->port_id];\n+\n \tswitch (vc_event->event) {\n \tcase VIRTCHNL2_EVENT_LINK_CHANGE:\n \t\tPMD_DRV_LOG(DEBUG, \"VIRTCHNL2_EVENT_LINK_CHANGE\");\n-\t\tvport->link_up = !!(vc_event->link_status);\n-\t\tvport->link_speed = vc_event->link_speed;\n+\t\tvport->base.link_up = !!(vc_event->link_status);\n+\t\tvport->base.link_speed = vc_event->link_speed;\n \t\tcpfl_dev_link_update(dev, 0);\n \t\tbreak;\n \tdefault:\n@@ -1498,10 +1508,8 @@ cpfl_handle_virtchnl_msg(struct cpfl_adapter_ext *adapter)\n \tstruct idpf_adapter *base = &adapter->base;\n \tstruct idpf_dma_mem *dma_mem = NULL;\n \tstruct idpf_hw *hw = &base->hw;\n-\tstruct virtchnl2_event *vc_event;\n \tstruct idpf_ctlq_msg ctlq_msg;\n \tenum idpf_mbx_opc mbx_op;\n-\tstruct idpf_vport *vport;\n \tuint16_t pending = 1;\n \tuint32_t vc_op;\n \tint ret;\n@@ -1523,18 +1531,8 @@ cpfl_handle_virtchnl_msg(struct cpfl_adapter_ext *adapter)\n \t\tswitch (mbx_op) {\n \t\tcase idpf_mbq_opc_send_msg_to_peer_pf:\n \t\t\tif (vc_op == VIRTCHNL2_OP_EVENT) {\n-\t\t\t\tif (ctlq_msg.data_len < sizeof(struct virtchnl2_event)) {\n-\t\t\t\t\tPMD_DRV_LOG(ERR, \"Error event\");\n-\t\t\t\t\treturn;\n-\t\t\t\t}\n-\t\t\t\tvc_event = (struct virtchnl2_event *)base->mbx_resp;\n-\t\t\t\tvport = cpfl_find_vport(adapter, vc_event->vport_id);\n-\t\t\t\tif (!vport) {\n-\t\t\t\t\tPMD_DRV_LOG(ERR, \"Can't find vport.\");\n-\t\t\t\t\treturn;\n-\t\t\t\t}\n-\t\t\t\tcpfl_handle_event_msg(vport, base->mbx_resp,\n-\t\t\t\t\t\t ctlq_msg.data_len);\n+\t\t\t\tcpfl_handle_vchnl_event_msg(adapter, adapter->base.mbx_resp,\n+\t\t\t\t\t\t\t ctlq_msg.data_len);\n \t\t\t} else {\n \t\t\t\tif (vc_op == base->pend_cmd)\n \t\t\t\t\tnotify_cmd(base, base->cmd_retval);\n", "prefixes": [ "v4", "03/10" ] }