Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131231/?format=api
{ "id": 131231, "url": "https://patches.dpdk.org/api/patches/131231/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230907152456.20570-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230907152456.20570-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230907152456.20570-2-stephen@networkplumber.org", "date": "2023-09-07T15:24:55", "name": "[v2,1/2] random: initialize the random state for non-EAL threads", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "0152c19fca273f46bf06b6a94b43770dadffba00", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230907152456.20570-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 29449, "url": "https://patches.dpdk.org/api/series/29449/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29449", "date": "2023-09-07T15:24:54", "name": "fixes to rte_random for non-EAL threads", "version": 2, "mbox": "https://patches.dpdk.org/series/29449/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131231/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131231/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BE26A42537;\n\tThu, 7 Sep 2023 17:25:16 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 9797C4029E;\n\tThu, 7 Sep 2023 17:25:12 +0200 (CEST)", "from mail-pj1-f45.google.com (mail-pj1-f45.google.com\n [209.85.216.45]) by mails.dpdk.org (Postfix) with ESMTP id B779F400EF\n for <dev@dpdk.org>; Thu, 7 Sep 2023 17:25:09 +0200 (CEST)", "by mail-pj1-f45.google.com with SMTP id\n 98e67ed59e1d1-26f6b2c8e80so853391a91.1\n for <dev@dpdk.org>; Thu, 07 Sep 2023 08:25:09 -0700 (PDT)", "from hermes.local (204-195-112-131.wavecable.com. [204.195.112.131])\n by smtp.gmail.com with ESMTPSA id\n e2-20020a170902b78200b001aaf2e8b1eesm12864400pls.248.2023.09.07.08.25.07\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Thu, 07 Sep 2023 08:25:08 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20230601.gappssmtp.com; s=20230601; t=1694100308;\n x=1694705108; darn=dpdk.org;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=h3Hh7EPNE1XiBDeaXN8wc+x0dVKKHiGt13RB1tFThDY=;\n b=xO4AUioCuv8YJyLKN3FKKTSjv86/mN+2xp9GGwVs7k8b2RuZMw+JDtgdAqice+sYLs\n pXfevctGr5fYMepIiJBVkh1NyQuYqI3ZTYTdn+1Oe0S3990gEzdq0VM0SlUTMVKB8+ax\n 9fgVKgL1gAoLv+mTpURy++NOEFCmDxe9SRWexjmlv6Sya85Smf6WOpdJ0I/7lqNmwbjd\n VpvpdCDgMw1Bg3C0JPFmQHYErz18wS9Fj3txQXz/Tsv0xKzC4gcU9FsMQVe/1pIibO1I\n BzuYKpQX6DsBMdFyNKJPLMPORyYermCaIB2hC4I+rVgclaOBeHwbFTOreUAB3Noi1JyS\n 2CoA==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1694100308; x=1694705108;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=h3Hh7EPNE1XiBDeaXN8wc+x0dVKKHiGt13RB1tFThDY=;\n b=AX2sCywsKIGlESQITndaTMX+eSLXnldK/k9lzljL1TrGs7PZXxV8VeluQqshHJUBsL\n vekNV3NeRwaEZpFUDsqeSLFZoqrx2c74zbNLo32oFQl7m5vWioWtinH+4rRe2JWHJ1ZX\n 5uvvpq1pmACV1uutc/IhOtp6KUfFUYzCw5Kf8q7WRihSVztixfaN2PedemIj5txsjof8\n EiBn2QXNbajRkPUlxlfY8hW1m62IAftYYEZwkdS2BXWcsThsOk05QE+8SB4GmgBzB1R9\n rPqZywFPjRiSCHoEKW/uDDBctyYlV441rT+dgJuXIq4x2Xitj+P9LMRkXabmgLsDYqjO\n AnFQ==", "X-Gm-Message-State": "AOJu0YwjHecGsaDBpEAG+QR0AX8Wi7cCRjxd/EQfT4Say3vnukuSnXTp\n 15qe2HX5SYyWZy+LsSt2U7a09JgtoPWZeVbqBo4=", "X-Google-Smtp-Source": "\n AGHT+IGTN1Eb0hXu9g6pFXiujq+pl2Ny5J5hDECwBaKQ86asGZWtDl7ALr6YmaXTzRq/E4VWCbL5ew==", "X-Received": "by 2002:a17:90b:3b46:b0:26f:f272:144c with SMTP id\n ot6-20020a17090b3b4600b0026ff272144cmr17541600pjb.27.1694100308522;\n Thu, 07 Sep 2023 08:25:08 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n mattias.ronnblom@ericsson.com,\n =?utf-8?q?Morten_Br=C3=B8rup?= <mb@smartsharesystems.com>,\n Bruce Richardson <bruce.richardson@intel.com>", "Subject": "[PATCH v2 1/2] random: initialize the random state for non-EAL\n threads", "Date": "Thu, 7 Sep 2023 08:24:55 -0700", "Message-Id": "<20230907152456.20570-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230907152456.20570-1-stephen@networkplumber.org>", "References": "<20230906155302.82749-1-stephen@networkplumber.org>\n <20230907152456.20570-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "The per-lcore PRNG was not initializing the rand_state of all\nthe lcores. Any usage of rte_random by a non-EAL lcore would\nuse rand_states[RTE_MAX_LCORE] which was never initialized.\n\nFix by using RTE_DIM() which will get all lcores.\n\nFixes: 3f002f069612 (\"eal: replace libc-based random generation with LFSR\")\nCc: mattias.ronnblom@ericsson.com\nAcked-by: Morten Brørup <mb@smartsharesystems.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/eal/common/rte_random.c | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)", "diff": "diff --git a/lib/eal/common/rte_random.c b/lib/eal/common/rte_random.c\nindex 53636331a27b..812e5b4757b5 100644\n--- a/lib/eal/common/rte_random.c\n+++ b/lib/eal/common/rte_random.c\n@@ -84,7 +84,7 @@ rte_srand(uint64_t seed)\n \tunsigned int lcore_id;\n \n \t/* add lcore_id to seed to avoid having the same sequence */\n-\tfor (lcore_id = 0; lcore_id < RTE_MAX_LCORE; lcore_id++)\n+\tfor (lcore_id = 0; lcore_id < RTE_DIM(rand_states); lcore_id++)\n \t\t__rte_srand_lfsr258(seed + lcore_id, &rand_states[lcore_id]);\n }\n \n", "prefixes": [ "v2", "1/2" ] }