Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131132/?format=api
{ "id": 131132, "url": "https://patches.dpdk.org/api/patches/131132/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230904061044.5692-2-haijie1@huawei.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230904061044.5692-2-haijie1@huawei.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230904061044.5692-2-haijie1@huawei.com", "date": "2023-09-04T06:10:40", "name": "[v3,1/5] app/proc-info: fix never show RSS info", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d48ce5db69c2886846247f4100e74a57dfeacd79", "submitter": { "id": 2935, "url": "https://patches.dpdk.org/api/people/2935/?format=api", "name": "Jie Hai", "email": "haijie1@huawei.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230904061044.5692-2-haijie1@huawei.com/mbox/", "series": [ { "id": 29410, "url": "https://patches.dpdk.org/api/series/29410/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29410", "date": "2023-09-04T06:10:39", "name": "support setting and querying RSS algorithms", "version": 3, "mbox": "https://patches.dpdk.org/series/29410/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131132/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/131132/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 75022424EC;\n\tMon, 4 Sep 2023 08:14:33 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 71405402C6;\n\tMon, 4 Sep 2023 08:14:33 +0200 (CEST)", "from szxga01-in.huawei.com (szxga01-in.huawei.com [45.249.212.187])\n by mails.dpdk.org (Postfix) with ESMTP id 078D6402B0\n for <dev@dpdk.org>; Mon, 4 Sep 2023 08:14:32 +0200 (CEST)", "from kwepemi500020.china.huawei.com (unknown [172.30.72.54])\n by szxga01-in.huawei.com (SkyGuard) with ESMTP id 4RfJG518mczrS8w;\n Mon, 4 Sep 2023 14:12:45 +0800 (CST)", "from localhost.localdomain (10.69.192.56) by\n kwepemi500020.china.huawei.com (7.221.188.8) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id\n 15.1.2507.31; Mon, 4 Sep 2023 14:14:30 +0800" ], "From": "Jie Hai <haijie1@huawei.com>", "To": "<dev@dpdk.org>, Reshma Pattan <reshma.pattan@intel.com>, Vipin Varghese\n <vipin.varghese@amd.com>, John McNamara <john.mcnamara@intel.com>", "CC": "<haijie1@huawei.com>, <lihuisong@huawei.com>", "Subject": "[PATCH v3 1/5] app/proc-info: fix never show RSS info", "Date": "Mon, 4 Sep 2023 14:10:40 +0800", "Message-ID": "<20230904061044.5692-2-haijie1@huawei.com>", "X-Mailer": "git-send-email 2.33.0", "In-Reply-To": "<20230904061044.5692-1-haijie1@huawei.com>", "References": "<20230826074607.16771-1-haijie1@huawei.com>\n <20230904061044.5692-1-haijie1@huawei.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.69.192.56]", "X-ClientProxiedBy": "dggems703-chm.china.huawei.com (10.3.19.180) To\n kwepemi500020.china.huawei.com (7.221.188.8)", "X-CFilter-Loop": "Reflected", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Command show-port should show RSS info (rss_key, len and rss_hf),\nHowever, the information is showned only when rss_conf.rss_key is not\nNULL. Since no memory is allocated for rss_conf.rss_key, rss_key\nwill always be NULL and the rss_info will never show. This patch\nallocates memory for rss_conf.rss_key and makes it possible to show\nRSS info.\n\nFixes: 8a37f37fc243 (\"app/procinfo: add --show-port\")\nCc: stable@dpdk.org\n\nSigned-off-by: Jie Hai <haijie1@huawei.com>\nSigned-off-by: Dongdong Liu <liudongdong3@huawei.com>\n---\n app/proc-info/main.c | 25 ++++++++++++++++---------\n 1 file changed, 16 insertions(+), 9 deletions(-)", "diff": "diff --git a/app/proc-info/main.c b/app/proc-info/main.c\nindex 88cee0ca487b..f6b77a705dce 100644\n--- a/app/proc-info/main.c\n+++ b/app/proc-info/main.c\n@@ -1013,6 +1013,7 @@ show_port(void)\n \t\tstruct rte_eth_fc_conf fc_conf;\n \t\tstruct rte_ether_addr mac;\n \t\tstruct rte_eth_dev_owner owner;\n+\t\tuint8_t *rss_key;\n \n \t\t/* Skip if port is not in mask */\n \t\tif ((enabled_port_mask & (1ul << i)) == 0)\n@@ -1171,19 +1172,25 @@ show_port(void)\n \t\t\tprintf(\"\\n\");\n \t\t}\n \n+\t\trss_key = malloc(dev_info.hash_key_size * sizeof(uint8_t));\n+\t\tif (rss_key == NULL)\n+\t\t\treturn;\n+\n+\t\trss_conf.rss_key = rss_key;\n+\t\trss_conf.rss_key_len = dev_info.hash_key_size;\n \t\tret = rte_eth_dev_rss_hash_conf_get(i, &rss_conf);\n \t\tif (ret == 0) {\n-\t\t\tif (rss_conf.rss_key) {\n-\t\t\t\tprintf(\" - RSS\\n\");\n-\t\t\t\tprintf(\"\\t -- RSS len %u key (hex):\",\n-\t\t\t\t\t\trss_conf.rss_key_len);\n-\t\t\t\tfor (k = 0; k < rss_conf.rss_key_len; k++)\n-\t\t\t\t\tprintf(\" %x\", rss_conf.rss_key[k]);\n-\t\t\t\tprintf(\"\\t -- hf 0x%\"PRIx64\"\\n\",\n-\t\t\t\t\t\trss_conf.rss_hf);\n-\t\t\t}\n+\t\t\tprintf(\" - RSS\\n\");\n+\t\t\tprintf(\"\\t -- RSS len %u key (hex):\",\n+\t\t\t\t\trss_conf.rss_key_len);\n+\t\t\tfor (k = 0; k < rss_conf.rss_key_len; k++)\n+\t\t\t\tprintf(\" %x\", rss_conf.rss_key[k]);\n+\t\t\tprintf(\"\\t -- hf 0x%\"PRIx64\"\\n\",\n+\t\t\t\t\trss_conf.rss_hf);\n \t\t}\n \n+\t\tfree(rss_key);\n+\n #ifdef RTE_LIB_SECURITY\n \t\tshow_security_context(i, true);\n #endif\n", "prefixes": [ "v3", "1/5" ] }