Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/131027/?format=api
{ "id": 131027, "url": "https://patches.dpdk.org/api/patches/131027/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230901032842.223547-19-wanry@3snic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230901032842.223547-19-wanry@3snic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230901032842.223547-19-wanry@3snic.com", "date": "2023-09-01T03:28:28", "name": "[v3,18/32] net/sssnic: add Rx interrupt support", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "ff1af422469f1e5b2704a5650dfe9038c47658d5", "submitter": { "id": 3119, "url": "https://patches.dpdk.org/api/people/3119/?format=api", "name": "Renyong Wan", "email": "wanry@3snic.com" }, "delegate": { "id": 319, "url": "https://patches.dpdk.org/api/users/319/?format=api", "username": "fyigit", "first_name": "Ferruh", "last_name": "Yigit", "email": "ferruh.yigit@amd.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230901032842.223547-19-wanry@3snic.com/mbox/", "series": [ { "id": 29399, "url": "https://patches.dpdk.org/api/series/29399/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29399", "date": "2023-09-01T03:28:13", "name": "Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters", "version": 3, "mbox": "https://patches.dpdk.org/series/29399/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/131027/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/131027/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 41BA342219;\n\tFri, 1 Sep 2023 05:30:55 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 49B48402EF;\n\tFri, 1 Sep 2023 05:29:40 +0200 (CEST)", "from VLXDG1SPAM1.ramaxel.com (email.ramaxel.com [221.4.138.186])\n by mails.dpdk.org (Postfix) with ESMTP id 280EF40647\n for <dev@dpdk.org>; Fri, 1 Sep 2023 05:29:36 +0200 (CEST)", "from V12DG1MBS03.ramaxel.local ([172.26.18.33])\n by VLXDG1SPAM1.ramaxel.com with ESMTP id 3813SwH2033317;\n Fri, 1 Sep 2023 11:28:58 +0800 (GMT-8)\n (envelope-from wanry@3snic.com)", "from localhost.localdomain (10.64.136.151) by\n V12DG1MBS03.ramaxel.local (172.26.18.33) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2375.17; Fri, 1 Sep 2023 11:28:57 +0800" ], "From": "<wanry@3snic.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, Renyong Wan <wanry@3snic.com>, Steven Song\n <steven.song@3snic.com>", "Subject": "[PATCH v3 18/32] net/sssnic: add Rx interrupt support", "Date": "Fri, 1 Sep 2023 11:28:28 +0800", "Message-ID": "<20230901032842.223547-19-wanry@3snic.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230901032842.223547-1-wanry@3snic.com>", "References": "<20230901032842.223547-1-wanry@3snic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.64.136.151]", "X-ClientProxiedBy": "V12DG1MBS03.ramaxel.local (172.26.18.33) To\n V12DG1MBS03.ramaxel.local (172.26.18.33)", "X-DNSRBL": "", "X-SPAM-SOURCE-CHECK": "pass", "X-MAIL": "VLXDG1SPAM1.ramaxel.com 3813SwH2033317", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Renyong Wan <wanry@3snic.com>\n\nSigned-off-by: Steven Song <steven.song@3snic.com>\nSigned-off-by: Renyong Wan <wanry@3snic.com>\n---\n doc/guides/nics/features/sssnic.ini | 1 +\n drivers/net/sssnic/base/sssnic_hw.c | 14 +++\n drivers/net/sssnic/base/sssnic_hw.h | 2 +\n drivers/net/sssnic/sssnic_ethdev.c | 2 +\n drivers/net/sssnic/sssnic_ethdev_rx.c | 135 ++++++++++++++++++++++++++\n drivers/net/sssnic/sssnic_ethdev_rx.h | 6 ++\n 6 files changed, 160 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/sssnic.ini b/doc/guides/nics/features/sssnic.ini\nindex b75c68cb33..e3b8166629 100644\n--- a/doc/guides/nics/features/sssnic.ini\n+++ b/doc/guides/nics/features/sssnic.ini\n@@ -7,6 +7,7 @@\n Link status = Y\n Link status event = Y\n Queue start/stop = Y\n+Rx interrupt = Y\n Unicast MAC filter = Y\n Multicast MAC filter = Y\n Linux = Y\ndiff --git a/drivers/net/sssnic/base/sssnic_hw.c b/drivers/net/sssnic/base/sssnic_hw.c\nindex 82eb4ea295..651a0aa7ef 100644\n--- a/drivers/net/sssnic/base/sssnic_hw.c\n+++ b/drivers/net/sssnic/base/sssnic_hw.c\n@@ -145,6 +145,20 @@ sssnic_msix_resend_disable(struct sssnic_hw *hw, uint16_t msix_id)\n \tsssnic_cfg_reg_write(hw, SSSNIC_MSIX_CTRL_REG, reg.u32);\n }\n \n+void\n+sssnic_msix_auto_mask_set(struct sssnic_hw *hw, uint16_t msix_id, int state)\n+{\n+\tstruct sssnic_msix_ctrl_reg reg;\n+\n+\treg.u32 = 0;\n+\tif (state == SSSNIC_MSIX_ENABLE)\n+\t\treg.auto_msk_set = 1;\n+\telse\n+\t\treg.auto_msk_clr = 1;\n+\treg.msxi_idx = msix_id;\n+\tsssnic_cfg_reg_write(hw, SSSNIC_MSIX_CTRL_REG, reg.u32);\n+}\n+\n static void\n sssnic_pf_status_set(struct sssnic_hw *hw, enum sssnic_pf_status status)\n {\ndiff --git a/drivers/net/sssnic/base/sssnic_hw.h b/drivers/net/sssnic/base/sssnic_hw.h\nindex e25f5595e6..4820212543 100644\n--- a/drivers/net/sssnic/base/sssnic_hw.h\n+++ b/drivers/net/sssnic/base/sssnic_hw.h\n@@ -100,6 +100,8 @@ int sssnic_hw_init(struct sssnic_hw *hw);\n void sssnic_hw_shutdown(struct sssnic_hw *hw);\n void sssnic_msix_state_set(struct sssnic_hw *hw, uint16_t msix_id, int state);\n void sssnic_msix_resend_disable(struct sssnic_hw *hw, uint16_t msix_id);\n+void sssnic_msix_auto_mask_set(struct sssnic_hw *hw, uint16_t msix_id,\n+\tint state);\n int sssnic_link_event_callback_register(struct sssnic_hw *hw,\n \tsssnic_link_event_cb_t *cb, void *priv);\n void sssnic_link_event_callback_unregister(struct sssnic_hw *hw);\ndiff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c\nindex 8a18f25889..35bb26a0b1 100644\n--- a/drivers/net/sssnic/sssnic_ethdev.c\n+++ b/drivers/net/sssnic/sssnic_ethdev.c\n@@ -362,6 +362,8 @@ static const struct eth_dev_ops sssnic_ethdev_ops = {\n \t.rx_queue_stop = sssnic_ethdev_rx_queue_stop,\n \t.tx_queue_start = sssnic_ethdev_tx_queue_start,\n \t.tx_queue_stop = sssnic_ethdev_tx_queue_stop,\n+\t.rx_queue_intr_enable = sssnic_ethdev_rx_queue_intr_enable,\n+\t.rx_queue_intr_disable = sssnic_ethdev_rx_queue_intr_disable,\n };\n \n static int\ndiff --git a/drivers/net/sssnic/sssnic_ethdev_rx.c b/drivers/net/sssnic/sssnic_ethdev_rx.c\nindex d8429e734d..9c1b2f20d1 100644\n--- a/drivers/net/sssnic/sssnic_ethdev_rx.c\n+++ b/drivers/net/sssnic/sssnic_ethdev_rx.c\n@@ -136,6 +136,12 @@ static const uint16_t sssnic_ethdev_rx_buf_size_tbl[] = { 32, 64, 96, 128, 192,\n /* Doorbell offset 8192 */\n #define SSSNIC_ETHDEV_RXQ_DB_OFFSET 0x2000\n \n+#define SSSNIC_ETHDEV_RX_MSIX_ID_START 1\n+#define SSSNIC_ETHDEV_RX_MSIX_ID_INVAL 0\n+#define SSSNIC_ETHDEV_RX_MSIX_PENDING_LIMIT 2\n+#define SSSNIC_ETHDEV_RX_MSIX_COALESCING_TIMER 2\n+#define SSSNIC_ETHDEV_RX_MSIX_RESNEDING_TIMER 7\n+\n struct sssnic_ethdev_rxq_doorbell {\n \tunion {\n \t\tuint64_t u64;\n@@ -750,3 +756,132 @@ sssnic_ethdev_rx_queue_all_stop(struct rte_eth_dev *ethdev)\n \n \treturn 0;\n }\n+\n+static int\n+sssinc_ethdev_rxq_intr_attr_init(struct sssnic_ethdev_rxq *rxq)\n+{\n+\tint ret;\n+\tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(rxq->ethdev);\n+\tstruct sssnic_msix_attr attr;\n+\n+\tattr.lli_set = 0;\n+\tattr.coalescing_set = 1;\n+\tattr.pending_limit = SSSNIC_ETHDEV_RX_MSIX_PENDING_LIMIT;\n+\tattr.coalescing_timer = SSSNIC_ETHDEV_RX_MSIX_COALESCING_TIMER;\n+\tattr.resend_timer = SSSNIC_ETHDEV_RX_MSIX_RESNEDING_TIMER;\n+\n+\tret = sssnic_msix_attr_set(hw, rxq->intr.msix_id, &attr);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to set msxi attributes\");\n+\t\treturn ret;\n+\t}\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_ethdev_rx_queue_intr_enable(struct rte_eth_dev *ethdev, uint16_t qid)\n+{\n+\tstruct sssnic_ethdev_rxq *rxq = ethdev->data->rx_queues[qid];\n+\tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);\n+\n+\tif (rxq->intr.enable)\n+\t\treturn 0;\n+\n+\tsssnic_msix_auto_mask_set(hw, rxq->intr.msix_id, SSSNIC_MSIX_ENABLE);\n+\tsssnic_msix_state_set(hw, rxq->intr.msix_id, SSSNIC_MSIX_ENABLE);\n+\trxq->intr.enable = 1;\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_ethdev_rx_queue_intr_disable(struct rte_eth_dev *ethdev, uint16_t qid)\n+{\n+\tstruct sssnic_ethdev_rxq *rxq = ethdev->data->rx_queues[qid];\n+\tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);\n+\n+\tif (!rxq->intr.enable)\n+\t\treturn 0;\n+\n+\tsssnic_msix_auto_mask_set(hw, rxq->intr.msix_id, SSSNIC_MSIX_DISABLE);\n+\tsssnic_msix_state_set(hw, rxq->intr.msix_id, SSSNIC_MSIX_DISABLE);\n+\tsssnic_msix_resend_disable(hw, rxq->intr.msix_id);\n+\trxq->intr.enable = 0;\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_ethdev_rx_intr_init(struct rte_eth_dev *ethdev)\n+{\n+\tstruct rte_intr_handle *intr_handle;\n+\tstruct sssnic_ethdev_rxq *rxq;\n+\tuint32_t nb_rxq, i;\n+\tint vec;\n+\tint ret;\n+\n+\tif (!ethdev->data->dev_conf.intr_conf.rxq)\n+\t\treturn 0;\n+\n+\tintr_handle = ethdev->intr_handle;\n+\n+\tif (!rte_intr_cap_multiple(intr_handle)) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Rx interrupts require MSI-X interrupts (vfio-pci driver)\\n\");\n+\t\treturn -ENOTSUP;\n+\t}\n+\n+\trte_intr_efd_disable(intr_handle);\n+\n+\tnb_rxq = ethdev->data->nb_rx_queues;\n+\n+\tret = rte_intr_efd_enable(intr_handle, nb_rxq);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to enable intr efd\");\n+\t\treturn ret;\n+\t}\n+\n+\tret = rte_intr_vec_list_alloc(intr_handle, NULL, nb_rxq);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to allocate rx intr vec list\");\n+\t\trte_intr_efd_disable(intr_handle);\n+\t\treturn ret;\n+\t}\n+\n+\tfor (i = 0; i < nb_rxq; i++) {\n+\t\tvec = (int)(i + SSSNIC_ETHDEV_RX_MSIX_ID_START);\n+\t\trte_intr_vec_list_index_set(intr_handle, i, vec);\n+\t\trxq = ethdev->data->rx_queues[i];\n+\t\trxq->intr.msix_id = vec;\n+\n+\t\tret = sssinc_ethdev_rxq_intr_attr_init(rxq);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\t\"Failed to initialize rxq %u (port %u) msix attribute.\",\n+\t\t\t\trxq->qid, rxq->port);\n+\t\t\tgoto intr_attr_init_fail;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+\n+intr_attr_init_fail:\n+\trte_intr_vec_list_free(intr_handle);\n+\trte_intr_efd_disable(intr_handle);\n+\n+\treturn ret;\n+}\n+\n+void\n+sssnic_ethdev_rx_intr_shutdown(struct rte_eth_dev *ethdev)\n+{\n+\tstruct rte_intr_handle *intr_handle = ethdev->intr_handle;\n+\tuint16_t i;\n+\n+\tfor (i = 0; i < ethdev->data->nb_rx_queues; i++)\n+\t\tsssnic_ethdev_rx_queue_intr_disable(ethdev, i);\n+\n+\trte_intr_efd_disable(intr_handle);\n+\trte_intr_vec_list_free(intr_handle);\n+}\ndiff --git a/drivers/net/sssnic/sssnic_ethdev_rx.h b/drivers/net/sssnic/sssnic_ethdev_rx.h\nindex c6ddc366d5..77a116f4a5 100644\n--- a/drivers/net/sssnic/sssnic_ethdev_rx.h\n+++ b/drivers/net/sssnic/sssnic_ethdev_rx.h\n@@ -24,5 +24,11 @@ int sssnic_ethdev_rx_queue_start(struct rte_eth_dev *ethdev, uint16_t queue_id);\n int sssnic_ethdev_rx_queue_stop(struct rte_eth_dev *ethdev, uint16_t queue_id);\n int sssnic_ethdev_rx_queue_all_start(struct rte_eth_dev *ethdev);\n int sssnic_ethdev_rx_queue_all_stop(struct rte_eth_dev *ethdev);\n+int sssnic_ethdev_rx_queue_intr_enable(struct rte_eth_dev *ethdev,\n+\tuint16_t qid);\n+int sssnic_ethdev_rx_queue_intr_disable(struct rte_eth_dev *ethdev,\n+\tuint16_t qid);\n+int sssnic_ethdev_rx_intr_init(struct rte_eth_dev *ethdev);\n+void sssnic_ethdev_rx_intr_shutdown(struct rte_eth_dev *ethdev);\n \n #endif\n", "prefixes": [ "v3", "18/32" ] }