Patch Comment List
List patch comments
GET /api/patches/131/comments/?format=api&order=submitter
[ { "id": 347, "web_url": "https://patches.dpdk.org/comment/347/", "msgid": "<53E9C96F.6050904@6wind.com>", "list_archive_url": "https://inbox.dpdk.org/dev/53E9C96F.6050904@6wind.com", "date": "2014-08-12T07:59:43", "subject": "Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "submitter": { "id": 8, "url": "https://patches.dpdk.org/api/people/8/?format=api", "name": "Olivier Matz", "email": "olivier.matz@6wind.com" }, "content": "Hi Bruce,\n\nOn 08/11/2014 11:45 PM, Stephen Hemminger wrote:\n> On Mon, 11 Aug 2014 21:44:37 +0100\n> Bruce Richardson <bruce.richardson@intel.com> wrote:\n>\n>> From: Olivier Matz <olivier.matz@6wind.com>\n>>\n>> It seems that RTE_MBUF_SCATTER_GATHER is not the proper name for the\n>> feature it provides. \"Scatter gather\" means that data is stored using\n>> several buffers. RTE_MBUF_REFCNT seems to be a better name for that\n>> feature as it provides a reference counter for mbufs.\n>>\n>> The macro RTE_MBUF_SCATTER_GATHER is poisoned to ensure this\n>> modification is seen by drivers or applications using it.\n>>\n>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n>> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAfter applying this first patch, I still get references to\n\"scatter gather\":\n\n$ git grep RTE_MBUF_SCATTER_GATHER\nexamples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) += ip_fragmentation\nexamples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) += ipv4_multicast\nexamples/ip_fragmentation/Makefile:ifneq \n($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\nexamples/ip_fragmentation/Makefile:$(error This application requires \nRTE_MBUF_SCATTER_GATHER to be enabled)\nexamples/ip_pipeline/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\nlib/librte_mbuf/rte_mbuf.h:#pragma GCC poison RTE_MBUF_SCATTER_GATHER\nlib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\nlib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\n\nOlivier", "headers": { "Return-Path": "<olivier.matz@6wind.com>", "Received": [ "from mail-wi0-f169.google.com (mail-wi0-f169.google.com\n\t[209.85.212.169]) by dpdk.org (Postfix) with ESMTP id 9B8A7B39D\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 09:56:51 +0200 (CEST)", "by mail-wi0-f169.google.com with SMTP id n3so6612430wiv.0\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 00:59:46 -0700 (PDT)", "from [10.16.0.195] (guy78-3-82-239-227-177.fbx.proxad.net.\n\t[82.239.227.177]) by mx.google.com with ESMTPSA id\n\tgi5sm7425968wjd.33.2014.08.12.00.59.44 for <multiple recipients>\n\t(version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128);\n\tTue, 12 Aug 2014 00:59:45 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:message-id:date:from:user-agent:mime-version:to\n\t:cc:subject:references:in-reply-to:content-type\n\t:content-transfer-encoding;\n\tbh=88K5aSyk3WrTjjB2CXNtY2BuMWMp6+7h+1mUB4Wbhbc=;\n\tb=bQvE3Egbq9yUAPRXbRYbsSDSbRpxKh/eGlXFsK9HakiZ8FcOdBzMihOUb7Opsk4c+9\n\tI+v0ZI+8IvB/7tWCQj9Aic8zNOMLpIrePJ5MQqpwACvlQUay1NyqczILxzBDo9EovVzu\n\th9d+hZJx+Lq9U/LmDEvDwO6Z5yzEfeViINKKyWk+pKPjijE+sfhP6TKLH7kitD8el6td\n\tWLO55XTb9CpvBCUsaXL3cNT93W6fEAoNOSuzH4+3DkKlmh3wUGkYzokFdJSQvdfGOmTX\n\ttRyM9Wxexq9JxJ8k+2HFAlgLjGLvzvTJcY6BDbeN/2enPOpOLWrBasUsdKP3oGwCQpkM\n\tkedw==", "X-Gm-Message-State": "ALoCoQlIsSPoak1AFmz0yIVhVZUXhMieMoTd/DmE2vEIhoiYZ3ZNlefxFYtLVVc2mr7YpPW5r8OT", "X-Received": "by 10.180.108.13 with SMTP id hg13mr31892150wib.28.1407830386002;\n\tTue, 12 Aug 2014 00:59:46 -0700 (PDT)", "Message-ID": "<53E9C96F.6050904@6wind.com>", "Date": "Tue, 12 Aug 2014 09:59:43 +0200", "From": "Olivier MATZ <olivier.matz@6wind.com>", "User-Agent": "Mozilla/5.0 (X11; Linux x86_64;\n\trv:24.0) Gecko/20100101 Icedove/24.5.0", "MIME-Version": "1.0", "To": "Bruce Richardson <bruce.richardson@intel.com>", "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>\n\t<1407789890-17355-2-git-send-email-bruce.richardson@intel.com>\n\t<20140811144521.21058e5b@haswell.linuxnetplumber.net>", "In-Reply-To": "<20140811144521.21058e5b@haswell.linuxnetplumber.net>", "Content-Type": "text/plain; charset=ISO-8859-1; format=flowed", "Content-Transfer-Encoding": "7bit", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 Aug 2014 07:56:51 -0000" }, "addressed": null }, { "id": 356, "web_url": "https://patches.dpdk.org/comment/356/", "msgid": "<59AF69C657FD0841A61C55336867B5B0343D8C21@IRSMSX103.ger.corp.intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/59AF69C657FD0841A61C55336867B5B0343D8C21@IRSMSX103.ger.corp.intel.com", "date": "2014-08-12T16:25:18", "subject": "Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "submitter": { "id": 20, "url": "https://patches.dpdk.org/api/people/20/?format=api", "name": "Bruce Richardson", "email": "bruce.richardson@intel.com" }, "content": "Ok, thanks, I'll see about fixing those.\nI see a number of comments about the format and structure of the patch set itself. I'll take those all on board, but I'll admit that I didn't rework the patchset much before submitting it as an RFC. I'm leaving that until I've finished on this and ready to start submitting non-RFC patchset for merge. Right now my primary concern is whether the reworked struct rte_mbuf has everything we need, and whether there are any performance regressions we need to fix due to the second cache line. \n\nRegards,\n/Bruce\n\n> -----Original Message-----\n> From: Olivier MATZ [mailto:olivier.matz@6wind.com]\n> Sent: Tuesday, August 12, 2014 1:00 AM\n> To: Richardson, Bruce\n> Cc: Stephen Hemminger; dev@dpdk.org\n> Subject: Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n> RTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT\n> \n> Hi Bruce,\n> \n> On 08/11/2014 11:45 PM, Stephen Hemminger wrote:\n> > On Mon, 11 Aug 2014 21:44:37 +0100\n> > Bruce Richardson <bruce.richardson@intel.com> wrote:\n> >\n> >> From: Olivier Matz <olivier.matz@6wind.com>\n> >>\n> >> It seems that RTE_MBUF_SCATTER_GATHER is not the proper name for the\n> >> feature it provides. \"Scatter gather\" means that data is stored using\n> >> several buffers. RTE_MBUF_REFCNT seems to be a better name for that\n> >> feature as it provides a reference counter for mbufs.\n> >>\n> >> The macro RTE_MBUF_SCATTER_GATHER is poisoned to ensure this\n> >> modification is seen by drivers or applications using it.\n> >>\n> >> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> >> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n> \n> After applying this first patch, I still get references to\n> \"scatter gather\":\n> \n> $ git grep RTE_MBUF_SCATTER_GATHER\n> examples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) +=\n> ip_fragmentation\n> examples/Makefile:DIRS-$(CONFIG_RTE_MBUF_SCATTER_GATHER) +=\n> ipv4_multicast\n> examples/ip_fragmentation/Makefile:ifneq\n> ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\n> examples/ip_fragmentation/Makefile:$(error This application requires\n> RTE_MBUF_SCATTER_GATHER to be enabled)\n> examples/ip_pipeline/Makefile:ifeq\n> ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\n> lib/librte_mbuf/rte_mbuf.h:#pragma GCC poison RTE_MBUF_SCATTER_GATHER\n> lib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\n> lib/librte_port/Makefile:ifeq ($(CONFIG_RTE_MBUF_SCATTER_GATHER),y)\n> \n> Olivier", "headers": { "Return-Path": "<bruce.richardson@intel.com>", "Received": [ "from mga02.intel.com (mga02.intel.com [134.134.136.20])\n\tby dpdk.org (Postfix) with ESMTP id 6E84FB3BC\n\tfor <dev@dpdk.org>; Tue, 12 Aug 2014 18:22:26 +0200 (CEST)", "from orsmga002.jf.intel.com ([10.7.209.21])\n\tby orsmga101.jf.intel.com with ESMTP; 12 Aug 2014 09:25:21 -0700", "from irsmsx103.ger.corp.intel.com ([163.33.3.157])\n\tby orsmga002.jf.intel.com with ESMTP; 12 Aug 2014 09:25:19 -0700", "from irsmsx154.ger.corp.intel.com (163.33.192.96) by\n\tIRSMSX103.ger.corp.intel.com (163.33.3.157) with Microsoft SMTP\n\tServer (TLS) id 14.3.195.1; Tue, 12 Aug 2014 17:25:19 +0100", "from irsmsx103.ger.corp.intel.com ([169.254.3.131]) by\n\tIRSMSX154.ger.corp.intel.com ([169.254.12.156]) with mapi id\n\t14.03.0195.001; Tue, 12 Aug 2014 17:25:18 +0100" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.01,849,1400050800\"; d=\"scan'208\";a=\"587075875\"", "From": "\"Richardson, Bruce\" <bruce.richardson@intel.com>", "To": "Olivier MATZ <olivier.matz@6wind.com>", "Thread-Topic": "[dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "Thread-Index": "AQHPtaUhN4m7oQul1EulENGzNX7FrpvL3wuAgACrp4CAAJwbcA==", "Date": "Tue, 12 Aug 2014 16:25:18 +0000", "Message-ID": "<59AF69C657FD0841A61C55336867B5B0343D8C21@IRSMSX103.ger.corp.intel.com>", "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>\n\t<1407789890-17355-2-git-send-email-bruce.richardson@intel.com>\n\t<20140811144521.21058e5b@haswell.linuxnetplumber.net>\n\t<53E9C96F.6050904@6wind.com>", "In-Reply-To": "<53E9C96F.6050904@6wind.com>", "Accept-Language": "en-GB, en-US", "Content-Language": "en-US", "X-MS-Has-Attach": "", "X-MS-TNEF-Correlator": "", "x-originating-ip": "[163.33.239.180]", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "quoted-printable", "MIME-Version": "1.0", "Cc": "\"dev@dpdk.org\" <dev@dpdk.org>", "Subject": "Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Tue, 12 Aug 2014 16:22:27 -0000" }, "addressed": null }, { "id": 336, "web_url": "https://patches.dpdk.org/comment/336/", "msgid": "<20140811144521.21058e5b@haswell.linuxnetplumber.net>", "list_archive_url": "https://inbox.dpdk.org/dev/20140811144521.21058e5b@haswell.linuxnetplumber.net", "date": "2014-08-11T21:45:21", "subject": "Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "content": "On Mon, 11 Aug 2014 21:44:37 +0100\nBruce Richardson <bruce.richardson@intel.com> wrote:\n\n> From: Olivier Matz <olivier.matz@6wind.com>\n> \n> It seems that RTE_MBUF_SCATTER_GATHER is not the proper name for the\n> feature it provides. \"Scatter gather\" means that data is stored using\n> several buffers. RTE_MBUF_REFCNT seems to be a better name for that\n> feature as it provides a reference counter for mbufs.\n> \n> The macro RTE_MBUF_SCATTER_GATHER is poisoned to ensure this\n> modification is seen by drivers or applications using it.\n> \n> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>\n> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>\n\nAcked-by: Stephen Hemminger <stephen@networkplumber.org>", "headers": { "Return-Path": "<stephen@networkplumber.org>", "Received": [ "from mail-pd0-f169.google.com (mail-pd0-f169.google.com\n\t[209.85.192.169]) by dpdk.org (Postfix) with ESMTP id 54D2FB39D\n\tfor <dev@dpdk.org>; Mon, 11 Aug 2014 23:42:33 +0200 (CEST)", "by mail-pd0-f169.google.com with SMTP id y10so11520987pdj.0\n\tfor <dev@dpdk.org>; Mon, 11 Aug 2014 14:45:24 -0700 (PDT)", "from haswell.linuxnetplumber.net\n\t(static-50-53-65-80.bvtn.or.frontiernet.net. [50.53.65.80])\n\tby mx.google.com with ESMTPSA id\n\twd7sm5757089pab.47.2014.08.11.14.45.24 for <multiple recipients>\n\t(version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\n\tMon, 11 Aug 2014 14:45:24 -0700 (PDT)" ], "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20130820;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to\n\t:references:mime-version:content-type:content-transfer-encoding;\n\tbh=gTzeYZ/7EqyaWj0u/HiBS86noXydUNZDVk4C3WrrnrI=;\n\tb=OpvGQ4opX5nBh7rmIz+xPAoz8oTfGd06EyQNAPvLkZPQzTLfs6YtGRMefwK5qIsbCk\n\tMb/J1pPm6EVVzPEA/i0KVXyJuCKZkZhhIAhjPwvTCY9p5s+aFPuL9HXxBU8Mf0vMWFa5\n\t70Brct2YeJRlFNnNHjHQeaEHU0xIoDCYGpQckTLvue22MPLYlNYMREgpIQzEGbEJ1YCv\n\tJGFfr9a9jfFpW8j7S7OA8xj8UaQrOOCKGk0QGH3pMz0U6aV8thzXR/yO1KNTnzgsdg53\n\t99+iBKeAoiqSn/68XOpeky/9Va61MZyYfzVRgVOvMEO5AYTofmTBIP4FiB2gvi7oyTUP\n\te7Kg==", "X-Gm-Message-State": "ALoCoQnpnPIr/7wb+CnoNLhEgW03P2fQJukEYiWz/By7slpm4xrdx09cOC7XIFh+75ioqjBiNAC0", "X-Received": "by 10.66.121.168 with SMTP id ll8mr441352pab.86.1407793524825;\n\tMon, 11 Aug 2014 14:45:24 -0700 (PDT)", "Date": "Mon, 11 Aug 2014 14:45:21 -0700", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "Bruce Richardson <bruce.richardson@intel.com>", "Message-ID": "<20140811144521.21058e5b@haswell.linuxnetplumber.net>", "In-Reply-To": "<1407789890-17355-2-git-send-email-bruce.richardson@intel.com>", "References": "<1407789890-17355-1-git-send-email-bruce.richardson@intel.com>\n\t<1407789890-17355-2-git-send-email-bruce.richardson@intel.com>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=US-ASCII", "Content-Transfer-Encoding": "7bit", "Cc": "dev@dpdk.org", "Subject": "Re: [dpdk-dev] [RFC PATCH 01/14] mbuf: rename\n\tRTE_MBUF_SCATTER_GATHER into RTE_MBUF_REFCNT", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "X-List-Received-Date": "Mon, 11 Aug 2014 21:42:33 -0000" }, "addressed": null } ]