Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130963/?format=api
{ "id": 130963, "url": "https://patches.dpdk.org/api/patches/130963/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230831095650.219964-31-wanry@3snic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230831095650.219964-31-wanry@3snic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230831095650.219964-31-wanry@3snic.com", "date": "2023-08-31T09:56:48", "name": "[v2,30/32] net/sssnic: support VLAN offload and filter", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "d37431af470a930f462316c69800d19d4f79feaf", "submitter": { "id": 3119, "url": "https://patches.dpdk.org/api/people/3119/?format=api", "name": "Renyong Wan", "email": "wanry@3snic.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230831095650.219964-31-wanry@3snic.com/mbox/", "series": [ { "id": 29383, "url": "https://patches.dpdk.org/api/series/29383/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29383", "date": "2023-08-31T09:56:18", "name": "Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters", "version": 2, "mbox": "https://patches.dpdk.org/series/29383/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/130963/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/130963/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id BC54041FDB;\n\tThu, 31 Aug 2023 12:01:43 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 131D141104;\n\tThu, 31 Aug 2023 11:58:37 +0200 (CEST)", "from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])\n by mails.dpdk.org (Postfix) with ESMTP id 18BA940DCA\n for <dev@dpdk.org>; Thu, 31 Aug 2023 11:58:27 +0200 (CEST)", "from V12DG1MBS03.ramaxel.local ([172.26.18.33])\n by VLXDG1SPAM1.ramaxel.com with ESMTP id 37V9vpHs064431;\n Thu, 31 Aug 2023 17:57:51 +0800 (GMT-8)\n (envelope-from wanry@3snic.com)", "from localhost.localdomain (10.64.136.151) by\n V12DG1MBS03.ramaxel.local (172.26.18.33) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2375.17; Thu, 31 Aug 2023 17:57:50 +0800" ], "From": "<wanry@3snic.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, Renyong Wan <wanry@3snic.com>, Steven Song\n <steven.song@3snic.com>", "Subject": "[PATCH v2 30/32] net/sssnic: support VLAN offload and filter", "Date": "Thu, 31 Aug 2023 17:56:48 +0800", "Message-ID": "<20230831095650.219964-31-wanry@3snic.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230831095650.219964-1-wanry@3snic.com>", "References": "<20230831095650.219964-1-wanry@3snic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.64.136.151]", "X-ClientProxiedBy": "V12DG1MBS03.ramaxel.local (172.26.18.33) To\n V12DG1MBS03.ramaxel.local (172.26.18.33)", "X-DNSRBL": "", "X-SPAM-SOURCE-CHECK": "pass", "X-MAIL": "VLXDG1SPAM1.ramaxel.com 37V9vpHs064431", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Renyong Wan <wanry@3snic.com>\n\nSigned-off-by: Steven Song <steven.song@3snic.com>\nSigned-off-by: Renyong Wan <wanry@3snic.com>\n---\n doc/guides/nics/features/sssnic.ini | 2 +\n drivers/net/sssnic/base/sssnic_api.c | 34 +++++++++++\n drivers/net/sssnic/base/sssnic_api.h | 1 +\n drivers/net/sssnic/base/sssnic_cmd.h | 9 +++\n drivers/net/sssnic/sssnic_ethdev.c | 87 ++++++++++++++++++++++++++++\n 5 files changed, 133 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/sssnic.ini b/doc/guides/nics/features/sssnic.ini\nindex 9bf05cb968..f5738ac934 100644\n--- a/doc/guides/nics/features/sssnic.ini\n+++ b/doc/guides/nics/features/sssnic.ini\n@@ -19,6 +19,8 @@ RSS hash = Y\n RSS key update = Y\n RSS reta update = Y\n Inner RSS = Y\n+VLAN filter = Y\n+VLAN offload = Y\n L3 checksum offload = Y\n L4 checksum offload = Y\n Inner L3 checksum = Y\ndiff --git a/drivers/net/sssnic/base/sssnic_api.c b/drivers/net/sssnic/base/sssnic_api.c\nindex d91896cdd2..68c16c9c1e 100644\n--- a/drivers/net/sssnic/base/sssnic_api.c\n+++ b/drivers/net/sssnic/base/sssnic_api.c\n@@ -1601,3 +1601,37 @@ sssnic_flow_ctrl_get(struct sssnic_hw *hw, bool *autoneg, bool *rx_en,\n \n \treturn 0;\n }\n+\n+int\n+sssnic_vlan_filter_set(struct sssnic_hw *hw, uint16_t vid, bool add)\n+{\n+\tint ret;\n+\tstruct sssnic_vlan_filter_set_cmd cmd;\n+\tstruct sssnic_msg msg;\n+\tuint32_t cmd_len;\n+\n+\tmemset(&cmd, 0, sizeof(cmd));\n+\tcmd.function = SSSNIC_FUNC_IDX(hw);\n+\tcmd.add = add ? 1 : 0;\n+\tcmd.vid = vid;\n+\tcmd_len = sizeof(cmd);\n+\n+\tsssnic_msg_init(&msg, (uint8_t *)&cmd, cmd_len,\n+\t\tSSSNIC_SET_PORT_VLAN_FILTER_CMD, SSSNIC_MPU_FUNC_IDX,\n+\t\tSSSNIC_LAN_MODULE, SSSNIC_MSG_TYPE_REQ);\n+\n+\tret = sssnic_mbox_send(hw, &msg, (uint8_t *)&cmd, &cmd_len, 0);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to send mbox message, ret=%d\", ret);\n+\t\treturn ret;\n+\t}\n+\n+\tif (cmd_len == 0 || cmd.common.status != 0) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Bad response to SSSNIC_SET_PORT_VLAN_FILTER_CMD, len=%u, status=%u\",\n+\t\t\tcmd_len, cmd.common.status);\n+\t\treturn -EIO;\n+\t}\n+\n+\treturn 0;\n+}\ndiff --git a/drivers/net/sssnic/base/sssnic_api.h b/drivers/net/sssnic/base/sssnic_api.h\nindex 36544a5dc3..28b235dda2 100644\n--- a/drivers/net/sssnic/base/sssnic_api.h\n+++ b/drivers/net/sssnic/base/sssnic_api.h\n@@ -469,5 +469,6 @@ int sssnic_flow_ctrl_set(struct sssnic_hw *hw, bool autoneg, bool rx_en,\n \tbool tx_en);\n int sssnic_flow_ctrl_get(struct sssnic_hw *hw, bool *autoneg, bool *rx_en,\n \tbool *tx_en);\n+int sssnic_vlan_filter_set(struct sssnic_hw *hw, uint16_t vid, bool add);\n \n #endif /* _SSSNIC_API_H_ */\ndiff --git a/drivers/net/sssnic/base/sssnic_cmd.h b/drivers/net/sssnic/base/sssnic_cmd.h\nindex d2054fad5a..3e70d0e223 100644\n--- a/drivers/net/sssnic/base/sssnic_cmd.h\n+++ b/drivers/net/sssnic/base/sssnic_cmd.h\n@@ -425,4 +425,13 @@ struct sssnic_flow_ctrl_cmd {\n \tuint8_t resvd1[5];\n };\n \n+struct sssnic_vlan_filter_set_cmd {\n+\tstruct sssnic_cmd_common common;\n+\tuint16_t function;\n+\tuint8_t add;\n+\tuint8_t resvd0;\n+\tuint16_t vid;\n+\tuint16_t resvd1;\n+};\n+\n #endif /* _SSSNIC_CMD_H_ */\ndiff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c\nindex 8999693027..8a1ccff70b 100644\n--- a/drivers/net/sssnic/sssnic_ethdev.c\n+++ b/drivers/net/sssnic/sssnic_ethdev.c\n@@ -16,6 +16,7 @@\n #include \"sssnic_ethdev_rss.h\"\n \n static int sssnic_ethdev_init(struct rte_eth_dev *ethdev);\n+static void sssnic_ethdev_vlan_filter_clean(struct rte_eth_dev *ethdev);\n \n static int\n sssnic_ethdev_infos_get(struct rte_eth_dev *ethdev,\n@@ -340,6 +341,7 @@ sssnic_ethdev_release(struct rte_eth_dev *ethdev)\n {\n \tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);\n \n+\tsssnic_ethdev_vlan_filter_clean(ethdev);\n \tsssnic_ethdev_link_intr_disable(ethdev);\n \tsssnic_ethdev_tx_queue_all_release(ethdev);\n \tsssnic_ethdev_rx_queue_all_release(ethdev);\n@@ -821,6 +823,89 @@ sssnic_ethdev_flow_ctrl_get(struct rte_eth_dev *ethdev,\n \treturn 0;\n }\n \n+static int\n+sssnic_ethdev_vlan_offload_set(struct rte_eth_dev *ethdev, int mask)\n+{\n+\tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);\n+\tstruct rte_eth_conf *dev_conf = ðdev->data->dev_conf;\n+\tuint8_t vlan_strip_en;\n+\tuint32_t vlan_filter_en;\n+\tint ret;\n+\n+\tif (mask & RTE_ETH_VLAN_STRIP_MASK) {\n+\t\tif (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_STRIP)\n+\t\t\tvlan_strip_en = 1;\n+\t\telse\n+\t\t\tvlan_strip_en = 0;\n+\n+\t\tret = sssnic_vlan_strip_enable_set(hw, vlan_strip_en);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to %s vlan strip offload\",\n+\t\t\t\tvlan_strip_en ? \"enable\" : \"disable\");\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\tif (mask & RTE_ETH_VLAN_FILTER_MASK) {\n+\t\tif (dev_conf->rxmode.offloads & RTE_ETH_RX_OFFLOAD_VLAN_FILTER)\n+\t\t\tvlan_filter_en = 1;\n+\t\telse\n+\t\t\tvlan_filter_en = 0;\n+\n+\t\tret = sssnic_vlan_filter_enable_set(hw, vlan_filter_en);\n+\t\tif (ret != 0) {\n+\t\t\tPMD_DRV_LOG(ERR, \"Failed to %s vlan filter offload\",\n+\t\t\t\tvlan_filter_en ? \"enable\" : \"disable\");\n+\t\t\treturn ret;\n+\t\t}\n+\t}\n+\n+\treturn 0;\n+}\n+\n+static int\n+sssnic_ethdev_vlan_filter_get(struct rte_eth_dev *ethdev, uint16_t vlan_id)\n+{\n+\tstruct rte_vlan_filter_conf *vfc = ðdev->data->vlan_filter_conf;\n+\tint vidx = vlan_id / 64;\n+\tint vbit = vlan_id % 64;\n+\n+\treturn !!(vfc->ids[vidx] & RTE_BIT64(vbit));\n+}\n+\n+static int\n+sssnic_ethdev_vlan_filter_set(struct rte_eth_dev *ethdev, uint16_t vlan_id,\n+\tint on)\n+{\n+\tstruct sssnic_hw *hw = SSSNIC_ETHDEV_TO_HW(ethdev);\n+\tint ret;\n+\n+\tif (sssnic_ethdev_vlan_filter_get(ethdev, vlan_id) == !!on)\n+\t\treturn 0;\n+\n+\tret = sssnic_vlan_filter_set(hw, vlan_id, !!on);\n+\tif (ret) {\n+\t\tPMD_DRV_LOG(ERR,\n+\t\t\t\"Failed to %s VLAN filter, vlan_id: %u, port: %u\",\n+\t\t\ton ? \"add\" : \"remove\", vlan_id, ethdev->data->port_id);\n+\t\treturn ret;\n+\t}\n+\n+\tPMD_DRV_LOG(DEBUG, \"%s VLAN %u filter to port %u\",\n+\t\ton ? \"Added\" : \"Removed\", vlan_id, ethdev->data->port_id);\n+\n+\treturn 0;\n+}\n+\n+static void\n+sssnic_ethdev_vlan_filter_clean(struct rte_eth_dev *ethdev)\n+{\n+\tuint16_t vlan_id;\n+\n+\tfor (vlan_id = 0; vlan_id <= RTE_ETHER_MAX_VLAN_ID; vlan_id++)\n+\t\tsssnic_ethdev_vlan_filter_set(ethdev, vlan_id, 0);\n+}\n+\n static const struct eth_dev_ops sssnic_ethdev_ops = {\n \t.dev_start = sssnic_ethdev_start,\n \t.dev_stop = sssnic_ethdev_stop,\n@@ -864,6 +949,8 @@ static const struct eth_dev_ops sssnic_ethdev_ops = {\n \t.fw_version_get = sssnic_ethdev_fw_version_get,\n \t.flow_ctrl_set = sssnic_ethdev_flow_ctrl_set,\n \t.flow_ctrl_get = sssnic_ethdev_flow_ctrl_get,\n+\t.vlan_offload_set = sssnic_ethdev_vlan_offload_set,\n+\t.vlan_filter_set = sssnic_ethdev_vlan_filter_set,\n };\n \n static int\n", "prefixes": [ "v2", "30/32" ] }