Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130799/?format=api
{ "id": 130799, "url": "https://patches.dpdk.org/api/patches/130799/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230829075829.208413-18-wanry@3snic.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230829075829.208413-18-wanry@3snic.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230829075829.208413-18-wanry@3snic.com", "date": "2023-08-29T07:58:14", "name": "[17/32] net/sssnic: support Tx queue start and stop", "commit_ref": null, "pull_url": null, "state": "superseded", "archived": true, "hash": "db6bd9be41b04b761cc2867e78f9a62e23dd3783", "submitter": { "id": 3119, "url": "https://patches.dpdk.org/api/people/3119/?format=api", "name": "Renyong Wan", "email": "wanry@3snic.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230829075829.208413-18-wanry@3snic.com/mbox/", "series": [ { "id": 29358, "url": "https://patches.dpdk.org/api/series/29358/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29358", "date": "2023-08-29T07:57:57", "name": "Introduce sssnic PMD for 3SNIC's 9x0 serials Ethernet adapters", "version": 1, "mbox": "https://patches.dpdk.org/series/29358/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/130799/comments/", "check": "warning", "checks": "https://patches.dpdk.org/api/patches/130799/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 9FCC241F53;\n\tTue, 29 Aug 2023 10:00:51 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 237D5402B2;\n\tTue, 29 Aug 2023 10:00:06 +0200 (CEST)", "from VLXDG1SPAM1.ramaxel.com (email.unionmem.com [221.4.138.186])\n by mails.dpdk.org (Postfix) with ESMTP id DD8A5402C9\n for <dev@dpdk.org>; Tue, 29 Aug 2023 09:59:57 +0200 (CEST)", "from V12DG1MBS03.ramaxel.local ([172.26.18.33])\n by VLXDG1SPAM1.ramaxel.com with ESMTP id 37T7wrMC080563;\n Tue, 29 Aug 2023 15:59:17 +0800 (GMT-8)\n (envelope-from wanry@3snic.com)", "from localhost.localdomain (10.64.136.151) by\n V12DG1MBS03.ramaxel.local (172.26.18.33) with Microsoft SMTP Server\n (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id\n 15.1.2375.17; Tue, 29 Aug 2023 15:58:44 +0800" ], "From": "<wanry@3snic.com>", "To": "<dev@dpdk.org>", "CC": "<ferruh.yigit@amd.com>, Renyong Wan <wanry@3snic.com>, Steven Song\n <steven.song@3snic.com>", "Subject": "[PATCH 17/32] net/sssnic: support Tx queue start and stop", "Date": "Tue, 29 Aug 2023 15:58:14 +0800", "Message-ID": "<20230829075829.208413-18-wanry@3snic.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230829075829.208413-1-wanry@3snic.com>", "References": "<20230829075829.208413-1-wanry@3snic.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "7bit", "Content-Type": "text/plain", "X-Originating-IP": "[10.64.136.151]", "X-ClientProxiedBy": "V12DG1MBS03.ramaxel.local (172.26.18.33) To\n V12DG1MBS03.ramaxel.local (172.26.18.33)", "X-DNSRBL": "", "X-SPAM-SOURCE-CHECK": "pass", "X-MAIL": "VLXDG1SPAM1.ramaxel.com 37T7wrMC080563", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Renyong Wan <wanry@3snic.com>\n\nSigned-off-by: Steven Song <steven.song@3snic.com>\nSigned-off-by: Renyong Wan <wanry@3snic.com>\n---\n doc/guides/nics/features/sssnic.ini | 1 +\n drivers/net/sssnic/sssnic_ethdev.c | 2 +\n drivers/net/sssnic/sssnic_ethdev_tx.c | 155 ++++++++++++++++++++++++++\n drivers/net/sssnic/sssnic_ethdev_tx.h | 4 +\n 4 files changed, 162 insertions(+)", "diff": "diff --git a/doc/guides/nics/features/sssnic.ini b/doc/guides/nics/features/sssnic.ini\nindex 82b527ba26..b75c68cb33 100644\n--- a/doc/guides/nics/features/sssnic.ini\n+++ b/doc/guides/nics/features/sssnic.ini\n@@ -6,6 +6,7 @@\n [Features]\n Link status = Y\n Link status event = Y\n+Queue start/stop = Y\n Unicast MAC filter = Y\n Multicast MAC filter = Y\n Linux = Y\ndiff --git a/drivers/net/sssnic/sssnic_ethdev.c b/drivers/net/sssnic/sssnic_ethdev.c\nindex 8822e5a17b..f474aeadd8 100644\n--- a/drivers/net/sssnic/sssnic_ethdev.c\n+++ b/drivers/net/sssnic/sssnic_ethdev.c\n@@ -361,6 +361,8 @@ static const struct eth_dev_ops sssnic_ethdev_ops = {\n \t.tx_queue_release = sssnic_ethdev_tx_queue_release,\n \t.rx_queue_start = sssnic_ethdev_rx_queue_start,\n \t.rx_queue_stop = sssnic_ethdev_rx_queue_stop,\n+\t.tx_queue_start = sssnic_ethdev_tx_queue_start,\n+\t.tx_queue_stop = sssnic_ethdev_tx_queue_stop,\n };\n \n static int\ndiff --git a/drivers/net/sssnic/sssnic_ethdev_tx.c b/drivers/net/sssnic/sssnic_ethdev_tx.c\nindex 052bbaf777..8a2aa372c1 100644\n--- a/drivers/net/sssnic/sssnic_ethdev_tx.c\n+++ b/drivers/net/sssnic/sssnic_ethdev_tx.c\n@@ -192,6 +192,18 @@ sssnic_ethdev_txq_ci_get(struct sssnic_ethdev_txq *txq)\n \treturn sssnic_workq_ci_get(txq->workq);\n }\n \n+static inline int\n+sssnic_ethdev_txq_pi_get(struct sssnic_ethdev_txq *txq)\n+{\n+\treturn sssnic_workq_pi_get(txq->workq);\n+}\n+\n+static inline uint16_t\n+sssnic_ethdev_txq_hw_ci_get(struct sssnic_ethdev_txq *txq)\n+{\n+\treturn *txq->hw_ci_addr & txq->idx_mask;\n+}\n+\n static inline void\n sssnic_ethdev_txq_consume(struct sssnic_ethdev_txq *txq, uint16_t num_entries)\n {\n@@ -353,3 +365,146 @@ sssnic_ethdev_tx_queue_all_release(struct rte_eth_dev *ethdev)\n \tfor (qid = 0; qid < ethdev->data->nb_tx_queues; qid++)\n \t\tsssnic_ethdev_tx_queue_release(ethdev, qid);\n }\n+\n+#define SSSNIC_ETHDEV_TX_FREE_BULK 64\n+static inline int\n+sssnic_ethdev_txq_pktmbufs_cleanup(struct sssnic_ethdev_txq *txq)\n+{\n+\tstruct sssnic_ethdev_tx_entry *txe;\n+\tstruct rte_mbuf *free_pkts[SSSNIC_ETHDEV_TX_FREE_BULK];\n+\tuint16_t num_free_pkts = 0;\n+\tuint16_t hw_ci, ci, id_mask;\n+\tuint16_t count = 0;\n+\tint num_entries;\n+\n+\tci = sssnic_ethdev_txq_ci_get(txq);\n+\thw_ci = sssnic_ethdev_txq_hw_ci_get(txq);\n+\tid_mask = txq->idx_mask;\n+\tnum_entries = sssnic_ethdev_txq_num_used_entries(txq);\n+\n+\twhile (num_entries > 0) {\n+\t\ttxe = &txq->txe[ci];\n+\n+\t\t/* HW has not consumed enough entries of current packet */\n+\t\tif (((hw_ci - ci) & id_mask) < txe->num_workq_entries)\n+\t\t\tbreak;\n+\n+\t\tnum_entries -= txe->num_workq_entries;\n+\t\tcount += txe->num_workq_entries;\n+\t\tci = (ci + txe->num_workq_entries) & id_mask;\n+\n+\t\tif (likely(txe->pktmbuf->nb_segs == 1)) {\n+\t\t\tstruct rte_mbuf *pkt =\n+\t\t\t\trte_pktmbuf_prefree_seg(txe->pktmbuf);\n+\t\t\ttxe->pktmbuf = NULL;\n+\n+\t\t\tif (unlikely(pkt == NULL))\n+\t\t\t\tcontinue;\n+\n+\t\t\tfree_pkts[num_free_pkts++] = pkt;\n+\t\t\tif (unlikely(pkt->pool != free_pkts[0]->pool ||\n+\t\t\t\t num_free_pkts >=\n+\t\t\t\t\t SSSNIC_ETHDEV_TX_FREE_BULK)) {\n+\t\t\t\trte_mempool_put_bulk(free_pkts[0]->pool,\n+\t\t\t\t\t(void **)free_pkts, num_free_pkts - 1);\n+\t\t\t\tnum_free_pkts = 0;\n+\t\t\t\tfree_pkts[num_free_pkts++] = pkt;\n+\t\t\t}\n+\t\t} else {\n+\t\t\trte_pktmbuf_free(txe->pktmbuf);\n+\t\t\ttxe->pktmbuf = NULL;\n+\t\t}\n+\t}\n+\n+\tif (num_free_pkts > 0)\n+\t\trte_mempool_put_bulk(free_pkts[0]->pool, (void **)free_pkts,\n+\t\t\tnum_free_pkts);\n+\n+\tsssnic_ethdev_txq_consume(txq, count);\n+\n+\treturn count;\n+}\n+\n+#define SSSNIC_ETHDEV_TXQ_FUSH_TIMEOUT 3000 /* 3 seconds */\n+static int\n+sssnic_ethdev_txq_flush(struct sssnic_ethdev_txq *txq)\n+{\n+\tuint64_t timeout;\n+\tuint16_t used_entries;\n+\n+\ttimeout = rte_get_timer_cycles() +\n+\t\t rte_get_timer_hz() * SSSNIC_ETHDEV_TXQ_FUSH_TIMEOUT / 1000;\n+\n+\tdo {\n+\t\tsssnic_ethdev_txq_pktmbufs_cleanup(txq);\n+\t\tused_entries = sssnic_ethdev_txq_num_used_entries(txq);\n+\t\tif (used_entries == 0)\n+\t\t\treturn 0;\n+\n+\t\trte_delay_us_sleep(1000);\n+\t} while (((long)(rte_get_timer_cycles() - timeout)) < 0);\n+\n+\tPMD_DRV_LOG(ERR, \"Flush port:%u txq:%u timeout, used_txq_entries:%u\",\n+\t\ttxq->port, txq->qid, sssnic_ethdev_txq_num_used_entries(txq));\n+\n+\treturn -ETIMEDOUT;\n+}\n+\n+int\n+sssnic_ethdev_tx_queue_start(struct rte_eth_dev *ethdev, uint16_t queue_id)\n+{\n+\tstruct sssnic_netdev *netdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\n+\tethdev->data->tx_queue_state[queue_id] = RTE_ETH_QUEUE_STATE_STARTED;\n+\tnetdev->num_started_txqs++;\n+\n+\tPMD_DRV_LOG(DEBUG, \"port %u txq %u started\", ethdev->data->port_id,\n+\t\tqueue_id);\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_ethdev_tx_queue_stop(struct rte_eth_dev *ethdev, uint16_t queue_id)\n+{\n+\tint ret;\n+\tstruct sssnic_netdev *netdev = SSSNIC_ETHDEV_PRIVATE(ethdev);\n+\tstruct sssnic_ethdev_txq *txq = ethdev->data->tx_queues[queue_id];\n+\n+\tret = sssnic_ethdev_txq_flush(txq);\n+\tif (ret != 0) {\n+\t\tPMD_DRV_LOG(ERR, \"Failed to flush port %u txq %u\",\n+\t\t\tethdev->data->port_id, queue_id);\n+\t\treturn ret;\n+\t}\n+\n+\tethdev->data->tx_queue_state[queue_id] = RTE_ETH_QUEUE_STATE_STOPPED;\n+\tnetdev->num_started_txqs--;\n+\n+\tPMD_DRV_LOG(DEBUG, \"port %u txq %u stopped\", ethdev->data->port_id,\n+\t\tqueue_id);\n+\n+\treturn 0;\n+}\n+\n+int\n+sssnic_ethdev_tx_queue_all_start(struct rte_eth_dev *ethdev)\n+{\n+\tuint16_t qid;\n+\tuint16_t numq = ethdev->data->nb_tx_queues;\n+\n+\tfor (qid = 0; qid < numq; qid++)\n+\t\tsssnic_ethdev_tx_queue_start(ethdev, qid);\n+\n+\treturn 0;\n+}\n+\n+void\n+sssnic_ethdev_tx_queue_all_stop(struct rte_eth_dev *ethdev)\n+{\n+\tuint16_t qid;\n+\tuint16_t numq = ethdev->data->nb_tx_queues;\n+\n+\tfor (qid = 0; qid < numq; qid++)\n+\t\tsssnic_ethdev_tx_queue_stop(ethdev, qid);\n+}\ndiff --git a/drivers/net/sssnic/sssnic_ethdev_tx.h b/drivers/net/sssnic/sssnic_ethdev_tx.h\nindex bd1d721e37..3de9e899a0 100644\n--- a/drivers/net/sssnic/sssnic_ethdev_tx.h\n+++ b/drivers/net/sssnic/sssnic_ethdev_tx.h\n@@ -23,5 +23,9 @@ int sssnic_ethdev_tx_queue_setup(struct rte_eth_dev *ethdev,\n void sssnic_ethdev_tx_queue_release(struct rte_eth_dev *ethdev,\n \tuint16_t queue_id);\n void sssnic_ethdev_tx_queue_all_release(struct rte_eth_dev *ethdev);\n+int sssnic_ethdev_tx_queue_start(struct rte_eth_dev *ethdev, uint16_t queue_id);\n+int sssnic_ethdev_tx_queue_stop(struct rte_eth_dev *ethdev, uint16_t queue_id);\n+int sssnic_ethdev_tx_queue_all_start(struct rte_eth_dev *ethdev);\n+void sssnic_ethdev_tx_queue_all_stop(struct rte_eth_dev *ethdev);\n \n #endif /* _SSSNIC_ETHDEV_TX_H_ */\n", "prefixes": [ "17/32" ] }