Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/130591/?format=api
{ "id": 130591, "url": "https://patches.dpdk.org/api/patches/130591/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230821160921.383832-2-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230821160921.383832-2-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230821160921.383832-2-stephen@networkplumber.org", "date": "2023-08-21T16:09:01", "name": "[v13,01/21] gso: don't log message on non TCP/UDP", "commit_ref": null, "pull_url": null, "state": "changes-requested", "archived": true, "hash": "9adfb914ac1c424a573cf598e81382532b82bfee", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 24651, "url": "https://patches.dpdk.org/api/users/24651/?format=api", "username": "dmarchand", "first_name": "David", "last_name": "Marchand", "email": "david.marchand@redhat.com" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230821160921.383832-2-stephen@networkplumber.org/mbox/", "series": [ { "id": 29298, "url": "https://patches.dpdk.org/api/series/29298/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29298", "date": "2023-08-21T16:09:00", "name": "Convert static log types in libraries to dynamic types", "version": 13, "mbox": "https://patches.dpdk.org/series/29298/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/130591/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/130591/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 626EF430C3;\n\tMon, 21 Aug 2023 18:09:53 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 521AA42FB2;\n\tMon, 21 Aug 2023 18:09:53 +0200 (CEST)", "from mail-pf1-f180.google.com (mail-pf1-f180.google.com\n [209.85.210.180])\n by mails.dpdk.org (Postfix) with ESMTP id 1799042B8B\n for <dev@dpdk.org>; Mon, 21 Aug 2023 18:09:51 +0200 (CEST)", "by mail-pf1-f180.google.com with SMTP id\n d2e1a72fcca58-68a3de5f231so815009b3a.0\n for <dev@dpdk.org>; Mon, 21 Aug 2023 09:09:51 -0700 (PDT)", "from hermes.local (204-195-127-207.wavecable.com. [204.195.127.207])\n by smtp.gmail.com with ESMTPSA id\n i1-20020a17090332c100b001bf2dcfe352sm7208159plr.234.2023.08.21.09.09.50\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 21 Aug 2023 09:09:50 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1692634191;\n x=1693238991;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=22sb9KeaWCIHf//+hSXs7eWusMhXwHuF7sjijeI+aRE=;\n b=Suq377ScWFNdfhIOulqEfgLCI5YfcDwNmnL57CqcQUu4Hhjo2CxbdHdqm6URlJe4PC\n 2/rATEHZCpSMIlMbLuiGau+6CoEVw8DB0QUePZroLlZ1ot/8lc5rVu86SQlFiqyMF9IX\n dpmiPXUJIJWINReHYYLXk1u3tdPS+gVVO6ag7AlGTq093iHkRBA5rU4J6XVT9HpaS4RW\n GiK1FtPbhaAZRxVlA4kZPICQCn5rI5uJ4i0c60FtymkklUF5I5Q3IDn3ObatdOzJYAT6\n ywE7iGQ1URXp2aJyKlmJEubD9V6Ez0JZVp720qzxkrI3pyavCK0PCCzcXSx24YIX2agP\n K5DQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1692634191; x=1693238991;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=22sb9KeaWCIHf//+hSXs7eWusMhXwHuF7sjijeI+aRE=;\n b=ljaGNlk4QKRD5ahNoBSS3aCn4SZ4va14guLl0kJgHfPIUaUnl4tkjYB4gEp2HMnGff\n 3CFVPn5etaRbpt3wdaQDP+jarzf0LEeTUzkMzWAUuaErei3jTT08QSC+RTEBQ0IdOO5g\n sWIDb4+1S/n3fgB5IgVUzKbbiPLccAuCNHIJoqcShfBK7P4h+uOvLuWe+KznU2HPWRkn\n OWCJ6H4UI/Kv3mW+8Q6mxJbDdjojzHf/C87IizHS1jQVs80j8dDDXVw3IRvkeQw35L8n\n 0INFOI7klSK4JQlUCSix9WYCNXCNndytsbaym+FaRKt0xYI09khUrQ2j70l5R4DjDJjV\n U5Kw==", "X-Gm-Message-State": "AOJu0Yx1Pu8wwWJ9XfY20+p1SqiGpTJEYH/L6DIdpzYpRQpwJZf6f2w/\n 2H+AHxs9Pg6YizwpbqdieMePLp7rmonYRgiAQkhJSrmX", "X-Google-Smtp-Source": "\n AGHT+IHiQUhPfesXdIZ6FkAqZz5d9EJhAiVeVsSwktlP9StRvj3R0kxbaCwHj2ieWkjyuNYfsqZYhA==", "X-Received": "by 2002:a05:6a20:969a:b0:147:d309:be7b with SMTP id\n hp26-20020a056a20969a00b00147d309be7bmr4474251pzc.62.1692634190811;\n Mon, 21 Aug 2023 09:09:50 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Stephen Hemminger <stephen@networkplumber.org>,\n Jiayu Hu <jiayu.hu@intel.com>, Mark Kavanagh <mark.b.kavanagh@intel.com>", "Subject": "[PATCH v13 01/21] gso: don't log message on non TCP/UDP", "Date": "Mon, 21 Aug 2023 09:09:01 -0700", "Message-Id": "<20230821160921.383832-2-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230821160921.383832-1-stephen@networkplumber.org>", "References": "<20230329234049.11071-1-stephen@networkplumber.org>\n <20230821160921.383832-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "If a large packet is passed into GSO routines of unknown protocol\nthen library would log a message.\nBetter to tell the application instead of logging.\n\nFixes: 119583797b6a (\"gso: support TCP/IPv4 GSO\")\nReviewed-by: Jiayu Hu <jiayu.hu@intel.com>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\n---\n lib/gso/rte_gso.c | 4 +---\n lib/gso/rte_gso.h | 1 +\n 2 files changed, 2 insertions(+), 3 deletions(-)", "diff": "diff --git a/lib/gso/rte_gso.c b/lib/gso/rte_gso.c\nindex 4b59217c16ee..e29c7d884aed 100644\n--- a/lib/gso/rte_gso.c\n+++ b/lib/gso/rte_gso.c\n@@ -80,9 +80,7 @@ rte_gso_segment(struct rte_mbuf *pkt,\n \t\tret = gso_udp4_segment(pkt, gso_size, direct_pool,\n \t\t\t\tindirect_pool, pkts_out, nb_pkts_out);\n \t} else {\n-\t\t/* unsupported packet, skip */\n-\t\tRTE_LOG(DEBUG, GSO, \"Unsupported packet type\\n\");\n-\t\tret = 0;\n+\t\tret = -ENOTSUP;\t/* only UDP or TCP allowed */\n \t}\n \n \tif (ret < 0) {\ndiff --git a/lib/gso/rte_gso.h b/lib/gso/rte_gso.h\nindex 40922524df42..c0f9a1b66ff2 100644\n--- a/lib/gso/rte_gso.h\n+++ b/lib/gso/rte_gso.h\n@@ -114,6 +114,7 @@ struct rte_gso_ctx {\n * - The number of GSO segments filled in pkts_out on success.\n * - Return 0 if it does not need to be GSO'd.\n * - Return -ENOMEM if run out of memory in MBUF pools.\n+ * - Return -ENOTSUP for protocols that can not be segmented\n * - Return -EINVAL for invalid parameters.\n */\n int rte_gso_segment(struct rte_mbuf *pkt,\n", "prefixes": [ "v13", "01/21" ] }