Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/1299/?format=api
{ "id": 1299, "url": "https://patches.dpdk.org/api/patches/1299/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/1416083649-6085-1-git-send-email-pablo.de.lara.guarch@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<1416083649-6085-1-git-send-email-pablo.de.lara.guarch@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/1416083649-6085-1-git-send-email-pablo.de.lara.guarch@intel.com", "date": "2014-11-15T20:34:09", "name": "[dpdk-dev] app/test: Removed file-prefix option in eal_flags and multiprocess unit tests for FreeBSD", "commit_ref": null, "pull_url": null, "state": "accepted", "archived": true, "hash": "2f07d4a2303de73a2b30559ffa02b935df5446af", "submitter": { "id": 9, "url": "https://patches.dpdk.org/api/people/9/?format=api", "name": "De Lara Guarch, Pablo", "email": "pablo.de.lara.guarch@intel.com" }, "delegate": null, "mbox": "https://patches.dpdk.org/project/dpdk/patch/1416083649-6085-1-git-send-email-pablo.de.lara.guarch@intel.com/mbox/", "series": [], "comments": "https://patches.dpdk.org/api/patches/1299/comments/", "check": "pending", "checks": "https://patches.dpdk.org/api/patches/1299/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@dpdk.org", "Delivered-To": "patchwork@dpdk.org", "Received": [ "from [92.243.14.124] (localhost [IPv6:::1])\n\tby dpdk.org (Postfix) with ESMTP id 944617F2D;\n\tSat, 15 Nov 2014 21:24:04 +0100 (CET)", "from mga09.intel.com (mga09.intel.com [134.134.136.24])\n\tby dpdk.org (Postfix) with ESMTP id 196B47F11\n\tfor <dev@dpdk.org>; Sat, 15 Nov 2014 21:24:02 +0100 (CET)", "from orsmga001.jf.intel.com ([10.7.209.18])\n\tby orsmga102.jf.intel.com with ESMTP; 15 Nov 2014 12:32:08 -0800", "from irvmail001.ir.intel.com ([163.33.26.43])\n\tby orsmga001.jf.intel.com with ESMTP; 15 Nov 2014 12:34:10 -0800", "from sivswdev02.ir.intel.com (sivswdev02.ir.intel.com\n\t[10.237.217.46])\n\tby irvmail001.ir.intel.com (8.14.3/8.13.6/MailSET/Hub) with ESMTP id\n\tsAFKY9g8032523 for <dev@dpdk.org>; Sat, 15 Nov 2014 20:34:09 GMT", "from sivswdev02.ir.intel.com (localhost [127.0.0.1])\n\tby sivswdev02.ir.intel.com with ESMTP id sAFKY9Mb006121\n\tfor <dev@dpdk.org>; Sat, 15 Nov 2014 20:34:09 GMT", "(from pdelarax@localhost)\n\tby sivswdev02.ir.intel.com with id sAFKY92h006117\n\tfor dev@dpdk.org; Sat, 15 Nov 2014 20:34:09 GMT" ], "X-ExtLoop1": "1", "X-IronPort-AV": "E=Sophos;i=\"5.07,392,1413270000\"; d=\"scan'208\";a=\"608445096\"", "From": "Pablo de Lara <pablo.de.lara.guarch@intel.com>", "To": "dev@dpdk.org", "Date": "Sat, 15 Nov 2014 20:34:09 +0000", "Message-Id": "<1416083649-6085-1-git-send-email-pablo.de.lara.guarch@intel.com>", "X-Mailer": "git-send-email 1.7.4.1", "Subject": "[dpdk-dev] [PATCH] app/test: Removed file-prefix option in\n\teal_flags and multiprocess unit tests for FreeBSD", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.15", "Precedence": "list", "List-Id": "patches and discussions about DPDK <dev.dpdk.org>", "List-Unsubscribe": "<http://dpdk.org/ml/options/dev>,\n\t<mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://dpdk.org/ml/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<http://dpdk.org/ml/listinfo/dev>,\n\t<mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org", "Sender": "\"dev\" <dev-bounces@dpdk.org>" }, "content": "eal_flags and multiprocess unit tests use --file-prefix option\nwhich is not supported in FreeBSD, so it has been removed\nif compiled for this OS\n\nSigned-off-by: Pablo de Lara <pablo.de.lara.guarch@intel.com>\n---\n app/test/test_eal_flags.c | 16 ++++++++++++----\n app/test/test_mp_secondary.c | 10 ++++++++++\n 2 files changed, 22 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/test_eal_flags.c b/app/test/test_eal_flags.c\nindex 1f95d7f..2d7f726 100644\n--- a/app/test/test_eal_flags.c\n+++ b/app/test/test_eal_flags.c\n@@ -400,18 +400,26 @@ test_invalid_b_flag(void)\n static int\n test_invalid_vdev_flag(void)\n {\n+#ifdef RTE_EXEC_ENV_BSDAPP\n+\t/* BSD target doesn't support prefixes at this point, and we also need to\n+\t * run another primary process here */\n+\tconst char * prefix = no_shconf;\n+#else\n+\tconst char * prefix = \"--file-prefix=vdev\";\n+#endif\n+\n \t/* Test with invalid vdev option */\n-\tconst char *vdevinval[] = {prgname, \"--file-prefix=vdev\",\"-n\", \"1\",\n+\tconst char *vdevinval[] = {prgname, prefix, \"-n\", \"1\",\n \t\t\t\t\"-c\", \"1\", vdev, \"eth_dummy\"};\n \n \t/* Test with valid vdev option */\n-\tconst char *vdevval1[] = {prgname, \"--file-prefix=vdev\", \"-n\", \"1\",\n+\tconst char *vdevval1[] = {prgname, prefix, \"-n\", \"1\",\n \t\"-c\", \"1\", vdev, \"eth_ring0\"};\n \n-\tconst char *vdevval2[] = {prgname, \"--file-prefix=vdev\", \"-n\", \"1\",\n+\tconst char *vdevval2[] = {prgname, prefix, \"-n\", \"1\",\n \t\"-c\", \"1\", vdev, \"eth_ring0,args=test\"};\n \n-\tconst char *vdevval3[] = {prgname, \"--file-prefix=vdev\", \"-n\", \"1\",\n+\tconst char *vdevval3[] = {prgname, prefix, \"-n\", \"1\",\n \t\"-c\", \"1\", vdev, \"eth_ring0,nodeaction=r1:0:CREATE\"};\n \n \tif (launch_proc(vdevinval) == 0) {\ndiff --git a/app/test/test_mp_secondary.c b/app/test/test_mp_secondary.c\nindex 95a12e2..b5d6802 100644\n--- a/app/test/test_mp_secondary.c\n+++ b/app/test/test_mp_secondary.c\n@@ -84,6 +84,7 @@\n #define launch_proc(ARGV) process_dup(ARGV, \\\n \t\tsizeof(ARGV)/(sizeof(ARGV[0])), __func__)\n \n+#ifdef RTE_EXEC_ENV_LINUXAPP\n static char*\n get_current_prefix(char * prefix, int size)\n {\n@@ -107,6 +108,7 @@ get_current_prefix(char * prefix, int size)\n \n \treturn prefix;\n }\n+#endif\n \n /*\n * This function is called in the primary i.e. main test, to spawn off secondary\n@@ -118,12 +120,16 @@ run_secondary_instances(void)\n \tint ret = 0;\n \tchar coremask[10];\n \n+#ifdef RTE_EXEC_ENV_LINUXAPP\n \tchar tmp[PATH_MAX] = {0};\n \tchar prefix[PATH_MAX] = {0};\n \n \tget_current_prefix(tmp, sizeof(tmp));\n \n \tsnprintf(prefix, sizeof(prefix), \"--file-prefix=%s\", tmp);\n+#else\n+\tconst char *prefix = \"\";\n+#endif\n \n \t/* good case, using secondary */\n \tconst char *argv1[] = {\n@@ -140,11 +146,13 @@ run_secondary_instances(void)\n \t\t\tprgname, \"-c\", coremask, \"--proc-type=ERROR\",\n \t\t\tprefix\n \t};\n+#ifdef RTE_EXEC_ENV_LINUXAPP\n \t/* bad case, using invalid file prefix */\n \tconst char *argv4[] = {\n \t\t\tprgname, \"-c\", coremask, \"--proc-type=secondary\",\n \t\t\t\t\t\"--file-prefix=ERROR\"\n \t};\n+#endif\n \n \tsnprintf(coremask, sizeof(coremask), \"%x\", \\\n \t\t\t(1 << rte_get_master_lcore()));\n@@ -153,7 +161,9 @@ run_secondary_instances(void)\n \tret |= launch_proc(argv2);\n \n \tret |= !(launch_proc(argv3));\n+#ifdef RTE_EXEC_ENV_LINUXAPP\n \tret |= !(launch_proc(argv4));\n+#endif\n \n \treturn ret;\n }\n", "prefixes": [ "dpdk-dev" ] }