Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129705/?format=api
{ "id": 129705, "url": "https://patches.dpdk.org/api/patches/129705/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230726023947.3760943-1-kaisenx.you@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230726023947.3760943-1-kaisenx.you@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230726023947.3760943-1-kaisenx.you@intel.com", "date": "2023-07-26T02:39:47", "name": "[v2] app/test:subprocess synchronization of parameters", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "69d94da66d6e0d08b16f4059b779f1bd3d418441", "submitter": { "id": 2900, "url": "https://patches.dpdk.org/api/people/2900/?format=api", "name": "Kaisen You", "email": "kaisenx.you@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230726023947.3760943-1-kaisenx.you@intel.com/mbox/", "series": [ { "id": 29017, "url": "https://patches.dpdk.org/api/series/29017/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=29017", "date": "2023-07-26T02:39:47", "name": "[v2] app/test:subprocess synchronization of parameters", "version": 2, "mbox": "https://patches.dpdk.org/series/29017/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129705/comments/", "check": "fail", "checks": "https://patches.dpdk.org/api/patches/129705/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 792E142F4A;\n\tWed, 26 Jul 2023 04:43:49 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 011FC40E25;\n\tWed, 26 Jul 2023 04:43:49 +0200 (CEST)", "from mga11.intel.com (mga11.intel.com [192.55.52.93])\n by mails.dpdk.org (Postfix) with ESMTP id 29B9D40A79;\n Wed, 26 Jul 2023 04:43:46 +0200 (CEST)", "from orsmga003.jf.intel.com ([10.7.209.27])\n by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jul 2023 19:43:45 -0700", "from unknown (HELO localhost.localdomain) ([10.239.252.104])\n by orsmga003-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 25 Jul 2023 19:43:43 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1690339427; x=1721875427;\n h=from:to:cc:subject:date:message-id:in-reply-to:\n references:mime-version:content-transfer-encoding;\n bh=fq470sG1IBkWSSZIqKD/cpY9DBmpU5YJF0Dcx16TFT8=;\n b=ES7K+diyJK6j551kwyOgxYV+V7bS/lkkXXC73deBwnEEXp6OS6g/25xN\n YPA9x5e7D5LPXF2Bm8Mr41C4QOOXzBIFu6+59U982IH7iWxVynHKrStvG\n /TmmBcMyqBK/5RjMuWFVFdldDMC11FkfwW67BavESJdB67JjcvLJRrlzQ\n BW8Q/YlvTQWX22zZc8xNJ2rhHsEaot8QPE7s7lmsw87dBIk2FgwQmdk8C\n yS90qS6zTQpFXuMRE++xsMhWzczLqfpV/ukPCjZ0ShJ/ADMlFGs/PYjGJ\n BXeR8z9hrKhpvERa3+mhRIYThY6/+L6alCjYToERhzj0OcBjKZNaMvDfz w==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10782\"; a=\"365354439\"", "E=Sophos;i=\"6.01,231,1684825200\"; d=\"scan'208\";a=\"365354439\"", "E=McAfee;i=\"6600,9927,10782\"; a=\"676468264\"", "E=Sophos;i=\"6.01,231,1684825200\"; d=\"scan'208\";a=\"676468264\"" ], "X-ExtLoop1": "1", "From": "Kaisen You <kaisenx.you@intel.com>", "To": "dev@dpdk.org", "Cc": "qiming.yang@intel.com, yidingx.zhou@intel.com,\n Kaisen You <kaisenx.you@intel.com>, stable@dpdk.org", "Subject": "[PATCH v2] app/test:subprocess synchronization of parameters", "Date": "Wed, 26 Jul 2023 10:39:47 +0800", "Message-Id": "<20230726023947.3760943-1-kaisenx.you@intel.com>", "X-Mailer": "git-send-email 2.25.1", "In-Reply-To": "<20230705093515.3285574-1-kaisenx.you@intel.com>", "References": "<20230705093515.3285574-1-kaisenx.you@intel.com>", "MIME-Version": "1.0", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "In meson_test, because the child process does not synchronize\nthe NIC startup parameters of the parent process at startup,\nit uses all NICs bound by vfio as startup parameters by default,\nand an exception occurs in the subsequent hugefile check,\ncausing the test to fail. Synchronize the NIC startup parameters\nof the parent process to the child process to solve this problem.\n\nFixes: af75078fece3 (\"first public release\")\nCc: stable@dpdk.org\n\nSigned-off-by: Kaisen You <kaisenx.you@intel.com>\n\n---\nChanges since v1:\n- change the patch title to modify the way child\n processes get NIC parameters\n---\n app/test/process.h | 27 +++++++++++++++++++++++----\n 1 file changed, 23 insertions(+), 4 deletions(-)", "diff": "diff --git a/app/test/process.h b/app/test/process.h\nindex 1f073b9c5c..76a1646b24 100644\n--- a/app/test/process.h\n+++ b/app/test/process.h\n@@ -15,9 +15,12 @@\n #include <string.h> /* strerror */\n #include <unistd.h> /* readlink */\n #include <dirent.h>\n+#include \"../../drivers/bus/pci/private.h\"\n \n #include <rte_string_fns.h> /* strlcpy */\n \n+#define MAX_EXTRA_ARGS 32\n+#define PCI_PRI_FMT \"%.4\" PRIx32 \":%.2\" PRIx8 \":%.2\" PRIx8 \".%\" PRIx8\n #ifdef RTE_EXEC_ENV_FREEBSD\n #define self \"curproc\"\n #define exe \"file\"\n@@ -33,7 +36,6 @@ extern void *send_pkts(void *empty);\n extern uint16_t flag_for_send_pkts;\n #endif\n #endif\n-\n /*\n * launches a second copy of the test process using the given argv parameters,\n * which should include argv[0] as the process name. To identify in the\n@@ -44,9 +46,13 @@ static inline int\n process_dup(const char *const argv[], int numargs, const char *env_value)\n {\n \tint num;\n-\tchar *argv_cpy[numargs + 1];\n-\tint i, status;\n+\tchar *argv_cpy[MAX_EXTRA_ARGS];\n+\tint i, status, s;\n \tchar path[32];\n+\tstruct rte_pci_device *dev = NULL;\n+\tchar type[MAX_EXTRA_ARGS];\n+\tchar *argv_str[MAX_EXTRA_ARGS];\n+\tchar str_1[] = \"-a\";\n #ifdef RTE_LIB_PDUMP\n #ifdef RTE_NET_RING\n \tpthread_t thread;\n@@ -113,10 +119,23 @@ process_dup(const char *const argv[], int numargs, const char *env_value)\n \t\t\tclosedir(dir);\n \t\t}\n #endif\n+\t\ts = -1;\n+\t\targv_str[0] = strdup(str_1);\n+\t\tFOREACH_DEVICE_ON_PCIBUS(dev) {\n+\t\t\ts = s + 2;\n+\t\t\tsprintf(type, PCI_PRI_FMT, dev->addr.domain,\n+\t\t\tdev->addr.bus, dev->addr.devid, dev->addr.function);\n+\t\t\targv_str[s - 1] = strdup(str_1);\n+\t\t\targv_str[s] = strdup(type);\n+\t\t}\n+\t\tfor (i = 0; i < s + 1; i++)\n+\t\t\targv_cpy[num + i] = strdup(argv_str[i]);\n+\n \t\tprintf(\"Running binary with argv[]:\");\n-\t\tfor (i = 0; i < num; i++)\n+\t\tfor (i = 0; i < num + s + 1; i++)\n \t\t\tprintf(\"'%s' \", argv_cpy[i]);\n \t\tprintf(\"\\n\");\n+\t\targv_cpy[numargs + s + 1] = NULL;\n \t\tfflush(stdout);\n \n \t\t/* set the environment variable */\n", "prefixes": [ "v2" ] }