Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129423/?format=api
{ "id": 129423, "url": "https://patches.dpdk.org/api/patches/129423/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230710170800.12478-3-stephen@networkplumber.org/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230710170800.12478-3-stephen@networkplumber.org>", "list_archive_url": "https://inbox.dpdk.org/dev/20230710170800.12478-3-stephen@networkplumber.org", "date": "2023-07-10T17:07:57", "name": "[v4,2/5] ethdev: check return result of rte_eth_dev_info_get", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "257e5d1342abde07ac2ec7eae5f63178a411b422", "submitter": { "id": 27, "url": "https://patches.dpdk.org/api/people/27/?format=api", "name": "Stephen Hemminger", "email": "stephen@networkplumber.org" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230710170800.12478-3-stephen@networkplumber.org/mbox/", "series": [ { "id": 28886, "url": "https://patches.dpdk.org/api/series/28886/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28886", "date": "2023-07-10T17:07:55", "name": "fixes for problems found by codeql analyzer", "version": 4, "mbox": "https://patches.dpdk.org/series/28886/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129423/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/129423/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id DDF6A42E3C;\n\tMon, 10 Jul 2023 19:08:15 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id 66A9C40EE4;\n\tMon, 10 Jul 2023 19:08:08 +0200 (CEST)", "from mail-pf1-f182.google.com (mail-pf1-f182.google.com\n [209.85.210.182])\n by mails.dpdk.org (Postfix) with ESMTP id E5B5340EE4\n for <dev@dpdk.org>; Mon, 10 Jul 2023 19:08:05 +0200 (CEST)", "by mail-pf1-f182.google.com with SMTP id\n d2e1a72fcca58-6686708c986so4182013b3a.0\n for <dev@dpdk.org>; Mon, 10 Jul 2023 10:08:05 -0700 (PDT)", "from hermes.local (204-195-120-218.wavecable.com. [204.195.120.218])\n by smtp.gmail.com with ESMTPSA id\n q17-20020a62e111000000b00682ed27f99dsm51799pfh.46.2023.07.10.10.08.03\n (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n Mon, 10 Jul 2023 10:08:04 -0700 (PDT)" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=networkplumber-org.20221208.gappssmtp.com; s=20221208; t=1689008885;\n x=1691600885;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:from:to:cc:subject:date\n :message-id:reply-to;\n bh=KbFQUlYs6HQbdGpJ+pYHgzZS0d5/E2CJRCb/AY/vnpU=;\n b=y/c65iVFfeOXu3hBRPlHJ4WPXaa59Qvzmz3r4CLlkqS8OJHiQHjgOeiC2fbzlc3qJp\n i1ZvEgo63sIGHDCLbaon40vZTSgk7cX3OlKUpTEx0APhjj7Fv7wlpMBe2G4ErSzPOGfa\n xzV+W3hm+fSsYzX2VPwcNX19VAdPzRCEjCYiGPfY0yc358bzdVzRXeDUQsRPgU/VE5BV\n r4upjEklHy68sYDM87taWzK0kURAoTqqIXVx4d9AbFQ/L3LaLlWODPK2EqByE7gZYRNx\n aKou9zoeo9d7KWGR5coUEgKGSshJDGunWhmmWpaEWPwFXeBrecyXS6ixVm4wdnTqS7SK\n lVKQ==", "X-Google-DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/relaxed;\n d=1e100.net; s=20221208; t=1689008885; x=1691600885;\n h=content-transfer-encoding:mime-version:references:in-reply-to\n :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n :subject:date:message-id:reply-to;\n bh=KbFQUlYs6HQbdGpJ+pYHgzZS0d5/E2CJRCb/AY/vnpU=;\n b=DNLSpaGFSngCKcvqlph0VFYFWXlIvceX5m2Ywi10Q2yFQ5TDKOaE1KcR/FO6/kcW4T\n fqlmNVDE7lIqQPuMn2MHRHWHfNW9hAqfHj8bCQCdXEiVx3RNn6JbqlA6WDGIWldd18zg\n yNo7/9JONC7EXnLhYE9RlVDHMrS8o6MSBu0JRFf+KaHfw6VaKZ/3pBbREyGPrUztF3+N\n 4N2v0hrnyGV467MqUm3vHZ5UnZS78D/gd/V4g6AFOphKceFx9umPsBbW0C9FYy5OlJrd\n C2Zqz8GRED9dJfX75qByOhHcUT7/z6Py2f5mkqQGuaRIir9HW9YYQfZgeDAvhKMslqT+\n zH6g==", "X-Gm-Message-State": "ABy/qLYg/SY6jMTqt7xggaIWTSxBWtLr+8aWgPSqGmT59Yiw004JH+GF\n 8PK2Gq+M5oDdlZ5z8VfGZofM0LvnZ7oQUWPDUOsgEw==", "X-Google-Smtp-Source": "\n APBJJlHeuRilX+IpRTQ5P5RHPOrEVPtDcPkOg23ZhDphegUgbt8A1uW+n/lnraCQdHZJG6ACthLCFw==", "X-Received": "by 2002:a05:6a00:22cc:b0:666:d78c:33ab with SMTP id\n f12-20020a056a0022cc00b00666d78c33abmr17844905pfj.21.1689008884848;\n Mon, 10 Jul 2023 10:08:04 -0700 (PDT)", "From": "Stephen Hemminger <stephen@networkplumber.org>", "To": "dev@dpdk.org", "Cc": "Sinan Kaya <okaya@kernel.org>,\n Stephen Hemminger <stephen@networkplumber.org>, =?utf-8?q?Morten_Br=C3=B8ru?=\n\t=?utf-8?q?p?= <mb@smartsharesystems.com>,\n Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@amd.com>,\n Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>", "Subject": "[PATCH v4 2/5] ethdev: check return result of rte_eth_dev_info_get", "Date": "Mon, 10 Jul 2023 10:07:57 -0700", "Message-Id": "<20230710170800.12478-3-stephen@networkplumber.org>", "X-Mailer": "git-send-email 2.39.2", "In-Reply-To": "<20230710170800.12478-1-stephen@networkplumber.org>", "References": "<20230120044140.95975-1-okaya@kernel.org>\n <20230710170800.12478-1-stephen@networkplumber.org>", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=UTF-8", "Content-Transfer-Encoding": "8bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "From: Sinan Kaya <okaya@kernel.org>\n\nrte_class_eth: eth_mac_cmp: The status of this call to rte_eth_dev_info_get\nis not checked, potentially leaving dev_info uninitialized.\n\nSigned-off-by: Sinan Kaya <okaya@kernel.org>\nSigned-off-by: Stephen Hemminger <stephen@networkplumber.org>\nReviewed-by: Morten Brørup <mb@smartsharesystems.com>\n---\n lib/ethdev/rte_class_eth.c | 4 +++-\n 1 file changed, 3 insertions(+), 1 deletion(-)", "diff": "diff --git a/lib/ethdev/rte_class_eth.c b/lib/ethdev/rte_class_eth.c\nindex b61dae849dce..05c100efbba3 100644\n--- a/lib/ethdev/rte_class_eth.c\n+++ b/lib/ethdev/rte_class_eth.c\n@@ -50,8 +50,10 @@ eth_mac_cmp(const char *key __rte_unused,\n \tif (rte_ether_unformat_addr(value, &mac) < 0)\n \t\treturn -1; /* invalid devargs value */\n \n+\tif (rte_eth_dev_info_get(data->port_id, &dev_info) < 0)\n+\t\treturn -1;\n+\n \t/* Return 0 if devargs MAC is matching one of the device MACs. */\n-\trte_eth_dev_info_get(data->port_id, &dev_info);\n \tfor (index = 0; index < dev_info.max_mac_addrs; index++)\n \t\tif (rte_is_same_ether_addr(&mac, &data->mac_addrs[index]))\n \t\t\treturn 0;\n", "prefixes": [ "v4", "2/5" ] }