Patch Detail
get:
Show a patch.
patch:
Update a patch.
put:
Update a patch.
GET /api/patches/129343/?format=api
{ "id": 129343, "url": "https://patches.dpdk.org/api/patches/129343/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/patch/20230706152626.476775-1-conor.fogarty@intel.com/", "project": { "id": 1, "url": "https://patches.dpdk.org/api/projects/1/?format=api", "name": "DPDK", "link_name": "dpdk", "list_id": "dev.dpdk.org", "list_email": "dev@dpdk.org", "web_url": "http://core.dpdk.org", "scm_url": "git://dpdk.org/dpdk", "webscm_url": "http://git.dpdk.org/dpdk", "list_archive_url": "https://inbox.dpdk.org/dev", "list_archive_url_format": "https://inbox.dpdk.org/dev/{}", "commit_url_format": "" }, "msgid": "<20230706152626.476775-1-conor.fogarty@intel.com>", "list_archive_url": "https://inbox.dpdk.org/dev/20230706152626.476775-1-conor.fogarty@intel.com", "date": "2023-07-06T15:26:26", "name": "hash: fix segfault by adding param name NULL check", "commit_ref": null, "pull_url": null, "state": "new", "archived": false, "hash": "2d34f074c0272603b40669a86525294a4691f70f", "submitter": { "id": 2199, "url": "https://patches.dpdk.org/api/people/2199/?format=api", "name": "Conor Fogarty", "email": "conor.fogarty@intel.com" }, "delegate": { "id": 1, "url": "https://patches.dpdk.org/api/users/1/?format=api", "username": "tmonjalo", "first_name": "Thomas", "last_name": "Monjalon", "email": "thomas@monjalon.net" }, "mbox": "https://patches.dpdk.org/project/dpdk/patch/20230706152626.476775-1-conor.fogarty@intel.com/mbox/", "series": [ { "id": 28864, "url": "https://patches.dpdk.org/api/series/28864/?format=api", "web_url": "https://patches.dpdk.org/project/dpdk/list/?series=28864", "date": "2023-07-06T15:26:26", "name": "hash: fix segfault by adding param name NULL check", "version": 1, "mbox": "https://patches.dpdk.org/series/28864/mbox/" } ], "comments": "https://patches.dpdk.org/api/patches/129343/comments/", "check": "success", "checks": "https://patches.dpdk.org/api/patches/129343/checks/", "tags": {}, "related": [], "headers": { "Return-Path": "<dev-bounces@dpdk.org>", "X-Original-To": "patchwork@inbox.dpdk.org", "Delivered-To": "patchwork@inbox.dpdk.org", "Received": [ "from mails.dpdk.org (mails.dpdk.org [217.70.189.124])\n\tby inbox.dpdk.org (Postfix) with ESMTP id 5EB4F42DE9;\n\tThu, 6 Jul 2023 17:26:35 +0200 (CEST)", "from mails.dpdk.org (localhost [127.0.0.1])\n\tby mails.dpdk.org (Postfix) with ESMTP id EA3D1410FA;\n\tThu, 6 Jul 2023 17:26:34 +0200 (CEST)", "from mga01.intel.com (mga01.intel.com [192.55.52.88])\n by mails.dpdk.org (Postfix) with ESMTP id DF6A840A79\n for <dev@dpdk.org>; Thu, 6 Jul 2023 17:26:32 +0200 (CEST)", "from fmsmga007.fm.intel.com ([10.253.24.52])\n by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;\n 06 Jul 2023 08:26:30 -0700", "from silpixa00400784.ir.intel.com ([10.237.213.48])\n by fmsmga007.fm.intel.com with ESMTP; 06 Jul 2023 08:26:29 -0700" ], "DKIM-Signature": "v=1; a=rsa-sha256; c=relaxed/simple;\n d=intel.com; i=@intel.com; q=dns/txt; s=Intel;\n t=1688657193; x=1720193193;\n h=from:to:cc:subject:date:message-id:mime-version:\n content-transfer-encoding;\n bh=gm5WkLy3KhO/blCWZNdiRdZThR0S2glfOa9LQNcboco=;\n b=G9wI4I2BUkzQnVpcLNOOyOYwlLD8wv0pBbHFOtGEmQB8ammA90irgi0v\n d90Lj6EzHR6K2BuCNgyId9oWLBsYjkdt7NznBlU01eF3Nx33DlyMtHsjr\n bpLiIT/TUrdPk/bxO4i/Mesp9qx7VobKl9xcyFGtca0ncJS5vVxFdjuD8\n 3WUHfDeNohvCQD+Lgje1iSx4/XlMBNXKkUy/cZaUL/QRR4ZmLjG4yXsMQ\n 977mAl/dps6eJLTuPAh+E2uutWvqpDYKEqfzpii5+mY1EE4UAwACVFZpF\n 9jZQ+5ifITJmejPghipsPjzkjm74GcNQJ0LmvkAOUSty5Mmr1WKd/IqDH A==;", "X-IronPort-AV": [ "E=McAfee;i=\"6600,9927,10763\"; a=\"394390572\"", "E=Sophos;i=\"6.01,185,1684825200\"; d=\"scan'208\";a=\"394390572\"", "E=McAfee;i=\"6600,9927,10763\"; a=\"722822326\"", "E=Sophos;i=\"6.01,185,1684825200\"; d=\"scan'208\";a=\"722822326\"" ], "X-ExtLoop1": "1", "From": "Conor Fogarty <conor.fogarty@intel.com>", "To": "dev@dpdk.org", "Cc": "Conor Fogarty <conor.fogarty@intel.com>,\n\tpablo.de.lara.guarch@intel.com", "Subject": "[PATCH] hash: fix segfault by adding param name NULL check", "Date": "Thu, 6 Jul 2023 16:26:26 +0100", "Message-Id": "<20230706152626.476775-1-conor.fogarty@intel.com>", "X-Mailer": "git-send-email 2.25.1", "MIME-Version": "1.0", "Content-Type": "text/plain; charset=\"us-ascii\"", "Content-Transfer-Encoding": "7bit", "X-BeenThere": "dev@dpdk.org", "X-Mailman-Version": "2.1.29", "Precedence": "list", "List-Id": "DPDK patches and discussions <dev.dpdk.org>", "List-Unsubscribe": "<https://mails.dpdk.org/options/dev>,\n <mailto:dev-request@dpdk.org?subject=unsubscribe>", "List-Archive": "<http://mails.dpdk.org/archives/dev/>", "List-Post": "<mailto:dev@dpdk.org>", "List-Help": "<mailto:dev-request@dpdk.org?subject=help>", "List-Subscribe": "<https://mails.dpdk.org/listinfo/dev>,\n <mailto:dev-request@dpdk.org?subject=subscribe>", "Errors-To": "dev-bounces@dpdk.org" }, "content": "Add NULL pointer check to params->name, which is later\ncopied into the hash datastructure. Without this check\nthe code segfaults on the strlcpy() of a NULL pointer.\n\nFixes: 48a399119619 (\"hash: replace with cuckoo hash implementation\")\n\nSigned-off-by: Conor Fogarty <conor.fogarty@intel.com>\n\n---\nCc: pablo.de.lara.guarch@intel.com\n---\n lib/hash/rte_cuckoo_hash.c | 1 +\n 1 file changed, 1 insertion(+)", "diff": "diff --git a/lib/hash/rte_cuckoo_hash.c b/lib/hash/rte_cuckoo_hash.c\nindex d92a903bb3..0aab091c4d 100644\n--- a/lib/hash/rte_cuckoo_hash.c\n+++ b/lib/hash/rte_cuckoo_hash.c\n@@ -166,6 +166,7 @@ rte_hash_create(const struct rte_hash_parameters *params)\n \t/* Check for valid parameters */\n \tif ((params->entries > RTE_HASH_ENTRIES_MAX) ||\n \t\t\t(params->entries < RTE_HASH_BUCKET_ENTRIES) ||\n+\t\t\t(params->name == NULL) ||\n \t\t\t(params->key_len == 0)) {\n \t\trte_errno = EINVAL;\n \t\tRTE_LOG(ERR, HASH, \"rte_hash_create has invalid parameters\\n\");\n", "prefixes": [] }